Re: [spi-devel-general] [PATCH 2/3] ep93xx: added chip revision reading function

2010-03-16 Thread Martin Guy
On 3/16/10, H Hartley Sweeten wrote: > On Monday, March 15, 2010 11:06 AM, H Hartley Sweeten wrote: > > On Monday, March 15, 2010 9:26 AM, Mika Westerberg wrote: > >> + * %EP93XX_CHIP_REV_A > >> + * %EP93XX_CHIP_REV_B > >> + * %EP93XX_CHIP_REV_C > >> + * %EP93XX_CHIP_REV_D0 > >> + * %EP93XX_

Re: [spi-devel-general] [PATCH 2/3] ep93xx: added chip revision reading function

2010-03-16 Thread H Hartley Sweeten
On Monday, March 15, 2010 11:06 AM, H Hartley Sweeten wrote: > On Monday, March 15, 2010 9:26 AM, Mika Westerberg wrote: >> Added a new function: ep93xx_chip_revision() which reads chip revision from >> the sysconfig register. >> >> Signed-off-by: Mika Westerberg > > Hello Mike, > > A couple comm

Re: [spi-devel-general] [PATCH 2/3] ep93xx: added chip revision reading function

2010-03-15 Thread Mika Westerberg
On Mon, Mar 15, 2010 at 07:44:27PM +, Martin Guy wrote: > Hi Mika, thanks, great work > > On 3/15/10, Mika Westerberg wrote: > > Added a new function: ep93xx_chip_revision() which reads chip revision from > > the > > sysconfig register. > > > > + * %EP93XX_CHIP_REV_D0 > > + * %EP93XX_CHIP

Re: [spi-devel-general] [PATCH 2/3] ep93xx: added chip revision reading function

2010-03-15 Thread Martin Guy
Hi Mika, thanks, great work On 3/15/10, Mika Westerberg wrote: > Added a new function: ep93xx_chip_revision() which reads chip revision from > the > sysconfig register. > > + * %EP93XX_CHIP_REV_D0 > + * %EP93XX_CHIP_REV_D1 > + * %EP93XX_CHIP_REV_E0 > + * %EP93XX_CHIP_REV_E1 > + * %EP93XX_C

Re: [spi-devel-general] [PATCH 2/3] ep93xx: added chip revision reading function

2010-03-15 Thread H Hartley Sweeten
On Monday, March 15, 2010 9:26 AM, Mika Westerberg wrote: > Added a new function: ep93xx_chip_revision() which reads chip revision from > the sysconfig register. > > Signed-off-by: Mika Westerberg Hello Mike, A couple comments below. > --- > arch/arm/mach-ep93xx/core.c | 26

[spi-devel-general] [PATCH 2/3] ep93xx: added chip revision reading function

2010-03-15 Thread Mika Westerberg
Added a new function: ep93xx_chip_revision() which reads chip revision from the sysconfig register. Signed-off-by: Mika Westerberg --- arch/arm/mach-ep93xx/core.c | 26 ++ arch/arm/mach-ep93xx/include/mach/platform.h | 11 +++ 2 files changed,