Re: [spi-devel-general] [PATCH 6/7] spi/mpc8xxx: don't check platform_get_irq's return value against zero

2009-12-17 Thread Anton Vorontsov
On Wed, Dec 16, 2009 at 05:10:08PM +0100, Uwe Kleine-König wrote: platform_get_irq returns -ENXIO on failure, so !irq was probably always true. Better use (int)irq = 0. Note that a return value of zero is still handled as error even though this could mean irq0. This is a followup to

[spi-devel-general] [PATCH 6/7] spi/mpc8xxx: don't check platform_get_irq's return value against zero

2009-12-16 Thread Uwe Kleine-König
platform_get_irq returns -ENXIO on failure, so !irq was probably always true. Better use (int)irq = 0. Note that a return value of zero is still handled as error even though this could mean irq0. This is a followup to 305b3228f9ff4d59f49e6d34a7034d44ee8ce2f0 that changed the return value of