Re: [spi-devel-general] pxa2xx_spi with SFRM

2008-09-08 Thread David Brownell
On Friday 15 August 2008, Vernon Sauder wrote: > >I think the  "1" and "15" above correspond to threshold register values > >of "0" and "14"; that is the above numbers are the number of words in > >the FIFO that trigger the interrupt/service request. > > All this still leaves me slightly confused.

Re: [spi-devel-general] pxa2xx_spi with SFRM

2008-08-29 Thread Ned Forrester
With the one small change re: 8191, below, this looks good to go. For what it's worth, you can add below your sign-off: Reviewed-by: Ned Forrester <[EMAIL PROTECTED]> It's time to add an appropriate [Patch] subject line to the patch, as outlined in the docs, and email it to David Brownell <[EMAIL

Re: [spi-devel-general] pxa2xx_spi with SFRM

2008-08-29 Thread Vernon Sauder
Ned, Sorry for the slow response. Real world/work intrudes sometimes. Here is another version of the patch along with responses to your comments. Ned Forrester wrote: >Vernon Sauder wrote: >> >> Would you be in favor of a patch like this? If the code does not >> match the documentation, let me

Re: [spi-devel-general] pxa2xx_spi with SFRM

2008-08-22 Thread Ned Forrester
Vernon Sauder wrote: > Ned Forrester wrote: > >> Ned Forrester wrote: >>> Vernon Sauder wrote: As a user, it would seem that the SSP should work with minimum fuss. If there are values that enable 99% of devices to work, then why would you *not* want them to be the defaults? If the

Re: [spi-devel-general] pxa2xx_spi with SFRM

2008-08-21 Thread Vernon Sauder
Ned Forrester wrote: >Ned Forrester wrote: >> Vernon Sauder wrote: >>> As a user, it would seem that the SSP should work with >>> minimum fuss. If there are values that enable 99% of devices to >>> work, then why would you *not* want them to be the defaults? If the >>> user needs to tweak the val

Re: [spi-devel-general] pxa2xx_spi with SFRM

2008-08-19 Thread Ned Forrester
Ned Forrester wrote: > Vernon Sauder wrote: >> As a user, it would seem that the SSP should work with >> minimum fuss. If there are values that enable 99% of devices to work, >> then why would you *not* want them to be the defaults? If the user >> needs to tweak the values because they need more p

Re: [spi-devel-general] pxa2xx_spi with SFRM

2008-08-18 Thread Ned Forrester
Vernon Sauder wrote: > Ned Forrester wrote: > >> I'm not sure that implementing defaults is a good idea. I prefer the >> current scheme of forcing the user to make a considered choice. In >> particular, 0 is a valid value for the timeout and thresholds (it means >> none in the case of timeout an

Re: [spi-devel-general] pxa2xx_spi with SFRM

2008-08-15 Thread Vernon Sauder
Ned Forrester wrote: >I'm not sure that implementing defaults is a good idea. I prefer the >current scheme of forcing the user to make a considered choice. In >particular, 0 is a valid value for the timeout and thresholds (it means >none in the case of timeout and one in the case of thresholds),

Re: [spi-devel-general] pxa2xx_spi with SFRM

2008-08-15 Thread Ned Forrester
Resend due to bad cc: address... Vernon Sauder wrote: > This is another problem. The thresholds and timeouts are taken from the > pxa2xx_spi_chip structure where cs_control is specified. So once I tried > to use cs_control, the timeout and thresholds were wrong. They driver > does not use defa

Re: [spi-devel-general] pxa2xx_spi with SFRM

2008-08-14 Thread Vernon Sauder
Again, thanks for the help. Ned Forrester wrote: I can see from your logic analyzer trace, that the clock is running before the transfer starts, but it should not be doing this, and such a problem has not been reported by others, so far as I know. You really need to find out why this is happeni

Re: [spi-devel-general] pxa2xx_spi with SFRM

2008-08-14 Thread Ned Forrester
Vernon Sauder wrote: > First, thanks for your replies. I am sorry. I left town for the weekend > and I forgot to include all the details. > > Jonathan Cameron wrote: >> [EMAIL PROTECTED] wrote: I am using a custom PXA270 board and tried to use the SSP port to communication with a SPI Fl

Re: [spi-devel-general] pxa2xx_spi with SFRM

2008-08-08 Thread Jonathan Cameron
[EMAIL PROTECTED] wrote: > I am as sea right now, with very limited email access. If you can > wait until Wed or Thursday of next week, I might be of more help. In > the mean time perhaps someone else will reply. > > Since the orignal author, Stephen Steet, became silent on this driver, > I and

Re: [spi-devel-general] pxa2xx_spi with SFRM

2008-08-08 Thread nforrester
I am as sea right now, with very limited email access. If you can wait until Wed or Thursday of next week, I might be of more help. In the mean time perhaps someone else will reply. Since the orignal author, Stephen Steet, became silent on this driver, I and several others have submitted patches

[spi-devel-general] pxa2xx_spi with SFRM

2008-08-07 Thread Vernon Sauder
Hi, I am using a custom PXA270 board and tried to use the SSP port to communication with a SPI Flash. After reading docs on how to configure the spi_master and spi devices, I have the device driver's probe being called. But I cannot get the pxa2xx_spi driver to work correctly. I can connect ei