RE: [PATCH 1/3] spi_topcliff_pch: support new device ML7213

2011-01-23 Thread Tomoya MORINAGA
Hi Grant, Thank you for your explanation. On Saturday, January 22, 2011 3:49 AM, Grant Likely wrote: > Am I correct so far? No, not true. Both Topcliff(Intel EG20 PCH) and OKISEMI ML7213 IOH SPI devices can't use multi-ChipSelect but 1 ChipSelect only. I show the my modified diagram below. - C

Re: [PATCH 1/3] spi_topcliff_pch: support new device ML7213

2011-01-21 Thread Grant Likely
On Tue, Jan 11, 2011 at 06:38:35PM +0900, Tomoya MORINAGA wrote: > Hi Grant, > > On Friday, January 07, 2011 6:22 PM, Milton Miller wrote: > > follow mfd_add_devices into drivers/mfd/mfd-core.c > I have also seen mfd-core.c. > However, I couldn't clear my question. > > Q1. It seems platform_devic

Re: [PATCH 1/3] spi_topcliff_pch: support new device ML7213

2011-01-18 Thread Grant Likely
INAGA > > Sent: Wednesday, January 12, 2011 2:27 PM > > To: 'Milton Miller'; 'Grant Likely' > > Cc: 'David Brownell'; > > spi-devel-general@lists.sourceforge.net; > > linux-ker...@vger.kernel.org; yong.y.w...@intel.com; > > joel.c

RE: [PATCH 1/3] spi_topcliff_pch: support new device ML7213

2011-01-18 Thread Tomoya MORINAGA
com; kok.howg....@intel.com; 'Toshiharu > Okada'; 'Wang, Qi' > Subject: RE: [PATCH 1/3] spi_topcliff_pch: support new device ML7213 > > On Tuesday, January 11, 2011 6:42 PM, Tomoya MORINAGA wrote: > > However, I couldn't clear my question. > > I sho

RE: [PATCH 1/3] spi_topcliff_pch: support new device ML7213

2011-01-11 Thread Tomoya MORINAGA
On Tuesday, January 11, 2011 6:42 PM, Tomoya MORINAGA wrote: > However, I couldn't clear my question. I show the current our coding image. Is the following agreeable with your saying ? struct spi_platform_data { u16 num_chipselect; bool little_endian; u8 bits_per_word;

RE: [PATCH 1/3] spi_topcliff_pch: support new device ML7213

2011-01-11 Thread Tomoya MORINAGA
Resend (Previous destination address is broken partly.) Hi Grant, On Friday, January 07, 2011 6:22 PM, Milton Miller wrote: > follow mfd_add_devices into drivers/mfd/mfd-core.c I have also seen mfd-core.c. However, I couldn't clear my question. Q1. It seems platform_device is not used in your ex

RE: [PATCH 1/3] spi_topcliff_pch: support new device ML7213

2011-01-11 Thread Tomoya MORINAGA
Hi Grant, On Friday, January 07, 2011 6:22 PM, Milton Miller wrote: > follow mfd_add_devices into drivers/mfd/mfd-core.c I have also seen mfd-core.c. However, I couldn't clear my question. Q1. It seems platform_device is not used in your example. Does need "platform_device" ? Q2. How detect pch_

Re: [PATCH 1/3] spi_topcliff_pch: support new device ML7213

2011-01-07 Thread Milton Miller
On: Mon, 27 Dec 2010 at about 11:23:45 -, Tomoya MORINAGA wrote: > On Thursday, January 06, 2011 1:39 AM, Grant Likely wrote: > > As far as examples go, drivers/mfd/timberdale.c seems reasonable, if a > > bit larger than what you need. > > Thank you for your suggestion. > However, though seei

RE: [PATCH 1/3] spi_topcliff_pch: support new device ML7213

2011-01-07 Thread Tomoya MORINAGA
Hi Milton, On Friday, January 07, 2011 6:22 PM, Milton Miller wrote: > follow mfd_add_devices into drivers/mfd/mfd-core.c It seems mfd_add_devices/mfd_add_device are valuable for us. I'll study this. Thanks, - Tomoya MORINAGA OKI SEMICONDUCTOR CO., LTD.

Re: [PATCH 1/3] spi_topcliff_pch: support new device ML7213

2011-01-07 Thread Milton Miller
On: Mon, 27 Dec 2010 at about 11:23:45 -, Tomoya MORINAGA wrote: > On Thursday, January 06, 2011 1:39 AM, Grant Likely wrote: > > As far as examples go, drivers/mfd/timberdale.c seems reasonable, if a > > bit larger than what you need. > > Thank you for your suggestion. > However, though seei

Re: [PATCH 1/3] spi_topcliff_pch: support new device ML7213

2011-01-07 Thread Milton Miller
On: Mon, 27 Dec 2010 at about 11:23:45 -, Tomoya MORINAGA wrote: > On Thursday, January 06, 2011 1:39 AM, Grant Likely wrote: > > As far as examples go, drivers/mfd/timberdale.c seems reasonable, if a > > bit larger than what you need. > > Thank you for your suggestion. > However, though seei

RE: [PATCH 1/3] spi_topcliff_pch: support new device ML7213

2011-01-06 Thread Tomoya MORINAGA
Hi Grant, Sorry, I made mistake in my-mail address. I sent again. On Thursday, January 06, 2011 1:39 AM, Grant Likely wrote: > As far as examples go, drivers/mfd/timberdale.c seems reasonable, if a > bit larger than what you need. Thank you for your suggestion. However, though seeing this drive

RE: [PATCH 1/3] spi_topcliff_pch: support new device ML7213

2011-01-06 Thread Tomoya MORINAGA
tel.com; Toshiharu Okada > Subject: Re: [PATCH 1/3] spi_topcliff_pch: support new device ML7213 > > On Wed, Jan 05, 2011 at 11:34:20AM +0900, Tomoya MORINAGA wrote: > > Hi Grant, > > > > On Wednesday, December 29, 2010 3:49 PM, Grant Likely wrote: > > &g

Re: [PATCH 1/3] spi_topcliff_pch: support new device ML7213

2011-01-05 Thread Grant Likely
On Wed, Jan 05, 2011 at 11:34:20AM +0900, Tomoya MORINAGA wrote: > Hi Grant, > > On Wednesday, December 29, 2010 3:49 PM, Grant Likely wrote: > >As previously discussed on this list, I would like to see support for > >multiple bus instances implemented differently. Rather than storing > >the spi_

Re: [PATCH 1/3] spi_topcliff_pch: support new device ML7213

2011-01-04 Thread Tomoya MORINAGA
Hi Grant, On Wednesday, December 29, 2010 3:49 PM, Grant Likely wrote: > As previously discussed on this list, I would like to see support for > multiple bus instances implemented differently. Rather than storing > the spi_master instances in an array in the pci device private data, > the pci dev

Re: [PATCH 1/3] spi_topcliff_pch: support new device ML7213

2010-12-28 Thread Grant Likely
On Mon, Dec 27, 2010 at 08:23:45PM +0900, Tomoya MORINAGA wrote: > Support ML7213 device of OKI SEMICONDUCTOR. > ML7213 is companion chip of Intel Atom E6xx series for IVI(In-Vehicle > Infotainment). > ML7213 is completely compatible for Intel EG20T PCH. > > Signed-off-by: Tomoya MORINAGA > ---