[Spice-devel] [Qxl PATCH] aligning surfaces stride to 4

2010-08-18 Thread Yonit Halperin
--- display/res.c | 10 ++ 1 files changed, 6 insertions(+), 4 deletions(-) diff --git a/display/res.c b/display/res.c index 3fe5fe6..6be006e 100644 --- a/display/res.c +++ b/display/res.c @@ -600,15 +600,17 @@ _inline void GetSurfaceMemory(PDev *pdev, UINT32 x, UINT32 y, UINT32 depth,

Re: [Spice-devel] [PATCH] spice: vdagent: add basic clipboard support

2010-08-18 Thread Alexander Larsson
On Wed, 2010-08-18 at 14:18 +0200, Attila Sukosd wrote: > Sorry for hijacking this, but whats the irc server/channel name? #spice on gimpnet -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Alexander LarssonRed Hat, Inc

Re: [Spice-devel] [PATCH] spice: vdagent: add basic clipboard support

2010-08-18 Thread Alon Levy
- "Gerd Hoffmann" wrote: > On 08/18/10 14:15, Alexander Larsson wrote: > > On Mon, 2010-08-09 at 12:58 +0300, Arnon Gilboa wrote: > >> From: Arnon Gilboa > >> > >> -currently supports text only (UTF8) > >> -add VDAgent::dispatch_message() > >> -in VDAgent::read_completion() handle multi-chun

Re: [Spice-devel] [PATCH] vdagent: use vdagent.h

2010-08-18 Thread Arnon Gilboa
Alexander Larsson wrote: On Mon, 2010-08-09 at 12:58 +0300, Arnon Gilboa wrote: From: Arnon Gilboa --- common/vdcommon.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/common/vdcommon.h b/common/vdcommon.h index 2e4ed5d..ba9d0ec 100644 --- a/common/vdcommon.h +++

Re: [Spice-devel] [PATCH] Controlling Windows display settings (e.g., wallpaper, UI effects and font smoothing)

2010-08-18 Thread Alexander Larsson
On Wed, 2010-08-11 at 08:46 +0300, Yonit Halperin wrote: > The configuration is received from Spice client. > The main usage of this option is for disabling display features in order to > accelerate Spice performance over limited network connections. > --- Ack -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=

Re: [Spice-devel] [PATCH] spice: vdagent: add basic clipboard support

2010-08-18 Thread Gerd Hoffmann
On 08/18/10 14:15, Alexander Larsson wrote: On Mon, 2010-08-09 at 12:58 +0300, Arnon Gilboa wrote: From: Arnon Gilboa -currently supports text only (UTF8) -add VDAgent::dispatch_message() -in VDAgent::read_completion() handle multi-chunk msgs -fix chunk size bug in VDService::handle_pipe_data()

Re: [Spice-devel] [PATCH] spice: vdagent: virtio serial adaptations

2010-08-18 Thread Alexander Larsson
On Mon, 2010-08-09 at 12:58 +0300, Arnon Gilboa wrote: > From: Arnon Gilboa Overall this looks good to me, although its hard to read in places due to whitespace-only changes in some places. It would be good to split it up in independent parts though, to make the history easier to read etc. > -m

Re: [Spice-devel] [PATCH] spice: vdagent: add basic clipboard support

2010-08-18 Thread Attila Sukosd
Sorry for hijacking this, but whats the irc server/channel name? Cheers, Attila On Wed, Aug 18, 2010 at 2:15 PM, Alexander Larsson wrote: > On Mon, 2010-08-09 at 12:58 +0300, Arnon Gilboa wrote: > > From: Arnon Gilboa > > > > -currently supports text only (UTF8) > > -add VDAgent::dispatch_mes

Re: [Spice-devel] [PATCH] spice: vdagent: add basic clipboard support

2010-08-18 Thread Alexander Larsson
On Mon, 2010-08-09 at 12:58 +0300, Arnon Gilboa wrote: > From: Arnon Gilboa > > -currently supports text only (UTF8) > -add VDAgent::dispatch_message() > -in VDAgent::read_completion() handle multi-chunk msgs > -fix chunk size bug in VDService::handle_pipe_data() > -add size to VDPipeMessage Thi

Re: [Spice-devel] [PATCH] spice: vdagent: drop mouse event when SendInput fails due to DesktopSwitch event delay #598968

2010-08-18 Thread Alexander Larsson
On Mon, 2010-08-09 at 12:58 +0300, Arnon Gilboa wrote: > From: Arnon Gilboa > > --- > vdagent/vdagent.cpp |9 - > 1 files changed, 4 in Ack -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Alexander Larsson

Re: [Spice-devel] [PATCH] spice: vdagent: return error code -1 on service install/uninstall failure #576625

2010-08-18 Thread Alexander Larsson
On Mon, 2010-08-09 at 12:58 +0300, Arnon Gilboa wrote: > From: Arnon Gilboa > > --- Ack -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Alexander LarssonRed Hat, Inc al...@redhat.comalexander.lars..

Re: [Spice-devel] [PATCH] spice: vdagent: upgrade solution & projects to vs2008

2010-08-18 Thread Alexander Larsson
On Mon, 2010-08-09 at 12:58 +0300, Arnon Gilboa wrote: > From: Arnon Gilboa > > --- > vdagent.sln|4 +- > vdagent/vdagent.vcproj | 75 > +--- > vdservice/vdservice.vcproj | 73 -- > 3 fil

Re: [Spice-devel] [PATCH] spice: vdagent: support x64 arch

2010-08-18 Thread Alexander Larsson
On Mon, 2010-08-09 at 12:58 +0300, Arnon Gilboa wrote: > > /* 7.18.1.4 Integer types capable of holding object pointers */ > > +#ifndef _WIN64 > + > typedef int intptr_t; > > typedef unsigned uintptr_t; > > +#endif > + So, the win64 compiler supports (u)intptr_t, but the win32 one doe

Re: [Spice-devel] [PATCH] vdagent: use vdagent.h

2010-08-18 Thread Alexander Larsson
On Mon, 2010-08-09 at 12:58 +0300, Arnon Gilboa wrote: > From: Arnon Gilboa > > --- > common/vdcommon.h |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/common/vdcommon.h b/common/vdcommon.h > index 2e4ed5d..ba9d0ec 100644 > --- a/common/vdcommon.h > +++ b/common/v

Re: [Spice-devel] [PATCH] server: remove unnecessary dependency between surfaces and Glz drawables

2010-08-18 Thread Alexander Larsson
On Wed, 2010-08-11 at 14:21 +0300, Yonit Halperin wrote: > Fixes freedesktop bug #28568 > --- Ack, although it would be nice to split this into two commits. One that removes the unnecessary red_clear_surface_glz_drawables() calls and moves the red_destroy_surface() call to release_drawable, which

Re: [Spice-devel] [Qxl PATCH] Change surfaces allocation method.

2010-08-18 Thread Alexander Larsson
On Wed, 2010-08-18 at 12:03 +0300, Yonit Halperin wrote: > The driver no longer claims to support DirectDraw. > It uses mspace to allocate surfaces and not HeapVidMemAllocAligned. > This fixes freedesktop bug #29254. > --- Ack -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-

Re: [Spice-devel] [Qxl PATCH] Change surfaces allocation method.

2010-08-18 Thread Alexander Larsson
On Wed, 2010-08-18 at 12:03 +0300, Yonit Halperin wrote: > On 08/17/2010 05:36 PM, Alexander Larsson wrote: > > On Tue, 2010-08-17 at 14:26 +0300, Yonit Halperin wrote: > >> The driver no longer claims to support DirectDraw. > >> It uses mspace to allocate surfaces and not HeapVidMemAllocAligned. >

[Spice-devel] [Qxl PATCH] Change surfaces allocation method.

2010-08-18 Thread Yonit Halperin
The driver no longer claims to support DirectDraw. It uses mspace to allocate surfaces and not HeapVidMemAllocAligned. This fixes freedesktop bug #29254. --- display/dd.c | 122 - display/dd.h | 15 - display/driver.c | 18 ++- display/q

Re: [Spice-devel] [Qxl PATCH] Change surfaces allocation method.

2010-08-18 Thread Yonit Halperin
On 08/17/2010 05:36 PM, Alexander Larsson wrote: On Tue, 2010-08-17 at 14:26 +0300, Yonit Halperin wrote: The driver no longer claims to support DirectDraw. It uses mspace to allocate surfaces and not HeapVidMemAllocAligned. This fixes freedesktop bug #29254. Ack (although you should git rm dd