[Spice-devel] [PATCH] Limiting video streaming to the primary surface. freedesktop bug #28088.

2010-08-22 Thread Yonit Halperin
--- server/red_worker.c | 47 --- 1 files changed, 40 insertions(+), 7 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index cbfe405..ef9aa53 100644 --- a/server/red_worker.c +++ b/server/red_worker.c @@ -1516,7 +1516,10 @@ static

Re: [Spice-devel] [PATCH 1/8] Move SurfaceInfo structure

2010-08-22 Thread Yonit Halperin
On 08/20/2010 09:54 PM, al...@redhat.com wrote: From: Alexander Larssonal...@redhat.com This is in preparation for using it in DevRes Ack ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org

Re: [Spice-devel] [PATCH 2/8] Add helper functions for surface info - id mapping

2010-08-22 Thread Yonit Halperin
On 08/20/2010 09:54 PM, al...@redhat.com wrote: From: Alexander Larssonal...@redhat.com --- display/driver.c |6 ++ display/res.c |4 ++-- display/surface.c |8 display/surface.h | 20 ++-- 4 files changed, 22 insertions(+), 16 deletions(-)

Re: [Spice-devel] [PATCH 3/8] Move SurfaceInfo to global data

2010-08-22 Thread Yonit Halperin
On 08/20/2010 09:54 PM, al...@redhat.com wrote: From: Alexander Larssonal...@redhat.com When we release a surface resource, for instance when AllocMem gets OOM, we call ReleaseOutput with the pdev in use (i.e. probably the currently active one). However, its possible that the resource we free

Re: [Spice-devel] [PATCH 4/8] Always release free resources when allocating

2010-08-22 Thread Yonit Halperin
On 08/20/2010 09:54 PM, al...@redhat.com wrote: From: Alexander Larssonal...@redhat.com Leaving around potentially freeable resources when you're about to allocate just increases the risk for fragmentation, which is bad, especially for the vram where we do many large allocations in a limited

Re: [Spice-devel] [PATCH 5/8] Make malloc_sem global

2010-08-22 Thread Yonit Halperin
On 08/20/2010 09:54 PM, al...@redhat.com wrote: From: Alexander Larssonal...@redhat.com It protects shared data (mspace info) so it needs to be shared. --- display/driver.c | 22 ++ display/qxldd.h |2 +- display/res.c| 17 + 3 files

Re: [Spice-devel] [PATCH 7/8] Store surfaces_used in a bit-array

2010-08-22 Thread Yonit Halperin
On 08/20/2010 09:54 PM, al...@redhat.com wrote: From: Alexander Larssonal...@redhat.com This is smaller than a byte array, and allows us to skip full blocks of 32 ids in one check. --- Hi, why not use a linked list, for free surfaces, in a static UINT32[n_surfaces] array? Any reason besides

Re: [Spice-devel] [PATCH 7/8] Store surfaces_used in a bit-array

2010-08-22 Thread Yonit Halperin
On 08/22/2010 03:56 PM, Yonit Halperin wrote: On 08/20/2010 09:54 PM, al...@redhat.com wrote: From: Alexander Larssonal...@redhat.com This is smaller than a byte array, and allows us to skip full blocks of 32 ids in one check. --- Hi, why not use a linked list, for free surfaces, in a static

Re: [Spice-devel] [PATCH 0/8] Win32 driver fixes for 0.6.0

2010-08-22 Thread Yonit Halperin
On 08/20/2010 09:54 PM, al...@redhat.com wrote: From: Alexander Larssonal...@redhat.com This is a bunch of changes I think we we need before the 0.6.0 release. They do: * Make SurfaceInfo global to fix potential memory corruption (#29053) * Make malloc_sem global since it protects a the