[Spice-devel] [PATCH] qxl:fix double free surface when create device bitmap failed

DrvCreateDeviceBitmap will call FreeSurface function when CreateDeviceBitmap failed, no need call FreeSurface function in CreateDeviceBitmap function; It fixes the windows XP bluescreen problem that I encounter. diff --git a/display/surface.c b/display/surface.c index 7146b32..38200aa 100644 --- a

[Spice-devel] [PATCH] server/tests: fix for AM_LDFLAGS introduction

broke build with previous patch (450278a299f2a91daec4b4fd2ca64262b5602850). --- server/tests/Makefile.am |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/server/tests/Makefile.am b/server/tests/Makefile.am index 1f8817f..d19abcb 100644 --- a/server/tests/Makefile.am

Re: [Spice-devel] [PATCH 0/2] mingw32 fixes - the ones that were not acked

Ack for both. On 12/08/2010 04:18 PM, Alon Levy wrote: Since they were all independent I just reordered to make sure it applies, and am sending the fixed ones after Hans review: + visibility flag disabled just for mingw32 target + simplify USE_CXIMAGE flag in platform.cpp + also made confi

[Spice-devel] [PATCH 1/2] mingw32 build: check for CXImage, disable if not found (only on mingw32)

v2: + simplify (Hans) + also report presence of cximage for mingw32 target --- client/windows/Makefile.am |1 + client/windows/platform.cpp | 15 +++ configure.ac| 37 - 3 files changed, 52 insertions(+), 1 deletions(-) di

[Spice-devel] [PATCH 2/2] mingw32 build: disable -fvisibility test for unsupported mingw32 target

From: Gerd Hoffmann Signed-off-by: Gerd Hoffmann v2: only disable for os_win32 (Hans) --- configure.ac |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/configure.ac b/configure.ac index 5b20e5b..72b377a 100644 --- a/configure.ac +++ b/configure.ac @@ -435,7 +435,7 @@ e

[Spice-devel] [PATCH 0/2] mingw32 fixes - the ones that were not acked

Since they were all independent I just reordered to make sure it applies, and am sending the fixed ones after Hans review: + visibility flag disabled just for mingw32 target + simplify USE_CXIMAGE flag in platform.cpp + also made configure check slightly nicer (reporting wise) Alon Levy (1):

Re: [Spice-devel] [PATCH 24/24] mingw32 build: use PRIu64 instead of ll

Ack. On 12/07/2010 10:28 PM, Alon Levy wrote: --- client/application.cpp |8 ++-- 1 files changed, 6 insertions(+), 2 deletions(-) diff --git a/client/application.cpp b/client/application.cpp index 3f1ae71..8f41ccf 100644 --- a/client/application.cpp +++ b/client/application.cpp @@ -

Re: [Spice-devel] [PATCH 22/24] mingw32 build: various fixes

On Wed, Dec 08, 2010 at 09:47:14AM +0100, Hans de Goede wrote: > Hi, > > On 12/07/2010 10:28 PM, Alon Levy wrote: > >--- > > client/windows/red_window.cpp |2 +- > > common/gdi_canvas.c |4 ++-- > > 2 files changed, 3 insertions(+), 3 deletions(-) > > > >diff --git a/client/wind

Re: [Spice-devel] [PATCH 23/24] mingw32 build: python_modules/marshal: use unsigned for for_loop index variable

Ack. On 12/07/2010 10:28 PM, Alon Levy wrote: --- python_modules/marshal.py |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/python_modules/marshal.py b/python_modules/marshal.py index 9ee1466..a82df98 100644 --- a/python_modules/marshal.py +++ b/python_modules/marsha

Re: [Spice-devel] [PATCH 22/24] mingw32 build: various fixes

Hi, On 12/07/2010 10:28 PM, Alon Levy wrote: --- client/windows/red_window.cpp |2 +- common/gdi_canvas.c |4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/client/windows/red_window.cpp b/client/windows/red_window.cpp index 56a757b..9f79ab3 100644 ---

Re: [Spice-devel] [PATCH 16/24] mingw32 build: check for CXImage, disable if not found (only on mingw32)

On Wed, Dec 08, 2010 at 09:43:47AM +0100, Hans de Goede wrote: > Hi, > > On 12/07/2010 10:28 PM, Alon Levy wrote: > >--- > > client/windows/Makefile.am |1 + > > client/windows/platform.cpp | 16 > > configure.ac| 21 + > > 3 files cha

Re: [Spice-devel] [PATCH 21/24] mingw32 build: fix two functions

Ack. On 12/07/2010 10:28 PM, Alon Levy wrote: --- client/windows/red_window.cpp |5 - common/canvas_base.c |2 +- 2 files changed, 1 insertions(+), 6 deletions(-) diff --git a/client/windows/red_window.cpp b/client/windows/red_window.cpp index 6d8a70d..56a757b 100644 --

Re: [Spice-devel] [PATCH 20/24] mingw32 build: add missing switch flags (nop)

Ack. On 12/07/2010 10:28 PM, Alon Levy wrote: --- client/windows/red_pixmap_gdi.cpp |6 +- client/windows/red_pixmap_sw.cpp |4 2 files changed, 9 insertions(+), 1 deletions(-) diff --git a/client/windows/red_pixmap_gdi.cpp b/client/windows/red_pixmap_gdi.cpp index cf8190

Re: [Spice-devel] [PATCH 19/24] mingw32 build: eol fixes

Ack. On 12/07/2010 10:28 PM, Alon Levy wrote: --- client/windows/platform.cpp | 22 +++--- 1 files changed, 11 insertions(+), 11 deletions(-) diff --git a/client/windows/platform.cpp b/client/windows/platform.cpp index 465bb2f..ebca0d1 100644 --- a/client/windows/platform.c

Re: [Spice-devel] [PATCH 18/24] mingw32 build: windows/Makefile.am: double NULL definition

Ack. On 12/07/2010 10:28 PM, Alon Levy wrote: --- client/windows/Makefile.am |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/client/windows/Makefile.am b/client/windows/Makefile.am index 81f41fc..ae104ff 100644 --- a/client/windows/Makefile.am +++ b/client/windows/Mak

Re: [Spice-devel] [PATCH 17/24] mingw32 build: missing linked files for spicec.exe

Ack. On 12/07/2010 10:28 PM, Alon Levy wrote: --- client/windows/Makefile.am |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/client/windows/Makefile.am b/client/windows/Makefile.am index 29c30a7..81f41fc 100644 --- a/client/windows/Makefile.am +++ b/client/windows/

Re: [Spice-devel] [PATCH 16/24] mingw32 build: check for CXImage, disable if not found (only on mingw32)

Hi, On 12/07/2010 10:28 PM, Alon Levy wrote: --- client/windows/Makefile.am |1 + client/windows/platform.cpp | 16 configure.ac| 21 + 3 files changed, 38 insertions(+), 0 deletions(-) diff --git a/client/windows/Makefile.am b/

Re: [Spice-devel] [PATCH 07/24] mingw32 build: -fvisibility test needs refinement, disable for now

On Wed, Dec 08, 2010 at 09:31:59AM +0100, Hans de Goede wrote: > Hmm, > > Not sure if I like this one, as it will polute the server > .so will all kinds of symbols. Maybe we should just > change the test to be: > > if test "x$have_gcc4" = "xyes" -a "$os_linux" = yes; then > > ? Pushed this one

Re: [Spice-devel] [PATCH 15/24] mingw32 build: remove unused, initialize uninitialized, reorder constructor initializers

Ack. On 12/07/2010 10:28 PM, Alon Levy wrote: --- client/controller.cpp |2 ++ client/windows/platform.cpp |8 client/windows/playback.cpp |3 +-- client/windows/record.cpp |2 +- 4 files changed, 8 insertions(+), 7 deletions(-) diff --git a/client/control

Re: [Spice-devel] [PATCH 14/24] mingw32 build: fix assignement as condition warning

Ack. On 12/07/2010 10:28 PM, Alon Levy wrote: --- client/windows/platform.cpp |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/client/windows/platform.cpp b/client/windows/platform.cpp index 06d5aa0..3e556fa 100644 --- a/client/windows/platform.cpp +++ b/client/window

Re: [Spice-devel] [PATCH 13/24] mingw32 build: fixed using -1 as uninitialized value for unsigned variables

Ack. On 12/07/2010 10:28 PM, Alon Levy wrote: --- client/red_client.cpp |4 ++-- client/red_client.h |2 +- client/red_peer.cpp |6 +++--- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/client/red_client.cpp b/client/red_client.cpp index 4923f29..c632a21 1006

Re: [Spice-devel] [PATCH 12/24] mingw32 build: fix signed/unsigned warnings as errors

Ack. On 12/07/2010 10:28 PM, Alon Levy wrote: --- client/application.cpp |4 ++-- client/cmd_line_parser.cpp |2 +- client/display_channel.cpp |2 +- client/hot_keys.cpp |2 +- client/mjpeg_decoder.cpp|2 +- client/mjpeg_decoder.h |6 +++---

Re: [Spice-devel] [PATCH 11/24] mingw32 build: fix configure.ac typo

Ack. On 12/07/2010 10:28 PM, Alon Levy wrote: --- configure.ac |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/configure.ac b/configure.ac index 7287946..918f7e7 100644 --- a/configure.ac +++ b/configure.ac @@ -154,7 +154,7 @@ for yield_func in pthread_yield pthread_

Re: [Spice-devel] [PATCH 10/24] mingw32 build: fix various warnings

Ack. On 12/07/2010 10:28 PM, Alon Levy wrote: --- client/windows/event_sources_p.cpp |2 +- client/windows/main.cpp| 10 +- client/windows/red_window_p.h |2 +- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/client/windows/event_sources_p.c

Re: [Spice-devel] [PATCH 09/24] mingw32 build: fix build errors

Ack. On 12/07/2010 10:28 PM, Alon Levy wrote: From: Gerd Hoffmann Signed-off-by: Gerd Hoffmann --- client/common.h | 10 ++ client/windows/platform_utils.h |3 ++- client/zlib_decoder.h |4 +++- common/gdi_canvas.c |4 ++-- 4 fil

Re: [Spice-devel] [PATCH 08/24] mingw32 build: disable ms compiler pragmas for gcc

Ack. On 12/07/2010 10:28 PM, Alon Levy wrote: From: Gerd Hoffmann Signed-off-by: Gerd Hoffmann --- client/common.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/client/common.h b/client/common.h index e1c149c..c3be656 100644 --- a/client/common.h +++ b/client/comm

Re: [Spice-devel] [PATCH 07/24] mingw32 build: -fvisibility test needs refinement, disable for now

Hmm, Not sure if I like this one, as it will polute the server .so will all kinds of symbols. Maybe we should just change the test to be: if test "x$have_gcc4" = "xyes" -a "$os_linux" = yes; then ? Regards, Hans On 12/07/2010 10:28 PM, Alon Levy wrote: From: Gerd Hoffmann Signed-off-by: G

Re: [Spice-devel] [PATCH 06/24] mingw32 build: add client/windows/Makefile, tweak configure

Ack. On 12/07/2010 10:28 PM, Alon Levy wrote: From: Gerd Hoffmann Signed-off-by: Gerd Hoffmann --- client/windows/Makefile.am | 195 configure.ac | 12 ++- 2 files changed, 205 insertions(+), 2 deletions(-) diff --git a/client/w

Re: [Spice-devel] [PATCH 05/24] build: s/HUGE/INFINITY/

Ack. On 12/07/2010 10:28 PM, Alon Levy wrote: From: Gerd Hoffmann Signed-off-by: Gerd Hoffmann --- client/red_client.cpp |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/client/red_client.cpp b/client/red_client.cpp index 46d5602..e1f5a42 100644 --- a/client/red_clie

Re: [Spice-devel] [PATCH 04/24] build: use jpeg_boolean with more recent libjpeg versions.

Ack. On 12/07/2010 10:28 PM, Alon Levy wrote: From: Gerd Hoffmann Signed-off-by: Gerd Hoffmann --- client/jpeg_decoder.cpp |6 +- client/mjpeg_decoder.cpp |6 +- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/client/jpeg_decoder.cpp b/client/jpeg_decoder.cp

Re: [Spice-devel] [PATCH 03/24] build: only check for x11 extensions when building for x11 platform.

Ack. On 12/07/2010 10:28 PM, Alon Levy wrote: From: Gerd Hoffmann --- configure.ac | 34 -- 1 files changed, 20 insertions(+), 14 deletions(-) diff --git a/configure.ac b/configure.ac index 7718a6d..4b732b5 100644 --- a/configure.ac +++ b/configure.ac @@ -2

Re: [Spice-devel] [PATCH 02/24] build: alsa is needed on linux only.

Ack. On 12/07/2010 10:28 PM, Alon Levy wrote: From: Gerd Hoffmann Signed-off-by: Gerd Hoffmann --- configure.ac | 10 ++ 1 files changed, 6 insertions(+), 4 deletions(-) diff --git a/configure.ac b/configure.ac index 4f3b118..7718a6d 100644 --- a/configure.ac +++ b/configure.ac @@

Re: [Spice-devel] [PATCH 01/24] server/tests: Makefile.am: use AM_LDFLAGS instead of LDFLAGS

Ack. On 12/07/2010 10:28 PM, Alon Levy wrote: --- server/tests/Makefile.am |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/server/tests/Makefile.am b/server/tests/Makefile.am index f91dfa4..1f8817f 100644 --- a/server/tests/Makefile.am +++ b/server/tests/Makefile.am