Re: [Spice-devel] [PATCH] server: improve error handling

2010-12-09 Thread Alon Levy
ACK On Thu, Dec 09, 2010 at 03:00:55PM +0100, Gerd Hoffmann wrote: > We should pass up errors instead of aborting. Do that at least > for bind() failures which actually happen in real live due to the > tcp port being busy. > > Signed-off-by: Gerd Hoffmann > --- > server/reds.c | 32 +

[Spice-devel] [PATCH] server: improve error handling

2010-12-09 Thread Gerd Hoffmann
We should pass up errors instead of aborting. Do that at least for bind() failures which actually happen in real live due to the tcp port being busy. Signed-off-by: Gerd Hoffmann --- server/reds.c | 32 1 files changed, 24 insertions(+), 8 deletions(-) diff -

Re: [Spice-devel] [PATCH] client/smartcard: external cac card library name and version changed

2010-12-09 Thread Hans de Goede
Ack. On 12/09/2010 02:34 PM, Alon Levy wrote: --- configure.ac |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index 72b377a..511d94e 100644 --- a/configure.ac +++ b/configure.ac @@ -183,10 +183,10 @@ if test "x$have_tunnel" = "xyes"; th

[Spice-devel] [PATCH] client/smartcard: external cac card library name and version changed

2010-12-09 Thread Alon Levy
--- configure.ac |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index 72b377a..511d94e 100644 --- a/configure.ac +++ b/configure.ac @@ -183,10 +183,10 @@ if test "x$have_tunnel" = "xyes"; then fi if test "x$have_smartcard" = "xyes"; then

Re: [Spice-devel] [PATCH 1/7] usb-linux: introduce a usb_linux_alt_setting function

2010-12-09 Thread Gerd Hoffmann
On 11/26/10 19:13, Hans de Goede wrote: The next patch in this series introduces multiple ways to get the alt setting dependent upon usb_fs_type, it is cleaner to put this into its own function. Note that this patch also changes the assumed alt setting in case of an error getting the alt setting

Re: [Spice-devel] Where is the file "spice/qxl_dev.h"?

2010-12-09 Thread Gerd Hoffmann
On 12/09/10 11:38, lin gu wrote: Hello,guys,thank you for the hard work of spice!I am reading the code of Spice and meet the include file ,but I can't find the file in qemu , spice or spice-protocol. It lives in spice-protocol. http://cgit.freedesktop.org/spice/spice-protocol/tree/spice/qxl

[Spice-devel] Where is the file "spice/qxl_dev.h"?

2010-12-09 Thread lin gu
Hello,guys,thank you for the hard work of spice!I am reading the code of Spice and meet the include file ,but I can't find the file in qemu , spice or spice-protocol.I read the change log of download sit,found it should be contained in the qemu,so where is it?How can I find it?I have got the spi

Re: [Spice-devel] [PATCH] qxl:fix double free surface when create device bitmap failed

2010-12-09 Thread Coolper Chen
On Thu, 2010-12-09 at 16:53 +0800, Alon Levy wrote: > On Thu, Dec 09, 2010 at 04:25:24PM +0800, Coolper Chen wrote: > > I'm using qxl master. > > > > GetSurfaceInfo(pdev, surface_id)->u.pdev = pdev; > > > > QXLGetSurface(pdev, phys_mem, size.cx, size.cy, depth, > > &stride, base_mem

Re: [Spice-devel] [PATCH] qxl:fix double free surface when create device bitmap failed

2010-12-09 Thread Alon Levy
On Thu, Dec 09, 2010 at 04:25:24PM +0800, Coolper Chen wrote: > I'm using qxl master. > > GetSurfaceInfo(pdev, surface_id)->u.pdev = pdev; > > QXLGetSurface(pdev, phys_mem, size.cx, size.cy, depth, > &stride, base_mem, allocation_type); > if (!*base_mem) { >//it executes "goto o

Re: [Spice-devel] [PATCH] qxl:fix double free surface when create device bitmap failed

2010-12-09 Thread Alon Levy
On Thu, Dec 09, 2010 at 04:25:24PM +0800, Coolper Chen wrote: > I'm using qxl master. > > GetSurfaceInfo(pdev, surface_id)->u.pdev = pdev; > > QXLGetSurface(pdev, phys_mem, size.cx, size.cy, depth, > &stride, base_mem, allocation_type); > if (!*base_mem) { >//it executes "goto o

Re: [Spice-devel] [PATCH] qxl:fix double free surface when create device bitmap failed

2010-12-09 Thread Coolper Chen
I'm using qxl master. GetSurfaceInfo(pdev, surface_id)->u.pdev = pdev; QXLGetSurface(pdev, phys_mem, size.cx, size.cy, depth, &stride, base_mem, allocation_type); if (!*base_mem) { //it executes "goto out_error2" in my windows xp guest. goto out_error2; } On Thu, 2010-12-09 a

Re: [Spice-devel] [PATCH] qxl:fix double free surface when create device bitmap failed

2010-12-09 Thread Alon Levy
On Thu, Dec 09, 2010 at 09:07:23AM +0800, Coolper Chen wrote: > DrvCreateDeviceBitmap will call FreeSurface function when > CreateDeviceBitmap failed, no need call FreeSurface function in > CreateDeviceBitmap function; > It fixes the windows XP bluescreen problem that I encounter. > > diff --git a

Re: [Spice-devel] [PATCH] qxl:fix double free surface when create device bitmap failed

2010-12-09 Thread Alon Levy
On Thu, Dec 09, 2010 at 09:07:23AM +0800, Coolper Chen wrote: > DrvCreateDeviceBitmap will call FreeSurface function when > CreateDeviceBitmap failed, no need call FreeSurface function in > CreateDeviceBitmap function; > It fixes the windows XP bluescreen problem that I encounter. > > diff --git a