Re: [Spice-devel] [PATCH qxl-win 0/4] fixes for RHBZ #722954, #731644

2011-08-24 Thread Alon Levy
On Wed, Aug 24, 2011 at 03:05:25PM +0300, Yonit Halperin wrote: ACK series. > The first patch removes unnecessary unmapping and remapping of the vram. > The third patch eliminates the need for the first patch, but I chose to still > apply it > since the unmapping is unnecessary. > > This set of

[Spice-devel] Status of getting usbredir support into F-16 / doing a 0.9.1 release?

2011-08-24 Thread Hans de Goede
Hi all, Just a quick update on $subject Done: 1) update libusb1 to 1.0.9 git snapshot (in F-16 stable) 2) update usbredir to 0.3.1 (in updates-testing and as buildroot-override) 3) build a qemu with usbredir support + a few extra patches (in updates-testing) To-do: 1) Do a new release of spice-

Re: [Spice-devel] [PATCH qxl-win 3/4] display: support clearing the pci-bar when the pdev is disabled for revision<3 as well, RHBZ #731644

2011-08-24 Thread Alon Levy
On Wed, Aug 24, 2011 at 03:05:28PM +0300, Yonit Halperin wrote: See comments below. > see also commit 3218f6cdb95a73. > > In revision < 3, objects (surfaces and other devram objects) stayed alive in > the pci ram > after DrvAssertMode(Disable) was called. Then, when another display driver > se

Re: [Spice-devel] [PATCH qxl-win 1/4] miniport: map vram to virtual address only once, #722954

2011-08-24 Thread Alon Levy
On Wed, Aug 24, 2011 at 03:05:26PM +0300, Yonit Halperin wrote: > DrvSurface calls IOCTL_VIDEO_MAP/UNMAP_VIDEO_MEMORY > respectively. > These calls make the miniport map/unmap the vram to/from system space. > The BSOD occurred since with qxl revision 2, the driver assumes that > as long as it is l

[Spice-devel] [PATCH qxl-win 3/4] display: support clearing the pci-bar when the pdev is disabled for revision<3 as well, RHBZ #731644

2011-08-24 Thread Yonit Halperin
see also commit 3218f6cdb95a73. In revision < 3, objects (surfaces and other devram objects) stayed alive in the pci ram after DrvAssertMode(Disable) was called. Then, when another display driver session started (upon switch user), the driver had newly initiated mspace, but an old release ring (

[Spice-devel] [PATCH qxl-win 2/4] display: not reset devices on DrvDisableDriver, RHBZ #731644

2011-08-24 Thread Yonit Halperin
When several sessions of the display driver are alive, DrvDisableDriver can be called for the older session while the newer session has already started. It happens when you switch users on a dual monitor XP guest. Reseting the devices in DrvDisableDriver while they are used by another session lea

[Spice-devel] [PATCH qxl-win 1/4] miniport: map vram to virtual address only once, #722954

2011-08-24 Thread Yonit Halperin
DrvSurface calls IOCTL_VIDEO_MAP/UNMAP_VIDEO_MEMORY respectively. These calls make the miniport map/unmap the vram to/from system space. The BSOD occurred since with qxl revision 2, the driver assumes that as long as it is loaded the vram stays (and all the other mem slots) valid and in the same p

[Spice-devel] [PATCH qxl-win 0/4] fixes for RHBZ #722954, #731644

2011-08-24 Thread Yonit Halperin
The first patch removes unnecessary unmapping and remapping of the vram. The third patch eliminates the need for the first patch, but I chose to still apply it since the unmapping is unnecessary. This set of patches might also solve the BSOD Damien Churchill encountered when connecting with rdp a

Re: [Spice-devel] [PATCH 1/3] fix inverted memset parameters

2011-08-24 Thread Hans de Goede
Good work! Ack series. I think we should add these to the 0.8 branch too. On 08/24/2011 04:41 AM, Christophe Fergeau wrote: Issue found by the Coverity scanner. --- server/red_dispatcher.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/server/red_dispatcher.c b/s