[Spice-devel] Possible SPICE/QEMU deadlock on fast client reconnect

2011-10-21 Thread Daniel P. Berrange
In testing my patches for 'add_client' support with SPICE, I noticed deadlock in the QEMU/SPICE code. It only happens if I close a SPICE client and then immediately reconnect within about 1 second. If I wait a couple of seconds before reconnecting the SPICE client I don't see the deadlock. I'm usi

[Spice-devel] [PATCH] Add SPICE support to add_client monitor command

2011-10-21 Thread Daniel P. Berrange
From: "Daniel P. Berrange" With the proposal of some new APIs[1] to libspice-server.so it is possible to add support for SPICE to the 'add_client' monitor command, bringing parity with VNC. Since SPICE can use TLS or plain connections, the command also gains a new 'tls' parameter to specify wheth

[Spice-devel] [PATCH 6/6] Do not assume that SPICE is using a TCP socket

2011-10-21 Thread Daniel P. Berrange
From: "Daniel P. Berrange" If setting the TCP_NODELAY socket option fails with ENOTSUP, then don't treat this is a fatal error. SPICE is likely just running over a UNIX socket instead. * server/inputs_channel.c: Ignore TCP_NODELAY socket opt fails Signed-off-by: Daniel P. Berrange --- server/

[Spice-devel] [PATCH 5/6] Allow auth to be skipped when attaching to pre-accepted clients

2011-10-21 Thread Daniel P. Berrange
From: "Daniel P. Berrange" When an applications passes in a pre-accepted socket for a client, they may well have already performed suitable authentication out of band. They should thus have the option to request that any spice authentication is skipped. * server/reds.c, spice.h: Add flag for ski

[Spice-devel] [PATCH 4/6] Add APIs for injecting a client connection socket

2011-10-21 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Allow applications to pass a pre-accepted client socket file descriptor in. The new APIs are spice_server_add_ssl_client and spice_server_add_client * server/reds.c: Implement new APIs * server/spice.h: Define new APIs Signed-off-by: Daniel P. Berrange --- server/re

[Spice-devel] [PATCH 3/6] Move SSL setup out of reds_accept_ssl_connection

2011-10-21 Thread Daniel P. Berrange
From: "Daniel P. Berrange" To allow setup of an SSL client, from a passed in client socket, move all the SSL client initialization code out of reds_accept_ssl_connection and into a new method called reds_init_client_ssl_connection * server/reds.c: Introduce reds_init_client_ssl_connection Signe

[Spice-devel] [PATCH 2/6] Rename __reds_accept_connection into reds_init_client_connection

2011-10-21 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Remove the accept() call from __reds_accept_connection and rename it to reds_init_client_connection. The caller is now responsible for accepting the new socket. The method reds_init_client_connection merely initializes it for usage. * server/reds.c: Add reds_init_clien

[Spice-devel] [PATCH 1/6] Merge reds_accept_connection into reds_accept

2011-10-21 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Neither reds_accept_connection or reds_accept are very long, so the split is pointless & increases code size for no gain. Merge them together to reduce code size * server/reds.c: Merge reds_accept_connection into reds_accept Signed-off-by: Daniel P. Berrange --- ser

[Spice-devel] [PATCH 0/6] Add new libspice-server.so APIs for injecting client sockets

2011-10-21 Thread Daniel P. Berrange
QEMU has a monitor command 'add_client' which can be used over a UNIX domain socket connection with SCM_RIGHTS, to pass a pre-opened client socket connection FD for graphics displays. This series adds two new APIs for libspice-server.so which enable QEMU to wire up this monitor command for SPICE, a

Re: [Spice-devel] Qemu-kvm for Spice...

2011-10-21 Thread Gerd Hoffmann
Hi, > http://cgit.freedesktop.org/spice/qemu spice support is merged upstream, these days this repository is just a staging area used to send out pull requests to merge spice patches upstream. Usually there is nothing interesting there. > Which is the right one for Qemu-kvm with Spice? Just

Re: [Spice-devel] inputs_channel.c undefined variable

2011-10-21 Thread Christophe Fergeau
On Fri, Oct 21, 2011 at 12:06:35AM -0700, Mizon Tsai wrote: > What is your favorite OS + IDE combo for doing Spice development?  Most of us are using Fedora I think, I'm using vim as an IDE > > Started a new Makefile C/C++ project, and ran a build (using GNU > Autotools build) after project setup

Re: [Spice-devel] inputs_channel.c undefined variable

2011-10-21 Thread Mizon Tsai
Hi Spice-developers, What is your favorite OS + IDE combo for doing Spice development?  I am trying Eclipse Indigo 64bit on Fedora 15 64bit. Started a new Makefile C/C++ project, and ran a build (using GNU Autotools build) after project setup. But when opened server/inputs_channel.c file, some v