Re: [Spice-devel] FFMPEG with Spice....

2011-10-28 Thread Alon Levy
On Thu, Oct 27, 2011 at 05:01:19PM -0700, Naga Mohan Pothula wrote: >Hi, >FFMPEG has mentioned in Spice user manual as prerequisite for building >Spice on Linux. >But it is no where mentioned at Building instructions under Spice wiki. >is FFMPEG currently used in Spice or not? >

Re: [Spice-devel] [PATCH 4/6] Add APIs for injecting a client connection socket

2011-10-28 Thread Gerd Hoffmann
Hi, >SPICE_SERVER_0.10.0.a (a, b, c, etc) Looks good to me. >SPICE_SERVER_0.10.0.p1 (patch level 1, 2, 3, etc) Would work too. I'd prefer 'a' but its a matter of taste after all ;) >SPICE_SERVER_0.10.1(go straight for 0.10.1 release version) Don't think we'll go straight t

Re: [Spice-devel] [PATCH 4/6] Add APIs for injecting a client connection socket

2011-10-28 Thread Daniel P. Berrange
On Fri, Oct 28, 2011 at 03:03:57PM +0200, Gerd Hoffmann wrote: > Hi, > > > diff --git a/server/spice-server.syms b/server/spice-server.syms > > index f1374bd..c34ff86 100644 > > --- a/server/spice-server.syms > > +++ b/server/spice-server.syms > > @@ -89,5 +89,7 @@ global: > > spice_server_

Re: [Spice-devel] [PATCH 4/6] Add APIs for injecting a client connection socket

2011-10-28 Thread Gerd Hoffmann
Hi, > diff --git a/server/spice-server.syms b/server/spice-server.syms > index f1374bd..c34ff86 100644 > --- a/server/spice-server.syms > +++ b/server/spice-server.syms > @@ -89,5 +89,7 @@ global: > spice_server_record_set_mute; > spice_server_record_set_volume; > spice_server_get

[Spice-devel] [PATCH 6/6] Do not assume that SPICE is using a TCP socket

2011-10-28 Thread Daniel P. Berrange
From: "Daniel P. Berrange" If setting the TCP_NODELAY socket option fails with ENOTSUP, then don't treat this is a fatal error. SPICE is likely just running over a UNIX socket instead. * server/inputs_channel.c: Ignore TCP_NODELAY socket opt fails Signed-off-by: Daniel P. Berrange --- server/

[Spice-devel] [PATCH 5/6] Allow auth to be skipped when attaching to pre-accepted clients

2011-10-28 Thread Daniel P. Berrange
From: "Daniel P. Berrange" When an applications passes in a pre-accepted socket for a client, they may well have already performed suitable authentication out of band. They should thus have the option to request that any spice authentication is skipped. * server/reds.c, spice.h: Add flag for ski

[Spice-devel] [PATCH 4/6] Add APIs for injecting a client connection socket

2011-10-28 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Allow applications to pass a pre-accepted client socket file descriptor in. The new APIs are spice_server_add_ssl_client and spice_server_add_client * server/reds.c: Implement new APIs * server/spice.h: Define new APIs Signed-off-by: Daniel P. Berrange --- server/re

[Spice-devel] [PATCH 3/6] Move SSL setup out of reds_accept_ssl_connection

2011-10-28 Thread Daniel P. Berrange
From: "Daniel P. Berrange" To allow setup of an SSL client, from a passed in client socket, move all the SSL client initialization code out of reds_accept_ssl_connection and into a new method called reds_init_client_ssl_connection * server/reds.c: Introduce reds_init_client_ssl_connection Signe

[Spice-devel] [PATCH 2/6] Rename __reds_accept_connection into reds_init_client_connection

2011-10-28 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Remove the accept() call from __reds_accept_connection and rename it to reds_init_client_connection. The caller is now responsible for accepting the new socket. The method reds_init_client_connection merely initializes it for usage. * server/reds.c: Add reds_init_clien

[Spice-devel] [PATCH 1/6] Merge reds_accept_connection into reds_accept

2011-10-28 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Neither reds_accept_connection or reds_accept are very long, so the split is pointless & increases code size for no gain. Merge them together to reduce code size * server/reds.c: Merge reds_accept_connection into reds_accept Signed-off-by: Daniel P. Berrange --- ser

[Spice-devel] [PATCH 0/6 v2] Add new libspice-server.so APIs for injecting client sockets

2011-10-28 Thread Daniel P. Berrange
An update to: http://lists.freedesktop.org/archives/spice-devel/2011-October/005834.html QEMU has a monitor command 'add_client' which can be used over a UNIX domain socket connection with SCM_RIGHTS, to pass a pre-opened client socket connection FD for graphics displays. This series adds two n

Re: [Spice-devel] [PATCH 2/6] Rename __reds_accept_connection into reds_init_client_connection

2011-10-28 Thread Daniel P. Berrange
On Wed, Oct 26, 2011 at 03:29:55PM +0200, Marc-André Lureau wrote: > Hi > > I would move the cb intialization in reds_init_client_connection () to > avoid duplication: > > stream = link->stream; > stream->read = stream_read_cb; > stream->write = stream_write_cb; > stream->writev =

Re: [Spice-devel] Usage of Celt library with Spice...

2011-10-28 Thread Christophe Fergeau
Hi, On Thu, Oct 27, 2011 at 05:01:51PM -0700, Naga Mohan Pothula wrote: > I noticed celt 0.11.1 had released but still spice uses > celt 0.5.1.3 which is very old version.It is clearly mentioned in > Building instruction at wiki.   celt = 0.5.1.3 (this is important, newer > versions use a differen