Todd And Margo Chester píše v Po 07. 11. 2011 v 19:08 -0800:
> Hi Guys,
>
> Scientific Linux 6.2 x64
> host: kvm
> guests: fc15 x64, XP-Pro x32, W7 x32
> spice 0.8.x
>
> To my consternation, I have found that if I mouse over my guest's SPICEc
> window,
> I will loose my mouse until the guest mac
Hi,
Ack series, after fixing the small comments.
Thanks,
Yonit.
On 11/07/2011 01:44 PM, Alon Levy wrote:
"introdice dispatcher" patch changed from v1, following Paolo's suggestion to
use poll. verified after the first patch and after the whole bit. (using
qxl-win-0.1-12). The large refactor of
Hi,
renames requests bellow
On 11/07/2011 01:44 PM, Alon Levy wrote:
---
server/dispatcher.c |9 +
server/dispatcher.h | 15 +++
2 files changed, 24 insertions(+), 0 deletions(-)
diff --git a/server/dispatcher.c b/server/dispatcher.c
index b54580e..7e9eb3a 100644
--
Hi,
2 comments bellow
On 11/07/2011 01:44 PM, Alon Levy wrote:
used for main_dispatcher only in this patch.
Dispatcher is meant to be used for Main<->any low frequency messages.
It's interface is meant to include the red_dispatcher usage:
fixed size messages per message type
some messages r
Hi Guys,
Scientific Linux 6.2 x64
host: kvm
guests: fc15 x64, XP-Pro x32, W7 x32
spice 0.8.x
To my consternation, I have found that if I mouse over my guest's SPICEc
window,
I will loose my mouse until the guest machine boots to the point that
its mouse
driver get enabled. Then I get my mous
Hi Guys,
Scientific Linux 6.2 x64
host: kvm
guests: fc15 x64, XP-Pro x32, W7 x32
spice 0.8.x
Googl'ing does to seem to help on this issue. Would some kind
person please send me a link to the actual directions as to how
to install Clip Board sharing?
Many thanks,
-T
Hi,
I would like to ask if there is any binary with Windows client for SPICE
0.8.x? The 0.6.x binary available at the site fails with some peculiar
error connected to SSL. So I wanted to give a try to 0.8.x version.
However, I'm not sure if I have all the infrastructure to compile the
Windows
Am Montag, den 07.11.2011, 15:43 +0100 schrieb Hans de Goede:
> AFAIK you may only call g_clear_object on non NULL GObject pointers,
> and if the matching foo_get was never called, it will be NULL, so
> I believe this should be:
>
> if (s->audio_manager)
> g_clear_object(&s->audio_ma
Hi,
On 11/07/2011 03:55 PM, Marc-André Lureau wrote:
Hi
AFAIK you may only call g_clear_object on non NULL GObject pointers,
and if the matching foo_get was never called, it will be NULL, so
I believe this should be:
if (s->audio_manager)
g_clear_object(&s->audio_manager);
g
Hi
> AFAIK you may only call g_clear_object on non NULL GObject pointers,
> and if the matching foo_get was never called, it will be NULL, so
> I believe this should be:
>
> if (s->audio_manager)
> g_clear_object(&s->audio_manager);
g_clear_object() doesn't want a NULL pointer (to
Hi,
Looks like a nice cleanup to me :)
I've one remark though, see below.
On 11/07/2011 03:01 PM, Marc-André Lureau wrote:
This is not really clean, as it may conflict with client usage
---
gtk/spice-audio.c|7 ++---
gtk/spice-gtk-session.c | 20 +++
gtk/spice-se
This is not really clean, as it may conflict with client usage
---
gtk/spice-audio.c|7 ++---
gtk/spice-gtk-session.c | 20 +++
gtk/spice-session-priv.h | 58 ++
gtk/spice-session.c | 56 +++
On Mon, Nov 07, 2011 at 01:44:59PM +0100, Gerd Hoffmann wrote:
> On 11/07/11 11:57, Alon Levy wrote:
> > On Thu, Nov 03, 2011 at 05:54:43PM +0100, Gerd Hoffmann wrote:
> >> Hi,
> >>
> 2) I could not see the boot failing with my F-14 image and qemu-1.0rc0
> since it does not show vga gra
On 11/07/11 11:57, Alon Levy wrote:
> On Thu, Nov 03, 2011 at 05:54:43PM +0100, Gerd Hoffmann wrote:
>> Hi,
>>
2) I could not see the boot failing with my F-14 image and qemu-1.0rc0
since it does not show vga graphics over spice.
>>>
>>> Looks like text mode broke while I wasn't looking
On Mon, Nov 07, 2011 at 01:28:49PM +0100, Gerd Hoffmann wrote:
> Hi,
>
> > So ideally, in the future, I think we would want to have something
> > like: "MySpiceClient (NameOfVM)".
>
> Yes (likewise for the window title). Unfortunaly the spice protocol
> doesn't support sending the vm name toda
Hi,
> So ideally, in the future, I think we would want to have something
> like: "MySpiceClient (NameOfVM)".
Yes (likewise for the window title). Unfortunaly the spice protocol
doesn't support sending the vm name today, so it isn't that easy to do.
cheers,
Gerd
On 11/07/2011 01:05 PM, Alon Levy wrote:
> >+void dispatcher_handle_recv_read(Dispatcher *dispatcher)
> >+{
> >+while (dispatcher_handle_single_read(dispatcher)) {
> >+}
> >+}
>
> This will busy-wait if no messages are ready.
dispatcher_handle_single_read returns 0 when it fails
On Mon, Nov 07, 2011 at 12:29:26PM +0100, Marc-André Lureau wrote:
> On Mon, Nov 7, 2011 at 9:28 AM, Christophe Fergeau
> wrote:
> > Is there any reason for not using a GOnce here?
>
> Can you use GOnce per-instance?
Ah no probably not.
> We need it for each session (unlike
> the smartcard ma
Hey
On Mon, Nov 7, 2011 at 9:43 AM, Christophe Fergeau wrote:
> Rereading g_get_application_name, I was wondering if g_get_prg_name()
> wouldn't be more appropriate here? g_get_application_name is the localized
> application name for presentation to the user, g_get_prg_name is an
> unlocalized on
On Mon, Nov 07, 2011 at 12:52:25PM +0100, Paolo Bonzini wrote:
> On 11/07/2011 12:44 PM, Alon Levy wrote:
> >+void dispatcher_handle_recv_read(Dispatcher *dispatcher)
> >+{
> >+while (dispatcher_handle_single_read(dispatcher)) {
> >+}
> >+}
>
> This will busy-wait if no messages are ready.
Hey
On Mon, Nov 7, 2011 at 9:33 AM, Christophe Fergeau wrote:
> Is it needed since there's a default value specified in g_param_spec_boolean?
>
Actually no if we specify G_PARAM_CONSTRUCT. I am going to push that
too for audio and usbredir property. Apparently it is not needed
elsewhere.
--
M
On 11/07/2011 12:44 PM, Alon Levy wrote:
+void dispatcher_handle_recv_read(Dispatcher *dispatcher)
+{
+while (dispatcher_handle_single_read(dispatcher)) {
+}
+}
This will busy-wait if no messages are ready.
I'm not sure what you want to do here, since this is the sole caller of
dispat
---
server/red_dispatcher.c | 14 +++---
server/red_dispatcher.h | 18 +---
server/red_worker.c | 94 ---
3 files changed, 66 insertions(+), 60 deletions(-)
diff --git a/server/red_dispatcher.c b/server/red_dispatcher.c
index eaa0164..17b4
---
server/dispatcher.c |9 +
server/dispatcher.h | 15 +++
2 files changed, 24 insertions(+), 0 deletions(-)
diff --git a/server/dispatcher.c b/server/dispatcher.c
index b54580e..7e9eb3a 100644
--- a/server/dispatcher.c
+++ b/server/dispatcher.c
@@ -111,6 +111,8 @@ stat
---
server/dispatcher.c | 12 +++-
server/dispatcher.h | 13 +++--
2 files changed, 18 insertions(+), 7 deletions(-)
diff --git a/server/dispatcher.c b/server/dispatcher.c
index e2973a4..b54580e 100644
--- a/server/dispatcher.c
+++ b/server/dispatcher.c
@@ -105,10 +105,12 @@ s
used for main_dispatcher only in this patch.
Dispatcher is meant to be used for Main<->any low frequency messages.
It's interface is meant to include the red_dispatcher usage:
fixed size messages per message type
some messages require an ack
Some methods are added to be used by RedDispatcher l
---
server/red_dispatcher.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/server/red_dispatcher.c b/server/red_dispatcher.c
index 5257e6b..0c7a875 100644
--- a/server/red_dispatcher.c
+++ b/server/red_dispatcher.c
@@ -47,7 +47,7 @@ static int num_active_workers = 0;
#d
"introdice dispatcher" patch changed from v1, following Paolo's suggestion to
use poll. verified after the first patch and after the whole bit. (using
qxl-win-0.1-12). The large refactor of red_dispatcher has been left almost
as is minus some renames for consistency (RedDispatcher is red_dispatche
Hi
On Mon, Nov 7, 2011 at 9:28 AM, Christophe Fergeau wrote:
> Is there any reason for not using a GOnce here?
Can you use GOnce per-instance? We need it for each session (unlike
the smartcard manager, which is also something we may want to change
in the future, I guess)
regards
--
Marc-André
On Thu, Nov 03, 2011 at 05:54:43PM +0100, Gerd Hoffmann wrote:
> Hi,
>
> >> 2) I could not see the boot failing with my F-14 image and qemu-1.0rc0
> >> since it does not show vga graphics over spice.
> >
> > Looks like text mode broke while I wasn't looking, investigating ...
>
> vga ports are
On Mon, Nov 07, 2011 at 09:28:34AM +0100, Paolo Bonzini wrote:
> On 11/06/2011 05:49 PM, Alon Levy wrote:
> >+while (read_size< size) {
> >+ret = read(fd, buf + read_size, size - read_size);
> >+if (ret == -1) {
> >+if (errno != EINTR) {
> >+if (errn
On Mon, Nov 07, 2011 at 09:35:27AM +0100, Christophe Fergeau wrote:
> On Sat, Nov 05, 2011 at 05:56:07PM +0100, Marc-André Lureau wrote:
> > ---
> > gtk/spice-audio.c |9 +
> > 1 files changed, 5 insertions(+), 4 deletions(-)
> >
> > diff --git a/gtk/spice-audio.c b/gtk/spice-audio.c
On Sat, Nov 05, 2011 at 05:56:07PM +0100, Marc-André Lureau wrote:
> ---
> gtk/spice-audio.c |9 +
> 1 files changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/gtk/spice-audio.c b/gtk/spice-audio.c
> index e991cea..3f4bb80 100644
> --- a/gtk/spice-audio.c
> +++ b/gtk/spice-audi
ACK
On Sat, Nov 05, 2011 at 05:56:09PM +0100, Marc-André Lureau wrote:
> ---
> gtk/spice-client.h |1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/gtk/spice-client.h b/gtk/spice-client.h
> index 48ea96d..3f84b0b 100644
> --- a/gtk/spice-client.h
> +++ b/gtk/spice-cli
On Sat, Nov 05, 2011 at 05:56:08PM +0100, Marc-André Lureau wrote:
> Create audio channels only if enable-audio is TRUE
> ---
> gtk/spice-channel.c | 14 ++
> gtk/spice-option.c |5 +
> gtk/spice-session.c | 28
> 3 files changed, 43 insertions
On 11/06/2011 05:49 PM, Alon Levy wrote:
+while (read_size< size) {
+ret = read(fd, buf + read_size, size - read_size);
+if (ret == -1) {
+if (errno != EINTR) {
+if (errno == EAGAIN&& !block) {
+return 0;
+}
+
On Sat, Nov 05, 2011 at 05:56:06PM +0100, Marc-André Lureau wrote:
> We are going to deprecate spice_audio_new()
> some day. There are a few know problems:
> - SpiceAudio is an abstract class,
> so it can't have a ctor
> - SpiceAudio should be a singleton,
> associated with the session lifetime
Ack
On 11/06/2011 06:49 PM, Alon Levy wrote:
printed before function name. No central location for prefixes.
Adding "WORKER", "ASYNC", "MAIN" since those were the current users.
---
common/spice_common.h |4 ++--
server/main_channel.c |2 +-
server/red_dispatcher.c | 17
All 4 patches look good, ACK series.
Regards,
Hans
On 11/05/2011 05:56 PM, Marc-André Lureau wrote:
We are going to deprecate spice_audio_new()
some day. There are a few know problems:
- SpiceAudio is an abstract class,
so it can't have a ctor
- SpiceAudio should be a singleton,
associa
39 matches
Mail list logo
