Re: [Spice-devel] [PATCH 0/6 v3] Add new libspice-server.so APIs for injecting client sockets

2011-12-12 Thread Daniel P. Berrange
On Mon, Dec 12, 2011 at 11:56:51AM -0500, Marc-André Lureau wrote: > Hi Daniel > > - Mensaje original - > > An update to: > > > > v2: > > http://lists.freedesktop.org/archives/spice-devel/2011-October/005881.html > > v1: > > http://lists.freedesktop.org/archives/spice-devel/2011-Octob

Re: [Spice-devel] [PATCH 0/6 v3] Add new libspice-server.so APIs for injecting client sockets

2011-12-12 Thread Marc-André Lureau
Hi Daniel - Mensaje original - > An update to: > > v2: > http://lists.freedesktop.org/archives/spice-devel/2011-October/005881.html > v1: > http://lists.freedesktop.org/archives/spice-devel/2011-October/005834.html I think I ack'ed it all in v2, so ack again from me. Do you have per

[Spice-devel] [PATCH 6/6] Do not assume that SPICE is using a TCP socket

2011-12-12 Thread Daniel P. Berrange
From: "Daniel P. Berrange" If setting the TCP_NODELAY socket option fails with ENOTSUP, then don't treat this is a fatal error. SPICE is likely just running over a UNIX socket instead. * server/inputs_channel.c: Ignore TCP_NODELAY socket opt fails Signed-off-by: Daniel P. Berrange --- server/

[Spice-devel] [PATCH 5/6] Allow auth to be skipped when attaching to pre-accepted clients

2011-12-12 Thread Daniel P. Berrange
From: "Daniel P. Berrange" When an applications passes in a pre-accepted socket for a client, they may well have already performed suitable authentication out of band. They should thus have the option to request that any spice authentication is skipped. * server/reds.c, spice.h: Add flag for ski

[Spice-devel] [PATCH 4/6] Add APIs for injecting a client connection socket

2011-12-12 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Allow applications to pass a pre-accepted client socket file descriptor in. The new APIs are spice_server_add_ssl_client and spice_server_add_client * server/reds.c: Implement new APIs * server/spice.h: Define new APIs Signed-off-by: Daniel P. Berrange --- server/re

[Spice-devel] [PATCH 3/6] Move SSL setup out of reds_accept_ssl_connection

2011-12-12 Thread Daniel P. Berrange
From: "Daniel P. Berrange" To allow setup of an SSL client, from a passed in client socket, move all the SSL client initialization code out of reds_accept_ssl_connection and into a new method called reds_init_client_ssl_connection * server/reds.c: Introduce reds_init_client_ssl_connection Signe

[Spice-devel] [PATCH 2/6] Rename __reds_accept_connection into reds_init_client_connection

2011-12-12 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Remove the accept() call from __reds_accept_connection and rename it to reds_init_client_connection. The caller is now responsible for accepting the new socket. The method reds_init_client_connection merely initializes it for usage. * server/reds.c: Add reds_init_clien

[Spice-devel] [PATCH 1/6] Merge reds_accept_connection into reds_accept

2011-12-12 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Neither reds_accept_connection or reds_accept are very long, so the split is pointless & increases code size for no gain. Merge them together to reduce code size * server/reds.c: Merge reds_accept_connection into reds_accept Signed-off-by: Daniel P. Berrange --- ser

[Spice-devel] [PATCH 0/6 v3] Add new libspice-server.so APIs for injecting client sockets

2011-12-12 Thread Daniel P. Berrange
An update to: v2: http://lists.freedesktop.org/archives/spice-devel/2011-October/005881.html v1: http://lists.freedesktop.org/archives/spice-devel/2011-October/005834.html QEMU has a monitor command 'add_client' which can be used over a UNIX domain socket connection with SCM_RIGHTS, to pass a p

Re: [Spice-devel] spice-gtk failing to build

2011-12-12 Thread Marc-André Lureau
On Fri, Dec 9, 2011 at 5:25 PM, Damien Churchill wrote: > Hi, I'm trying to build git HEAD and I'm receiving an error: > > CC SpiceClientGtk_la-spice-client-gtk-module.defs.lo > For the records, this is now fixed in spice-gtk.git, thanks -- Marc-André Lureau __