[Spice-devel] [PATCH spice-gtk] windows: initialize co->ret to not randomly release fiber

2011-12-14 Thread Marc-André Lureau
--- gtk/coroutine_winfibers.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/gtk/coroutine_winfibers.c b/gtk/coroutine_winfibers.c index a22da3b..a4cd14b 100644 --- a/gtk/coroutine_winfibers.c +++ b/gtk/coroutine_winfibers.c @@ -60,6 +60,7 @@ int coroutine_init(struct cor

Re: [Spice-devel] License in server/red_parse_qxl.h is GPL, not LGPL

2011-12-14 Thread Bruce Rogers
>>> On 12/14/2011 at 10:10 AM, "Daniel P. Berrange" >>> wrote: > On Wed, Dec 14, 2011 at 09:02:52AM -0700, Bruce Rogers wrote: >> When trying to submit a spice package to openSUSE, >> our licensing team noticed that the file server/red_parse_qxl.h >> is GPL-2.0+. This seems like an oversight,

Re: [Spice-devel] License in server/red_parse_qxl.h is GPL, not LGPL

2011-12-14 Thread Daniel P. Berrange
On Wed, Dec 14, 2011 at 09:02:52AM -0700, Bruce Rogers wrote: > When trying to submit a spice package to openSUSE, > our licensing team noticed that the file server/red_parse_qxl.h > is GPL-2.0+. This seems like an oversight, particularly as the > corresponding red_parse_qxl.c file right next to th

Re: [Spice-devel] [PATCH spice-gtk 1/9] spice-channel: cleanup, get rid of wait_interruptible variable

2011-12-14 Thread Marc-André Lureau
Hi guys, Hans, this is a similar patch series I already reviewed positively, I would just prefer Christophe reviewed the smartcard changes, and did a quick test. cheers ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freed

[Spice-devel] License in server/red_parse_qxl.h is GPL, not LGPL

2011-12-14 Thread Bruce Rogers
When trying to submit a spice package to openSUSE, our licensing team noticed that the file server/red_parse_qxl.h is GPL-2.0+. This seems like an oversight, particularly as the corresponding red_parse_qxl.c file right next to the header file has a LGPL-2.1+ license, which was corrected subsequent

Re: [Spice-devel] [PATCH spice-gtk] Disable mouse accelleration when grabbing the mouse (in server mode)

2011-12-14 Thread Alon Levy
On Wed, Dec 14, 2011 at 02:17:15PM +0100, Hans de Goede wrote: > Otherwise accel will be applied twice, once by the client and then once > more by the guest. Unfortunately there seems to be no gdk / gtk API for this > so this patch uses direct libX11 calls. > ACK. > Signed-off-by: Hans de Goede

[Spice-devel] [PATCH spice-gtk 9/9] spice-channel: cleanup, remove spice_channel_send_msg()

2011-12-14 Thread Hans de Goede
There are only 2 callers, both of which want it to do a different thing, making the callers do this directly allows us to remove spice_channel_send_msg(); and gets rid of the weirdness where we've a function which can be called in both co-routine and system context. Signed-off-by: Hans de Goede -

[Spice-devel] [PATCH spice-gtk 8/9] spice-channel: Move read only check to spice_channel_write_msg()

2011-12-14 Thread Hans de Goede
This is a preparation patch for removing spice_channel_send_msg(). Note that this means that buffered writes won't get checked until they are actually send by the co-routine. Signed-off-by: Hans de Goede --- gtk/spice-channel.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(

[Spice-devel] [PATCH spice-gtk 7/9] spice-channel: Move setting of header->size to spice_channel_write_msg()

2011-12-14 Thread Hans de Goede
Just a small cleanup patch. Signed-off-by: Hans de Goede --- gtk/spice-channel.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/gtk/spice-channel.c b/gtk/spice-channel.c index ed22378..08b8d4b 100644 --- a/gtk/spice-channel.c +++ b/gtk/spice-channel.c @@ -540,8 +54

[Spice-devel] [PATCH spice-gtk 6/9] spice-channel: replace the xmit buf by a queue of SpiceOutMsg-s

2011-12-14 Thread Hans de Goede
This has a number of advantages: -It significantly simplifies the code -It avoids memcpy-ing all the write data one more time -It avoids malloc / realloc / free of the xmit buffer (this gets replaced by gslice alloc / free for the queue elements) Signed-off-by: Hans de Goede --- gtk/spice-chann

[Spice-devel] [PATCH spice-gtk 5/9] Make sure spice_channel_iterate_write() always flushes *all* pending writes

2011-12-14 Thread Hans de Goede
This patch changes 1 line, and fixes 2 bugs in this one line: 1) We keep the xmit_buffer around for reuse (re-filling) later, so checking if we've a xmit_buffer to determine wether we should do a write is wrong, instead we should check if the xmit_buffer has data in it. 2) If the write blocks

[Spice-devel] [PATCH spice-gtk 4/9] spice_msg_out[_send_internal]: Take ownership of the passed SpiceMsgOut

2011-12-14 Thread Hans de Goede
All callers of spice_msg_out[_send_internal] unref the message immediately after calling spice_msg_out[_send_internal]. This patch changes the semantics so that spice_msg_out[_send_internal] takes ownership and it is responsible for unref-ing the passed in SpiceMsgOut. This is a preparation patch

[Spice-devel] [PATCH spice-gtk 3/9] channel-smartcard: unref in flight messages as soon as they are send

2011-12-14 Thread Hans de Goede
This is a preparation patch for making spice_msg_out_send() take ownership of the passed in msg. Signed-off-by: Hans de Goede --- gtk/channel-smartcard.c | 12 +--- 1 files changed, 9 insertions(+), 3 deletions(-) diff --git a/gtk/channel-smartcard.c b/gtk/channel-smartcard.c index 64

[Spice-devel] [PATCH spice-gtk 2/9] smartcard_message_complete_in_flight cleanup error checking

2011-12-14 Thread Hans de Goede
smartcard_message_complete_in_flight should never get called if there is no message in flight (priv->in_flight_message != NULL). Signed-off-by: Hans de Goede --- gtk/channel-smartcard.c |5 + 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/gtk/channel-smartcard.c b/gtk/cha

[Spice-devel] [PATCH spice-gtk 1/9] spice-channel: cleanup, get rid of wait_interruptible variable

2011-12-14 Thread Hans de Goede
The private wait_interruptible channel variable is not used anywhere, except in one test, which is useless since it never gets set. Signed-off-by: Hans de Goede --- gtk/spice-channel-priv.h |1 - gtk/spice-channel.c |9 + 2 files changed, 1 insertions(+), 9 deletions(-) dif

[Spice-devel] [PATCH spice-gtk] Disable mouse accelleration when grabbing the mouse (in server mode)

2011-12-14 Thread Hans de Goede
Otherwise accel will be applied twice, once by the client and then once more by the guest. Unfortunately there seems to be no gdk / gtk API for this so this patch uses direct libX11 calls. Signed-off-by: Hans de Goede --- gtk/spice-widget.c | 33 + 1 files chang

Re: [Spice-devel] client_migrate_info - do we need a new command?

2011-12-14 Thread Avi Kivity
On 12/13/2011 08:19 PM, Anthony Liguori wrote: > In our call today, Avi asked that we evaluate whether the interface > for client_migrate_info is the Right Interface before we introduce a > new command to work around the fact that async commands are broken. > > I looked into this today and here's w

Re: [Spice-devel] client_migrate_info - do we need a new command?

2011-12-14 Thread Yonit Halperin
Hi, On 12/13/2011 08:19 PM, Anthony Liguori wrote: In our call today, Avi asked that we evaluate whether the interface for client_migrate_info is the Right Interface before we introduce a new command to work around the fact that async commands are broken. I looked into this today and here's what