Re: [Spice-devel] keyboard and Mouse Fails....

2011-12-19 Thread Naga Mohan Pothula
We can move mouse over the guest but the guest doesn't respond for user actions like mouse click. In the same way for keyboard actions. Client machine needs to get restarted or close Xwindows to reconnect guest. This issue happens only when we connect windows guest infullscreen mode with auto-c

Re: [Spice-devel] [PATCH] Define exec_prefix in .pc files

2011-12-19 Thread Hans de Goede
Hi All, Thanks, applied and pushed. Regards, Hans On 12/19/2011 02:26 PM, Christophe Fergeau wrote: @libdir@ is expanded to ${exec_prefix}/lib on my machine so we need exec_prefix to be defined in the .pc file. --- usbredirhost/libusbredirhost.pc.in |1 + usbredirparser/libusbredi

Re: [Spice-devel] [PATCH] Define exec_prefix in .pc files

2011-12-19 Thread Marc-André Lureau
On Mon, Dec 19, 2011 at 2:30 PM, Christophe Fergeau wrote: > On Mon, Dec 19, 2011 at 02:26:58PM +0100, Christophe Fergeau wrote: > > @libdir@ is expanded to ${exec_prefix}/lib on my machine so we > > need exec_prefix to be defined in the .pc file. > > Forgot to credit Marc-André for the bug report

Re: [Spice-devel] [PATCH] client: log command line (rhbz 767581)

2011-12-19 Thread Hans de Goede
Ack. On 12/19/2011 02:35 PM, Alon Levy wrote: --- client/application.cpp |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/client/application.cpp b/client/application.cpp index decf8a1..c621b75 100644 --- a/client/application.cpp +++ b/client/application.cpp @@ -2

[Spice-devel] [PATCH] client: log command line (rhbz 767581)

2011-12-19 Thread Alon Levy
--- client/application.cpp |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/client/application.cpp b/client/application.cpp index decf8a1..c621b75 100644 --- a/client/application.cpp +++ b/client/application.cpp @@ -2645,6 +2645,13 @@ int Application::main(int argc, c

Re: [Spice-devel] [PATCH] Define exec_prefix in .pc files

2011-12-19 Thread Christophe Fergeau
On Mon, Dec 19, 2011 at 02:26:58PM +0100, Christophe Fergeau wrote: > @libdir@ is expanded to ${exec_prefix}/lib on my machine so we > need exec_prefix to be defined in the .pc file. Forgot to credit Marc-André for the bug report, this probably should be added before pushing :) Christophe pgpCw

[Spice-devel] [PATCH] Define exec_prefix in .pc files

2011-12-19 Thread Christophe Fergeau
@libdir@ is expanded to ${exec_prefix}/lib on my machine so we need exec_prefix to be defined in the .pc file. --- usbredirhost/libusbredirhost.pc.in |1 + usbredirparser/libusbredirparser.pc.in |1 + 2 files changed, 2 insertions(+), 0 deletions(-) diff --git a/usbredirhost/libusbred

Re: [Spice-devel] [PATCH spice-gtk 00/10]: Move USB event handling to a separate thread

2011-12-19 Thread Christophe Fergeau
Hi, On Mon, Dec 19, 2011 at 01:58:57PM +0100, Marc-André Lureau wrote: > I am using master branch, but I get the following error when running > ./configure in spice-gtk: > > configure: error: Package requirements (libusbredirhost >= 0.3.2) were not > met: > > Variable 'exec_prefix' not defined i

Re: [Spice-devel] [PATCH spice-gtk 00/10]: Move USB event handling to a separate thread

2011-12-19 Thread Hans de Goede
Hi, On 12/19/2011 01:58 PM, Marc-André Lureau wrote: Hi On Mon, Dec 19, 2011 at 12:24 PM, Hans de Goede mailto:hdego...@redhat.com>> wrote: Hi All, Well it has been long in the making, but here it finally is :) Note that if you want to compile with usbredir support after this pat

Re: [Spice-devel] [PATCH spice-gtk 00/10]: Move USB event handling to a separate thread

2011-12-19 Thread Marc-André Lureau
Hi On Mon, Dec 19, 2011 at 12:24 PM, Hans de Goede wrote: > Hi All, > > Well it has been long in the making, but here it finally is :) > > Note that if you want to compile with usbredir support after this patch set > you will need the latest usbredir from git, grab it here: > http://cgit.freedes

Re: [Spice-devel] [PATCH spice-gtk 6/6] Support semi-seamless migration

2011-12-19 Thread Marc-André Lureau
On Sun, Dec 18, 2011 at 7:23 PM, Alon Levy wrote: > This looks strange - is this removal related to this patch? > Yes, we changed it by a gio-coroutine condition. When we reenter the mainloop, the condition is checked and the coroutine may continue. This is actually a bit cleaner than yielding d

[Spice-devel] [PATCH spice-gtk 10/10] usbredir: Give devices a user friendly description

2011-12-19 Thread Hans de Goede
Before this patch devices were described like this to the user: USB device at 2-14 After this patch the description is: SanDisk Cruzer Blade [0781:5567] at 2-14 Signed-off-by: Hans de Goede --- gtk/usb-device-manager.c | 64 - 1 files changed, 62 ins

[Spice-devel] [PATCH spice-gtk 08/10] usbredir: Remove spice_usb_device_manager_get main_context argument

2011-12-19 Thread Hans de Goede
Now that we no longer use a GUsbSource this is no longer needed. Note this is a change to our public API, but that is ok since we have not yet done an official release with usbredir support. Signed-off-by: Hans de Goede --- gtk/channel-usbredir.c |6 ++ gtk/spice-gtk-session.c |2

[Spice-devel] [PATCH spice-gtk 07/10] usbredir: Handle usb events from a thread

2011-12-19 Thread Hans de Goede
This solves various latency issues with USB handling. Signed-off-by: Hans de Goede --- gtk/channel-usbredir.c |5 + gtk/usb-device-manager.c | 45 - 2 files changed, 37 insertions(+), 13 deletions(-) diff --git a/gtk/channel-usbredir.c b/g

[Spice-devel] [PATCH spice-gtk 06/10] usbredir: Add locking callbacks for libusbredirhost

2011-12-19 Thread Hans de Goede
This is a preparation patch for handling usb packet completion in a separate thread. Signed-off-by: Hans de Goede --- gtk/channel-usbredir.c | 36 1 files changed, 32 insertions(+), 4 deletions(-) diff --git a/gtk/channel-usbredir.c b/gtk/channel-usbredir.

[Spice-devel] [PATCH spice-gtk 05/10] usbredir: Create USB event source on demand

2011-12-19 Thread Hans de Goede
This is a preparation patch for handling usb packet completion in a separate thread. Signed-off-by: Hans de Goede --- gtk/Makefile.am |1 + gtk/channel-usbredir.c| 15 gtk/usb-device-manager-priv.h | 36 + gtk/usb-device-mana

[Spice-devel] [PATCH spice-gtk 04/10] usbredir: Use new libusbredirhost write flush callback

2011-12-19 Thread Hans de Goede
The new (in usbredir-0.3.2) usbredirhost_open_full() function allows us to be notified whenever usb packets completing result in data to be send to the host. This removes the need for using g_usb_source_set_callback and seeing if there is data to write on any of the usb channels each time some usb

[Spice-devel] [PATCH spice-gtk 03/10] usbredir: USB channels can not be read only

2011-12-19 Thread Hans de Goede
A usbredir channel must always be bi-directional. spice-server allows only one client to connect even when in multi-client mode. Since usually there are multiple usb channels available, it is allowed for one client to use one channel, while another client uses another usb channel. Signed-off-by: H

[Spice-devel] [PATCH spice-gtk 02/10] usbredir: Stop setting private data explictly to NULL on init

2011-12-19 Thread Hans de Goede
This is not necessary and as we get more private data it becomes unyieldly. Signed-off-by: Hans de Goede --- gtk/usb-device-manager.c |6 -- 1 files changed, 0 insertions(+), 6 deletions(-) diff --git a/gtk/usb-device-manager.c b/gtk/usb-device-manager.c index 313b6ab..ea43b75 100644 --

[Spice-devel] [PATCH spice-gtk 01/10] spice-channel: Allow spice_msg_out_send to be called from multiple threads

2011-12-19 Thread Hans de Goede
This is a preparation patch for handling usb packet completion in a separate thread. Signed-off-by: Hans de Goede --- gtk/spice-channel-priv.h |3 +++ gtk/spice-channel.c | 38 ++ 2 files changed, 37 insertions(+), 4 deletions(-) diff --git a/gtk/s

[Spice-devel] [PATCH spice-gtk 00/10]: Move USB event handling to a separate thread

2011-12-19 Thread Hans de Goede
Hi All, Well it has been long in the making, but here it finally is :) Note that if you want to compile with usbredir support after this patch set you will need the latest usbredir from git, grab it here: http://cgit.freedesktop.org/~jwrdegoede/usbredir/ Regards, Hans __

Re: [Spice-devel] keyboard and Mouse Fails....

2011-12-19 Thread Christophe Fergeau
On Mon, Dec 19, 2011 at 12:32:47AM -0800, Naga Mohan Pothula wrote: > Hi, > > Keyboard and Mouse failure happens when windows guests are connected from > linux client.  What do you mean exactly by keyboard and mouse failures? You can't type anything nor move the mouse? Or do you observe a differ

Re: [Spice-devel] [PATCH spice-gtk 0/6] RFC: add semi-seamless migration support

2011-12-19 Thread Hans de Goede
Hi, I must say that I do not completely grok all the changes, but I think no-one in the team will without spending a significant amount of time. With that said I cannot find anything wrong (other then Alon's 2 messages about commit messages), so: ACK series. Regards, Hans On 12/18/2011 06:27

Re: [Spice-devel] [PATCH xf86-video-qxl] configure.ac: support autoconf 2.63

2011-12-19 Thread Christophe Fergeau
On Sun, Dec 18, 2011 at 07:54:57PM +0200, Alon Levy wrote: > AC_CHECK_FILE(cond,[not-empty],[]) in autoconf 2.63 produces an empty > else that is illegal for bash, but forgoes the else when given a > AC_CHECK_FILE(cond,[not-empty]). 2.68 produces correct output on both, > so it's unaffected. > ---

[Spice-devel] keyboard and Mouse Fails....

2011-12-19 Thread Naga Mohan Pothula
Hi, Keyboard and Mouse failure happens when windows guests are connected from linux client.  This doesn't happen when connecting from windows client. This issue happens after booting procedure is completed and user desktop is displayed. Tested with Spice v0.10.0 and Qemu v0.15.1.  Seems problem