Good catch, ack. Do you have commit access to the git repo?
Christophe
On Fri, Jan 27, 2012 at 11:38:40AM -0200, Erlon Cruz wrote:
> Compilation was breaking due to warning errors even when configuring with
> --enable-werror=no. This patch fix this.
> ---
> configure.ac |3 +--
> 1 files ch
On Fri, Jan 27, 2012 at 12:11:08PM -0500, Marc-André Lureau wrote:
>
>
> - Mensaje original -
> > configure.ac was using 2 slightly different styles for have_foo
> > tests:
> > if test x"$have_foo" = "xyes"; then
> > and:
> > if test "x$have_foo" = "xyes"; then
> >
> > Switch to the latt
On Fri, Jan 27, 2012 at 04:58:56PM +0100, Hans de Goede wrote:
> Josh Bressers has been so kind to review the usb-acl-helper for possible
> security issues. One of his recomendations was to harden the usb-acl-helper
> by building it as a Position Independent Executable.
>
> Signed-off-by: Hans de
On Fri, Jan 27, 2012 at 04:58:54PM +0100, Hans de Goede wrote:
> * No need to set AM_CONDITIONAL WITH_POLKIT from the enable_usbredir tests, it
> get sets from the enable_polkit tests in all paths
> * Improve the help text: mention auto as option, policykit -> PolicyKit,
> not yes but auto is t
looks all good to me, ack all
- Mensaje original -
> * No need to set AM_CONDITIONAL WITH_POLKIT from the enable_usbredir
> tests, it
> get sets from the enable_polkit tests in all paths
> * Improve the help text: mention auto as option, policykit ->
> PolicyKit,
> not yes but auto is
- Mensaje original -
> configure.ac was using 2 slightly different styles for have_foo
> tests:
> if test x"$have_foo" = "xyes"; then
> and:
> if test "x$have_foo" = "xyes"; then
>
> Switch to the latter style everywhere for consistency.
Somehow, I thought the x"$foo" style was more con
Hey,
The NPAPI plugin spice-xpi reached its 2.7 release!
Get it here:
http://spice-space.org/download/releases/spice-xpi-2.7.tar.bz2
sha1sum
30253b2c07fe8438988aed5ccd66ee5b9a6b692 spice-xpi-2.7.tar.bz2
Summary of changes since 2.6:
- run /usr/libexec/spice-xpi-client first
- simple test.html
Hi,
The entire series looks good to me, ACK-series!
Regards,
Hans
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/spice-devel
Josh Bressers has been so kind to review the usb-acl-helper for possible
security issues. One of his recomendations was to ensure that the file
we're setting the acl on is a chardev.
Signed-off-by: Hans de Goede
---
gtk/spice-client-glib-usb-acl-helper.c | 16 +++-
1 files changed,
Not really important given the short livedness of the process, but
still should be fixed.
Signed-off-by: Hans de Goede
---
gtk/spice-client-glib-usb-acl-helper.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/gtk/spice-client-glib-usb-acl-helper.c
b/gtk/spice-client-gl
Josh Bressers has been so kind to review the usb-acl-helper for possible
security issues. One of his recomendations was to harden the usb-acl-helper
by building it as a Position Independent Executable.
Signed-off-by: Hans de Goede
---
configure.ac| 26 ++
gtk/Makefi
configure.ac was using 2 slightly different styles for have_foo tests:
if test x"$have_foo" = "xyes"; then
and:
if test "x$have_foo" = "xyes"; then
Switch to the latter style everywhere for consistency.
Signed-off-by: Hans de Goede
---
configure.ac | 16
1 files changed, 8 in
* No need to set AM_CONDITIONAL WITH_POLKIT from the enable_usbredir tests, it
get sets from the enable_polkit tests in all paths
* Improve the help text: mention auto as option, policykit -> PolicyKit,
not yes but auto is the default
* Warn when building with usbredir support but not building
---
NEWS |5 +
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/NEWS b/NEWS
index e69de29..36f9455 100644
--- a/NEWS
+++ b/NEWS
@@ -0,0 +1,5 @@
+spice-xpi 2.7
+=
+
+- build fixes for newer and older xul
+- fix out of tree build
--
1.7.7.6
___
Deal with const and non-const return value of NPP_GetMIMEDescription().
Although it is hard to find evidences of how this value is used, I
think the non-const value could return a static string. But I prefer
being on the safe side and return a strdup() to the risk of leaking
that string on older v
Fix out of tree build, and some minor clean-up.
---
SpiceXPI/Makefile.am| 13 -
SpiceXPI/src/plugin/Makefile.am |2 ++
2 files changed, 6 insertions(+), 9 deletions(-)
diff --git a/SpiceXPI/Makefile.am b/SpiceXPI/Makefile.am
index 9f0ad0b..5cef195 100644
--- a/SpiceX
---
autogen.sh | 13 +
1 files changed, 13 insertions(+), 0 deletions(-)
create mode 100755 autogen.sh
diff --git a/autogen.sh b/autogen.sh
new file mode 100755
index 000..e5a152d
--- /dev/null
+++ b/autogen.sh
@@ -0,0 +1,13 @@
+#!/bin/sh
+set -e # exit on errors
+
+srcdir=`dir
---
SpiceXPI/src/plugin/Makefile.am | 25 +
configure.ac| 21 ++---
2 files changed, 23 insertions(+), 23 deletions(-)
diff --git a/SpiceXPI/src/plugin/Makefile.am b/SpiceXPI/src/plugin/Makefile.am
index 1c3d3db..c6ba8f0 100644
--- a
Compilation was breaking due to warning errors even when configuring with
--enable-werror=no. This patch fix this.
---
configure.ac |3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/configure.ac b/configure.ac
index 0f8ad7d..8cabbd6 100644
--- a/configure.ac
+++ b/configu
On Thu, Jan 26, 2012 at 01:46:36PM -0800, Naga Mohan Pothula wrote:
>Hi,
>I'm facing problems while building Upstream Spice on CentOS 5.7 64-bit
>host.
>I haven't face problems when i build the same code on Ubuntu 10.04 64-bit
>host.
>I installed "pyparsing" into Centos 5. s
20 matches
Mail list logo