Re: [Spice-devel] [PATCH] Fix mandatory -Werror option

2012-01-27 Thread Christophe Fergeau
Good catch, ack. Do you have commit access to the git repo? Christophe On Fri, Jan 27, 2012 at 11:38:40AM -0200, Erlon Cruz wrote: > Compilation was breaking due to warning errors even when configuring with > --enable-werror=no. This patch fix this. > --- > configure.ac |3 +-- > 1 files ch

Re: [Spice-devel] [PATCH spice-gtk 2/5] configure.ac: s/x"$have_foo"/"x$have_foo"/

2012-01-27 Thread Christophe Fergeau
On Fri, Jan 27, 2012 at 12:11:08PM -0500, Marc-André Lureau wrote: > > > - Mensaje original - > > configure.ac was using 2 slightly different styles for have_foo > > tests: > > if test x"$have_foo" = "xyes"; then > > and: > > if test "x$have_foo" = "xyes"; then > > > > Switch to the latt

Re: [Spice-devel] [PATCH spice-gtk 3/5] configure: Add an option for building the acl helper as PIE

2012-01-27 Thread Christophe Fergeau
On Fri, Jan 27, 2012 at 04:58:56PM +0100, Hans de Goede wrote: > Josh Bressers has been so kind to review the usb-acl-helper for possible > security issues. One of his recomendations was to harden the usb-acl-helper > by building it as a Position Independent Executable. > > Signed-off-by: Hans de

Re: [Spice-devel] [PATCH spice-gtk 1/5] configure.ac: Cleanup policykit checks

2012-01-27 Thread Christophe Fergeau
On Fri, Jan 27, 2012 at 04:58:54PM +0100, Hans de Goede wrote: > * No need to set AM_CONDITIONAL WITH_POLKIT from the enable_usbredir tests, it > get sets from the enable_polkit tests in all paths > * Improve the help text: mention auto as option, policykit -> PolicyKit, > not yes but auto is t

Re: [Spice-devel] [PATCH spice-gtk 1/5] configure.ac: Cleanup policykit checks

2012-01-27 Thread Marc-André Lureau
looks all good to me, ack all - Mensaje original - > * No need to set AM_CONDITIONAL WITH_POLKIT from the enable_usbredir > tests, it > get sets from the enable_polkit tests in all paths > * Improve the help text: mention auto as option, policykit -> > PolicyKit, > not yes but auto is

Re: [Spice-devel] [PATCH spice-gtk 2/5] configure.ac: s/x"$have_foo"/"x$have_foo"/

2012-01-27 Thread Marc-André Lureau
- Mensaje original - > configure.ac was using 2 slightly different styles for have_foo > tests: > if test x"$have_foo" = "xyes"; then > and: > if test "x$have_foo" = "xyes"; then > > Switch to the latter style everywhere for consistency. Somehow, I thought the x"$foo" style was more con

[Spice-devel] [Announce] spice-xpi 2.7 released

2012-01-27 Thread Marc-André Lureau
Hey, The NPAPI plugin spice-xpi reached its 2.7 release! Get it here: http://spice-space.org/download/releases/spice-xpi-2.7.tar.bz2 sha1sum 30253b2c07fe8438988aed5ccd66ee5b9a6b692 spice-xpi-2.7.tar.bz2 Summary of changes since 2.6: - run /usr/libexec/spice-xpi-client first - simple test.html

Re: [Spice-devel] [PATCH spice-xpi 1/5] build: fix build on both rhel6/

2012-01-27 Thread Hans de Goede
Hi, The entire series looks good to me, ACK-series! Regards, Hans ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel

[Spice-devel] [PATCH spice-gtk 5/5] spice-client-glib-usb-acl-helper: ensure we set the acl on a chardev

2012-01-27 Thread Hans de Goede
Josh Bressers has been so kind to review the usb-acl-helper for possible security issues. One of his recomendations was to ensure that the file we're setting the acl on is a chardev. Signed-off-by: Hans de Goede --- gtk/spice-client-glib-usb-acl-helper.c | 16 +++- 1 files changed,

[Spice-devel] [PATCH spice-gtk 4/5] spice-client-glib-usb-acl-helper: Fix memleak

2012-01-27 Thread Hans de Goede
Not really important given the short livedness of the process, but still should be fixed. Signed-off-by: Hans de Goede --- gtk/spice-client-glib-usb-acl-helper.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/gtk/spice-client-glib-usb-acl-helper.c b/gtk/spice-client-gl

[Spice-devel] [PATCH spice-gtk 3/5] configure: Add an option for building the acl helper as PIE

2012-01-27 Thread Hans de Goede
Josh Bressers has been so kind to review the usb-acl-helper for possible security issues. One of his recomendations was to harden the usb-acl-helper by building it as a Position Independent Executable. Signed-off-by: Hans de Goede --- configure.ac| 26 ++ gtk/Makefi

[Spice-devel] [PATCH spice-gtk 2/5] configure.ac: s/x"$have_foo"/"x$have_foo"/

2012-01-27 Thread Hans de Goede
configure.ac was using 2 slightly different styles for have_foo tests: if test x"$have_foo" = "xyes"; then and: if test "x$have_foo" = "xyes"; then Switch to the latter style everywhere for consistency. Signed-off-by: Hans de Goede --- configure.ac | 16 1 files changed, 8 in

[Spice-devel] [PATCH spice-gtk 1/5] configure.ac: Cleanup policykit checks

2012-01-27 Thread Hans de Goede
* No need to set AM_CONDITIONAL WITH_POLKIT from the enable_usbredir tests, it get sets from the enable_polkit tests in all paths * Improve the help text: mention auto as option, policykit -> PolicyKit, not yes but auto is the default * Warn when building with usbredir support but not building

[Spice-devel] [PATCH spice-xpi 5/5] Release v2.7

2012-01-27 Thread Marc-André Lureau
--- NEWS |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/NEWS b/NEWS index e69de29..36f9455 100644 --- a/NEWS +++ b/NEWS @@ -0,0 +1,5 @@ +spice-xpi 2.7 += + +- build fixes for newer and older xul +- fix out of tree build -- 1.7.7.6 ___

[Spice-devel] [PATCH spice-xpi 4/5] build: deal with non-const return values of NPP_GetMIMEDescription()

2012-01-27 Thread Marc-André Lureau
Deal with const and non-const return value of NPP_GetMIMEDescription(). Although it is hard to find evidences of how this value is used, I think the non-const value could return a static string. But I prefer being on the safe side and return a strdup() to the risk of leaking that string on older v

[Spice-devel] [PATCH spice-xpi 3/5] build: fix out-of-tree build

2012-01-27 Thread Marc-André Lureau
Fix out of tree build, and some minor clean-up. --- SpiceXPI/Makefile.am| 13 - SpiceXPI/src/plugin/Makefile.am |2 ++ 2 files changed, 6 insertions(+), 9 deletions(-) diff --git a/SpiceXPI/Makefile.am b/SpiceXPI/Makefile.am index 9f0ad0b..5cef195 100644 --- a/SpiceX

[Spice-devel] [PATCH spice-xpi 2/5] build: add simple autogen.sh file

2012-01-27 Thread Marc-André Lureau
--- autogen.sh | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) create mode 100755 autogen.sh diff --git a/autogen.sh b/autogen.sh new file mode 100755 index 000..e5a152d --- /dev/null +++ b/autogen.sh @@ -0,0 +1,13 @@ +#!/bin/sh +set -e # exit on errors + +srcdir=`dir

[Spice-devel] [PATCH spice-xpi 1/5] build: fix build on both rhel6/

2012-01-27 Thread Marc-André Lureau
--- SpiceXPI/src/plugin/Makefile.am | 25 + configure.ac| 21 ++--- 2 files changed, 23 insertions(+), 23 deletions(-) diff --git a/SpiceXPI/src/plugin/Makefile.am b/SpiceXPI/src/plugin/Makefile.am index 1c3d3db..c6ba8f0 100644 --- a

[Spice-devel] [PATCH] Fix mandatory -Werror option

2012-01-27 Thread Erlon Cruz
Compilation was breaking due to warning errors even when configuring with --enable-werror=no. This patch fix this. --- configure.ac |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index 0f8ad7d..8cabbd6 100644 --- a/configure.ac +++ b/configu

Re: [Spice-devel] Build problems with Upstream Spice on CentOS 5...

2012-01-27 Thread Alon Levy
On Thu, Jan 26, 2012 at 01:46:36PM -0800, Naga Mohan Pothula wrote: >Hi, >I'm facing problems while building Upstream Spice on CentOS 5.7 64-bit >host. >I haven't face problems when i build the same code on Ubuntu 10.04 64-bit >host. >I installed "pyparsing" into Centos 5. s