[Spice-devel] [PATCH spice-gtk 7/7] usbredir: Add awareness of host/guest side filtering

2012-02-18 Thread Hans de Goede
Signed-off-by: Hans de Goede --- gtk/channel-usbredir-priv.h |6 + gtk/channel-usbredir.c | 19 +++-- gtk/map-file|1 + gtk/usb-device-manager.c| 44 +++--- gtk/usb-device-manager.h|3 ++ gtk/usb-devi

[Spice-devel] [PATCH spice-gtk 6/7] usbredir: Add device rejected errors

2012-02-18 Thread Hans de Goede
Signed-off-by: Hans de Goede --- gtk/channel-usbredir.c | 82 - gtk/channel-usbredir.h |4 ++ gtk/spicy.c |2 + gtk/usb-device-manager.c | 37 + gtk/usb-device-manager.h |4 ++- gtk/usb-device-widget.

[Spice-devel] [PATCH spice-gtk 5/7] usbredir: Shrink the usb device selection dialog when devices are unplugged

2012-02-18 Thread Hans de Goede
Signed-off-by: Hans de Goede --- gtk/spicy.c |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/gtk/spicy.c b/gtk/spicy.c index cbc702e..2757bd7 100644 --- a/gtk/spicy.c +++ b/gtk/spicy.c @@ -419,6 +419,11 @@ static void menu_cb_remove_smartcard(GtkAction *action, v

[Spice-devel] [PATCH spice-gtk 4/7] usbredir: make channel lifetime equal to session lifetime

2012-02-18 Thread Hans de Goede
--- configure.ac|2 +- gtk/channel-usbredir-priv.h | 31 ++ gtk/channel-usbredir.c | 139 +-- gtk/spice-channel-priv.h|1 + gtk/spice-channel.c |9 +++ gtk/usb-device-manager.c| 15 +++-- 6 files

[Spice-devel] [PATCH spice-gtk 3/7] usbutil: Add support for getting strings from usb.ids

2012-02-18 Thread Hans de Goede
Unfortunately not all device makers go to the "trouble" of adding device identification strings to a device's descriptors. This patch makes spice-gtk translate vid/pid into strings if the device lacks the strings. Signed-off-by: Hans de Goede --- configure.ac| 21 gtk/Makefile.am

[Spice-devel] [PATCH spice-gtk 2/7] usbutil: Add a spice_usb_util_get_device_strings helper function

2012-02-18 Thread Hans de Goede
Signed-off-by: Hans de Goede --- gtk/usb-device-manager.c | 32 gtk/usbutil.c| 38 +- gtk/usbutil.h|8 +--- 3 files changed, 50 insertions(+), 28 deletions(-) diff --git a/gtk/usb-device-mana

[Spice-devel] [PATCH spice-gtk 1/7] usb: Move various helper functions into usbutil.[c, h]

2012-02-18 Thread Hans de Goede
Signed-off-by: Hans de Goede --- gtk/Makefile.am |2 + gtk/channel-usbredir.c|5 +- gtk/usb-device-manager-priv.h |6 +-- gtk/usb-device-manager.c | 81 +++--- gtk/usb-device-manager.h |2 +- gtk/usbutil.c

Re: [Spice-devel] [PATCH spice-protocol] Add controller message ENABLE_SMARTCARD

2012-02-18 Thread Alon Levy
On Sat, Feb 18, 2012 at 04:20:24PM +0100, Marc-André Lureau wrote: > The sent message must be a ControllerValue whose value is either '0' > disabled, or '1' enabled. I'm going to be sending a patch to add an additional change to the protocol this week, for the spice_qel_update_async_dirty call, so

Re: [Spice-devel] [PATCH] server/spicevmc: Don't destroy the rcc twice

2012-02-18 Thread Alon Levy
On Sat, Feb 18, 2012 at 04:04:04PM +0100, Hans de Goede wrote: > spicevmc calls red_channel_client_destroy() on the rcc when it disconnects > since we don't want to delay the destroy until the session gets closed as > spicevmc channels can be opened, closed and opened again during a single > sessio

Re: [Spice-devel] [PATCH spice-protocol] Add controller message ENABLE_SMARTCARD

2012-02-18 Thread Hans de Goede
Looks good, ack. On 02/18/2012 04:20 PM, Marc-André Lureau wrote: The sent message must be a ControllerValue whose value is either '0' disabled, or '1' enabled. --- configure.ac|2 +- spice/controller_prot.h |2 ++ 2 files changed, 3 insertions(+), 1 deletions(-) diff --

Re: [Spice-devel] [PATCH spice-xpi 1/2] build: use spice-protocol headers

2012-02-18 Thread Hans de Goede
Series looks good, ACK. On 02/18/2012 02:54 PM, Marc-André Lureau wrote: --- SpiceXPI/src/plugin/Makefile.am |2 +- SpiceXPI/src/plugin/controller.h |2 +- SpiceXPI/src/plugin/controller_prot.h | 138 - configure.ac

[Spice-devel] [PATCH spice-protocol] Add controller message ENABLE_SMARTCARD

2012-02-18 Thread Marc-André Lureau
The sent message must be a ControllerValue whose value is either '0' disabled, or '1' enabled. --- configure.ac|2 +- spice/controller_prot.h |2 ++ 2 files changed, 3 insertions(+), 1 deletions(-) diff --git a/configure.ac b/configure.ac index e1c3861..9047742 100644 --- a/co

Re: [Spice-devel] [PATCH spice-gtk] Add controller ENABLE_SMARTCARD message

2012-02-18 Thread Hans de Goede
Looks good, ack. On 02/18/2012 02:54 PM, Marc-André Lureau wrote: --- configure.ac |2 +- data/spice-protocol.vapi |2 ++ gtk/controller/controller.vala |4 3 files changed, 7 insertions(+), 1 deletions(-) diff --git a/configure.ac b/configure.ac in

[Spice-devel] [PATCH] server/spicevmc: Don't destroy the rcc twice

2012-02-18 Thread Hans de Goede
spicevmc calls red_channel_client_destroy() on the rcc when it disconnects since we don't want to delay the destroy until the session gets closed as spicevmc channels can be opened, closed and opened again during a single session. This causes red_channel_client_destroy() to get called twice, trigg

[Spice-devel] [PATCH spice-xpi 2/2] Add smartcard option

2012-02-18 Thread Marc-André Lureau
--- SpiceXPI/src/plugin/nsScriptablePeer.cpp |7 +++ SpiceXPI/src/plugin/nsScriptablePeer.h |1 + SpiceXPI/src/plugin/plugin.cpp | 13 + SpiceXPI/src/plugin/plugin.h |5 + 4 files changed, 26 insertions(+), 0 deletions(-) diff --git a/Spic

[Spice-devel] [PATCH spice-xpi 1/2] build: use spice-protocol headers

2012-02-18 Thread Marc-André Lureau
--- SpiceXPI/src/plugin/Makefile.am |2 +- SpiceXPI/src/plugin/controller.h |2 +- SpiceXPI/src/plugin/controller_prot.h | 138 - configure.ac |3 + 4 files changed, 5 insertions(+), 140 deletions(-) delete mode 1006

[Spice-devel] [PATCH spice-gtk] Add controller ENABLE_SMARTCARD message

2012-02-18 Thread Marc-André Lureau
--- configure.ac |2 +- data/spice-protocol.vapi |2 ++ gtk/controller/controller.vala |4 3 files changed, 7 insertions(+), 1 deletions(-) diff --git a/configure.ac b/configure.ac index d8602fd..28b3418 100644 --- a/configure.ac +++ b/configure.ac @@ -61,