[Spice-devel] [PATCH] red_worker: rename epoll_timeout to event_timeout

2012-02-20 Thread Dan McGee
With future patches in mind that will allow for some other non-Linux-specific event polling sytem to be used, rename this to a more generic name. All of the select/poll/epoll/kqueue family of calls are related to evented I/O, so 'event_' makes sense in this case. Signed-off-by: Dan McGee --- ser

Re: [Spice-devel] [PATCH 2/7] red_worker: rename epoll_timeout to event_timeout

2012-02-20 Thread Dan McGee
On Mon, Feb 20, 2012 at 6:07 PM, Dan McGee wrote: > On Fri, Feb 17, 2012 at 2:52 AM, Alon Levy wrote: >> On Thu, Feb 16, 2012 at 11:30:08PM -0600, Dan McGee wrote: >>> With future patches in mind that will allow for some other >>> non-Linux-specific event polling sytem to be used, rename this to

Re: [Spice-devel] [PATCH 2/7] red_worker: rename epoll_timeout to event_timeout

2012-02-20 Thread Dan McGee
On Fri, Feb 17, 2012 at 2:52 AM, Alon Levy wrote: > On Thu, Feb 16, 2012 at 11:30:08PM -0600, Dan McGee wrote: >> With future patches in mind that will allow for some other >> non-Linux-specific event polling sytem to be used, rename this to a more >> generic name. All of the select/poll/epoll/kqu

Re: [Spice-devel] [PATCH spice-gtk 7/7] usbredir: Add awareness of host/guest side filtering

2012-02-20 Thread Marc-André Lureau
On Mon, Feb 20, 2012 at 3:29 PM, Hans de Goede wrote: > The purpose of spice_usb_device_manager_device_ok_with_guest is for a UI > (like the device selection widget) to show these devices in a different > way (ie set their widgets as not sensitive), how do you propose to > convey the reason why th

Re: [Spice-devel] [PATCH spice-gtk 7/7] usbredir: Add awareness of host/guest side filtering

2012-02-20 Thread Hans de Goede
Hi, On 02/20/2012 02:59 PM, Marc-André Lureau wrote: On Sun, Feb 19, 2012 at 12:50 AM, Hans de Goede wrote: +int spice_usb_device_manager_device_ok_with_guest(SpiceUsbDeviceManager *self, It would make sense to have a more generic function that returns a detailled error. Something like: gbo

Re: [Spice-devel] [PATCH] server: spice_qxl_update_area_dirty_async

2012-02-20 Thread Gerd Hoffmann
Hi, >> Ok, I completely forgot about that. There is the downside that the way >> it is currently written any implementation of update_area_complete will >> be called always, and causes a little work in >> handle_dev_update_async_helper. Don't think this is a big issue. Due to lazy rendering th

Re: [Spice-devel] [PATCH spice-gtk 4/7] usbredir: make channel lifetime equal to session lifetime

2012-02-20 Thread Marc-André Lureau
On Mon, Feb 20, 2012 at 11:07 AM, Hans de Goede wrote: >> I would prefer if it didn't call g_error() here. > > > I understand but given that: > 1) This only happens on memory allocation errors > 2) glib already does a g_error on memory allocation errors >   in other places > 3) Doing other error h

Re: [Spice-devel] [PATCH] server: spice_qxl_update_area_dirty_async

2012-02-20 Thread Alon Levy
On Mon, Feb 20, 2012 at 03:37:45PM +0200, Alon Levy wrote: > On Mon, Feb 20, 2012 at 02:52:51PM +0200, Yonit Halperin wrote: > > Hi, > > On 02/19/2012 02:53 PM, Alon Levy wrote: > > >On Sun, Feb 19, 2012 at 02:37:16PM +0200, Alon Levy wrote: > > >>Bumps spice to 0.9.2, since it adds a new symbol. T

Re: [Spice-devel] [PATCH spice-gtk 7/7] usbredir: Add awareness of host/guest side filtering

2012-02-20 Thread Marc-André Lureau
On Sun, Feb 19, 2012 at 12:50 AM, Hans de Goede wrote: > +int spice_usb_device_manager_device_ok_with_guest(SpiceUsbDeviceManager > *self, It would make sense to have a more generic function that returns a detailled error. Something like: gboolean spice_usb_device_manager_can_redirect_device (S

[Spice-devel] CAD calculations serverside.

2012-02-20 Thread Jorgen . Davidsson
Hi I'm looking at a way to run CAD from multiple clients for a low cost and the graphics calculations need to be done serverside since some of the clients connecting to the server aren't that powerful. I was looking at a solution where we install a graphics card in the physical server and run

Re: [Spice-devel] [PATCH] server: spice_qxl_update_area_dirty_async

2012-02-20 Thread Alon Levy
On Mon, Feb 20, 2012 at 02:52:51PM +0200, Yonit Halperin wrote: > Hi, > On 02/19/2012 02:53 PM, Alon Levy wrote: > >On Sun, Feb 19, 2012 at 02:37:16PM +0200, Alon Levy wrote: > >>Bumps spice to 0.9.2, since it adds a new symbol. This will be 0.8.4 > >>in 0.8 branch - the syms file is updated to con

Re: [Spice-devel] [PATCH] server: spice_qxl_update_area_dirty_async

2012-02-20 Thread Yonit Halperin
Hi, On 02/19/2012 02:53 PM, Alon Levy wrote: On Sun, Feb 19, 2012 at 02:37:16PM +0200, Alon Levy wrote: Bumps spice to 0.9.2, since it adds a new symbol. This will be 0.8.4 in 0.8 branch - the syms file is updated to contain 0.8.3 and 0.8.4. Forgot to change this comment. I'll drop the 0.10.1-

Re: [Spice-devel] Performance expectations

2012-02-20 Thread Yonit Halperin
Hi, On 02/15/2012 06:22 PM, Kai Meyer wrote: On 02/15/2012 05:19 AM, Yonit Halperin wrote: On 02/15/2012 01:16 AM, Kai Meyer wrote: Help me set my expectations straight. Should I be able to use spice from inside a VM on my local machine to view video streaming services like Youtube, Hulu, and

Re: [Spice-devel] [PATCH] Fix = use instead of ==

2012-02-20 Thread Alon Levy
On Mon, Feb 20, 2012 at 11:53:14AM +0100, Christophe Fergeau wrote: > When checking for ConnectNamedPipe status, the error check uses > if ( err = ERROR_IO_PENDING) instead of using == which causes this > error check to always trigger. This commit fixes this, however it > needs careful testing sinc

Re: [Spice-devel] Windows guest hangs while doing shutdown with dual monitors.

2012-02-20 Thread Christophe Fergeau
On Fri, Feb 17, 2012 at 05:46:49PM -0800, Naga Mohan Pothula wrote: > Hi, > > Win7 guest hangs all the time while doing shutdown. Noticed this behaviour > with Upstream Spice. > > > Issue happens: > >   when guest is launched with dual monitors in full-screen with Auto-conf mode > > > Issue

[Spice-devel] [PATCH] Fix = use instead of ==

2012-02-20 Thread Christophe Fergeau
When checking for ConnectNamedPipe status, the error check uses if ( err = ERROR_IO_PENDING) instead of using == which causes this error check to always trigger. This commit fixes this, however it needs careful testing since the fact that it went unnoticed means the code with the bug was working as

Re: [Spice-devel] [PATCH] server: spice_qxl_update_area_dirty_async

2012-02-20 Thread Alon Levy
On Mon, Feb 20, 2012 at 11:26:19AM +0100, Hans de Goede wrote: > Hi, > > On 02/19/2012 01:53 PM, Alon Levy wrote: > >On Sun, Feb 19, 2012 at 02:37:16PM +0200, Alon Levy wrote: > >>Bumps spice to 0.9.2, since it adds a new symbol. This will be 0.8.4 > >>in 0.8 branch - the syms file is updated to c

Re: [Spice-devel] [PATCH] server: spice_qxl_update_area_dirty_async

2012-02-20 Thread Alon Levy
On Mon, Feb 20, 2012 at 11:26:19AM +0100, Hans de Goede wrote: > Hi, > > On 02/19/2012 01:53 PM, Alon Levy wrote: > >On Sun, Feb 19, 2012 at 02:37:16PM +0200, Alon Levy wrote: > >>Bumps spice to 0.9.2, since it adds a new symbol. This will be 0.8.4 > >>in 0.8 branch - the syms file is updated to c

Re: [Spice-devel] [PATCH] server: spice_qxl_update_area_dirty_async

2012-02-20 Thread Hans de Goede
Hi, On 02/19/2012 01:53 PM, Alon Levy wrote: On Sun, Feb 19, 2012 at 02:37:16PM +0200, Alon Levy wrote: Bumps spice to 0.9.2, since it adds a new symbol. This will be 0.8.4 in 0.8 branch - the syms file is updated to contain 0.8.3 and 0.8.4. Forgot to change this comment. I'll drop the 0.10.1

Re: [Spice-devel] [PATCH spice-gtk 4/7] usbredir: make channel lifetime equal to session lifetime

2012-02-20 Thread Hans de Goede
Hi, On 02/19/2012 03:19 PM, Marc-André Lureau wrote: On Sun, Feb 19, 2012 at 12:50 AM, Hans de Goede wrote: +if (!priv->host) +g_error("Out of memory allocating usbredirhost"); spice-gtk is a library, and should not abort a program using it. Agreed. However, if it's for memor

Re: [Spice-devel] [PATCH spice-gtk 1/7] usb: Move various helper functions into usbutil.[c, h]

2012-02-20 Thread Hans de Goede
Hi, On 02/19/2012 03:05 PM, Marc-André Lureau wrote: On Sun, Feb 19, 2012 at 12:50 AM, Hans de Goede wrote: +return "Success"; did we disussed before that those strings should be translatable if they are shown to the user? No, actually making them translatable is the reason why lib

Re: [Spice-devel] [Qemu-devel] [PATCH 4/4] [experimental] add optinal 64bit vram bar to qxl

2012-02-20 Thread Alon Levy
On Mon, Feb 20, 2012 at 09:00:14AM +0100, Gerd Hoffmann wrote: > Hi, > > > I guess you will s/4/QXL_VRAM64_RANGE_INDEX/ when you send the > > spice-protocol patch? > > Yes. > > >> -if (qxl->vram_size < 4096) { > >> -qxl->vram_size = 4096; > >> +if (qxl->vram_size < qxl->vram32_

Re: [Spice-devel] [PATCH 4/4] [experimental] add optinal 64bit vram bar to qxl

2012-02-20 Thread Gerd Hoffmann
Hi, > I guess you will s/4/QXL_VRAM64_RANGE_INDEX/ when you send the > spice-protocol patch? Yes. >> -if (qxl->vram_size < 4096) { >> -qxl->vram_size = 4096; >> +if (qxl->vram_size < qxl->vram32_size) { >> +qxl->vram_size = qxl->vram32_size; > > Am I reading correctly