Hi
On Wed, Feb 22, 2012 at 5:28 PM, Hans de Goede wrote:
> Attached are the 6 patches which Marc-André reviewed earlier today. I've
> incorporated all his suggestions. Note that patches 2 and 3 are unchanged,
> so they don't need a re-review.
ack the new series
--
Marc-André Lureau
___
I can confirm with the listed guests tablet was no longer needed.
- Chris
-Original Message-
From: Itamar Heim [mailto:ih...@redhat.com]
Sent: Wednesday, February 22, 2012 10:01 AM
To: Brown, Chris (GE Healthcare)
Cc: acath...@redhat.com; us...@ovirt.org; lp...@redhat.com;
spice-devel@lis
Do we have such plugins for Windows users that would like to open their
vms from browser?
From Fedora side, the firefox plugin works fine.
Thanks!
--
Cheers
Douglas
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedeskt
On Wed, Feb 22, 2012 at 03:09:09PM +0100, Gerd Hoffmann wrote:
> On 02/22/12 13:28, Alon Levy wrote:
> > On Wed, Feb 22, 2012 at 12:18:50PM +0100, Gerd Hoffmann wrote:
> >> Hi,
> >>
> >> It's not obvious to me how the non-flipped case (qxl_stride > 0) is
> >> handled now. Have you tested this wi
On Wed, Feb 22, 2012 at 12:46:28PM +0100, Gerd Hoffmann wrote:
> On 02/21/12 22:39, Alon Levy wrote:
> > This changes the behavior of the monitor command. After the previous
> > patch, there is no longer an option of deadlock with virt-manager, but
> > ppm_save is called too early, before the updat
Signed-off-by: Hans de Goede
---
configure.ac|2 +-
gtk/channel-usbredir-priv.h |6 ++
gtk/channel-usbredir.c | 19 ---
gtk/usb-device-manager.c| 18 +-
4 files changed, 40 insertions(+), 5 deletions(-)
diff --git a/configu
Add a spice_usb_device_manager_can_redirect_device function and use this
in SpiceUsbDeviceWidget to check if redirection is available.
Signed-off-by: Hans de Goede
---
gtk/map-file |1 +
gtk/usb-device-manager.c | 71 ++---
gtk/usb-device-manager.h |
And in general gnome-hig-ify usb-device-widget:
* Use spacing instead of padding so that there is no padding at the
outside/border of the widget, allowing the user to control the border size.
* Use multiple of 6 as spacing / indentation values
* Show the label left justified and bold, show the ch
When running "./configure --disable-usbredir" the
"USB redirection support" line in the summary at the end of ./configure
would be empty after "support" instead of ending with yes or no.
Signed-off-by: Hans de Goede
---
configure.ac |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
Rather then treating it as any other error. This avoids showing an error
dialog after the user pressed cancel in the policykit dialog.
Signed-off-by: Hans de Goede
---
gtk/spice-client-glib-usb-acl-helper.c |5 +
gtk/usb-acl-helper.c | 13 ++---
2 files change
Signed-off-by: Hans de Goede
---
gtk/channel-usbredir.c| 61 +++-
gtk/spicy.c |2 +
gtk/usb-device-manager-priv.h |3 ++
gtk/usb-device-manager.c | 29 +++
gtk/usb-device-manager.h |4 ++-
gtk/
Hi All,
Attached are the 6 patches which Marc-André reviewed earlier today. I've
incorporated all his suggestions. Note that patches 2 and 3 are unchanged,
so they don't need a re-review.
Thanks & Regards,
Hans
___
Spice-devel mailing list
Spice-devel@
On 02/22/2012 03:28 PM, Marc-André Lureau wrote:
Hi
On Tue, Feb 21, 2012 at 3:12 PM, Hans de Goede wrote:
+spice_usbredir_channel_get_guest_filter(
+g_ptr_array_index(priv->channels, 0),
+&guest_filter_rules,&guest_filter_rules_count);
Memory management of guest_filter_rules is
On 02/22/2012 05:47 PM, Brown, Chris (GE Healthcare) wrote:
Itamar/oVirt team,
Just wanted to let you know the latest nightly build and latest
RHEV/RHEL spice client/plugin has completely resolved mouse interaction
issues with the following tested guests:
Red Hat 7.3
Red Hat 9
Fedora core 1 - 14
On Wed, Feb 22, 2012 at 03:37:46PM +0100, Gerd Hoffmann wrote:
> On 02/22/12 15:25, Alon Levy wrote:
> > On Wed, Feb 22, 2012 at 02:58:10PM +0100, Gerd Hoffmann wrote:
> >>> And the only user of screen_dump_filename is:
> >>>
> >>> static void vga_save_dpy_update(DisplayState *ds,
> >>>
Hi,
On 02/22/2012 03:12 PM, Marc-André Lureau wrote:
The patch looks fine in general.
You like to use a lot GError in general, which is a good thing. But we
didn't have so many error conditions reported until now. You shouldn't
be affraid to introduce and use different error codes. That would
a
Hi,
On 02/22/2012 02:57 PM, Marc-André Lureau wrote:
Somehow the infobar is not aligned with the checkbox buttons below. Is
it intentionnal?
On Tue, Feb 21, 2012 at 3:12 PM, Hans de Goede wrote:
+gtk_box_pack_start(GTK_BOX(hbox), widget, FALSE, FALSE, 0);
I would expand/fill the label
Hi,
Thanks for all the reviews!
On 02/22/2012 01:50 PM, Marc-André Lureau wrote:
On Tue, Feb 21, 2012 at 3:12 PM, Hans de Goede wrote:
diff --git a/gtk/channel-usbredir.c b/gtk/channel-usbredir.c
+/**
+ * SpiceUsbredirChannel::device-error:
+ * @channel: #SpiceUsbredirChannel that
On 02/22/12 15:25, Alon Levy wrote:
> On Wed, Feb 22, 2012 at 02:58:10PM +0100, Gerd Hoffmann wrote:
>>> And the only user of screen_dump_filename is:
>>>
>>> static void vga_save_dpy_update(DisplayState *ds,
>>> int x, int y, int w, int h)
>>> {
>>> if (screen_d
Hi
On Tue, Feb 21, 2012 at 3:12 PM, Hans de Goede wrote:
> + spice_usbredir_channel_get_guest_filter(
> + g_ptr_array_index(priv->channels, 0),
> + &guest_filter_rules, &guest_filter_rules_count);
Memory management of guest_filter_rules isn't explicit here, but
looking at usbred
On Wed, Feb 22, 2012 at 02:58:10PM +0100, Gerd Hoffmann wrote:
> > And the only user of screen_dump_filename is:
> >
> > static void vga_save_dpy_update(DisplayState *ds,
> > int x, int y, int w, int h)
> > {
> > if (screen_dump_filename) {
> > ppm_save(
On Wed, Feb 22, 2012 at 03:09:09PM +0100, Gerd Hoffmann wrote:
> On 02/22/12 13:28, Alon Levy wrote:
> > On Wed, Feb 22, 2012 at 12:18:50PM +0100, Gerd Hoffmann wrote:
> >> Hi,
> >>
> >> It's not obvious to me how the non-flipped case (qxl_stride > 0) is
> >> handled now. Have you tested this wi
The patch looks fine in general.
You like to use a lot GError in general, which is a good thing. But we
didn't have so many error conditions reported until now. You shouldn't
be affraid to introduce and use different error codes. That would
allow the caller to do something smart about it (may soun
On 02/22/12 13:28, Alon Levy wrote:
> On Wed, Feb 22, 2012 at 12:18:50PM +0100, Gerd Hoffmann wrote:
>> Hi,
>>
>> It's not obvious to me how the non-flipped case (qxl_stride > 0) is
>> handled now. Have you tested this with both windows+linux guests?
>
> It isn't handled. The simplest way is ju
> And the only user of screen_dump_filename is:
>
> static void vga_save_dpy_update(DisplayState *ds,
> int x, int y, int w, int h)
> {
> if (screen_dump_filename) {
> ppm_save(screen_dump_filename, ds->surface);
upstream/master this here:
sc
Somehow the infobar is not aligned with the checkbox buttons below. Is
it intentionnal?
On Tue, Feb 21, 2012 at 3:12 PM, Hans de Goede wrote:
> + gtk_box_pack_start(GTK_BOX(hbox), widget, FALSE, FALSE, 0);
I would expand/fill the label
> + priv->info_bar = gtk_alignment_new(0, 0, 0, 0);
Fabiano Fidêncio píše v St 22. 02. 2012 v 02:53 -0200:
> Howdy!
>
> I found out the problem. It was a regression introduced by commit
> 075360945860ad9bdd491921954b383bf762b0e5, in QEMU (almost had a
> birthday).
> There's one attached patch, that reverts the problematic commit and
> fixes the con
ack
On Tue, Feb 21, 2012 at 3:12 PM, Hans de Goede wrote:
> When running "./configure --disable-usbredir" the
> "USB redirection support" line in the summary at the end of ./configure
> would be empty after "support" instead of ending with yes or no.
>
> Signed-off-by: Hans de Goede
> ---
> con
ack
On Tue, Feb 21, 2012 at 3:12 PM, Hans de Goede wrote:
> Rather then treating it as any other error. This avoids showing an error
> dialog after the user pressed cancel in the policykit dialog.
>
> Signed-off-by: Hans de Goede
> ---
> gtk/spice-client-glib-usb-acl-helper.c | 5 +
> gt
On Tue, Feb 21, 2012 at 3:12 PM, Hans de Goede wrote:
> diff --git a/gtk/channel-usbredir.c b/gtk/channel-usbredir.c
> + /**
> + * SpiceUsbredirChannel::device-error:
> + * @channel: #SpiceUsbredirChannel that emitted the signal
> + * @device: #SpiceUsbDevice boxed object correspon
On Wed, Feb 22, 2012 at 12:46:28PM +0100, Gerd Hoffmann wrote:
> On 02/21/12 22:39, Alon Levy wrote:
> > This changes the behavior of the monitor command. After the previous
> > patch, there is no longer an option of deadlock with virt-manager, but
> > ppm_save is called too early, before the updat
On Wed, Feb 22, 2012 at 12:46:28PM +0100, Gerd Hoffmann wrote:
> On 02/21/12 22:39, Alon Levy wrote:
> > This changes the behavior of the monitor command. After the previous
> > patch, there is no longer an option of deadlock with virt-manager, but
> > ppm_save is called too early, before the updat
On Wed, Feb 22, 2012 at 12:41:01PM +0100, Gerd Hoffmann wrote:
> Hi,
>
> > +qxl->render_update_redraw_area.left = 0;
> > +qxl->render_update_redraw_area.right =
> > +qxl->guest_primary.surface.width;
> > +qxl->render_update_redraw_area.top= 0;
> > +qxl->render_upda
On Wed, Feb 22, 2012 at 12:18:50PM +0100, Gerd Hoffmann wrote:
> Hi,
>
> It's not obvious to me how the non-flipped case (qxl_stride > 0) is
> handled now. Have you tested this with both windows+linux guests?
It isn't handled. The simplest way is just to if on the stride and do a
single memcpy
On Wed, Feb 22, 2012 at 12:10:08PM +0100, Gerd Hoffmann wrote:
> On 02/21/12 22:39, Alon Levy wrote:
> > Using vga->screen_dump results in a number of calls to ppm_save,
> > instead of a single one.
>
> Can you investigate why?
oh, I know why. vga_screen_dump implementation:
screen_dump_file
On Wed, Feb 22, 2012 at 11:59:18AM +0100, Marc-André Lureau wrote:
> On Wed, Feb 22, 2012 at 9:15 AM, Alon Levy wrote:
> > Or do you think it
> > should diverge simply because different packages will have different
> > needs at the same time?
>
> I wouldn't say "diverge". It's the same protocol a
On 02/21/12 22:39, Alon Levy wrote:
> This changes the behavior of the monitor command. After the previous
> patch, there is no longer an option of deadlock with virt-manager, but
> ppm_save is called too early, before the update has completed. With this
> patch it is called at the correct moment,
Hi,
> +qxl->render_update_redraw_area.left = 0;
> +qxl->render_update_redraw_area.right =
> +qxl->guest_primary.surface.width;
> +qxl->render_update_redraw_area.top= 0;
> +qxl->render_update_redraw_area.bottom =
> +qxl->guest_primary.surface.height;
Are th
On 02/21/12 22:39, Alon Levy wrote:
> Will be used in the next patch.
Looks good, and is more readable without all the #ifdefs.
> static void qxl_spice_flush_surfaces_async(PCIQXLDevice *qxl)
> {
> -spice_qxl_flush_surfaces_async(&qxl->ssd.qxl, 0);
> + spice_qxl_flush_surfaces_async(&qxl->s
Hi,
It's not obvious to me how the non-flipped case (qxl_stride > 0) is
handled now. Have you tested this with both windows+linux guests?
cheers,
Gerd
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mail
On 02/21/12 22:39, Alon Levy wrote:
> drop all ifdefs on SPICE_INTERFACE_QXL_MINOR >= 1 as a result,
> 0.8.2 has SPICE_INTERFACE_QXL_MINOR == 1.
Nice. I think there are a few more SPICE_SERVER_VERSION #ifdefs which
can be dropped too. Also SPICE_INTERFACE_CORE_MINOR ...
cheers,
Gerd
On 02/21/12 22:39, Alon Levy wrote:
> Using vga->screen_dump results in a number of calls to ppm_save,
> instead of a single one.
Can you investigate why?
> Lacking time to test all the possible users of
> vga->screen_dump, avoid the redundant calls by doing the vga_hw_update+
> ppm_save in qxl_h
On Wed, Feb 22, 2012 at 9:15 AM, Alon Levy wrote:
> Or do you think it
> should diverge simply because different packages will have different
> needs at the same time?
I wouldn't say "diverge". It's the same protocol after all, just used
at build time only.
If we break it, we are screwed anyway.
On 02/21/2012 12:09 PM, Hans de Goede wrote:
> Hi,
>
> I'm working on some better / prettier error reporting for the usb
> device widget, and I
> was wondering should we auto-redirect newly plugged in USB devices
> when auto-redir
> is enabled and they get plugged on while showing the USB device
>
On Tue, Feb 21, 2012 at 09:31:55AM -0800, Naga Mohan Pothula wrote:
> Hi Christophe/Aon,
>
> Debugging is not possible for this scenario and hence stack trace could not
> be retrieved.
Why not possible? Did you disable/strip debug symbols? You can always
attach gdb to a running process using gdb
On Wed, Feb 22, 2012 at 12:27:07AM +0100, Marc-André Lureau wrote:
> On Tue, Feb 21, 2012 at 6:48 PM, Alon Levy wrote:
> > We will still need releases for anyone building from tarballs, which
> > includes all distribution built packages.
>
> Not with the submodule & autofoo solution I proposed fo
46 matches
Mail list logo
