Re: [Spice-devel] Failing to compile spice-gtk: ../common/client_marshallers.h:27:24: fatal error: marshaller.h: No such file or directory

2012-04-02 Thread Yaniv Kaul
On 04/01/2012 10:41 PM, Marc-André Lureau wrote: Hi - Mensaje original - Indeed - that was the problem - thank you. I don't know how it was not removed during 'git pull'. (and already found a spice-gtk bug - the 'shift+F12' combination seems to work only as 'left-shift+F12', not

[Spice-devel] [PATCH spice-protocol] controller: add COLOR_DEPTH and DISABLE_EFFECTS messages

2012-04-02 Thread Yonit Halperin
rhbz #787447 Signed-off-by: Yonit Halperin yhalp...@redhat.com --- spice/controller_prot.h |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/spice/controller_prot.h b/spice/controller_prot.h index a60b122..f7b1f26 100644 --- a/spice/controller_prot.h +++

[Spice-devel] [PATCH spice-common] updated submodule spice-protocol

2012-04-02 Thread Yonit Halperin
added the disable-effects and color-depth options to the controller Signed-off-by: Yonit Halperin yhalp...@redhat.com --- spice-protocol |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/spice-protocol b/spice-protocol index 32da251..8cf92f0 16 --- a/spice-protocol +++

[Spice-devel] [PATCH spice-gtk] controller: add support for DISABLE_EFFECTS and COLOR_DEPTH

2012-04-02 Thread Yonit Halperin
rhbz #787449 Signed-off-by: Yonit Halperin yhalp...@redhat.com --- data/spice-protocol.vapi |3 +++ gtk/controller/controller.vala |9 + spice-common |2 +- 3 files changed, 13 insertions(+), 1 deletions(-) diff --git a/data/spice-protocol.vapi

[Spice-devel] [PATCH spice-xpi] add support for DisableEffects and ColorDepth

2012-04-02 Thread Yonit Halperin
rhbz #747313 Signed-off-by: Yonit Halperin yhalp...@redhat.com --- SpiceXPI/src/plugin/nsISpicec.idl|2 ++ SpiceXPI/src/plugin/nsScriptablePeer.cpp | 16 +++- SpiceXPI/src/plugin/nsScriptablePeer.h |2 ++ SpiceXPI/src/plugin/plugin.cpp | 26

[Spice-devel] [PATCH virt-viewer] spice/controller: add support for the properties disable-effects color-depth

2012-04-02 Thread Yonit Halperin
rhbz #808986 Signed-off-by: Yonit Halperin yhalp...@redhat.com --- src/remote-viewer.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/src/remote-viewer.c b/src/remote-viewer.c index 7dda7fe..5f7685f 100644 --- a/src/remote-viewer.c +++ b/src/remote-viewer.c @@ -583,7

Re: [Spice-devel] Read data out of the Virtqueue

2012-04-02 Thread Charles . Tsai-蔡清海-研究發展部
Alon, In spice client, the creation of the channel is based on init-num_of_channels that is returned from the spice server. Please see the following function to create the spice channel from the client void RedClient::handle_channels(RedPeer::InMessage* message) {

Re: [Spice-devel] [PATCH spice-protocol] controller: add COLOR_DEPTH and DISABLE_EFFECTS messages

2012-04-02 Thread Hans de Goede
ACK. On 04/02/2012 09:41 AM, Yonit Halperin wrote: rhbz #787447 Signed-off-by: Yonit Halperinyhalp...@redhat.com --- spice/controller_prot.h |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/spice/controller_prot.h b/spice/controller_prot.h index a60b122..f7b1f26

Re: [Spice-devel] [PATCH spice-common] updated submodule spice-protocol

2012-04-02 Thread Hans de Goede
ACK. On 04/02/2012 09:41 AM, Yonit Halperin wrote: added the disable-effects and color-depth options to the controller Signed-off-by: Yonit Halperinyhalp...@redhat.com --- spice-protocol |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/spice-protocol b/spice-protocol

Re: [Spice-devel] oVirt - spice activex / spice-xpi plugins for Windows?

2012-04-02 Thread Christophe Fergeau
On Wed, Feb 22, 2012 at 06:12:35PM -0500, Douglas Landgraf wrote: Do we have such plugins for Windows users that would like to open their vms from browser? I don't think we have such plugins yet unfortunately... Something really useful would be someone doing a VisualC++ build of spice-xpi. It

Re: [Spice-devel] [PATCH spice-gtk] controller: add support for DISABLE_EFFECTS and COLOR_DEPTH

2012-04-02 Thread Hans de Goede
ACK. On 04/02/2012 09:42 AM, Yonit Halperin wrote: rhbz #787449 Signed-off-by: Yonit Halperinyhalp...@redhat.com --- data/spice-protocol.vapi |3 +++ gtk/controller/controller.vala |9 + spice-common |2 +- 3 files changed, 13 insertions(+), 1

Re: [Spice-devel] [PATCH spice-xpi] add support for DisableEffects and ColorDepth

2012-04-02 Thread Hans de Goede
ACK. On 04/02/2012 09:42 AM, Yonit Halperin wrote: rhbz #747313 Signed-off-by: Yonit Halperinyhalp...@redhat.com --- SpiceXPI/src/plugin/nsISpicec.idl|2 ++ SpiceXPI/src/plugin/nsScriptablePeer.cpp | 16 +++- SpiceXPI/src/plugin/nsScriptablePeer.h |2 ++

Re: [Spice-devel] [PATCH virt-viewer] spice/controller: add support for the properties disable-effects color-depth

2012-04-02 Thread Hans de Goede
ACK. On 04/02/2012 09:43 AM, Yonit Halperin wrote: rhbz #808986 Signed-off-by: Yonit Halperinyhalp...@redhat.com --- src/remote-viewer.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/src/remote-viewer.c b/src/remote-viewer.c index 7dda7fe..5f7685f 100644 ---

Re: [Spice-devel] [PATCH spice-xpi] add support for DisableEffects and ColorDepth

2012-04-02 Thread Christophe Fergeau
Hey, On Mon, Apr 02, 2012 at 10:42:32AM +0300, Yonit Halperin wrote: @@ -482,6 +484,28 @@ void nsPluginInstance::SetUsbAutoShare(PRBool aUsbAutoShare) // when fixed in RHEVM } +/* attribute string ColorDepth; */ +char *nsPluginInstance::GetColorDepth() const +{ +return

[Spice-devel] [spice-gtk 2/2] autogen.sh: log configure command line

2012-04-02 Thread Christophe Fergeau
Since --enable-vala may or may not be passed to configure, seeing the actual command line that was used is helpful. --- autogen.sh |1 + 1 file changed, 1 insertion(+) diff --git a/autogen.sh b/autogen.sh index 11aedb0..aefd2fd 100755 --- a/autogen.sh +++ b/autogen.sh @@ -15,6 +15,7 @@ if

[Spice-devel] [spice-devel] spice-xpi rhbz#806215

2012-04-02 Thread Peter Hatina
Hi, can you have a look at this, before I can push it to FDO git? From fef8de569a7268bed272105649941b9dac5f4f98 Mon Sep 17 00:00:00 2001 From: Peter Hatina phat...@redhat.com Date: Mon, 2 Apr 2012 12:11:20 +0200 Subject: [PATCH 1/4] remove unused class member --- SpiceXPI/src/plugin/plugin.h |

Re: [Spice-devel] [spice-gtk 1/2] configure.ac: improve vala detection

2012-04-02 Thread Marc-André Lureau
Hi - Mensaje original - Currently, configure doesn't check for vala, nor set vala related variables unless --enable-vala was passed. autogen.sh automatically pass --enable-vala if controller.vala.stamp doesn't exist. However, this is not enough since if controller.vala is newer than

[Spice-devel] [PATCH spice 00/12] Add more compiler warnings

2012-04-02 Thread Daniel P. Berrange
A followup to the previous patch which enabled more compiler warnings for spice-gtk. This one does the same for 'spice'. Less to fix now that we have spice-common shared ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org

[Spice-devel] [PATCH spice 01/12] Don't do arithmetic on void * type, use uint8_t instead

2012-04-02 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Arithmetic on void * types is non-portable trivially avoided * server/dispatcher.c: Use uint8_t for arithmetic Signed-off-by: Daniel P. Berrange berra...@redhat.com --- server/dispatcher.c | 12 ++-- 1 files changed, 6 insertions(+), 6

[Spice-devel] [PATCH spice 05/12] Mark some variables as volatile

2012-04-02 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com When using setjmp/longjmp the state of local variables can be undefined in certain scenarios: [quote man(longjmp)] The values of automatic variables are unspecified after a call to longjmp() if they meet all the following criteria:

[Spice-devel] [PATCH spice 09/12] VSCMsgHeader.reader_id is unsigned, so don't check for = 0

2012-04-02 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com * server/smartcard.c: Fix assertion to not check for = 0 on unsigned variable Signed-off-by: Daniel P. Berrange berra...@redhat.com --- server/smartcard.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/server/smartcard.c

Re: [Spice-devel] [spice-gtk 1/2] configure.ac: improve vala detection

2012-04-02 Thread Marc-André Lureau
- Mensaje original - Alternatively, doing unconditionnally --enable-vala in autogen.sh would work for me too I think. That sounds reasonable. ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org

Re: [Spice-devel] [spice-gtk 1/2] configure.ac: improve vala detection

2012-04-02 Thread Hans de Goede
Hi, On 04/02/2012 12:38 PM, Marc-André Lureau wrote: Hi - Mensaje original - Currently, configure doesn't check for vala, nor set vala related variables unless --enable-vala was passed. autogen.sh automatically pass --enable-vala if controller.vala.stamp doesn't exist. However, this

Re: [Spice-devel] [spice-devel] spice-xpi rhbz#806215

2012-04-02 Thread Peter Hatina
Hi, On 04/02/2012 01:41 PM, Hans de Goede wrote: Hi, I assumed you've tested things still compile and work after this? If so ack. Regards, Hans Yes. Btw, the member m_fIPC was not used at all. On 04/02/2012 12:30 PM, Peter Hatina wrote: Hi, can you have a look at this,

Re: [Spice-devel] [spice-gtk 1/2] configure.ac: improve vala detection

2012-04-02 Thread Christophe Fergeau
On Mon, Apr 02, 2012 at 07:40:31AM -0400, Marc-André Lureau wrote: - Mensaje original - Alternatively, doing unconditionnally --enable-vala in autogen.sh would work for me too I think. That sounds reasonable. Ok, though on second thought I'd rather we also have vala

Re: [Spice-devel] [spice-gtk 1/2] configure.ac: improve vala detection

2012-04-02 Thread Marc-André Lureau
- Mensaje original - On Mon, Apr 02, 2012 at 07:40:31AM -0400, Marc-André Lureau wrote: - Mensaje original - Alternatively, doing unconditionnally --enable-vala in autogen.sh would work for me too I think. That sounds reasonable. Ok, though on second thought

Re: [Spice-devel] [Qemu-devel] Vioserial of Windows guest OS on Qemu 0.15

2012-04-02 Thread Vadim Rozenfeld
On Monday, March 19, 2012 02:48:43 PM Paul Lu-???-? wrote: Hi Vadim, Here is the configuration: /usr/local/bin/qemu-system-x86_64 \ -localtime \ -boot order=c,menu=on \ -drive file=/var/lib/libvirt/images/xxx.img \ -vga qxl \ -cdrom /home/paul/Downloads/ISO/virtio-win-0.1-15.iso \

[Spice-devel] [PATCH spice-gtk 1/2] SpiceDisplay: Don't try to scale mouse coordinates when we're not scaling

2012-04-02 Thread Hans de Goede
Often (when not resized by the user) even though scaling is enabled, we are not actually scaling. In this case it is not necessary to scale the mouse coordinates, and sometimes it is even harmful. Signed-off-by: Hans de Goede hdego...@redhat.com --- gtk/spice-widget.c |2 +- 1 file changed,

[Spice-devel] [PATCH spice-gtk 2/2] SpiceDisplay: Fix rounding of mouse motion events with GTK-3.0

2012-04-02 Thread Hans de Goede
Before this patch we were assuming that the GdkEventMotion value we receive are always whole (integer) numbers, which is not the case with GTK-3.0. Signed-off-by: Hans de Goede hdego...@redhat.com --- gtk/spice-widget.c | 20 +++- 1 file changed, 15 insertions(+), 5

Re: [Spice-devel] [virt-tools-list] [PATCH virt-viewer] spice/controller: add support for the properties disable-effects color-depth

2012-04-02 Thread Hans de Goede
ACK On 04/02/2012 09:43 AM, Yonit Halperin wrote: rhbz #808986 Signed-off-by: Yonit Halperinyhalp...@redhat.com --- src/remote-viewer.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/src/remote-viewer.c b/src/remote-viewer.c index 7dda7fe..5f7685f 100644 ---

Re: [Spice-devel] [PATCH spice-gtk 1/2] SpiceDisplay: Don't try to scale mouse coordinates when we're not scaling

2012-04-02 Thread Marc-André Lureau
ack series - Mensaje original - Often (when not resized by the user) even though scaling is enabled, we are not actually scaling. In this case it is not necessary to scale the mouse coordinates, and sometimes it is even harmful. Signed-off-by: Hans de Goede hdego...@redhat.com ---

[Spice-devel] fix build with glib 2.32

2012-04-02 Thread nicolas prochazka
hello patch from Marc-André Lureau : [Spice-devel] [PATCH spice-gtk 1/2] build: fix build with glib 2.32 does not cover channel-usbredir.c  file compilation is not possible. Regards, Nicolas Prochazka. ___ Spice-devel mailing list

Re: [Spice-devel] fix build with glib 2.32

2012-04-02 Thread Marc-André Lureau
Hi - Mensaje original - hello patch from Marc-André Lureau : [Spice-devel] [PATCH spice-gtk 1/2] build: fix build with glib 2.32 does not cover channel-usbredir.c  file compilation is not possible. Can you try the attached patch? thanksdiff --git a/gtk/channel-usbredir.c

Re: [Spice-devel] oVirt - spice activex / spice-xpi plugins for Windows?

2012-04-02 Thread Nerijus Baliunas
On Mon, 2 Apr 2012 10:37:25 +0200 Christophe Fergeau cferg...@redhat.com wrote: Do we have such plugins for Windows users that would like to open their vms from browser? I don't think we have such plugins yet unfortunately... Something really useful would be someone doing a VisualC++

Re: [Spice-devel] [PATCH spice 06/12] Remove 2 *MB* stack frame in red_worker_main

2012-04-02 Thread Marc-André Lureau
On Mon, Apr 2, 2012 at 1:23 PM, Daniel P. Berrange berra...@redhat.com wrote: From: Daniel P. Berrange berra...@redhat.com The red_worker_main method allocates a RedWorker struct instance on the stack. This struct is a full 2 MB in size which is not at all resonable to allocate on the stack.