[Spice-devel] Spice Client Rendering

2012-04-19 Thread 蒋媛园
Hi I want to know that whether all the graphics are rendered in the Spice client or not. For example, the engine-managed surfaces are rendered in VNC way, however device-managed surfaces are rendered in Spice way (through cmds: QXLdrawable). Thanks in advance Best

[Spice-devel] Spice Client Rendering

2012-04-19 Thread 蒋媛园
Hi I want to know that whether all the graphics are rendered in the Spice client or not. For example, the engine-managed surfaces are rendered in VNC way, however device-managed surfaces are rendered in Spice way (through cmds: QXLdrawable). Thanks in advance Best Regards!

Re: [Spice-devel] [PATCH v2 spice-protocol 2/2] Add qos related messages

2012-04-19 Thread Yonit Halperin
On 04/18/2012 08:47 PM, Marc-André Lureau wrote: Hi On Wed, Apr 18, 2012 at 7:34 PM, Marc-André Lureau marcandre.lur...@gmail.com wrote: It would be - QOS_QUERY(nbytes) - nbytes of various messages 1 or n - QOS_ACK Further questions about this, how can the server really determine the

Re: [Spice-devel] [PATCH spice-gtk] Rewrite URI parsing to work with IPv6 raw addresses

2012-04-19 Thread David Jaša
Marc-André Lureau píše v St 18. 04. 2012 v 12:01 -0400: - Mensaje original - Is that really a burden ? libxml2 exists on pretty much every system in the world. Even my TV came with a copy of the Libxml2 README and LICENSE :-) virt-viewer / libvirt will already be using it too.

Re: [Spice-devel] [PATCH spice-gtk] RFC: widget: improve undesired key repeatition

2012-04-19 Thread Hans de Goede
Hi, On 04/19/2012 03:17 AM, Marc-André Lureau wrote: The remote end receives key press and key release seperately, but this can cause extra key repetition between the two event messages: - if the network is slow - if the server is busy and doesn't handle the events quickly enough - if the

[Spice-devel] [PATCH] Fix callback signature for --spice-debug option handling

2012-04-19 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com The callback for option handling should return TRUE otherwise the option parser will think parsing failed. The current 'void' return type meant it was non-deterministic whether --spice-debug actually worked or not Signed-off-by: Daniel P. Berrange

[Spice-devel] [PATCH spice-gtk] setsockopt: check for ENOTSUP only if defined

2012-04-19 Thread Uri Lublin
For windows (mingw32) ENOTSUP is not defined. Related to 3bfadb8587f59a74d373e26385d348a105c2e425 --- gtk/spice-channel.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/gtk/spice-channel.c b/gtk/spice-channel.c index 783b94a..3952e9a 100644 ---

Re: [Spice-devel] [PATCH] Fix callback signature for --spice-debug option handling

2012-04-19 Thread Hans de Goede
Good catch, ACK. Regards, Hans On 04/19/2012 12:07 PM, Daniel P. Berrange wrote: From: Daniel P. Berrangeberra...@redhat.com The callback for option handling should return TRUE otherwise the option parser will think parsing failed. The current 'void' return type meant it was

Re: [Spice-devel] [PATCH spice-gtk] setsockopt: check for ENOTSUP only if defined

2012-04-19 Thread Hans de Goede
Looks good, ack. On 04/19/2012 10:41 AM, Uri Lublin wrote: For windows (mingw32) ENOTSUP is not defined. Related to 3bfadb8587f59a74d373e26385d348a105c2e425 --- gtk/spice-channel.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/gtk/spice-channel.c

Re: [Spice-devel] [PATCH] Fix callback signature for --spice-debug option handling

2012-04-19 Thread Daniel P. Berrange
On Thu, Apr 19, 2012 at 12:12:57PM +0200, Hans de Goede wrote: Good catch, ACK. Thanks, applied now I finally have GIT accesss on fd.o Daniel -- |: http://berrange.com -o-http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o-

[Spice-devel] [PATCH 1/6] server/tests: refactor test_display_base

2012-04-19 Thread Alon Levy
--- server/tests/test_display_base.c | 79 ++ 1 file changed, 45 insertions(+), 34 deletions(-) diff --git a/server/tests/test_display_base.c b/server/tests/test_display_base.c index f6c3f6b..e376195 100644 --- a/server/tests/test_display_base.c +++

[Spice-devel] [PATCH 2/6] server/tests/test_display_base: fix two int to pointer cast warnings

2012-04-19 Thread Alon Levy
--- server/tests/test_display_base.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/server/tests/test_display_base.c b/server/tests/test_display_base.c index e376195..d060f3f 100644 --- a/server/tests/test_display_base.c +++ b/server/tests/test_display_base.c @@ -533,7

[Spice-devel] [PATCH 3/6] server/tests: add test_get_width/test_get_height

2012-04-19 Thread Alon Levy
--- server/tests/test_display_base.c | 16 server/tests/test_display_base.h |3 +++ 2 files changed, 19 insertions(+) diff --git a/server/tests/test_display_base.c b/server/tests/test_display_base.c index d060f3f..fd9a37e 100644 --- a/server/tests/test_display_base.c +++

[Spice-devel] [PATCH 4/6] server/tests: refactor Command

2012-04-19 Thread Alon Levy
--- server/tests/test_display_base.c | 10 +++ server/tests/test_display_base.h | 33 server/tests/test_display_resolution_changes.c | 10 +++ 3 files changed, 37 insertions(+), 16 deletions(-) diff --git

[Spice-devel] [PATCH 6/6] server/tests/test_display_streaming: update to create sized frames

2012-04-19 Thread Alon Levy
--- server/tests/test_display_streaming.c | 44 +++-- 1 file changed, 37 insertions(+), 7 deletions(-) diff --git a/server/tests/test_display_streaming.c b/server/tests/test_display_streaming.c index 1b81d76..b4fe013 100644 ---

Re: [Spice-devel] [PATCH v2 spice-protocol 2/2] Add qos related messages

2012-04-19 Thread David Jaša
Marc-André Lureau píše v St 18. 04. 2012 v 19:47 +0200: Hi On Wed, Apr 18, 2012 at 7:34 PM, Marc-André Lureau marcandre.lur...@gmail.com wrote: It would be - QOS_QUERY(nbytes) - nbytes of various messages 1 or n - QOS_ACK Further questions about this, how can the server really

Re: [Spice-devel] Spice Client Rendering

2012-04-19 Thread Noel Van Hook
It is the latter case. Much of the drawing is done done using device managed surfaces, and QXL drawing commands, but there is always the possibility of falling all the way back to CPU drawing to a memory bitmap which is then copied to the client. Noel 2012/4/19 蒋媛园 jiangqq_...@126.com: Hi I

[Spice-devel] [PATCH spice-gtk (v2)] Fix multiple problems with URI parsing

2012-04-19 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com The URI parsing was not correctly skipping over the path component if a port number was specified using the traditional URI scheme, eg spice://somehost:5900/ would result in failed parse due to the trailing '/' The URI parsing was also not

Re: [Spice-devel] [PATCH spice-gtk (v2)] Fix multiple problems with URI parsing

2012-04-19 Thread Marc-André Lureau
On Thu, Apr 19, 2012 at 4:51 PM, Daniel P. Berrange berra...@redhat.com wrote: +    g_printerr([%s][%s][%s][%s]\n, uri, authority, path, query); Is this a leftover? If not perhaps SPICE_DEBUG is more appropriate -- Marc-André Lureau ___ Spice-devel

[Spice-devel] [PATCH spice-gtk (v3)] Fix multiple problems with URI parsing

2012-04-19 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com The URI parsing was not correctly skipping over the path component if a port number was specified using the traditional URI scheme, eg spice://somehost:5900/ would result in failed parse due to the trailing '/' The URI parsing was also not

[Spice-devel] Auto-config not working with Spicy client...

2012-04-19 Thread Naga Mohan Pothula
Hi, Built Qemu v0.12.1, Spice v0.8.3 and Spice-gtk v0.6.2 from SRPMS of RHEL 6.2. When I launched session with SPICY client in full-screen mode(ie., --full-screen=auto-conf), screen resolution is not adjusted automatically. VDAgent is working fine at guest. Tested even with Spice-gtk-0.11 and

Re: [Spice-devel] [PATCH spice-gtk (v3)] Fix multiple problems with URI parsing

2012-04-19 Thread Marc-André Lureau
Hi Somehow, it doesn' t work anymore without trailing / -- Marc-André Lureau ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel

Re: [Spice-devel] [PATCH spice-gtk] RFC: widget: improve undesired key repeatition

2012-04-19 Thread Marc-André Lureau
Hi Now that I implemented it a bit more correctly, using a timer, and splitting the in two patches, I realize that it doesn't work with windows. Windows expect to receive several key press events apparently. Hans, the hack you mentionned in spicec doesn't seem to be what you said, since spicec