Hi,
>>> I have now got Spice working on openSUSE using spice client as
>>> opposed to virt-viewer. However I still have the problem that there
>>> is no Microphone Audio Recording device present, only a line-in
>>> device. Any suggestion what I need to do to get that device to
>>> install itself
Do not depend on uninitialized "len" variable to set the query string.
https://bugzilla.redhat.com/show_bug.cgi?id=818169
---
gtk/spice-session.c |8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/gtk/spice-session.c b/gtk/spice-session.c
index 959e099..b3c66ce 100644
On Wed, May 02, 2012 at 02:03:55PM +0200, Marc-André Lureau wrote:
> Do not depend on uninitialized "len" variable to set the query string.
>
> https://bugzilla.redhat.com/show_bug.cgi?id=818169
> ---
> gtk/spice-session.c |8 +++-
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> di
- Mensaje original -
> > if (path) {
> > size_t prefix = strcspn(path, URI_QUERY_START);
> > -if (len)
> > -query = path + prefix;
> > +query = path + prefix;
> > } else {
> > size_t prefix = strcspn(authority, URI_QUERY_START);
> >
On Wed, May 02, 2012 at 08:31:32AM -0400, Marc-André Lureau wrote:
>
>
> - Mensaje original -
> > > if (path) {
> > > size_t prefix = strcspn(path, URI_QUERY_START);
> > > -if (len)
> > > -query = path + prefix;
> > > +query = path + prefix;
> > >
These series contain patches for spice-protocol, spice-common, spice, and spice
gtk.
They fix rhbz 813826 815422 815426.
Part of the patches were already sent as part of the video/mjpeg/qos series.
However, since then, I have made more modifications that were required due to
a difference in the l
rhbz #815422
Add SPICE_MSG_DISPLAY_STREAM_DATA_SIZED, for stream_data message
that in addition to the mjpeg data, also contains the
(1) width and height of the compressed frame.
(2) the destination box of the frame.
The server can send such messages only to clients with
SPICE_DISPLAY_CAP_SIZED_STR
---
common/rect.h | 11 +++
1 files changed, 11 insertions(+), 0 deletions(-)
diff --git a/common/rect.h b/common/rect.h
index a63d785..655e9e8 100644
--- a/common/rect.h
+++ b/common/rect.h
@@ -74,6 +74,12 @@ static INLINE int rect_is_same_size(const SpiceRect *r1,
const SpiceRect *r2
---
common/rect.h | 10 ++
1 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/common/rect.h b/common/rect.h
index 655e9e8..a9c1b08 100644
--- a/common/rect.h
+++ b/common/rect.h
@@ -80,6 +80,11 @@ static INLINE int rect_contains(const SpiceRect *big, const
SpiceRect *small)
---
common/rect.h | 11 +++
1 files changed, 11 insertions(+), 0 deletions(-)
diff --git a/common/rect.h b/common/rect.h
index a9c1b08..f8bacf1 100644
--- a/common/rect.h
+++ b/common/rect.h
@@ -21,6 +21,7 @@
#include
#include "draw.h"
+#include "log.h"
SPICE_BEGIN_DECLS
@@ -8
---
common/region.c | 11 +++
common/region.h |2 ++
2 files changed, 13 insertions(+), 0 deletions(-)
diff --git a/common/region.c b/common/region.c
index 30a11e3..cd9ade0 100644
--- a/common/region.c
+++ b/common/region.c
@@ -386,6 +386,17 @@ void region_ret_rects(const QRegion *r
rhbz #813826, #815426
Add SPICE_MSG_DISPLAY_STREAM_DATA_SIZED, for stream_data message
that also contains the size and destination box of the data.
The server can send such messages only to clients with
SPICE_DISPLAY_CAP_SIZED_STREAM.
---
common/messages.h | 15 ++-
spice-protocol
We need some rect/region getters methods that were added
---
spice-common |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/spice-common b/spice-common
index 6af29a9..178c7ea 16
--- a/spice-common
+++ b/spice-common
@@ -1 +1 @@
-Subproject commit 6af29a97ac2d4e88e1391dd
---
server/red_worker.c | 27 ---
1 files changed, 16 insertions(+), 11 deletions(-)
diff --git a/server/red_worker.c b/server/red_worker.c
index 07782c8..09a9357 100644
--- a/server/red_worker.c
+++ b/server/red_worker.c
@@ -2485,6 +2485,11 @@ static void red_display_re
Differentiate between the clipping of the video stream, and the region
that currently displays fragments of the video stream (henceforth,
vis_region). The latter equals or contains the former one. For example,
let c1 be the clip area at time t1, and c2 be the clip area at time t2,
where t1 < t2. If
Upgrading a stream: When the stream's visible region is bigger than the one of
the last
frame, we will send an updated screenshot of the visible region, instead
of sending the last frame losslessly.
---
server/red_worker.c | 92 +++---
1 files changed
The previous patch took care that streams will be upgraded by a surface
screenshot and not the last frame, if necessary. Thus, there is no
more a reason for detaching drawables from streams when they are
rendered. Moreover, detaching such drawables can cause glitches, in
case they are still in the
spice-common changes: STREAM_DATA_SIZED message was added in order to support
video streams with frames that their size is different from the initial size
that the stream was created with.
This patch also includes server and client adjustments to the new
SpiceMsgDisplayStreamData.
---
client/disp
rhbz #813826
When playing a youtube video on Windows guest, the driver sometimes sends
images which contain the video frames, but also other parts of the
screen (e.g., the youtube process bar). In order to prevent glitches, we send
these
images as part of the stream, using SPICE_MSG_DISPLAY_STREA
---
server/red_worker.c | 42 --
1 files changed, 12 insertions(+), 30 deletions(-)
diff --git a/server/red_worker.c b/server/red_worker.c
index 306b316..18d6309 100644
--- a/server/red_worker.c
+++ b/server/red_worker.c
@@ -2454,31 +2454,6 @@ static Stre
From: Alon Levy
---
server/tests/test_display_base.c | 79 +
1 files changed, 45 insertions(+), 34 deletions(-)
diff --git a/server/tests/test_display_base.c b/server/tests/test_display_base.c
index f6c3f6b..e376195 100644
--- a/server/tests/test_display_ba
From: Alon Levy
---
server/tests/test_display_base.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/server/tests/test_display_base.c b/server/tests/test_display_base.c
index e376195..d060f3f 100644
--- a/server/tests/test_display_base.c
+++ b/server/tests/test_displa
From: Alon Levy
---
server/tests/test_display_base.c | 16
server/tests/test_display_base.h |3 +++
2 files changed, 19 insertions(+), 0 deletions(-)
diff --git a/server/tests/test_display_base.c b/server/tests/test_display_base.c
index d060f3f..fd9a37e 100644
--- a/serve
From: Alon Levy
---
server/tests/test_display_base.c | 10 +++
server/tests/test_display_base.h | 33 ---
server/tests/test_display_resolution_changes.c | 10 +++---
3 files changed, 37 insertions(+), 16 deletions(-)
diff --git a/server/
From: Alon Levy
---
server/tests/test_display_base.c | 43 -
server/tests/test_display_base.h |2 +
2 files changed, 39 insertions(+), 6 deletions(-)
diff --git a/server/tests/test_display_base.c b/server/tests/test_display_base.c
index f7b85c1..b43859c
From: Alon Levy
---
server/tests/test_display_streaming.c | 44 +++-
1 files changed, 37 insertions(+), 7 deletions(-)
diff --git a/server/tests/test_display_streaming.c
b/server/tests/test_display_streaming.c
index 1b81d76..b4fe013 100644
--- a/server/tests/test_
---
server/tests/test_display_base.c | 34 --
server/tests/test_display_base.h |2 ++
2 files changed, 30 insertions(+), 6 deletions(-)
diff --git a/server/tests/test_display_base.c b/server/tests/test_display_base.c
index b43859c..79781f7 100644
--- a/server
---
server/tests/test_display_base.c |4
server/tests/test_display_base.h |6 ++
2 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/server/tests/test_display_base.c b/server/tests/test_display_base.c
index 79781f7..8601611 100644
--- a/server/tests/test_display_base.c
---
server/tests/test_display_base.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/server/tests/test_display_base.c b/server/tests/test_display_base.c
index 8601611..1840bfa 100644
--- a/server/tests/test_display_base.c
+++ b/server/tests/test_display_base.c
@@ -506,8
CC: Alon Levy
---
server/tests/test_display_streaming.c | 197 ++---
1 files changed, 181 insertions(+), 16 deletions(-)
diff --git a/server/tests/test_display_streaming.c
b/server/tests/test_display_streaming.c
index b4fe013..f395800 100644
--- a/server/tests/test_
rhbz #815426
When playing a youtube video on Windows guest, the driver sometimes sends
images which contain a video frame, but also other parts of the
screen (e.g., the you tube process bar). In order to prevent glitches, we send
these
images as part of the stream, using SPICE_MSG_DISPLAY_STREAM_
Hi
On Sat, Apr 28, 2012 at 8:20 AM, xufango wrote:
> if (NULL != st->out_frame)
> free(st->out_frame);
What version of spice-gtk are you using? That leak should be fixed
since version 0.8 (commit a73f841b59faadccec2c0c410f15149d4a5cb5bb)
regards
--
Marc-André Lureau
looks good, ack both spice-protocol and spice-common changes
On Wed, May 2, 2012 at 3:55 PM, Yonit Halperin wrote:
> rhbz #813826, #815426
>
> Add SPICE_MSG_DISPLAY_STREAM_DATA_SIZED, for stream_data message
> that also contains the size and destination box of the data.
> The server can send such
Hi
Minor comments below
On Wed, May 2, 2012 at 4:05 PM, Yonit Halperin wrote:
> --- a/gtk/channel-display-priv.h
> +++ b/gtk/channel-display-priv.h
> @@ -73,6 +73,11 @@ typedef struct display_stream {
> SpiceChannel *channel;
> } display_stream;
>
> +void stream_get_dimension
On Wed, May 02, 2012 at 05:01:42PM +0300, Yonit Halperin wrote:
> rhbz #813826
>
This patch doesn't apply. The patch needs some fixing anyway, comments
below.
> When playing a youtube video on Windows guest, the driver sometimes sends
> images which contain the video frames, but also other parts
On Wed, May 02, 2012 at 05:01:45PM +0300, Yonit Halperin wrote:
> From: Alon Levy
No longer required, superceded by 39565707a9b9b6460ca18c5c9749ae565d583e2a
(minus a missing space but de nada).
>
> ---
> server/tests/test_display_base.c |4 ++--
> 1 files changed, 2 insertions(+), 2 deleti
On Wed, May 02, 2012 at 05:01:36PM +0300, Yonit Halperin wrote:
ACK series, minus two commented patches. Another comment that you can
fix or not coming up (same as last time, the *1.3 turned to *2 constant,
but just a nitpick).
> We need some rect/region getters methods that were added
> ---
> s
On Wed, May 02, 2012 at 05:01:42PM +0300, Yonit Halperin wrote:
> rhbz #813826
>
One comment below.
> When playing a youtube video on Windows guest, the driver sometimes sends
> images which contain the video frames, but also other parts of the
> screen (e.g., the youtube process bar). In order
On Wed, May 02, 2012 at 09:20:37PM +0300, Alon Levy wrote:
> On Wed, May 02, 2012 at 05:01:36PM +0300, Yonit Halperin wrote:
>
> ACK series, minus two commented patches. Another comment that you can
> fix or not coming up (same as last time, the *1.3 turned to *2 constant,
> but just a nitpick).
I had a puzzling bug where I could not establish a connection
with a spice server across an openvpn connection onto a Debian
stable box. It turns out that the network stack in question
apparently is very careful on non blocking sockets, and was
returning EAGAIN on the network ping test transmissio
40 matches
Mail list logo
