Re: [Spice-devel] [PATCH] server/red_worker: don't release self_bitmap unless refcount is 0

2012-05-14 Thread Uri Lublin
On 05/13/2012 02:40 PM, Alon Levy wrote: From: Yonit Halperinyhalp...@redhat.com RHBZ: 808936 --- server/red_worker.c |7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index 473d0d6..60f30d3 100644 ---

[Spice-devel] [PATCH 1/3] server/red_worker: red_process_drawable: have single point of exit

2012-05-14 Thread Alon Levy
--- server/red_worker.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index 60f30d3..4304f29 100644 --- a/server/red_worker.c +++ b/server/red_worker.c @@ -3905,23 +3905,19 @@ static inline void

[Spice-devel] [PATCH 2/3] server/red_worker/red_process_commands: rename drawable to red_drawable (later add a local drawable)

2012-05-14 Thread Alon Levy
--- server/red_worker.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index 4304f29..e1c86fa 100644 --- a/server/red_worker.c +++ b/server/red_worker.c @@ -4843,15 +4843,15 @@ static int red_process_commands(RedWorker

[Spice-devel] [PATCH 3/3] server/red_worker: fix possible leak of self_bitmap

2012-05-14 Thread Alon Levy
After the previous patch moving self_bitmap freeing inside red_drawable ref count, we have a possible self_bitmap leak: red_process_commands red_get_drawable | red_drawable #1, red_drawable-self_bitmap == 1 red_process_drawable | rd #2, d #1, d-self_bitmap != NULL release_drawable | rd #1,

Re: [Spice-devel] Problem with dual-display full-screen client on X

2012-05-14 Thread Christophe Fergeau
Hey, On Fri, May 11, 2012 at 04:33:43PM -0500, Noel Van Hook wrote: Background information: I am running the guest OS (CentOS) with dual heads. I am also running the client on CentOS. When I open the client, two client windows appear (spice0 and spice1), and all is well with the world. The

Re: [Spice-devel] Problem with dual-display full-screen client on X

2012-05-14 Thread Noel Van Hook
On Mon, May 14, 2012 at 8:54 AM, Christophe Fergeau cferg...@redhat.com wrote: Hey, On Fri, May 11, 2012 at 04:33:43PM -0500, Noel Van Hook wrote: Background information: I am running the guest OS (CentOS) with dual heads. I am also running the client on CentOS. When I open the client, two

Re: [Spice-devel] [usbredir PATCH 1/6] configure: Windows: ignore usbredirserver and usbredirtestclient subdirs

2012-05-14 Thread Uri Lublin
On 05/03/2012 06:48 PM, Christophe Fergeau wrote: What's wrong with the test client on Windows? The socket code? I spent some time trying to make usbredirtestclient to work on Windows, but not too much. Various things needs to be ported (some are as easy as adding an include, some not as