ACK series.
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/spice-devel
John
A. Sullivan III
wrote on Thu, 13 Sep 2012 08:38:11 -0400:
On Thu, 2012-09-13 at 08:06 -0400, Alon Levy wrote:
Hi Mohsen,
multiple sessions to the single VM are not on the roadmap. There is
experimental mult
> On Thu, Sep 13, 2012 at 05:53:39PM +0200, Christophe Fergeau wrote:
> > In spice.proto it's defined as enum8 cursor_type type;, which means
> > it's demarshalled as an uint8_t.
> > This caused valgrind warnings about using uninitialized memory
> > during a connection to a VM with remote-viewer
>
> SpiceCursor::header is only valid when SPICE_CURSOR_FLAGS_NONE is
> not set in SpiceCursor::flags, so don't try to log info about
> the header before we have tested this flag.
ACK both.
> ---
> gtk/channel-cursor.c | 8 +---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git
> We never actually connected the host_image pixmap to
> the primary screen, because we never operate on the bits
> of the primary screen.
>
> This causes problems if we wish to use traditional X
> operations to modify the primary screen, as they will
> fail and corrupt memory as they go.
Looks g
check with strict but do not enable it.
Signed-off-by: Aric Stewart
---
quic.js | 101 ++
1 files changed, 42 insertions(+), 59 deletions(-)
diff --git a/quic.js b/quic.js
index 15d2dbf..699820f 100644
--- a/quic.js
+++ b/quic.js
@@ -1
Signed-off-by: Aric Stewart
---
quic.js | 10 --
1 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/quic.js b/quic.js
index 138b052..15d2dbf 100644
--- a/quic.js
+++ b/quic.js
@@ -957,6 +957,7 @@ QuicEncoder.prototype.quic_rgb32_uncompress_row = function
(prev_row, cur_row)
removing the function call overhead improves performance
Signed-off-by: Aric Stewart
---
quic.js | 27 +++
1 files changed, 11 insertions(+), 16 deletions(-)
diff --git a/quic.js b/quic.js
index 0e33610..138b052 100644
--- a/quic.js
+++ b/quic.js
@@ -436,11 +436,6 @@ fu
eleminates a function call and many object references for performance
Signed-off-by: Aric Stewart
---
quic.js | 134 ++
1 files changed, 73 insertions(+), 61 deletions(-)
diff --git a/quic.js b/quic.js
index 0bae57e..0e33610 100644
---
Signed-off-by: Aric Stewart
---
quic.js | 180 +--
1 files changed, 71 insertions(+), 109 deletions(-)
diff --git a/quic.js b/quic.js
index 3007624..0bae57e 100644
--- a/quic.js
+++ b/quic.js
@@ -641,41 +641,32 @@ QuicEncoder.prototype.
Signed-off-by: Aric Stewart
---
quic.js | 18 +-
1 files changed, 5 insertions(+), 13 deletions(-)
diff --git a/quic.js b/quic.js
index 7c5be6b..3007624 100644
--- a/quic.js
+++ b/quic.js
@@ -330,11 +330,11 @@ QuicModel.prototype = {
function QuicBucket()
{
+this.counters =
The client of _get_samples() holds a ref to the SndChannel, and we
should access that SndChannel when _put_samples() is called, not the one
that happens to currently be attached to the Interface.
---
(Apologies, both of these are meant for spice.git.)
server/snd_worker.c | 16 +++-
When we release the SndChannel reference during
snd_disconnect_channel(), we need to set the pointer to NULL so it
doesn't get released again on client reconnect during
snd_set_playback_peer(). This can happen when a reference is held from
_playback_get_buffer().
---
server/snd_worker.c | 2 +-
1
Take a look at OSDVT.
On 13 Sep 2012, at 17:36, "John A. Sullivan III"
wrote:
> On Thu, 2012-09-13 at 20:16 +0430, Mohsen Saeedi wrote:
>>
>>
>>
>> John A. Sullivan III wrote on Thu, 13
>> Sep 2012 08:38:11 -0400:
>>> On Thu, 2012-09-13 at 08:06 -0400, Alon Levy wrote:
> Hi Mohsen,
>
On Thu, Sep 13, 2012 at 05:53:39PM +0200, Christophe Fergeau wrote:
> In spice.proto it's defined as enum8 cursor_type type;, which means
> it's demarshalled as an uint8_t.
> This caused valgrind warnings about using uninitialized memory
> during a connection to a VM with remote-viewer
Forget the
On Thu, 2012-09-13 at 20:16 +0430, Mohsen Saeedi wrote:
>
>
>
> John A. Sullivan III wrote on Thu, 13
> Sep 2012 08:38:11 -0400:
> > On Thu, 2012-09-13 at 08:06 -0400, Alon Levy wrote:
> > > > Hi Mohsen,
> > > >
> > > > multiple sessions to the single VM are not on the roadmap. There is
> > >
We never actually connected the host_image pixmap to
the primary screen, because we never operate on the bits
of the primary screen.
This causes problems if we wish to use traditional X
operations to modify the primary screen, as they will
fail and corrupt memory as they go.
---
src/qxl.h
> So we allocate another framebuffer here. Hmm, it is just another 1-16 MB of
> memory ;)
Yeah, good point.
>
> Do you have an example how to produce corruption?
I'm working on a proper patch for my render + send mode. When I go to
render into the screen frame buffer, my world comes crashing
SpiceCursor::header is only valid when SPICE_CURSOR_FLAGS_NONE is
not set in SpiceCursor::flags, so don't try to log info about
the header before we have tested this flag.
---
gtk/channel-cursor.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/gtk/channel-cursor.c b/gt
It automatically prepends the channel name to the log message
for easier debugging.
Fixes rhbz#822437
---
gtk/channel-base.c | 17 ---
gtk/channel-cursor.c | 4 +-
gtk/channel-display.c| 32 ++---
gtk/channel-inputs.c | 6 +--
gtk/channel-main.c | 14 +++
In spice.proto it's defined as enum8 cursor_type type;, which means
it's demarshalled as an uint8_t.
This caused valgrind warnings about using uninitialized memory
during a connection to a VM with remote-viewer
---
common/draw.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/c
>
> Resent as a patch because of line wrapping issues
> there remain a number of todos including implementing more than just
> rgb32 images
Somehow it still required manual merging. I think I got it right, but please
check; Yes, the pushed patch.. next time I'll push to some other tree to avoid
Dear guys:
I'm always wondering how SPICE works, takes advantage of physical video
card or just CPU calculation?
If i replace the old physical video card with a better one or plug in an
extra one, will my SPICE performance be better?
Please tell me something about this, THANKS.
___
resent, I am sure waiting moderation because of its size.
-aric
On 9/13/12 10:07 AM, Alon Levy wrote:
>> humm, I thought I fixed this issue. I am using thunderbird sending as
>> text with line wrapping turned off.
>>
>> I will keep tweaking and see if i can fully resolve this for my next
>> patc
Dear guys:
I'm always wondering how SPICE works, takes advantage of physical video
card or just CPU calculation?
If i replace the old physical video card with a better one or plug in an
extra one, will my SPICE performance be better?
Please tell me something about this, THANKS.
___
> humm, I thought I fixed this issue. I am using thunderbird sending as
> text with line wrapping turned off.
>
> I will keep tweaking and see if i can fully resolve this for my next
> patches.
>
> They should be shorter so easier for me to really make sure the
> e-mail is not corrupting them.
I
> Passing NULL for pbits into fbScreenInit is a treacherous
> thing to do. It works, because we rapidly resize
> the screen, and because the normal path never uses
> the screen pixmap.
>
> However, having NULL for pbits has side effects that derive
> from the fact that NULL prevents ModifyPixmapH
humm, I thought I fixed this issue. I am using thunderbird sending as text with
line wrapping turned off.
I will keep tweaking and see if i can fully resolve this for my next patches.
They should be shorter so easier for me to really make sure the e-mail is not
corrupting them.
-aric
On 9/13/
> Alon Levy píše v Čt 13. 09. 2012 v 10:31 -0400:
> > > On Wed, Sep 12, 2012 at 11:22:14AM -0500, Aric Stewart wrote:
> > > > there remain a few TODOs including implementing more than just
> > > > rgb32 images
> > > >
> > > > Signed-off-by: Aric Stewart
> > > [cut to avoid bombarding the list]
>
Passing NULL for pbits into fbScreenInit is a treacherous
thing to do. It works, because we rapidly resize
the screen, and because the normal path never uses
the screen pixmap.
However, having NULL for pbits has side effects that derive
from the fact that NULL prevents ModifyPixmapHeader
from doi
---
src/qxl_driver.c |4
1 file changed, 4 insertions(+)
diff --git a/src/qxl_driver.c b/src/qxl_driver.c
index 04a9aa8..dbb8ceb 100644
--- a/src/qxl_driver.c
+++ b/src/qxl_driver.c
@@ -1386,7 +1386,9 @@ static Bool
qxl_has_composite (qxl_screen_t *qxl)
{
return
+#ifndef XSPICE
Alon Levy píše v Čt 13. 09. 2012 v 10:31 -0400:
> > On Wed, Sep 12, 2012 at 11:22:14AM -0500, Aric Stewart wrote:
> > > there remain a few TODOs including implementing more than just
> > > rgb32 images
> > >
> > > Signed-off-by: Aric Stewart
> > [cut to avoid bombarding the list]
> >
> > I can't
> On Wed, Sep 12, 2012 at 11:22:14AM -0500, Aric Stewart wrote:
> > there remain a few TODOs including implementing more than just
> > rgb32 images
> >
> > Signed-off-by: Aric Stewart
> [cut to avoid bombarding the list]
>
> I can't actually review this, although it seems like a great deal of
>
ACK - and huzzah! Nice 5x performance boost...
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/spice-devel
> This is only part of the message corruption solution.
> The other part is fixing virtio-serial / spice-qemu-char throttling
> code.
>
> -replace write_[lock/unlock/completion] calls with
> [new/enqueue]_message
> -remove clipboard specific _out_msg_* class members
> -remove ugly loop - while (a-
John A. Sullivan III píše v Čt 13. 09. 2012 v 08:38 -0400:
> On Thu, 2012-09-13 at 08:06 -0400, Alon Levy wrote:
> > > Hi Mohsen,
> > >
> > > multiple sessions to the single VM are not on the roadmap. There is
> > > experimental multi-client support but it is to make more users see
> > > the
> > >
On Thu, 2012-09-13 at 08:06 -0400, Alon Levy wrote:
> > Hi Mohsen,
> >
> > multiple sessions to the single VM are not on the roadmap. There is
> > experimental multi-client support but it is to make more users see
> > the
> > same session.
>
> Moshen,
>
> I misunderstood. In this case, I guess
> Hi Mohsen,
>
> multiple sessions to the single VM are not on the roadmap. There is
> experimental multi-client support but it is to make more users see
> the
> same session.
Moshen,
I misunderstood. In this case, I guess I don't actually see how we could fix
your problem without circumventin
> Hi,
>
> On 09/12/2012 08:09 PM, Alon Levy wrote:
> > If the guest supports client monitors config we pass it the
> > VDAgentMonitorsConfig message via the
> > QXLInterface::client_monitors_config api instead of via the
> > vdagent.
> > ---
> > server/agent-msg-filter.c | 8 +++
> > serve
> Thanks.
> we want to develope spice for multiple concurrent spice console on
> single OS. for example, we want to use windows XP as single VM for
> multiple users. we want to develop it as spice feature. is it
> possible? any help or idea? shall we work on that experimental
> feature?
Great to h
Hi,
On 09/12/2012 08:09 PM, Alon Levy wrote:
If the guest supports client monitors config we pass it the
VDAgentMonitorsConfig message via the
QXLInterface::client_monitors_config api instead of via the vdagent.
---
server/agent-msg-filter.c | 8 +++
server/agent-msg-filter.h | 1 +
se
Hi Mohsen,
multiple sessions to the single VM are not on the roadmap. There is
experimental multi-client support but it is to make more users see the
same session.
And adding to what Gavin has already written: oVirt leverages KSM so
that when you have multiple similar VMs on the same host, common
> On 09/12/2012 07:32 PM, Mohsen Saeedi wrote:
> > Hi
> > I want to know, we are force to install one windows per user? does
> > spice
> > can provide a multi remote connection to a single windows XP
> > machine?
> > I want to install one windows XP as virtual desktop and then share
> > it
> > with
On 09/13/2012 10:24 AM, Karli Sjöberg wrote:
13 sep 2012 kl. 01.21 skrev Dead Horse:
Thank you! glad to be able to help ;)
As Itamar mentioned if you are running the spice client inside a VM
(dunno if this is case) you will need the guest paravirtual driver
and/or services for mouse handling.
Thanks for your feedback David. I'll track the thread and check the
bugzilla ticket status.
Regards,
Guillaume
On Wed, Sep 12, 2012 at 5:37 PM, David Jaša wrote:
> David Jaša píše v St 12. 09. 2012 v 17:17 +0200:
> > Guillaume Sabouraud píše v St 12. 09. 2012 v 11:46 +0200:
> > > Hi,
> > >
> >
On Wed, Sep 12, 2012 at 11:22:14AM -0500, Aric Stewart wrote:
> there remain a few TODOs including implementing more than just rgb32 images
>
> Signed-off-by: Aric Stewart
[cut to avoid bombarding the list]
I can't actually review this, although it seems like a great deal of
progress. Should I w
On 09/12/12 15:13, Alon Levy wrote:
> - no addition of guest capabilities, use interrupt mask instead, ignore
>0 or ~0 that are set by current windows driver.
> - use crc to solve possible write while read.
> - limit heads to 64, statically allocated on rom by host.
> - some misc trace fixe
On 09/13/2012 07:52 AM, Mohsen Saeedi wrote:
Thanks itamar
Can you tell me when is it available? Is it available on development
versions?
not sure, hence why i cc'd spice-devel for info
Best regards
On Sep 13, 2012 1:14 AM, "Itamar Heim" mailto:ih...@redhat.com>> wrote:
On 09/12/2012 07
48 matches
Mail list logo
