Re: [Spice-devel] [PATCH spice-gtk] win32: clip and move cursor within window region

2012-11-15 Thread Alon Levy
> Windows grab do not exist like on X11, so we need to clip the cursor > to our client window, while making sure it doesn't overlap with > windows statusbar. When wrapping the cursor, we need to make sure we > also stay within the clip region, or else the clip is inverted > (pointer can't enter the

[Spice-devel] Very poor performance on KVM with Ubuntu 12.10 guest

2012-11-15 Thread Jodi Curtis
Hi Having fought my way through getting used to KVM, I have installed a development desktop along side some servers, and the performance is unusable. The Ubuntu GUI seems very slow and not very responsive. It was not as bad as VGA but it is still unusable, all I need is to work in a development g

Re: [Spice-devel] [RFC] server/red_parse_qxl: introduce visitor for cursor

2012-11-15 Thread Alon Levy
> Hi > > > > > On Wed, Nov 14, 2012 at 9:36 PM, Alon Levy < al...@redhat.com > > wrote: > > > This is a second attempt at recording commands received from the qxl > device. The visitor allows more code to be shared between the device > to > spice struct verifier and copier and the logger. >

Re: [Spice-devel] [RFC] server/red_parse_qxl: introduce visitor for cursor

2012-11-15 Thread Marc-André Lureau
Hi On Wed, Nov 14, 2012 at 9:36 PM, Alon Levy wrote: > This is a second attempt at recording commands received from the qxl > device. The visitor allows more code to be shared between the device to > spice struct verifier and copier and the logger. > I missed the first version somehow. So a b

Re: [Spice-devel] [PATCH 3/5] vdagent: use virtio-serial, remove pipe usage

2012-11-15 Thread Arnon Gilboa
Christophe Fergeau wrote: This one is quite complicated to review, I didn't look at it very carefully... will be nice if you give it another 5 mins... On Wed, Nov 07, 2012 at 03:19:49PM +0200, Arnon Gilboa wrote: --- vdagent/vdagent.cpp| 467 +++-

Re: [Spice-devel] [PATCH 3/5] vdagent: use virtio-serial, remove pipe usage

2012-11-15 Thread Christophe Fergeau
This one is quite complicated to review, I didn't look at it very carefully... On Wed, Nov 07, 2012 at 03:19:49PM +0200, Arnon Gilboa wrote: > --- > vdagent/vdagent.cpp| 467 > +++- > vdagent/vdagent.vcproj | 32 +++- > 2 files changed, 256 inse

Re: [Spice-devel] [PATCH 1/5] vdservice: remove virtio-serial & pipe usage

2012-11-15 Thread Christophe Fergeau
Most of it is code removal, looks good, Christophe On Wed, Nov 07, 2012 at 03:19:47PM +0200, Arnon Gilboa wrote: > --- > vdservice/vdservice.cpp| 471 > > vdservice/vdservice.vcproj | 24 --- > 2 files changed, 36 insertions(+), 459 deletions(

Re: [Spice-devel] [PATCH 5/5] vdagent: extract event_dispatcher from input_desktop_message_loop

2012-11-15 Thread Arnon Gilboa
Christophe Fergeau wrote: On Wed, Nov 07, 2012 at 03:19:51PM +0200, Arnon Gilboa wrote: --- vdagent/vdagent.cpp | 105 +++ 1 files changed, 56 insertions(+), 49 deletions(-) diff --git a/vdagent/vdagent.cpp b/vdagent/vdagent.cpp index 9bb0898

Re: [Spice-devel] [PATCH 5/5] vdagent: extract event_dispatcher from input_desktop_message_loop

2012-11-15 Thread Christophe Fergeau
On Wed, Nov 07, 2012 at 03:19:51PM +0200, Arnon Gilboa wrote: > --- > vdagent/vdagent.cpp | 105 > +++ > 1 files changed, 56 insertions(+), 49 deletions(-) > > diff --git a/vdagent/vdagent.cpp b/vdagent/vdagent.cpp > index 9bb0898..7495826 100644

Re: [Spice-devel] [vdagent-win] Fix mingw compilation

2012-11-15 Thread Arnon Gilboa
ack Christophe Fergeau wrote: This got broken with the recent code moves from vdservice to vdagent. --- Makefile.am | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/Makefile.am b/Makefile.am index b050aff..9b73def 100644 --- a/Makefile.am +++ b/Makefile.am @@ -

Re: [Spice-devel] [PATCH 4/5] vdagent: remove pipe common defs

2012-11-15 Thread Christophe Fergeau
Looks good after the preliminary work, ACK Christophe On Wed, Nov 07, 2012 at 03:19:50PM +0200, Arnon Gilboa wrote: > --- > common/vdcommon.h | 31 --- > 1 files changed, 0 insertions(+), 31 deletions(-) > > diff --git a/common/vdcommon.h b/common/vdcommon.h > inde

Re: [Spice-devel] [PATCH 2/5] vdagent: mv vdi_port files from vdservice

2012-11-15 Thread Christophe Fergeau
On Wed, Nov 07, 2012 at 03:19:48PM +0200, Arnon Gilboa wrote: > --- > vdagent/pci_vdi_port.cpp | 132 + > vdagent/pci_vdi_port.h| 59 + > vdagent/vdi_port.cpp | 90 > vdagent/vdi_port.h| 75 ++

[Spice-devel] [vdagent-win] Fix mingw compilation

2012-11-15 Thread Christophe Fergeau
This got broken with the recent code moves from vdservice to vdagent. --- Makefile.am | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/Makefile.am b/Makefile.am index b050aff..9b73def 100644 --- a/Makefile.am +++ b/Makefile.am @@ -20,7 +20,7 @@ LIBS = -lversion

Re: [Spice-devel] [PATCH spice-gtk] win32: clip and move cursor within window region

2012-11-15 Thread Christophe Fergeau
Looks good, On Wed, Nov 14, 2012 at 03:21:36PM +0100, Marc-André Lureau wrote: > Windows grab do not exist like on X11, so we need to clip the cursor > to our client window, while making sure it doesn't overlap with > windows statusbar. When wrapping the cursor, we need to make sure we > also stay

Re: [Spice-devel] spice-guest-tools-0.1.exe couldn't work correctly with spice 0.12

2012-11-15 Thread Jacky.He
Hi, I have got the same problem in windows xp guest, my version are: qemu-kvm 1.1 & 1.2 spice 0.12 spice protocol 0.12.2 spice-gtk 0.14 does this problem to be fixed? Thanks a log Best Regards Jacky -Original Message- From: spice-devel-bounces+jacky.he=gmail@lists.freedesktop.org [ma

Re: [Spice-devel] [Engine-devel] SPICE IP override

2012-11-15 Thread David Jaša
Simon Grinberg píše v Čt 15. 11. 2012 v 03:52 -0500: > > - Original Message - > > From: "Yaniv Kaul" > > To: "Simon Grinberg" > > Cc: engine-de...@ovirt.org, "Itamar Heim" > > Sent: Thursday, November 15, 2012 10:42:19 AM > > Subject: Re: [Engine-devel] SPICE IP override > > > > On 11/