Re: [Spice-devel] [PATCH v2 qxl-win] miniport: halve QXL_IO_UPDATE_IRQ calls

2013-07-30 Thread Yonit Halperin
Ack. looks good. On 07/30/2013 06:22 AM, Alon Levy wrote: QXL_IO_UPDATE_IRQ causes the device to check int_mask and int_pending and issue an interrupt if that is required. Since we just zeroed int_mask, no interrupt will ever be issued. Since we issue another QXL_IO_UPDATE_IRQ in the interrupt ro

Re: [Spice-devel] [PATCH 2/3] miniport: use a limited interrupt mask

2013-07-30 Thread Yonit Halperin
Ack On 07/29/2013 09:14 AM, Alon Levy wrote: --- miniport/qxl.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/miniport/qxl.c b/miniport/qxl.c index 33efac7..f5d6b48 100644 --- a/miniport/qxl.c +++ b/miniport/qxl.c @@ -26,6 +26,10 @@ #endif #include "minima

Re: [Spice-devel] [PATCH 1/3] display/driver: DrvDeleteDeviceBitmap: log if pdev disabled

2013-07-30 Thread Yonit Halperin
Ack On 07/29/2013 09:14 AM, Alon Levy wrote: Alternative is to leak, and this happens regularely. Perhaps we should be keeping track and destroying these surfaces later (in case no reset happens in the middle, which destroys all off screen surfaces anyway). --- display/driver.c | 5 + 1 fi

[Spice-devel] [PATCH v2 qxl-win] miniport: halve QXL_IO_UPDATE_IRQ calls

2013-07-30 Thread Alon Levy
QXL_IO_UPDATE_IRQ causes the device to check int_mask and int_pending and issue an interrupt if that is required. Since we just zeroed int_mask, no interrupt will ever be issued. Since we issue another QXL_IO_UPDATE_IRQ in the interrupt routine DPC right after resetting int_mask any pending interru

Re: [Spice-devel] "configure: error: At least one of spice or vnc must be used" on Ubuntu Desktop 12.04 x64

2013-07-30 Thread David Jaša
Hi, Yannis Milios píše v Po 29. 07. 2013 v 17:52 +0300: > Hello and thank you for this great software! > > I have Ubuntu 12.04 (x32 & x64bit) and I'm trying to make spice-client to > work by using a gui tool like virt-viewer. > > What I have already done: > > 1. sudo apt-get install spice-clien

[Spice-devel] "configure: error: At least one of spice or vnc must be used" on Ubuntu Desktop 12.04 x64

2013-07-30 Thread Yannis Milios
Hello and thank you for this great software! I have Ubuntu 12.04 (x32 & x64bit) and I'm trying to make spice-client to work by using a gui tool like virt-viewer. What I have already done: 1. sudo apt-get install spice-client 2. sudo apt-get install spice-client-gtk 3. made a temp folder and then