ACK
The rest of the patches that haven't been acked in this series, are the
same as in the previous series, right? If so, ack series.
Cheers,
Yonit.
On 09/12/2013 08:09 AM, Marc-André Lureau wrote:
From: Marc-André Lureau
The current coroutine channel_iterate() creates a GSource for the soc
- Original Message -
> On Thu, Sep 12, 2013 at 06:10:38PM +0200, Marc-André Lureau wrote:
> > yeah spice-common update was in the next one.. it's a bit of shame
> > that when doing a rebase, the remote are not updated automatically, so
> > it's easy to git commit -a --amend when doing an
(1) receive timeout as a parameter.
(2) add a return value and pass the handling
of failures to the calling routine.
---
server/red_channel.c | 73 ++--
server/red_channel.h | 22 ++--
server/red_worker.c | 53 +++
rhbz#1004443
The methods that trigger waitings on the client pipe require that
the waiting will succeed in order to continue, or otherwise, that
all the living pipe items will be released (e.g., when
we must destroy a surface, we need that all its related pipe items will
be released). Shutdown of
(1) merge 'force' and 'wait_for_outgoing_item' to one parameter.
'wait_for_outgoing_item' is a derivative of 'force'.
(2) move the call to red_wait_outgoing_item to
red_clear_surface_drawables_from_pipe
---
server/red_worker.c | 20 +++-
1 file changed, 11 insertions(+), 9 del
Hi Christophe,
It is currently very hard, bordering on impossible to build gvfs for
Android, because it ends up depending on GTK. The sequence of
dependencies is:
glib network I/O -> gvfs -> libsoup-gnome -> gnome-keyring -> gcr-3 ->
gcr-ui-3 -> GTK
The glib guys are arguing that this is not a b
Hey Iordan,
On Thu, Sep 12, 2013 at 01:11:45PM -0400, i iordanov wrote:
> Hi Christophe,
>
> It is currently very hard, bordering on impossible to build gvfs for
> Android, because it ends up depending on GTK. The sequence of
> dependencies is:
>
> glib network I/O -> gvfs -> libsoup-gnome -> gn
On Thu, Sep 12, 2013 at 06:10:38PM +0200, Marc-André Lureau wrote:
> yeah spice-common update was in the next one.. it's a bit of shame
> that when doing a rebase, the remote are not updated automatically, so
> it's easy to git commit -a --amend when doing an interactive rebase
> and slip in submod
On Thu, Sep 12, 2013 at 06:11:53PM +0200, Marc-André Lureau wrote:
> On Thu, Sep 12, 2013 at 6:01 PM, Christophe Fergeau
> wrote:
> > Is there a reason for doing a strstr rather than iterating over the string
> > split on ':' ?
>
> simplicity, iirc, even glib does that.
I would use different wo
ACK, thanks fro the split. Is the spice-common change needed in this patch?
I would have expected it to be part of the next one?
Christophe
On Thu, Sep 12, 2013 at 02:09:11PM +0200, Marc-André Lureau wrote:
> This allows to simplify a little bit derived class (no need to override
> handle_msg), a
ACK
On Thu, Sep 12, 2013 at 02:09:10PM +0200, Marc-André Lureau wrote:
> This function will allow to set base handlers and specific channel
> handlers in a common way, instead of each channel having to override the
> base channel virtual handle_msg().
> ---
> gtk/channel-base.c | 39 +++
On Thu, Sep 12, 2013 at 02:09:12PM +0200, Marc-André Lureau wrote:
> Allow to disable selectively channels, mainly used for testing,
> ex: SPICE_DISABLE_CHANNELS=display spicy-stats -p 12345
> ---
> gtk/spice-channel-priv.h | 2 ++
> gtk/spice-channel.c | 7 +++
> 2 files changed, 9 inser
ACK
On Thu, Sep 12, 2013 at 02:09:09PM +0200, Marc-André Lureau wrote:
> Checking by value make the flag fields useless. Unfortunately, when
> adding more flags, the server will have to ensure it can safely send it,
> by checking some of new client caps (for some features).
> ---
> gtk/channel-di
On Thu, Sep 12, 2013 at 06:12:20PM +0200, Marc-André Lureau wrote:
> In glib:
>
> domains = g_getenv ("G_MESSAGES_DEBUG");
> if (((log_level & INFO_LEVELS) == 0) ||
> domains == NULL ||
> (strcmp (domains, "all") != 0 && (!log_domain || !strstr
> (domains, log_domain
> retu
On Thu, Sep 12, 2013 at 6:01 PM, Christophe Fergeau wrote:
> On Thu, Sep 12, 2013 at 02:09:12PM +0200, Marc-André Lureau wrote:
>> Allow to disable selectively channels, mainly used for testing,
>> ex: SPICE_DISABLE_CHANNELS=display spicy-stats -p 12345
>> ---
>> gtk/spice-channel-priv.h | 2 ++
>
In glib:
domains = g_getenv ("G_MESSAGES_DEBUG");
if (((log_level & INFO_LEVELS) == 0) ||
domains == NULL ||
(strcmp (domains, "all") != 0 && (!log_domain || !strstr
(domains, log_domain
return;
On Thu, Sep 12, 2013 at 6:11 PM, Marc-André Lureau
wrote:
> On Thu, Sep 12,
yeah spice-common update was in the next one.. it's a bit of shame
that when doing a rebase, the remote are not updated automatically, so
it's easy to git commit -a --amend when doing an interactive rebase
and slip in submodules update from the following commits (I think it
even resolve silently th
Hi Alexandre,
Alexandre DERUMIER píše v Pá 30. 08. 2013 v 15:36 +0200:
> Hi,
>
> I'm looking for documentation about multi monitor setup, and I can't find it.
>
> How do it work ?
For Windows VMs, up to four qxl devices can be specified on the command
line. Linux VMs will see 4 heads on the sin
As pointed out by Yonit on the ML:
> (1) the palette cache shouldn't be shared among the display channels. I.e.,
> there should be one instance per channel, and not one instance in
> spice-session.
---
gtk/channel-display.c| 4 +++-
gtk/spice-session-priv.h | 1 -
gtk/spice-session.c | 6
---
gtk/channel-base.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/gtk/channel-base.c b/gtk/channel-base.c
index abcf9d9..646042d 100644
--- a/gtk/channel-base.c
+++ b/gtk/channel-base.c
@@ -169,12 +169,12 @@ void spice_channel_handle_migrate(SpiceChannel *channel,
From: Marc-André Lureau
---
gtk/channel-display.c | 4 ++--
gtk/spice-channel.c | 8
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/gtk/channel-display.c b/gtk/channel-display.c
index 45d31c5..0af3859 100644
--- a/gtk/channel-display.c
+++ b/gtk/channel-display.c
@@ -6
From: Marc-André Lureau
Use of coroutines allow to simplify spice_channel_recv_msg(), it doesn't
need to keep current reading state, it can rely on the coroutine stack
for that.
---
gtk/channel-base.c | 1 +
gtk/spice-channel-priv.h | 3 +--
gtk/spice-channel.c | 50 +++-
From: Marc-André Lureau
The current coroutine channel_iterate() creates a GSource for the socket
reenters the mainloop waiting for IO condition. This is really heavy
usage of mainloop showing up in system time and user space
profiling (10% of CPU time spent in mainloop overhead). Instead flush
al
From: Marc-André Lureau
The cache code isn't very quick, it shows up in profilers. Using
GHashTable allows to simplify the code while making it faster.
---
gtk/channel-cursor.c | 56 +++
gtk/channel-display.c | 93 +++---
gtk/spice-
Avoid hard-coding surface 0 as being primary, although in practice it
always is so far. Also a lot of lookups are primary, so add a shortcut
for this special case (~30% apparently), it shows some small lookup
speedup.
before:
real 0m5.008s
user 0m3.253s
sys 0m2.015s
after:
real0m
From: Marc-André Lureau
That doesn't seem to really improve performance so much,
but that' s what we should do probably.
---
gtk/spice-util.c | 13 ++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff --git a/gtk/spice-util.c b/gtk/spice-util.c
index e02fc4d..4372f28 100644
--- a
With a Spice replay (a tool not yet merged, but available in dev
branches), the following commit improves a little bit performance by not
spending so much CPU time in looking up surfaces. I found initially
hotspot with "perf", and get a consistant ~200ms speedup with "time
spicy-stats" after replac
Improve a bit the code by using hashtable ownership.
---
gtk/channel-display.c | 16 +---
1 file changed, 9 insertions(+), 7 deletions(-)
diff --git a/gtk/channel-display.c b/gtk/channel-display.c
index a0bdec1..8734721 100644
--- a/gtk/channel-display.c
+++ b/gtk/channel-display.c
@@
Allow to disable selectively channels, mainly used for testing,
ex: SPICE_DISABLE_CHANNELS=display spicy-stats -p 12345
---
gtk/spice-channel-priv.h | 2 ++
gtk/spice-channel.c | 7 +++
2 files changed, 9 insertions(+)
diff --git a/gtk/spice-channel-priv.h b/gtk/spice-channel-priv.h
inde
This function will allow to set base handlers and specific channel
handlers in a common way, instead of each channel having to override the
base channel virtual handle_msg().
---
gtk/channel-base.c | 39 +++
gtk/spice-channel-priv.h | 2 ++
gtk/spice-chan
This allows to simplify a little bit derived class (no need to override
handle_msg), and allows the base class more flexibility (for example for
filtering messages, as in the following patch)
---
gtk/channel-cursor.c | 43 -
gtk/channel-display.c| 97 +++
Checking by value make the flag fields useless. Unfortunately, when
adding more flags, the server will have to ensure it can safely send it,
by checking some of new client caps (for some features).
---
gtk/channel-display.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/gtk/
On Thu, Sep 12, 2013 at 01:32:07PM +0200, Marc-André Lureau wrote:
> On Wed, Sep 11, 2013 at 11:09 AM, Christophe Fergeau
> wrote:
> > On Tue, Sep 10, 2013 at 04:43:39PM +0200, Marc-André Lureau wrote:
> >> From: Marc-André Lureau
> >>
> >> Thos function shows up in some profiling results, it see
On Thu, Sep 12, 2013 at 1:32 PM, Marc-André Lureau
wrote:
> On Wed, Sep 11, 2013 at 11:09 AM, Christophe Fergeau
> wrote:
> (fyi, 5% is about the same amount of cpu used for glz or quic decoding
> in this recording)
scrap that, they take much more if you cumulate all their functions.
--
Ma
On Wed, Sep 11, 2013 at 11:09 AM, Christophe Fergeau
wrote:
> On Tue, Sep 10, 2013 at 04:43:39PM +0200, Marc-André Lureau wrote:
>> From: Marc-André Lureau
>>
>> Thos function shows up in some profiling results, it seems we can
>> trivially replace it with a precomputed array of 256bytes.
>
> I f
hi:
Thanks about your hard work.
I use aSPICE in my Android device and she works well.And I also built SPICE
client for Android (https://github.com/iiordanov/bVNC).
But they do not support usbredir, if I want them to support, how can I do? Are
you planning a version with usbredir?
Tha
36 matches
Mail list logo
