[Spice-devel] [PATCH spice-gtk 1/2] display: fix palette regression

2013-10-03 Thread Marc-André Lureau
palette_get() used to return a ref, and palette_release() used to release that ref. Since ed877341, the palette is no longer refcount'ed, since its usage is exclusively local in common/canvas code. palette_release() shouldn't remove the palette from the cache.

Re: [Spice-devel] [spice-gtk] Use latest warnings.m4 from gnulib

2013-10-03 Thread Christophe Fergeau
Ping ? Christophe On Fri, Sep 27, 2013 at 09:17:55AM +0200, Christophe Fergeau wrote: The one we were using does not work properly with clang, causing the build process to try to use -f/-W options that are not supported by clang. --- The same patch has already been ACKed and pushed in

Re: [Spice-devel] [spice-gtk PATCHv4 0/2] Use system CA store

2013-10-03 Thread Christophe Fergeau
Ping? Christophe On Tue, Sep 24, 2013 at 10:03:47AM +0200, Christophe Fergeau wrote: Hey, here is a v4 of my series. Changes since v3: - added a line at the end of configure indicating which CA store will be used (if any), this was requested during review but I forgot to add it in v3 -

Re: [Spice-devel] [PATCH spice-gtk 1/2] display: fix palette regression

2013-10-03 Thread Christophe Fergeau
On Thu, Oct 03, 2013 at 01:53:55PM +0200, Marc-André Lureau wrote: palette_get() used to return a ref, and palette_release() used to release that ref. Since ed877341, the palette is no longer refcount'ed, since its usage is exclusively local in common/canvas code. palette_release()

Re: [Spice-devel] [PATCH spice-gtk 1/2] display: fix palette regression

2013-10-03 Thread Marc-André Lureau
- Original Message - On Thu, Oct 03, 2013 at 01:53:55PM +0200, Marc-André Lureau wrote: palette_get() used to return a ref, and palette_release() used to release that ref. Since ed877341, the palette is no longer refcount'ed, since its usage is exclusively local in

Re: [Spice-devel] [Users] unable to start vm in 3.3 and f19 with gluster

2013-10-03 Thread Itamar Heim
On 10/03/2013 01:21 AM, Gianluca Cecchi wrote: On Wed, Oct 2, 2013 at 9:16 PM, Itamar Heim wrote: On 10/02/2013 12:57 AM, Gianluca Cecchi wrote: Today I was able to work again on this matter and it seems related to spice Every time I start the VM (that is defined with spice) it goes in and

Re: [Spice-devel] [spice-gtk] Use latest warnings.m4 from gnulib

2013-10-03 Thread Daniel P. Berrange
On Fri, Sep 27, 2013 at 09:17:55AM +0200, Christophe Fergeau wrote: The one we were using does not work properly with clang, causing the build process to try to use -f/-W options that are not supported by clang. --- The same patch has already been ACKed and pushed in

Re: [Spice-devel] [PATCH spice-gtk 2/2] display: cache id is uint64_t

2013-10-03 Thread Christophe Fergeau
On Thu, Oct 03, 2013 at 01:53:56PM +0200, Marc-André Lureau wrote: --- gtk/channel-display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gtk/channel-display.c b/gtk/channel-display.c index e0f17eb..a57453f 100644 --- a/gtk/channel-display.c +++

Re: [Spice-devel] [PATCH spice-gtk 1/2] display: fix palette regression

2013-10-03 Thread Christophe Fergeau
On Thu, Oct 03, 2013 at 08:51:15AM -0400, Marc-André Lureau wrote: - Original Message - On Thu, Oct 03, 2013 at 01:53:55PM +0200, Marc-André Lureau wrote: palette_get() used to return a ref, and palette_release() used to release that ref. Since ed877341, the palette is

Re: [Spice-devel] [PATCH spice-gtk 1/2] display: fix palette regression

2013-10-03 Thread Marc-André Lureau
- Original Message - On Thu, Oct 03, 2013 at 08:51:15AM -0400, Marc-André Lureau wrote: - Original Message - On Thu, Oct 03, 2013 at 01:53:55PM +0200, Marc-André Lureau wrote: palette_get() used to return a ref, and palette_release() used to release that ref.

Re: [Spice-devel] [PATCH spice-gtk 1/2] display: fix palette regression

2013-10-03 Thread Christophe Fergeau
On Thu, Oct 03, 2013 at 09:43:31AM -0400, Marc-André Lureau wrote: - Original Message - On Thu, Oct 03, 2013 at 08:51:15AM -0400, Marc-André Lureau wrote: - Original Message - On Thu, Oct 03, 2013 at 01:53:55PM +0200, Marc-André Lureau wrote:

Re: [Spice-devel] Where is the source code of aSpice? And is there a spice version in iOS?

2013-10-03 Thread i iordanov
Hi Shen, The source code is part of the bVNC project. https://github.com/iiordanov/bVNC Please keep in mind that the user interface is GPL licensed, and if you distribute binaries to third parties, you must also make public the exact source code that was used to produce the binaries. Cheers

[Spice-devel] govirt 0.30 plans

2013-10-03 Thread i iordanov
Hi Christophe, When do you plan to release govirt 0.30 with the SSL fixes and the new API for getting available VMs, powering on the VM at login time, etc.? Do you plan to include something like the function that I submitted to spice-devel earlier for reading the cert from a local file? You had

[Spice-devel] [PATCH 2/3] server: set dispatcher before calling attache_worker

2013-10-03 Thread Marc-André Lureau
This allows to call spice_qxl_add_memslot during attache_worker(), like done in the tests. --- server/red_dispatcher.c | 12 +++- server/red_dispatcher.h | 3 ++- server/reds.c | 2 +- 3 files changed, 10 insertions(+), 7 deletions(-) diff --git a/server/red_dispatcher.c

[Spice-devel] [PATCH 1/3] server: mark deprecated symbols

2013-10-03 Thread Marc-André Lureau
--- server/Makefile.am | 1 + server/spice.h | 51 +-- 2 files changed, 30 insertions(+), 22 deletions(-) diff --git a/server/Makefile.am b/server/Makefile.am index 815f65e..8cbd87b 100644 --- a/server/Makefile.am +++ b/server/Makefile.am @@

[Spice-devel] [PATCH 3/3] server/tests: avoid using deprecated symbols

2013-10-03 Thread Marc-André Lureau
--- server/tests/test_display_base.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/server/tests/test_display_base.c b/server/tests/test_display_base.c index 20c0e47..ccdd2f2 100644 --- a/server/tests/test_display_base.c +++ b/server/tests/test_display_base.c @@