> > And AFAIK SASL does not even compile with mingw, so it is quite useless.
>
> Marc-Andre did some work to make it build
>
> http://fedorapeople.org/cgit/elmarco/public_git/mingw32-cyrus-sasl.git/
>
> though I do not know what the current status of it is, whether his fixes were
> ever
> app
Signed-off-by: Jeremy White
---
src/qxl_driver.c |4 ++--
src/spiceqxl_display.c |2 +-
src/spiceqxl_io_port.c | 22 +++---
3 files changed, 14 insertions(+), 14 deletions(-)
diff --git a/src/qxl_driver.c b/src/qxl_driver.c
index f076f00..91ba6c2 100644
--- a/src/
> > And AFAIK SASL does not even compile with mingw, so it is quite useless.
>
> Marc-Andre did some work to make it build
>
> http://fedorapeople.org/cgit/elmarco/public_git/mingw32-cyrus-sasl.git/
>
> though I do not know what the current status of it is, whether his fixes were
> ever
> app
Signed-off-by: Jeremy White
---
src/qxl_image.c |3 ---
1 file changed, 3 deletions(-)
diff --git a/src/qxl_image.c b/src/qxl_image.c
index 40798b3..2349fca 100644
--- a/src/qxl_image.c
+++ b/src/qxl_image.c
@@ -125,9 +125,6 @@ remove_image_info (image_info_t *info)
free (info);
}
-#
On Thu, Oct 10, 2013 at 11:04 AM, Hans de Goede wrote:
> Hi All,
>
> So trying to summarize what has been discussed before:
>
> The basic idea for virgil + spice integration is to use qemu's console
> layer as an abstraction between the new virtio-vga device Dave has in
> mind: http://airlied.liv
> Which is just re-inventing the wheel. IMHO re-inventing wheels is bad,
> particularly when security is involved.
Maybe. But using complex code instead of easy code is also bad.
Using the whole SASL layer to callback the PVE auth layer adds a
lot of useless code, without any gain!
> Marc-Andre did some work to make it build
>
> http://fedorapeople.org/cgit/elmarco/public_git/mingw32-cyrus-sasl.git/
>
> though I do not know what the current status of it is, whether his fixes were
> ever
> applied by upstream or not.
Please do not force me to use such complex framework.
On Thu, Oct 17, 2013 at 03:30:09PM +, Dietmar Maurer wrote:
> > SASL has a "plain" plugin for straing (username,password) auth, so this
> > offers no
> > new functionality.
>
> But it offers that functionality without the requirement of SASL.
Which is just re-inventing the wheel. IMHO re-in
> SASL has a "plain" plugin for straing (username,password) auth, so this
> offers no
> new functionality.
But it offers that functionality without the requirement of SASL.
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.free
On Thu, Oct 17, 2013 at 03:06:17PM +, Dietmar Maurer wrote:
> > Can you describe what you are trying to achieve exactly through this
> > auth_plain_verify_credentials callback?
> > I assume you want to check the
> > (username, password) against 'something' once you got them from the client?
>
On Thu, Oct 17, 2013 at 02:53:57PM +0200, Christophe Fergeau wrote:
> Hey,
>
> On Thu, Oct 17, 2013 at 01:53:01PM +0200, diet...@proxmox.com wrote:
> > This adds a very simple authentication method using username/pasword.
> >
> > The password is not encryped, so this method is only safe if you us
> > The password is not encryped, so this method is only safe if you use TLS.
>
> Can you describe what you are trying to achieve exactly through this
> auth_plain_verify_credentials callback? I assume you want to check the
> (username, password) against 'something' once you got them from the clie
Ack series.
On 10/17/2013 03:27 AM, Alon Levy wrote:
> Signed-off-by: Alon Levy
> ---
> src/qxl.h | 2 +-
> src/qxl_kms.c | 2 +-
> src/qxl_surface.c | 5 +++--
> src/qxl_surface_ums.c | 2 +-
> 4 files changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/src/qxl.h
> Can you describe what you are trying to achieve exactly through this
> auth_plain_verify_credentials callback?
> I assume you want to check the
> (username, password) against 'something' once you got them from the client?
yes
> Can the SASL support already do what you are looking for?
SASL is
Hey,
On Thu, Oct 17, 2013 at 01:53:01PM +0200, diet...@proxmox.com wrote:
> This adds a very simple authentication method using username/pasword.
>
> The password is not encryped, so this method is only safe if you use TLS.
Can you describe what you are trying to achieve exactly through this
aut
This adds a very simple authentication method using username/pasword.
The password is not encryped, so this method is only safe if you use TLS.
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/
Index: new/server/reds.c
===
--- new.orig/server/reds.c 2013-10-17 10:32:37.0 +0200
+++ new/server/reds.c 2013-10-17 13:33:53.0 +0200
@@ -146,6 +146,9 @@
SpiceLinkMess *link_mess;
int mess_pos;
Tic
Index: new/spice-common/spice-protocol/spice/protocol.h
===
--- new.orig/spice-common/spice-protocol/spice/protocol.h 2013-10-17
09:05:41.0 +0200
+++ new/spice-common/spice-protocol/spice/protocol.h2013-10-17
09:49:
On 10/14/2013 05:52 PM, Fabio Fantoni wrote:
I have added vdagent support on libxl for hvm domUs using upstream qemu.
On windows domUs it is working without problems found in over one year
that I'm using it.
On linux domUs is not working, it seems to be a problem on the kernel
side and/or lin
> > Why is that wrong?
> You are right. And yet thunderbird won't show me the contents on reply, and I
> saw there was an attachment, so I assumed. My bad. Still I don't know why
> thunderbird fails to quote the message on reply and instead gives me an empty
> message.
I also noticed that the mail
On Wed, Oct 16, 2013 at 01:13:10PM -0400, Marc-André Lureau wrote:
>
>
> - Original Message -
> > While looking at the SASL code, I noticed some memory leaks in error paths.
> > This commit adds a cleanup: block to free some of the memory dynamically
> > allocated in that function, and re
On 10/17/2013 11:27 AM, Dietmar Maurer wrote:
On 10/16/2013 02:04 PM, diet...@proxmox.com wrote:
For next time: can you send the patches inline? it is easier to respond to then
to
mails with attachments.
I guess I have already done that. I use 'quilt mail' to send the patches, and
the
raw emai
I've tested this. Previously strncat was used incorrectly, it is
replaced with snprintf per Uri's suggestion.
Signed-off-by: Alon Levy
---
src/spiceqxl_audio.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/spiceqxl_audio.c b/src/spiceqxl_audio.c
index 3cd80ff..5b8
Signed-off-by: Alon Levy
---
examples/spiceqxl.xorg.conf.example | 3 ++-
scripts/Xspice | 8 +++-
2 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/examples/spiceqxl.xorg.conf.example
b/examples/spiceqxl.xorg.conf.example
index d1129e7..be8a16b 100644
--- a
Signed-off-by: Alon Levy
---
src/uxa/uxa-glyphs.c | 2 +-
src/uxa/uxa-render.c | 6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/uxa/uxa-glyphs.c b/src/uxa/uxa-glyphs.c
index 6dd8e58..fe3d6e8 100644
--- a/src/uxa/uxa-glyphs.c
+++ b/src/uxa/uxa-glyphs.c
@@ -715,7 +715,
Signed-off-by: Alon Levy
---
src/spiceqxl_display.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/spiceqxl_display.c b/src/spiceqxl_display.c
index 9c42d84..3acbb1c 100644
--- a/src/spiceqxl_display.c
+++ b/src/spiceqxl_display.c
@@ -287,7 +287,8 @@ static int interfac
Signed-off-by: Alon Levy
---
src/qxl.h | 2 +-
src/qxl_kms.c | 2 +-
src/qxl_surface.c | 5 +++--
src/qxl_surface_ums.c | 2 +-
4 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/src/qxl.h b/src/qxl.h
index 52e92e9..c699c58 100644
--- a/src/qxl.h
+++ b/src/qxl.
> On 10/16/2013 02:04 PM, diet...@proxmox.com wrote:
> For next time: can you send the patches inline? it is easier to respond to
> then to
> mails with attachments.
I guess I have already done that. I use 'quilt mail' to send the patches, and
the
raw email contains:
Content-Disposition: inlin
On 10/16/2013 10:08 PM, Marc-André Lureau wrote:
In theory, zero-ing the surface shouldn't be necessary, as only
invalidated/painted region should be shown. However, this results in
less artifacts on resolution changes (probably some regions are painted,
but with masks, blend, copy etc), in parti
On 10/16/2013 02:04 PM, diet...@proxmox.com wrote:
For next time: can you send the patches inline? it is easier to respond
to then to mails with attachments.
You should increment SPICE_INTERFACE_KEYBOARD_MINOR as well to allow
users (qemu / spiceterm / xspice etc.) to compile to both old and n
30 matches
Mail list logo
