Re: [Spice-devel] [PATCH spice-common] Fix generating Makefile.in with automake >=1.14

2014-03-05 Thread Marc-André Lureau
ack - Original Message - > When using automake >=1.14 on spice, the following error occurs: > > automake-1.14: warnings are treated as errors > common/Makefile.am:4: warning: source file > '$(srcdir)/generated_client_demarshallers.c' is in a subdirectory, > common/Makefile.am:4: b

Re: [Spice-devel] [PATCH] Check RSA_generate_key_ex return value

2014-03-05 Thread Christophe Fergeau
On Tue, Mar 04, 2014 at 12:16:50PM -0500, Marc-André Lureau wrote: > ack > > - Original Message - > > This can fail in fips mode for example. If we ignore the failure, we'll get > > a crash: > > > > #0 0x7f38d63728a0 in BN_num_bits () from /lib64/libcrypto.so.10 > > #1 0x7f38d

[Spice-devel] [PATCH spice-common] Fix generating Makefile.in with automake >=1.14

2014-03-05 Thread Tiziano Müller
When using automake >=1.14 on spice, the following error occurs: automake-1.14: warnings are treated as errors common/Makefile.am:4: warning: source file '$(srcdir)/generated_client_demarshallers.c' is in a subdirectory, common/Makefile.am:4: but option 'subdir-objects' is disabled Fix th