Re: [Spice-devel] [PATCH] qxl_driver.c: fix compiler warning 'defined but not used' qxl_kernel_mode_enabled

2014-06-25 Thread Alon Levy
On Mon, Jun 09, 2014 at 04:08:37PM +0300, Alon Levy wrote: Signed-off-by: Alon Levy al...@redhat.com --- src/qxl_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qxl_driver.c b/src/qxl_driver.c index b9aa0e9..d9bf447 100644 --- a/src/qxl_driver.c

Re: [Spice-devel] [PATCH] qxl_driver.c: fix compiler warning 'defined but not used' qxl_kernel_mode_enabled

2014-06-25 Thread Christophe Fergeau
On Wed, Jun 25, 2014 at 06:14:18AM -0400, Alon Levy wrote: On Mon, Jun 09, 2014 at 04:08:37PM +0300, Alon Levy wrote: Signed-off-by: Alon Levy al...@redhat.com --- src/qxl_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qxl_driver.c

[Spice-devel] [PATCH] qxl_image.c: fix compilation break

2014-06-25 Thread Alon Levy
Since 3d511c30206bd8c9a207c436186a03af0bb02962 Xspice building is broken due to undefined MAX_RELOCS when not building with XF86DRM_MODE. --- src/qxl_image.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/qxl_image.c b/src/qxl_image.c index eb66b63..8927fd4 100644 --- a/src/qxl_image.c

[Spice-devel] [PATCH spice] server: don't assert on invalid client message

2014-06-25 Thread Marc-André Lureau
Some users have been reaching this error: snd_receive: ASSERT n failed A misbehaving client could easily hit that condition by sending too big messages. Instead of assert(), replace with a warning. When a message too big to fit is received, it will simply disconnect the channel.

Re: [Spice-devel] [PATCH spice] server: don't assert on invalid client message

2014-06-25 Thread Uri Lublin
On 06/25/2014 03:36 PM, Marc-André Lureau wrote: Some users have been reaching this error: snd_receive: ASSERT n failed A misbehaving client could easily hit that condition by sending too big messages. Instead of assert(), replace with a warning. When a message too big to fit is received, it