[Spice-devel] [PATCH] Fix leaks

2014-07-15 Thread Fabiano Fidêncio
--- usbredirhost/usbredirhost.c | 1 + usbredirtestclient/usbredirtestclient.c | 3 +++ 2 files changed, 4 insertions(+) diff --git a/usbredirhost/usbredirhost.c b/usbredirhost/usbredirhost.c index bbaafa4..6ab6e1b 100644 --- a/usbredirhost/usbredirhost.c +++ b/usbredirhost/usbredirho

Re: [Spice-devel] video performance in rhel/centos 7 vs fedora 20

2014-07-15 Thread Cody Chan
On Tue, Jul 15, 2014 at 11:22 PM, Marc-André Lureau wrote: > Hi > > - Original Message - > > Hi All, > > > > We have been piloting deployments of VM using Fedora 20 host and guest > > and have been very happy with performance and stability in almost every > > respect, so a big thanks to a

Re: [Spice-devel] video performance in rhel/centos 7 vs fedora 20

2014-07-15 Thread Scott Dowdle
Greetings, - Original Message - > Hi > > - Original Message - > > Hi All, > > > > We have been piloting deployments of VM using Fedora 20 host and guest > > and have been very happy with performance and stability in almost every > > respect, so a big thanks to all for this hard w

Re: [Spice-devel] video performance in rhel/centos 7 vs fedora 20

2014-07-15 Thread Marc-André Lureau
Hi - Original Message - > Hi All, > > We have been piloting deployments of VM using Fedora 20 host and guest > and have been very happy with performance and stability in almost every > respect, so a big thanks to all for this hard work. Things are looking > great. > > Now we have been te

[Spice-devel] [vdagent-linux 1/2] Reply to TIMESTAMP requests

2014-07-15 Thread Marc-André Lureau
This is to please vncviewer. https://bugzilla.redhat.com/show_bug.cgi?id=1117764 --- src/vdagent-x11-priv.h | 1 + src/vdagent-x11.c | 15 +++ 2 files changed, 16 insertions(+) diff --git a/src/vdagent-x11-priv.h b/src/vdagent-x11-priv.h index c607850..4a5729b 100644 --- a/src/

[Spice-devel] [vdagent-linux 2/2] Handle STRING selection type

2014-07-15 Thread Marc-André Lureau
This is to please vncviewer. https://bugzilla.redhat.com/show_bug.cgi?id=1117764 --- src/vdagent-x11-priv.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/vdagent-x11-priv.h b/src/vdagent-x11-priv.h index 4a5729b..38f852e 100644 --- a/src/vdagent-x11-priv.h +++ b/src/

[Spice-devel] video performance in rhel/centos 7 vs fedora 20

2014-07-15 Thread David Mansfield
Hi All, We have been piloting deployments of VM using Fedora 20 host and guest and have been very happy with performance and stability in almost every respect, so a big thanks to all for this hard work. Things are looking great. Now we have been testing deployments of these same VMs (F20 gue

[Spice-devel] [PATCH] Don't use _GET_PRIVATE all the time

2014-07-15 Thread Fabiano Fidêncio
Let's make use of the priv members in the structs, which are much much faster. Also, to keep the type-safety, the SPICE_IS_* macros were added in the public methods affected by this patch. Patch based on an old patch old patch from Alexander Larsson (al...@redhat.com). --- gtk/channel-cursor.c

Re: [Spice-devel] [spice-common][PATCH 1/2] quic: Fix "UNINIT" caught by coverity

2014-07-15 Thread Marc-André Lureau
ack - Original Message - > In case of the model evolution mode has a obsolete or non-valid value, > just return, avoiding then the usage of non initalized variables. > --- > common/quic.c | 12 +--- > 1 file changed, 5 insertions(+), 7 deletions(-) > > diff --git a/common/quic.c

Re: [Spice-devel] [spice-common][PATCH 2/2] quic_family_tmpl: Fix "FORWARD_NULL" caught by coverity

2014-07-15 Thread Marc-André Lureau
ack - Original Message - > Ensure the received bucket is non NULL > --- > common/quic_family_tmpl.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/common/quic_family_tmpl.c b/common/quic_family_tmpl.c > index 12ef62f..9a434e0 100644 > --- a/common/quic_family_tmpl.c > +++ b/c

Re: [Spice-devel] [spice-gtk][PATCH] Prefer using g_malloc0()/g_free()

2014-07-15 Thread Marc-André Lureau
ack - Original Message - > As we already depend on GLib, let's use g_{malloc,new}0() instead of the > standard malloc() or the spice_{malloc,new}*() and g_free() instead of > the standard free() when possible. > Memory allocated by other libraries using malloc() should still be freed > by

[Spice-devel] [spice-gtk][PATCH] Prefer using g_malloc0()/g_free()

2014-07-15 Thread Fabiano Fidêncio
As we already depend on GLib, let's use g_{malloc,new}0() instead of the standard malloc() or the spice_{malloc,new}*() and g_free() instead of the standard free() when possible. Memory allocated by other libraries using malloc() should still be freed by free(). As a side effect of the changes, we

[Spice-devel] [spice-common][PATCH 2/2] quic_family_tmpl: Fix "FORWARD_NULL" caught by coverity

2014-07-15 Thread Fabiano Fidêncio
Ensure the received bucket is non NULL --- common/quic_family_tmpl.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/common/quic_family_tmpl.c b/common/quic_family_tmpl.c index 12ef62f..9a434e0 100644 --- a/common/quic_family_tmpl.c +++ b/common/quic_family_tmpl.c @@ -72,6 +72,8 @@ static vo

[Spice-devel] [spice-common][PATCH 1/2] quic: Fix "UNINIT" caught by coverity

2014-07-15 Thread Fabiano Fidêncio
In case of the model evolution mode has a obsolete or non-valid value, just return, avoiding then the usage of non initalized variables. --- common/quic.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/common/quic.c b/common/quic.c index 4584336..90ea47b 100644 --