Re: [Spice-devel] [RFC] client: Remove client code

2014-11-21 Thread Fabiano Fidêncio
On Fri, 2014-11-21 at 10:23 -0600, Jonathon Jongsma wrote: > On Fri, 2014-11-21 at 06:11 -0500, Marc-André Lureau wrote: > > Hi > > > > - Original Message - > > > The client has been superseded by virt-viewer ( > > > http://virt-manager.org/download/sources/virt-viewer/ ) and is no longer

Re: [Spice-devel] [PATCH spice-gtk v3] Release keyboard grab using keyboard shortcut

2014-11-21 Thread Marc-André Lureau
- Original Message - > > > > Hi, > > > > > > I can't reproduce it. To make it clear for me, your scenario is: > > > press > > > ctrl+alt, then alt+tab, then alt+tab back, at this point the > > > keyboard > > > doesn't have the grab (eg due to a mouse move) and you have to > > > press >

Re: [Spice-devel] [RFC] client: Remove client code

2014-11-21 Thread Jonathon Jongsma
On Fri, 2014-11-21 at 06:11 -0500, Marc-André Lureau wrote: > Hi > > - Original Message - > > The client has been superseded by virt-viewer ( > > http://virt-manager.org/download/sources/virt-viewer/ ) and is no longer > > being maintained. > > --- > > > > I think it's time that we remove

Re: [Spice-devel] [PATCH spice-gtk v3] Release keyboard grab using keyboard shortcut

2014-11-21 Thread Pavel Grunt
> > Hi, > > > > I can't reproduce it. To make it clear for me, your scenario is: > > press > > ctrl+alt, then alt+tab, then alt+tab back, at this point the > > keyboard > > doesn't have the grab (eg due to a mouse move) and you have to > > press > > ctrl+alt two times to regain it ? > > Exact, I

Re: [Spice-devel] [xf86-video-qxl] Enable smartcard support for XSpice.

2014-11-21 Thread Alon Levy
On 11/21/2014 05:03 PM, Jeremy White wrote: > Thanks for the careful review. > >>> +static void push_apdu(smartcard_ccid_t *ccid, void *data, int len) >>> +{ >>> +apdu_t *a = calloc(1, sizeof(*a) + len); >>> +apdu_t **p; >>> + >>> +a->data = malloc(len); >>> +memcpy(a->data, data,

[Spice-devel] [xf86-video-qxl v2] Enable smartcard support for XSpice.

2014-11-21 Thread Jeremy White
This is done by creating a Unix domain socket to which smartcard messages are transferred, using the vscard protocol. A further system library, spiceccid, is used to provide an interface into pcsc-lite, specifically the pcsc-lite daemon, so that regular Unix applications can access the passed thro

Re: [Spice-devel] [xf86-video-qxl] Enable smartcard support for XSpice.

2014-11-21 Thread Jeremy White
Thanks for the careful review. +static void push_apdu(smartcard_ccid_t *ccid, void *data, int len) +{ +apdu_t *a = calloc(1, sizeof(*a) + len); +apdu_t **p; + +a->data = malloc(len); +memcpy(a->data, data, len); 1. No need to add ( + len ) to the calloc above as a->data is

Re: [Spice-devel] screen freezed for 2-3 minutes on spice connect on xen windows 7 domU's with qxl after save/restore

2014-11-21 Thread Fabio Fantoni
Il 21/11/2014 12:05, Fabio Fantoni ha scritto: Il 20/11/2014 12:21, Fabio Fantoni ha scritto: Il 13/11/2014 13:22, Fabio Fantoni ha scritto: Il 13/11/2014 11:14, Fabio Fantoni ha scritto: Il 19/09/2014 15:18, Fabio Fantoni ha scritto: Il 12/09/2014 16:46, Fabio Fantoni ha scritto: Il 08/07/2

Re: [Spice-devel] [spice-gtk] Remove channels from SpiceSession::channels on session disconnect

2014-11-21 Thread Marc-André Lureau
The patch was missing a second case where channels are removed from the session, see attached patch. Fundamentally, it doesn't change much from my patch, I guess removing g_clear_object(channel->priv->session) and ignoring the case where the channel isn't in the session (like you do here) would ha

Re: [Spice-devel] [RFC] client: Remove client code

2014-11-21 Thread Marc-André Lureau
Hi - Original Message - > The client has been superseded by virt-viewer ( > http://virt-manager.org/download/sources/virt-viewer/ ) and is no longer > being maintained. > --- > > I think it's time that we remove this code, just let me know if you think we > should keep it a bit longer, I'

Re: [Spice-devel] [spice-common] glc: Fix "warning: unused variable 'recreate'"

2014-11-21 Thread Marc-André Lureau
ack - Original Message - > --- > common/glc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/common/glc.c b/common/glc.c > index c1795de..8fd8700 100644 > --- a/common/glc.c > +++ b/common/glc.c > @@ -1260,7 +1260,6 @@ void glc_copy_pixels(GLCCtx glc, int x_dest

Re: [Spice-devel] screen freezed for 2-3 minutes on spice connect on xen windows 7 domU's with qxl after save/restore

2014-11-21 Thread Fabio Fantoni
Il 20/11/2014 12:21, Fabio Fantoni ha scritto: Il 13/11/2014 13:22, Fabio Fantoni ha scritto: Il 13/11/2014 11:14, Fabio Fantoni ha scritto: Il 19/09/2014 15:18, Fabio Fantoni ha scritto: Il 12/09/2014 16:46, Fabio Fantoni ha scritto: Il 08/07/2014 12:34, Fabio Fantoni ha scritto: Il 08/07/2

[Spice-devel] [RFC] client: Remove client code

2014-11-21 Thread Christophe Fergeau
The client has been superseded by virt-viewer ( http://virt-manager.org/download/sources/virt-viewer/ ) and is no longer being maintained. --- I think it's time that we remove this code, just let me know if you think we should keep it a bit longer, I'll just drop that patch for a while :) Christo

[Spice-devel] [spice-common] glc: Fix "warning: unused variable 'recreate'"

2014-11-21 Thread Christophe Fergeau
--- common/glc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common/glc.c b/common/glc.c index c1795de..8fd8700 100644 --- a/common/glc.c +++ b/common/glc.c @@ -1260,7 +1260,6 @@ void glc_copy_pixels(GLCCtx glc, int x_dest, int y_dest, int x_src, int y_src, i

Re: [Spice-devel] [PATCH spice-gtk v3] Release keyboard grab using keyboard shortcut

2014-11-21 Thread Marc-André Lureau
- Original Message - > Hi, > > I can't reproduce it. To make it clear for me, your scenario is: press > ctrl+alt, then alt+tab, then alt+tab back, at this point the keyboard > doesn't have the grab (eg due to a mouse move) and you have to press > ctrl+alt two times to regain it ? Exact,

Re: [Spice-devel] [PATCH spice-gtk v3] Release keyboard grab using keyboard shortcut

2014-11-21 Thread Pavel Grunt
Hi, I can't reproduce it. To make it clear for me, your scenario is: press ctrl+alt, then alt+tab, then alt+tab back, at this point the keyboard doesn't have the grab (eg due to a mouse move) and you have to press ctrl+alt two times to regain it ? Thank you Pavel > > For some reason, I still

Re: [Spice-devel] [spice-gtk] Remove channels from SpiceSession::channels on session disconnect

2014-11-21 Thread Marc-André Lureau
It doesn't work well, I get a crash with pretty poor backtrace when migrating with virt-manager (looks like an "extra" unref from python GC). On Thu, Nov 20, 2014 at 3:52 PM, Christophe Fergeau wrote: > spice_session_disconnect gets rid of the reference it owns on > the SpiceChannels listed in Sp

Re: [Spice-devel] [PATCH spice-gtk v3] Release keyboard grab using keyboard shortcut

2014-11-21 Thread Marc-André Lureau
For some reason, I still need to press ctrl+alt two times to regain the grab. On Wed, Nov 19, 2014 at 1:39 PM, Pavel Grunt wrote: > This commit adds the ability to release the keyboard grab when > the release keys (ctrl+alt) are pressed and released. It allows > to use keyboard shortcuts (eg alt+

[Spice-devel] [PATCH 1/2] configure.ac: Only check for xinerama for client builds

2014-11-21 Thread Christophe Fergeau
Xinerama support is only used for the X11 client, but is currently being checked even for server only builds. This commit ensures Xinerama is not checked for/added to spice-server.pc when not building the client. --- configure.ac | 36 ++-- 1 file changed, 18 insert

[Spice-devel] [PATCH 2/2] configure.ac: Never add xinerama to SPICE_REQUIRES

2014-11-21 Thread Christophe Fergeau
SPICE_REQUIRES is only used to generate the Requires.private line of spice-server.pc. The server code is not using xinerama, so we don't need to list xinerama in Requires.private. --- configure.ac | 1 - 1 file changed, 1 deletion(-) diff --git a/configure.ac b/configure.ac index 7a5a8ec..7ef60b7

[Spice-devel] [PATCH 2/2] configure.ac: Never add xinerama to SPICE_REQUIRES

2014-11-21 Thread Christophe Fergeau
SPICE_REQUIRES is only used to generate the Requires.private line of spice-server.pc. The server code is not using xinerama, so we don't need to list xinerama in Requires.private. --- configure.ac | 1 - 1 file changed, 1 deletion(-) diff --git a/configure.ac b/configure.ac index 7a5a8ec..7ef60b7

[Spice-devel] [PATCH 1/2] configure.ac: Only check for xinerama for client builds

2014-11-21 Thread Christophe Fergeau
Xinerama support is only used for the X11 client, but is currently being checked even for server only builds. This commit ensures Xinerama is not checked for/added to spice-server.pc when not building the client. --- configure.ac | 36 ++-- 1 file changed, 18 insert

Re: [Spice-devel] [PATCH] Update README with links to git/bugtracker/mailing list

2014-11-21 Thread Christophe Fergeau
On Fri, Nov 21, 2014 at 10:02:50AM +0100, Marc-André Lureau wrote: > On Fri, Nov 21, 2014 at 9:32 AM, Christophe Fergeau > wrote: > > +Bug reports can be filed against the Spice/usbredir component: > > +https://bugs.freedesktop.org/enter_bug.cgi?product=Spice > > > Even better link: > https://b

Re: [Spice-devel] [PATCH] Update README with links to git/bugtracker/mailing list

2014-11-21 Thread Marc-André Lureau
On Fri, Nov 21, 2014 at 9:32 AM, Christophe Fergeau wrote: > +Bug reports can be filed against the Spice/usbredir component: > +https://bugs.freedesktop.org/enter_bug.cgi?product=Spice Even better link: https://bugs.freedesktop.org/enter_bug.cgi?product=Spice&component=usbredir -- Marc-André L

Re: [Spice-devel] [PATCH spice] configure.ac: use portable shell

2014-11-21 Thread Christophe Fergeau
Hey, Looks good to me, ACK (though I would have put the AS_VAR_APPEND bits and the test == bits in 2 separate patches). Christophe On Thu, Nov 20, 2014 at 08:55:38PM +0300, Alexander Tsoy wrote: > This fixes the following errors when configure run in dash: > > ./configure: 17366: ./configure:

[Spice-devel] [PATCH] Update README with links to git/bugtracker/mailing list

2014-11-21 Thread Christophe Fergeau
--- README | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/README b/README index d0fdc6e..256accd 100644 --- a/README +++ b/README @@ -29,5 +29,14 @@ usbredirtestclient: A small testclient for the usbredir protocol over tcp, using usbredirparser +The upstream g