On Thu, Dec 04, 2014 at 12:09:15PM -0500, Marc-André Lureau wrote:
> Hi
>
> - Original Message -
> > On Thu, Dec 04, 2014 at 05:59:07PM +0100, Marc-André Lureau wrote:
> > > On Thu, Dec 4, 2014 at 5:53 PM, Christophe Fergeau
> > > wrote:
> > > > Replacing autogen.sh with a totally differe
Hi
- Original Message -
> On Thu, Dec 04, 2014 at 05:59:07PM +0100, Marc-André Lureau wrote:
> > On Thu, Dec 4, 2014 at 5:53 PM, Christophe Fergeau
> > wrote:
> > > Replacing autogen.sh with a totally different one is _not_ something
> > > trivial.
> >
> > It is to me, it took me about a
On Thu, Dec 04, 2014 at 05:59:07PM +0100, Marc-André Lureau wrote:
> On Thu, Dec 4, 2014 at 5:53 PM, Christophe Fergeau
> wrote:
> > Replacing autogen.sh with a totally different one is _not_ something
> > trivial.
>
> It is to me, it took me about a minute to do all that. It is also
> trivial t
On Thu, Dec 4, 2014 at 5:53 PM, Christophe Fergeau wrote:
> Replacing autogen.sh with a totally different one is _not_ something
> trivial.
It is to me, it took me about a minute to do all that. It is also
trivial to remove it or change it. Do you have something to say about
the change itself?
-
On Thu, Dec 04, 2014 at 05:42:18PM +0100, Marc-André Lureau wrote:
> Use autoreconf, allow out of tree autogen.sh run.
> ---
> Pushed upstream as trivial build fix.
Replacing autogen.sh with a totally different one is _not_ something
trivial.
Christophe
pgpF0gZjXIhYD.pgp
Description: PGP signat
Use autoreconf, allow out of tree autogen.sh run.
---
Pushed upstream as trivial build fix.
autogen.sh | 167 -
1 file changed, 10 insertions(+), 157 deletions(-)
diff --git a/autogen.sh b/autogen.sh
index 7d7c534..de6881d 100755
--- a/a
On Thu, Dec 4, 2014 at 4:27 PM, Christophe Fergeau wrote:
> On Thu, Dec 04, 2014 at 02:36:29PM +0100, Fabiano Fidêncio wrote:
>> On Thu, 2014-12-04 at 14:15 +0100, Christophe Fergeau wrote:
>> > Nothing uses the definition it contains (I've tested spice-gtk and
>> > spice)
>> > ---
>> > common/ca
On Thu, Dec 04, 2014 at 04:48:12PM +0100, Marc-André Lureau wrote:
> This interface has long been deprecated, and I don't know of any user.
> Perhaps the header could even be removed from spice-protocol?
I haven't answered to that question, but I'd tend to just go with that
patch for now, if nothi
On Thu, Dec 04, 2014 at 04:48:12PM +0100, Marc-André Lureau wrote:
> This interface has long been deprecated, and I don't know of any user.
> Perhaps the header could even be removed from spice-protocol?
> ---
> spice/vdi_dev.h | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/spice/vd
This interface has long been deprecated, and I don't know of any user.
Perhaps the header could even be removed from spice-protocol?
---
spice/vdi_dev.h | 4
1 file changed, 4 insertions(+)
diff --git a/spice/vdi_dev.h b/spice/vdi_dev.h
index 8e0eec9..d51cb2a 100644
--- a/spice/vdi_dev.h
+++
On Thu, Dec 04, 2014 at 02:36:29PM +0100, Fabiano Fidêncio wrote:
> On Thu, 2014-12-04 at 14:15 +0100, Christophe Fergeau wrote:
> > Nothing uses the definition it contains (I've tested spice-gtk and
> > spice)
> > ---
> > common/canvas_base.c | 1 -
> > common/mutex.h | 42
On Thu, 2014-12-04 at 14:15 +0100, Christophe Fergeau wrote:
> Nothing uses the definition it contains (I've tested spice-gtk and
> spice)
> ---
> common/canvas_base.c | 1 -
> common/mutex.h | 42 --
> 2 files changed, 43 deletions(-)
> delete mode
ack
- Original Message -
> Nothing uses the definition it contains (I've tested spice-gtk and
> spice)
> ---
> common/canvas_base.c | 1 -
> common/mutex.h | 42 --
> 2 files changed, 43 deletions(-)
> delete mode 100644 common/mutex.h
>
>
Nothing uses the definition it contains (I've tested spice-gtk and
spice)
---
common/canvas_base.c | 1 -
common/mutex.h | 42 --
2 files changed, 43 deletions(-)
delete mode 100644 common/mutex.h
diff --git a/common/canvas_base.c b/common/canvas_ba
On Thu, Dec 04, 2014 at 07:45:46AM -0500, Marc-André Lureau wrote:
>
>
> - Original Message -
> > On Thu, Dec 04, 2014 at 06:06:34AM -0500, Marc-André Lureau wrote:
> > > > Well, I'm not suggesting something that drastic ;) Not running
> > > > spice-protocol configure every time is an eas
- Original Message -
> On Thu, Dec 04, 2014 at 06:06:34AM -0500, Marc-André Lureau wrote:
> > > Well, I'm not suggesting something that drastic ;) Not running
> > > spice-protocol configure every time is an easy win without making huge
> > > changes to what we have now.
> >
> > I am not
On Thu, Dec 04, 2014 at 06:06:34AM -0500, Marc-André Lureau wrote:
> > Well, I'm not suggesting something that drastic ;) Not running
> > spice-protocol configure every time is an easy win without making huge
> > changes to what we have now.
>
> I am not sure, I don't know what you have in mind to
On Wed, Dec 03, 2014 at 12:42:03PM -0500, Marc-André Lureau wrote:
> What is the problem you are trying to solve by removing submodule?
Ok, given the discussion going on, I'll drop
'build-sys: Remove spice-protocol submodule' and the next patch from
that series so that we can try to move forward w
Hi
- Original Message -
> Well, from my side, the reason we started using them is because they
> _seemed_ convenient (not much experience with submodules back in the
> days), and after a while, they don't seem that convenient to me. Maybe
> I failed at wrapping my head properly around them
- Original Message -
> On Thu, Dec 04, 2014 at 05:22:34AM -0500, Marc-André Lureau wrote:
> >
> > hi
> >
> > - Original Message -
> > > On Thu, Dec 04, 2014 at 05:12:53AM -0500, Marc-André Lureau wrote:
> > > > I mean that spice-protocol headers could be part of spice-common
> >
On Thu, Dec 04, 2014 at 05:22:34AM -0500, Marc-André Lureau wrote:
>
> hi
>
> - Original Message -
> > On Thu, Dec 04, 2014 at 05:12:53AM -0500, Marc-André Lureau wrote:
> > > I mean that spice-protocol headers could be part of spice-common
> > > repository, and released with spice-common
On Thu, Dec 04, 2014 at 05:21:41AM -0500, Marc-André Lureau wrote:
> > There's a change every few months in spice-protocol, so yeah, before
> > making a release of spice-server/spice-gtk which uses new features from
> > spice-protocol, we'd need to make a release. This is how it already
> > works f
hi
- Original Message -
> On Thu, Dec 04, 2014 at 05:12:53AM -0500, Marc-André Lureau wrote:
> > I mean that spice-protocol headers could be part of spice-common
> > repository, and released with spice-common.
>
> Released with spice-common? We are not there yet, are we?
>
It's a fairl
- Original Message -
> On Wed, Dec 03, 2014 at 12:42:03PM -0500, Marc-André Lureau wrote:
> > hi
> >
> > - Original Message -
> > > Hey, this patch series refactors the content of configure.ac of
> > > spice-common,
> > > and
> > > makes a few cleanups of Makefile.am. The reason
On Thu, Dec 04, 2014 at 05:12:53AM -0500, Marc-André Lureau wrote:
> I mean that spice-protocol headers could be part of spice-common
> repository, and released with spice-common.
Released with spice-common? We are not there yet, are we?
Christophe
pgpn8KZwODgeT.pgp
Description: PGP signature
_
On Wed, Dec 03, 2014 at 12:42:03PM -0500, Marc-André Lureau wrote:
> hi
>
> - Original Message -
> > Hey, this patch series refactors the content of configure.ac of
> > spice-common,
> > and
> > makes a few cleanups of Makefile.am. The reason for these changes is that
> > I'd
> > like to
Hi
- Original Message -
> On Wed, Dec 03, 2014 at 01:12:56PM -0500, Marc-André Lureau wrote:
> > hi
> >
> > - Original Message -
> > > Now that spice-protocol is no longer a submodule, it's no longer
> > > possible to automatically overwrite enums.h within the spice-protocol
> > >
On Wed, Dec 03, 2014 at 01:12:56PM -0500, Marc-André Lureau wrote:
> hi
>
> - Original Message -
> > Now that spice-protocol is no longer a submodule, it's no longer
> > possible to automatically overwrite enums.h within the spice-protocol
> > submodule when spice.proto changes in the spic
On Wed, Dec 03, 2014 at 01:09:05PM -0500, Marc-André Lureau wrote:
>
> - Original Message -
> > This macro is not available with RHEL6 autoconf.
>
> Well, running autoconf in RHEL6 shouldn't be needed, I don't think we need
> fallback.
I build spice-gtk/spice-server from git on EL6 once
29 matches
Mail list logo
