Re: [Spice-devel] [spice-common PATCH] ssl_verify.c: Add IPv6 support

2015-09-07 Thread Daniel P. Berrange
On Mon, Sep 07, 2015 at 06:55:47PM +0200, Lukas Venhoda wrote: > Add inet_pton and inet_ntop which supports IPv6 address. > inet_aton left for compatibility. You really should not use any of the inet_* functions, even the ones which technically support IPv6. Instead use getaddrinfo()/getnameinfo(

[Spice-devel] [spice-common PATCH] ssl_verify.c: Add IPv6 support

2015-09-07 Thread Lukas Venhoda
Add inet_pton and inet_ntop which supports IPv6 address. inet_aton left for compatibility. --- common/ssl_verify.c | 32 +++- 1 file changed, 23 insertions(+), 9 deletions(-) diff --git a/common/ssl_verify.c b/common/ssl_verify.c index a830800..d247d95 100644 --- a/com

Re: [Spice-devel] [vdagent-linux] vdagent: Return '1' when virtio device cannot be opened

2015-09-07 Thread Frediano Ziglio
Acked! > The vdagent process currently exits with an error code set to 0 whenn > the virtio device cannot be opened (for example because it's missing). > This is not consistent with the other failures to startup which set the > exit code to 1. This commit ensures 1 is returned in this situation to

[Spice-devel] [PATCH] replay: fix formatting string

2015-09-07 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- server/red_replay_qxl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/red_replay_qxl.c b/server/red_replay_qxl.c index fe53dda..ad1a8fd 100644 --- a/server/red_replay_qxl.c +++ b/server/red_replay_qxl.c @@ -310,7 +310,7 @@ static voi

[Spice-devel] [vdagent-linux] vdagent: Return '1' when virtio device cannot be opened

2015-09-07 Thread Christophe Fergeau
The vdagent process currently exits with an error code set to 0 whenn the virtio device cannot be opened (for example because it's missing). This is not consistent with the other failures to startup which set the exit code to 1. This commit ensures 1 is returned in this situation too. Resolves: rh

Re: [Spice-devel] [spice-server PATCH v1 0/3] memory pool limit on char-device

2015-09-07 Thread Victor Toso
Hey! On Thu, Aug 20, 2015 at 04:20:37PM +0200, Victor Toso wrote: > Hi folks, > > While trying webdav, a few issues came up related on memory usage in > the server/host side. This series should help on spice side by defining > a limit to the memory pool queue in the char-device. > > The memory poo

[Spice-devel] [PATCH spice-html5 3/5] spiceconn.js: Add missing channel names

2015-09-07 Thread Pavel Grunt
--- spiceconn.js | 14 ++ 1 file changed, 14 insertions(+) diff --git a/spiceconn.js b/spiceconn.js index f19b109..70437be 100644 --- a/spiceconn.js +++ b/spiceconn.js @@ -374,6 +374,20 @@ SpiceConn.prototype = return "inputs"; else if (this.type == SPICE_CHANNEL

[Spice-devel] [PATCH spice-html5 4/5] Use name of channel instead of number

2015-09-07 Thread Pavel Grunt
--- main.js | 2 +- spiceconn.js | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/main.js b/main.js index 99b2274..be8ad2e 100644 --- a/main.js +++ b/main.js @@ -138,10 +138,10 @@ SpiceMainConn.prototype.process_channel_message = function(msg) this.cu

[Spice-devel] [PATCH spice-html5 0/5] Small debug related improvements

2015-09-07 Thread Pavel Grunt
The debug log provided by the spice-html5 client is full of constants related to channel and message ids. The intention of this patch series is to use channel and message names instead to make the debug log more readable. Pavel Grunt (5): display.js: Remove unreachable return enums.js: Update

[Spice-devel] [PATCH spice-html5 1/5] display.js: Remove unreachable return

2015-09-07 Thread Pavel Grunt
--- display.js | 2 -- 1 file changed, 2 deletions(-) diff --git a/display.js b/display.js index 7938527..00f2903 100644 --- a/display.js +++ b/display.js @@ -171,8 +171,6 @@ SpiceDisplayConn.prototype.process_channel_message = function(msg) has_alpha: this.surfaces[draw_

[Spice-devel] [PATCH spice-html5 2/5] enums.js: Update for new channels

2015-09-07 Thread Pavel Grunt
--- enums.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/enums.js b/enums.js index 6e94025..bca463a 100644 --- a/enums.js +++ b/enums.js @@ -200,6 +200,8 @@ var SPICE_CHANNEL_RECORD= 6; var SPICE_CHANNEL_TUNNEL= 7; var SPICE_CHANNEL_SMARTCARD

[Spice-devel] [PATCH spice-html5 5/5] Set nonhandled messages as not implemented

2015-09-07 Thread Pavel Grunt
Avoid spamming log --- cursor.js | 18 display.js | 91 + main.js | 60 playback.js | 18 4 files changed, 187 insertions(+) diff --git a/cursor.js b/cursor.js ind

Re: [Spice-devel] [PATCH] build-sys: Update warning message

2015-09-07 Thread Christophe Fergeau
On Mon, Sep 07, 2015 at 09:20:45AM -0400, Frediano Ziglio wrote: > Even better: > > From: Frediano Ziglio > Date: Fri, 4 Sep 2015 11:22:01 +0100 > Subject: [PATCH] build-sys: Update warning message > > arch_warn was set to 1 only if architecture is not x86, x64 or arm. > Update the message as we

Re: [Spice-devel] [spice-HTML5][PATCH try 2] Handling non-topdown lz_rgb

2015-09-07 Thread Pavel Grunt
On Mon, 2015-09-07 at 15:08 +0200, Fabio Fantoni wrote: > Il 07/09/2015 14:06, Pavel Grunt ha scritto: > > Hi Fabio, > > > > On Mon, 2015-09-07 at 13:35 +0200, Fabio Fantoni wrote: > > > Il 03/09/2015 15:28, Pavel Grunt ha scritto: > > > > Hi, > > > > > > > > On Thu, 2015-09-03 at 11:52 +0200, Fa

Re: [Spice-devel] [PATCH] build-sys: Update warning message

2015-09-07 Thread Frediano Ziglio
Even better: From: Frediano Ziglio Date: Fri, 4 Sep 2015 11:22:01 +0100 Subject: [PATCH] build-sys: Update warning message arch_warn was set to 1 only if architecture is not x86, x64 or arm. Update the message as we actually main test x64. Also change the way message is saved so it easier to spo

Re: [Spice-devel] [spice-HTML5][PATCH try 2] Handling non-topdown lz_rgb

2015-09-07 Thread Fabio Fantoni
Il 07/09/2015 14:06, Pavel Grunt ha scritto: > Hi Fabio, > > On Mon, 2015-09-07 at 13:35 +0200, Fabio Fantoni wrote: >> Il 03/09/2015 15:28, Pavel Grunt ha scritto: >>> Hi, >>> >>> On Thu, 2015-09-03 at 11:52 +0200, Fabio Fantoni wrote: Hi, based also on js console output: http://pastebin

Re: [Spice-devel] [PATCH v2 2/2] spiceqxl: Reject invalid boolean values, just like for other options.

2015-09-07 Thread Christophe Fergeau
On Tue, Sep 01, 2015 at 12:44:51AM +0200, Francois Gouget wrote: > On Mon, 31 Aug 2015, Frediano Ziglio wrote: > [...] > > I think etiher we should merge first patch and discard the second or you > > should merge > > the two patches together. > > I think it would be ok to commit them separately a

Re: [Spice-devel] [PATCH v2] Xspice: Don't set defaults for the options.

2015-09-07 Thread Christophe Fergeau
I've pushed this patch, thanks! On Mon, Aug 31, 2015 at 03:26:43PM +0200, Francois Gouget wrote: > Otherwise they override Spice server's real builtin defaults, the Xorg > configuration file settings, and even the XSPICE_XXX environment variables. > For instance, without this patch calling Xspice

Re: [Spice-devel] [spice-HTML5][PATCH try 2] Handling non-topdown lz_rgb

2015-09-07 Thread Pavel Grunt
Hi Fabio, On Mon, 2015-09-07 at 13:35 +0200, Fabio Fantoni wrote: > Il 03/09/2015 15:28, Pavel Grunt ha scritto: > > Hi, > > > > On Thu, 2015-09-03 at 11:52 +0200, Fabio Fantoni wrote: > > > Hi, based also on js console output: > > > http://pastebin.com/L9Rr3Y25 > > > I tried this patch for fix t

Re: [Spice-devel] [PATCH qxl] Xspice: Don't set defaults for the options.

2015-09-07 Thread Christophe Fergeau
On Mon, Aug 31, 2015 at 03:18:50PM +0200, Francois Gouget wrote: > On Mon, 10 Aug 2015, Christophe Fergeau wrote: > > > On Mon, Jun 08, 2015 at 05:52:59PM +0200, Francois Gouget wrote: > > > Otherwise they override Spice server's real builtin defaults, the Xorg > > > configuration file settings,

Re: [Spice-devel] [spice-HTML5][PATCH try 2] Handling non-topdown lz_rgb

2015-09-07 Thread Fabio Fantoni
Il 03/09/2015 15:28, Pavel Grunt ha scritto: > Hi, > > On Thu, 2015-09-03 at 11:52 +0200, Fabio Fantoni wrote: >> Hi, based also on js console output: >> http://pastebin.com/L9Rr3Y25 >> I tried this patch for fix the non-topdown problem (remove one of the >> FIXME type): >> http://lists.freedesktop

Re: [Spice-devel] [PATCH] build-sys: Update warning message

2015-09-07 Thread Christophe Fergeau
Saying that spice-server has been tested 'extensively' on x86 is not really true imo, even less so for arm. I'd go with: diff --git a/configure.ac b/configure.ac index 1903384..9208b09 100644 --- a/configure.ac +++ b/configure.ac @@ -63,7 +63,7 @@ m4_ifndef([AS_VAR_APPEND], # Check for the CPU w

Re: [Spice-devel] [spice-protocol PATCH v4] audio: Do not volume-sync without audio

2015-09-07 Thread Pavel Grunt
Ack, Pavel On Mon, 2015-09-07 at 11:55 +0200, Victor Toso wrote: > In case audio backend is not initialized correctly or there isn't audio > in the VM, we should not try to volume-sync. > > Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1257210 > --- > src/channel-main.c | 6 -- > src/s

Re: [Spice-devel] lots of what looks like "memory issues" to me but I don't know enough to understand the messages...

2015-09-07 Thread Christophe Fergeau
Hey, On Sun, Sep 06, 2015 at 11:28:57PM +0100, Graeme Vetterlein wrote: > I bought a Intel i7 with 16Gb of RAM , installed Fedora20 (then current) > it was called "real" .. my intent was to run all my systems as virtual > machines under it . Sadly over a year on on I've not managed it due to > th

[Spice-devel] lots of what looks like "memory issues" to me but I don't know enough to understand the messages...

2015-09-07 Thread Graeme Vetterlein
I bought a Intel i7 with 16Gb of RAM , installed Fedora20 (then current) it was called "real" .. my intent was to run all my systems as virtual machines under it . Sadly over a year on on I've not managed it due to the very slow graphics. Today I just built a new vm of the latest Jessie (Debian 8)

[Spice-devel] [spice-protocol PATCH v4] audio: Do not volume-sync without audio

2015-09-07 Thread Victor Toso
In case audio backend is not initialized correctly or there isn't audio in the VM, we should not try to volume-sync. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1257210 --- src/channel-main.c | 6 -- src/spice-audio.c | 4 2 files changed, 8 insertions(+), 2 deletions(-) diff --

[Spice-devel] [spice-gtk PATCH v3] audio: Do not volume-sync without audio

2015-09-07 Thread Victor Toso
In case audio backend is not initialized correctly or there isn't audio in the VM, we should not try to volume-sync. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1257210 --- src/channel-main.c | 6 -- src/spice-audio.c | 4 2 files changed, 8 insertions(+), 2 deletions(-) diff --

Re: [Spice-devel] [spice-gtk PATCH v1] audio: Do not volume-sync without audio

2015-09-07 Thread Victor Toso
Hi, On Mon, Sep 07, 2015 at 11:30:05AM +0200, Victor Toso wrote: > > So this is correct behaviour - returning because audio is not available ? > > Maybe it can be in the following 'if', because it "is not going to sync > > audio > > with guest" > > I only thought about first part of your comment

[Spice-devel] [spice-gtk PATCH v2] audio: Do not volume-sync without audio

2015-09-07 Thread Victor Toso
In case audio backend is not initialized correctly or there isn't audio in the VM, we should not try to volume-sync. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1257210 --- src/channel-main.c | 8 src/spice-audio.c | 4 2 files changed, 12 insertions(+) diff --git a/src/cha

Re: [Spice-devel] [spice-gtk PATCH v1] audio: Do not volume-sync without audio

2015-09-07 Thread Victor Toso
Thanks for the review! On Mon, Sep 07, 2015 at 11:17:41AM +0200, Pavel Grunt wrote: > Hi Victor, > > On Mon, 2015-09-07 at 10:41 +0200, Victor Toso wrote: > > In case audio backend is not initialized correctly or there isn't audio > > in the VM, we should not try to volume-sync. > > > > Fixes: htt

Re: [Spice-devel] [spice-gtk PATCH v1] audio: Do not volume-sync without audio

2015-09-07 Thread Pavel Grunt
Hi Victor, On Mon, 2015-09-07 at 10:41 +0200, Victor Toso wrote: > In case audio backend is not initialized correctly or there isn't audio > in the VM, we should not try to volume-sync. > > Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1257210 > --- > src/channel-main.c | 8 > src/

[Spice-devel] [spice-gtk PATCH v1] audio: Do not volume-sync without audio

2015-09-07 Thread Victor Toso
In case audio backend is not initialized correctly or there isn't audio in the VM, we should not try to volume-sync. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1257210 --- src/channel-main.c | 8 src/spice-audio.c | 4 2 files changed, 12 insertions(+) diff --git a/src/cha