Re: [Spice-devel] [Qemu-devel] [PATCH] [RFC] LZ4 compression option for SPICE

Il 27/01/2015 09:26, Markus Armbruster ha scritto: > Eric Blake writes: > >> On 01/26/2015 01:48 AM, Javier Celaya wrote: >>> Sorry, I forgot to patch the command-line help. Hope it helps. >>> > Recently, SPICE included the lz4 compression algorithm. This patch adds > a command line option

[Spice-devel] [PATCH 1/2] use variables foo_LIBS and foo_CFLAGS in deps, not their values

spice-common/m4/spice-deps.m4 adds various foo_CFLAGS and foo_DEPS to the given common_CFLAGS and common_DEPS. But it does this by substituting the value directly, instead of using these variables (which are also being defined with AC_DEFINE). This way, it is impossible to re-define these variable

[Spice-devel] [PATCH 2/2] do not link spice with libcacard

None of the libcacard symbols are actually used by the library, only the header files, so there's no need to link with libcacard. Signed-off-by: Michael Tokarev --- spice-common/m4/spice-deps.m4 | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/spice-common/m4/spice-deps.m4 b

[Spice-devel] [PATCH 01/12] Bug fix: delete the reader entry after queueing an event, not before

From: Jeremy White As far as I can tell, the vreader_remove_reader function is not presently in use anywhere; I have an upcoming patch set that uses it. Signed-off-by: Jeremy White Reviewed-by: Marc-André Lureau --- src/vreader.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --g

[Spice-devel] [PATCH 02/12] build-sys: add --enable-pcsc

From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- configure.ac | 26 ++ 1 file changed, 26 insertions(+) diff --git a/configure.ac b/configure.ac index b841ec1..b878526 100644 --- a/configure.ac +++ b/configure.ac @@ -36,9 +36,35 @@ AX_CODE_COVERAGE() PKG_CH

[Spice-devel] [PATCH 11/12] build-sys: move G_LOG_DOMAIN to CPPFLAGS

From: Marc-André Lureau So the whole project use the same log domain. Signed-off-by: Marc-André Lureau --- Makefile.am | 1 + src/vreader.c | 5 - 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/Makefile.am b/Makefile.am index b8e8a90..1cef1ee 100644 --- a/Makefile.am +++ b

[Spice-devel] [PATCH 05/12] Enable support for passthru

From: Jeremy White Enable support for passthru (e.g. direct to pcsc) smart cards in the emul_options entry point in libcacard. Signed-off-by: Jeremy White Reviewed-by: Marc-André Lureau --- src/vcard_emul_nss.c | 28 +++- src/vcard_emul_type.c | 2 +- 2 files changed

[Spice-devel] [PATCH 10/12] Add some tests & code coverage

From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- Makefile.am | 28 ++- build-aux/glib-tap.mk | 150 +++ build-aux/tap-driver.sh | 652 build-aux/tap-test | 5 + configure.ac| 4 +- m4/glibte

[Spice-devel] [PATCH 04/12] Add a VCARD_DIRECT implemention to the libcacard smartcard support

From: Jeremy White This uses libpcsclite to provide direct communication with a smartcard. Signed-off-by: Jeremy White Reviewed-by: Marc-André Lureau --- Makefile.am | 9 +- configure.ac | 1 + src/capcsc.c | 505

[Spice-devel] [PATCH 03/12] Add error checking to vcard_emul_options

From: Jeremy White Also add an alias of 'nssemul' for the default card of hw=yes hw_type=cac, and an alias of 'passthru' for the new card type of hw=yes hw_type=passthru. This allows the spice-gtk client to take a more human friendly set of arguments and relay them through to this code. Signed-

[Spice-devel] [PATCH 07/12] libcacard: Fix bug detected with 'smatch'

From: Thomas Huth 'smatch' complains about two bugs and one style issue in card_7816.c: libcacard/card_7816.c:273 vcard_apdu_set_length() warn: should this be a bitwise op? libcacard/card_7816.c:295 vcard_apdu_set_length() warn: should this be a bitwise op? libcacard/card_7816.c:661 vcard7816_

[Spice-devel] [PATCH 06/12] Remove the (broken) passthru option

From: Jeremy White That option can be achieved using -e "use_hw=yes hw_type=passthru" Signed-off-by: Jeremy White Reviewed-by: Marc-André Lureau --- src/vscclient.c | 16 +++- 1 file changed, 3 insertions(+), 13 deletions(-) diff --git a/src/vscclient.c b/src/vscclient.c index e9

[Spice-devel] [PATCH 09/12] Add libcacard.h

From: Marc-André Lureau A top-level header file is often easier to deal with for programs Signed-off-by: Marc-André Lureau --- Makefile.am | 1 + src/libcacard.h | 22 ++ 2 files changed, 23 insertions(+) create mode 100644 src/libcacard.h diff --git a/Makefile.am b/

[Spice-devel] [PATCH 00/12] libcacard: pending patches

From: Marc-André Lureau A series of pending patches for libcacard, adapted from previous patches for qemu. Most of this patches have already been reviewed by me, other adapted, or added. A second look is worth it: - add error checking to vcard_emul_options() - add VCARD_DIRECT implementation to

[Spice-devel] [PATCH 12/12] NEWS: update for upcoming 2.5.1

From: Marc-André Lureau --- NEWS | 11 +++ 1 file changed, 11 insertions(+) diff --git a/NEWS b/NEWS index 8e55e71..b2778f3 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,14 @@ +v2.5.1 +== + +- fix mingw cross-compilation +- add error checking to vcard_emul_options() +- add VCARD_DIRECT im

[Spice-devel] [PATCH 08/12] build-sys: do not install vcardt_internal.h

From: Marc-André Lureau It was not in the exported symbols, so it shouldn't hurt to remove it now. Signed-off-by: Marc-André Lureau --- Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile.am b/Makefile.am index b1e257f..513272b 100644 --- a/Makefile.am +++

Re: [Spice-devel] [PATCH 0/4 v2] libcacard: a few fixes that allows the library to be crosscompiled (using mingw)

On Thu, Oct 8, 2015 at 5:25 PM, Marc-André Lureau wrote: > ack series, thanks Pushed, thanks! ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel

Re: [Spice-devel] [PATCH 0/4 v2] libcacard: a few fixes that allows the library to be crosscompiled (using mingw)

ack series, thanks On Thu, Oct 8, 2015 at 5:23 PM, Fabiano Fidêncio wrote: > Second round ... changes are going to be pointed out patch by patch ... > > Fabiano Fidêncio (4): > mingw: remove cac_is_cac_card dead code > mingw: avoid problems for using %zd (C99) > mingw: include ws2tcpip head

[Spice-devel] [PATCH 1/4 v2] mingw: remove cac_is_cac_card dead code

Without removing cac_is_cac_card the following error can be faced: Cannot export cac_is_cac_card: symbol not defined collect2: error: ld returned 1 exit status Found a not so old QEMU thread about this: https://www.mail-archive.com/qemu-devel%40nongnu.org/msg291698.html -- Changes since v1: - Rem

[Spice-devel] [PATCH 4/4 v2] mingw: include and link to ws2_32

Otherwise the following errors can be faced: src/vscclient-vscclient.o: In function `send_msg': /home/ffidenci/src/upstream/libcacard/src/vscclient.c:122: undefined reference to `_imp__htonl@4' /home/ffidenci/src/upstream/libcacard/src/vscclient.c:124: undefined reference to `_imp__htonl@4' src/vsc

[Spice-devel] [PATCH 0/4 v2] libcacard: a few fixes that allows the library to be crosscompiled (using mingw)

Second round ... changes are going to be pointed out patch by patch ... Fabiano Fidêncio (4): mingw: remove cac_is_cac_card dead code mingw: avoid problems for using %zd (C99) mingw: include ws2tcpip header mingw: include and link to ws2_32 Makefile.am | 8 configure

[Spice-devel] [PATCH 2/4 v2] mingw: avoid problems for using %zd (C99)

Otherwise the following problem can be faced: src/vscclient.c: In function 'connect_to_qemu': src/vscclient.c:642:16: error: unknown conversion type character 'z' in format [-Werror=format=] printf("Connected (sizeof Header=%zd)!\n", sizeof(VSCMsgHeader)); ^ src/v

[Spice-devel] [PATCH 3/4 v2] mingw: include ws2tcpip header

This header has the definition of getaddrinfo, according to: https://msdn.microsoft.com/en-us/library/windows/desktop/ms738520(v=vs.85).aspx --- Changes since v1: - No changes since v1 --- src/vscclient.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/vscclient.c b/src/vscclient.c index f

[Spice-devel] [common PATCH 2/4 v2] ssl-verify: Don't print DNS when using IP

Print IP address instead of DNS, when using IP adress connection. --- Changes since v1: - New patch - Wasn't changed in v1 --- common/ssl_verify.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common/ssl_verify.c b/common/ssl_verify.c index 24c6e2c..72a3dd8 100644 --- a/

[Spice-devel] [common PATCH 1/4 v2] ssl-verify: Only check addr length when using IP addr

Only check for address lenght, when connecting trough IP address. It is not used, when connecting trough DNS hostname. --- Changes since v1: - New patch - Wasn't moved in v1 --- common/ssl_verify.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/common/ssl_veri

[Spice-devel] [common PATCH 4/4 v2] ssl-verify: Changed debug msg from IPv4 to IPv6

Spice debug message printed only IPv4 addresses using inet_ntoa. Changed to inet_pton for IPv6 support. Can't use getnameinfo, because IP address in certificate is already in struct in(6)_addr format used by inet_ntop function. Added inet_ntop for Windows XP compatibility. --- Changes since v1:

[Spice-devel] [common PATCH 3/4 v2] ssl-verify: Changed IPv4 hostname to IPv6

Changed old inet_aton function for modern getaddrinfo. inet_aton only supported IPv4 addresses, and wasn't available on windows machines. getaddrinfo supports both IPv4 and IPv6 natively. --- Changes since v1: - Changed inet_pton() to getaddrinfo() - Removed inet_aton() compatibility function -

Re: [Spice-devel] [NSIS 7/8] Change installer filename

On Thu, Sep 10, 2015 at 4:20 PM, Christophe Fergeau wrote: > On Thu, Sep 10, 2015 at 03:14:14PM +0300, Yedidyah Bar David wrote: >> for ovirt use ovirt-guest-tools-setup >> > > This rename can probably be squashed in 1/8 ? > > >> Allow passing a custom DISPLAYED_VERSION and EXE_VERSION > > Can you

Re: [Spice-devel] [NSIS 4/8] packaging: Update installer to include new oVirt GA .ini files

On Thu, Sep 10, 2015 at 4:19 PM, Christophe Fergeau wrote: > On Thu, Sep 10, 2015 at 03:14:11PM +0300, Yedidyah Bar David wrote: >> From: Lev Veyde >> >> Recent version of oVirt Guest Agent added 2 new .ini conf files. >> This patch modifies the installer, so these files are installed >> as well.

Re: [Spice-devel] [NSIS 3/8] packaging: Re-enable NSIS branding

On Thu, Sep 10, 2015 at 4:18 PM, Christophe Fergeau wrote: > Do you know why we want it to be enabled? I don't really care either > way, just curious.. Not sure, Lev? > > Christophe > > On Thu, Sep 10, 2015 at 03:14:10PM +0300, Yedidyah Bar David wrote: >> From: Lev Veyde >> >> Change-Id: I8692

Re: [Spice-devel] Spice Using Problem

On Thu, Oct 08, 2015 at 09:55:18AM +0800, 395459...@qq.com wrote: > hi > when i use spicy with --spice-debug,i collect all the print information to > spice_error.txt, > can you find the problem with this file > thanks Nothing stands out from a quick look. Is it happening with recent spice-gtk re

Re: [Spice-devel] [spice-server] syntax-check: Exclude red_replay_qxl.c from sc_cast_of_argument_to_free

Hey, On Thu, Oct 08, 2015 at 10:18:08AM +0200, Christophe Fergeau wrote: > red_replay_qxl.c stores some pointers QXLPHYSICAL data members (ie > uint64_t), and then needs to free them, so the cast is required. > --- > cfg.mk | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/cfg.mk b/cfg.

Re: [Spice-devel] [ovirt-devel] ovirt-guest-agent behavior on disconnect

On 10/01/2015 02:47 AM, Vinzenz Feenstra wrote: On 09/30/2015 10:03 PM, Barak Azulay wrote: Barak On Sep 30, 2015, at 10:04, Michal Skrivanek <michal.skriva...@redhat.com> wrote: On Sep 25, 2015, at 19:40 , David Mansfield <

[Spice-devel] [spice-server] syntax-check: Exclude red_replay_qxl.c from sc_cast_of_argument_to_free

red_replay_qxl.c stores some pointers QXLPHYSICAL data members (ie uint64_t), and then needs to free them, so the cast is required. --- cfg.mk | 2 ++ 1 file changed, 2 insertions(+) diff --git a/cfg.mk b/cfg.mk index 7cf1d58..c935327 100644 --- a/cfg.mk +++ b/cfg.mk @@ -150,3 +150,5 @@ exclude_f

Re: [Spice-devel] [PATCH 04/10] syntax-check: Don't cast free() arguments

On Thu, Oct 08, 2015 at 07:41:47AM +0200, Victor Toso wrote: > Hi, > > On Wed, Oct 07, 2015 at 06:45:11PM +0200, Christophe Fergeau wrote: > > --- > > server/red_replay_qxl.c | 12 ++-- > > 1 file changed, 6 insertions(+), 6 deletions(-) > > > > diff --git a/server/red_replay_qxl.c b/ser