Re: [Spice-devel] spice-html5 is not compatible with the spice-guest-tools.

2016-01-28 Thread Fabio Fantoni
Il 29/01/2016 07:48, Pavel Grunt ha scritto: > Hi Melo, > > On Fri, 2016-01-29 at 11:10 +0800, 苏成才 wrote: >> Hi Grunt: >> Thanks for your reply, and I would like to support both spice-gtk >> and spice-html5, if I stop the server-side image compression, does it >> increase the network bandwidth

Re: [Spice-devel] spice-html5 is not compatible with the spice-guest-tools.

2016-01-28 Thread Pavel Grunt
Hi Melo, On Fri, 2016-01-29 at 11:10 +0800, 苏成才 wrote: > Hi Grunt: >     Thanks for your reply, and I would like to support both spice-gtk > and spice-html5, if I stop the server-side image compression, does it > increase the network bandwidth? It will increase the network bandwidth usage. The

Re: [Spice-devel] spice-html5 is not compatible with the spice-guest-tools.

2016-01-28 Thread 苏成才
Hi Grunt: Thanks for your reply, and I would like tosupport bothspice-gtkandspice-html5,if Istop the server-side image compression, does it increasethe network bandwidth? Another solution is uninstall the QXLdriver,will it affect themouse events and screendisplay(for example very slow)?

Re: [Spice-devel] [PATCH v6 04/10] win-usbredir: Move installer interaction logic to separate functions

2016-01-28 Thread Jonathon Jongsma
On Thu, 2015-10-29 at 17:26 +0200, Dmitry Fleytman wrote: > Signed-off-by: Dmitry Fleytman > --- > spice-common | 2 +- > src/usb-device-manager.c | 108 -- > - > 2 files changed, 66 insertions(+), 44 deletions(-) > > diff --git a/spice-c

Re: [Spice-devel] [PATCH v6 02/10] Simplify spice_usb_device_manager_device_to_libdev()

2016-01-28 Thread Jonathon Jongsma
Acked-by: Jonathon Jongsma On Thu, 2015-10-29 at 17:26 +0200, Dmitry Fleytman wrote: > From: Christophe Fergeau > > The Windows-specific version duplicates some code from > spice_usb_device_equal_libdev(), this commit > switches to using that helper instead. > --- > src/usb-device-manager.c |

Re: [Spice-devel] [PATCH v6 01/10] Simplify spice_usb_device_equal_libdev()

2016-01-28 Thread Jonathon Jongsma
Acked-by: Jonathon Jongsma On Thu, 2015-10-29 at 17:26 +0200, Dmitry Fleytman wrote: > From: Christophe Fergeau > > The Windows-specific version duplicates some code from > spice_usb_device_manager_libdev_match(), this commit > switches to using that helper instead. > --- > src/usb-device-man

Re: [Spice-devel] [PATCH] worker: unify flush_cursor_commands and flush_display_commands

2016-01-28 Thread Jonathon Jongsma
Acked-by: Jonathon Jongsma On Thu, 2016-01-28 at 16:15 +, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio > --- > server/red-worker.c | 75 +++- > - > 1 file changed, 26 insertions(+), 49 deletions(-) > > diff --git a/server/red-worke

Re: [Spice-devel] [PATCH 01/16] worker: use glib main loop

2016-01-28 Thread Frediano Ziglio
> > I've looked at this patch so many times now that it's hard to review it > objectively anymore ;) But it looks good to me. I think we still want the > follow-up patch that removes the pushing after this goes in, though. > > Acked-by: Jonathon Jongsma > Merged Time to celebrate! Fred

[Spice-devel] [PATCH] worker: unify flush_cursor_commands and flush_display_commands

2016-01-28 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- server/red-worker.c | 75 +++-- 1 file changed, 26 insertions(+), 49 deletions(-) diff --git a/server/red-worker.c b/server/red-worker.c index eb87813..90ece22 100644 --- a/server/red-worker.c +++ b/server/red-wor

Re: [Spice-devel] [PATCH v2 7/9] worker: unify flush_cursor_commands and flush_display_commands

2016-01-28 Thread Frediano Ziglio
> > On Tue, 2016-01-26 at 14:51 +0100, Pavel Grunt wrote: > > On Tue, 2016-01-26 at 09:44 +, Frediano Ziglio wrote: > > > Signed-off-by: Frediano Ziglio > > > --- > > > server/red-worker.c | 68 ++- > > > -- > > > 1 file changed, 23 insertions

Re: [Spice-devel] [PATCH 01/16] worker: use glib main loop

2016-01-28 Thread Jonathon Jongsma
I've looked at this patch so many times now that it's hard to review it objectively anymore ;) But it looks good to me. I think we still want the follow-up patch that removes the pushing after this goes in, though. Acked-by: Jonathon Jongsma On Wed, 2016-01-27 at 12:48 +, Frediano Ziglio w

[Spice-devel] [PATCH v2] tests: exit on SIGABRT

2016-01-28 Thread Frediano Ziglio
Fatal error exit usually with abort() causing SIGABRT to be triggered which can have problems with core dump generation depending on system settings. Capturing and exiting on this signal solve the problem. Signed-off-by: Frediano Ziglio --- tests/test-logging.c | 6 ++ 1 file changed, 6 inse

Re: [Spice-devel] [PATCH] tests: exit on SIGABRT

2016-01-28 Thread Frediano Ziglio
- Original Message - > From: "Christophe Fergeau" > To: "Frediano Ziglio" > Cc: spice-devel@lists.freedesktop.org > Sent: Thursday, January 28, 2016 2:55:04 PM > Subject: Re: [Spice-devel] [PATCH] tests: exit on SIGABRT > > Hey, > > On Thu, Jan 28, 2016 at 02:22:22PM +, Frediano Z

Re: [Spice-devel] [PATCH] tests: exit on SIGABRT

2016-01-28 Thread Christophe Fergeau
Hey, On Thu, Jan 28, 2016 at 02:22:22PM +, Frediano Ziglio wrote: > Fatal error exit usually with abort() causing SIGABRT to be triggered > which can have problems with core dump degeration depending on system degeration? generation? > settings. Capturing and exiting on this signal solve the

[Spice-devel] [PATCH spice v2 04/15] Remove global inputs channel

2016-01-28 Thread Pavel Grunt
From: Jonathon Jongsma Make the RedsState object own an InputsChannel object rather than having a global inputs channel. This means changing a lot of inputs-related API to take an InputsChannel* argument and moving the keyboard, mouse, and tablet objects into the InputsChannel object. --- v2: squ

Re: [Spice-devel] [PATCH 10/16] Move default_renderer into RedsState

2016-01-28 Thread Frediano Ziglio
> > On Wed, 2016-01-27 at 12:48 +, Frediano Ziglio wrote: > > From: Jonathon Jongsma > > > > Not global. > > Looking at PATCH 12/16: What is the usage of the field? It is > initialized in spice_server_new(), added to renderers in > spice_server_init() and cleared when spice_server_add_rend

Re: [Spice-devel] [PATCH 11/16] Fix crash when checking mouse mode

2016-01-28 Thread Frediano Ziglio
> > On Wed, 2016-01-27 at 12:48 +, Frediano Ziglio wrote: > > From: Jonathon Jongsma > > > > Since the mouse mode is now stored in the inputs channel, we were > > crashing when somebody was calling this API before the inputs channel > > was created. > > The same apply for more functions in

[Spice-devel] [PATCH] tests: exit on SIGABRT

2016-01-28 Thread Frediano Ziglio
Fatal error exit usually with abort() causing SIGABRT to be triggered which can have problems with core dump degeration depending on system settings. Capturing and exiting on this signal solve the problem. Signed-off-by: Frediano Ziglio --- tests/test-logging.c | 6 ++ 1 file changed, 6 inse

Re: [Spice-devel] [PATCH spice-common] Use lz4 if possible

2016-01-28 Thread Pavel Grunt
On Thu, 2016-01-28 at 12:16 +0100, Victor Toso wrote: > Hi, > On Wed, Jan 20, 2016 at 09:02:30AM +0100, Pavel Grunt wrote: > > Change the default option to "auto" > I really don't see any problem on having this > Acked-by: Victor Toso Thanks, pushed Pavel > > > --- > >  m4/spice-deps.m4 | 16 ++

Re: [Spice-devel] [PATCH 10/16] Move default_renderer into RedsState

2016-01-28 Thread Pavel Grunt
On Wed, 2016-01-27 at 12:48 +, Frediano Ziglio wrote: > From: Jonathon Jongsma > > Not global. Looking at PATCH 12/16: What is the usage of the field? It is initialized in spice_server_new(), added to renderers in spice_server_init() and cleared when spice_server_add_renderer() is called. Wh

Re: [Spice-devel] [PATCH 06/16] main_channel_init() -> main_channel_new()

2016-01-28 Thread Pavel Grunt
On Wed, 2016-01-27 at 12:48 +, Frediano Ziglio wrote: > From: Jonathon Jongsma > > Rename to make function name more consistent > > Acked-by: Frediano Ziglio Acked-by: Pavel Grunt > --- >  server/main-channel.c | 2 +- >  server/main-channel.h | 2 +- >  server/reds.c | 2 +- >  3 fil

Re: [Spice-devel] [PATCH 05/16] inputs_init() -> inputs_channel_new()

2016-01-28 Thread Pavel Grunt
On Wed, 2016-01-27 at 12:48 +, Frediano Ziglio wrote: > From: Jonathon Jongsma > > Rename function to be more consistent > > Acked-by: Frediano Ziglio Acked-by: Pavel Grunt > --- >  server/inputs-channel.c | 2 +- >  server/inputs-channel.h | 2 +- >  server/reds.c   | 2 +- >  3 file

Re: [Spice-devel] [PATCH 11/16] Fix crash when checking mouse mode

2016-01-28 Thread Pavel Grunt
On Wed, 2016-01-27 at 12:48 +, Frediano Ziglio wrote: > From: Jonathon Jongsma > > Since the mouse mode is now stored in the inputs channel, we were > crashing when somebody was calling this API before the inputs channel > was created. The same apply for more functions in inputs-channel.h, n

Re: [Spice-devel] [Xen-devel] Developers for virgl 3d windows guest support

2016-01-28 Thread Gerd Hoffmann
Hi, > About virtio-gpu using virgl3d project for 3d hw acceleration support > and is what I mainly watching for its large gpu choice/support, seems > any gpu that have a drm driver in host kernel is supported by virgl, or > I'm wrong? You need a mesa driver too. But, yes, pretty much any mo

Re: [Spice-devel] [PATCH spice-common] Use lz4 if possible

2016-01-28 Thread Victor Toso
Hi, On Wed, Jan 20, 2016 at 09:02:30AM +0100, Pavel Grunt wrote: > Change the default option to "auto" I really don't see any problem on having this Acked-by: Victor Toso > --- > m4/spice-deps.m4 | 16 +++- > 1 file changed, 11 insertions(+), 5 deletions(-) > > diff --git a/m4/spice

Re: [Spice-devel] spice-html5 is not compatible with the spice-guest-tools.

2016-01-28 Thread Pavel Grunt
Hi, On Thu, 2016-01-28 at 16:10 +0800, 苏成才 wrote: > Hi guys: > I encountered a problem: the windows screen cannot display properly > when use spice-html5, also the VM installed spice-guest-tools.exe. > But if i don't install the spice-guest-tools, then everything is ok. > My env is: > 1) spice-htm

Re: [Spice-devel] UsbDk-related patches

2016-01-28 Thread Chris Dickens
Hi, I have addressed this issue with commit c8f71151. Regards, Chris On Wed, Jan 27, 2016 at 6:06 AM, Dmitry Fleytman wrote: > > > Sent from my iPhone > >> On 27 Jan 2016, at 15:58, Christophe Fergeau wrote: >> >>> On Wed, Jan 27, 2016 at 02:09:25PM +0200, Dmitry Fleytman wrote: >>> On 27

Re: [Spice-devel] [Xen-devel] Developers for virgl 3d windows guest support

2016-01-28 Thread Fabio Fantoni
Il 27/01/2016 19:37, Konrad Rzeszutek Wilk ha scritto: On Tue, Jan 26, 2016 at 05:48:34PM +0100, Fabio Fantoni wrote: I take a fast look to virgl 3d project even if I not tested it for now. It seems interesting for adding 2d and 3d hw acceleration support to virtual machines with a large hw (gpu

Re: [Spice-devel] [PATCH v9 00/24] Add GStreamer support for video streaming

2016-01-28 Thread Pavel Grunt
Hi, sorry for the late reply. On Mon, 2016-01-25 at 20:45 +0100, Francois Gouget wrote: > On Thu, 21 Jan 2016, Pavel Grunt wrote: > [...] > > > I have never tested it with the replay functionality so I don't > > > know of  > > > any compatibility issue. So in theory access to the replay log > > >

Re: [Spice-devel] UsbDk-related patches

2016-01-28 Thread Christophe Fergeau
On Wed, Jan 27, 2016 at 11:49:28AM -0800, Chris Dickens wrote: > Hi, > > I have addressed this issue with commit c8f71151. Great, thanks, looks good to me! Christophe signature.asc Description: PGP signature ___ Spice-devel mailing list Spice-devel@l