Re: [Spice-devel] [spice-server 7/8] Use more explicit variable name in marshall_gl_scanout()

2016-03-15 Thread Frediano Ziglio
> > --- > server/dcc-send.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/server/dcc-send.c b/server/dcc-send.c > index a1f9214..eb866cf 100644 > --- a/server/dcc-send.c > +++ b/server/dcc-send.c > @@ -2307,12 +2307,12 @@ static void marshall_gl_scanout(RedChan

Re: [Spice-devel] [spice-server 5/8] Use QXLInstance instead of QXLState in red_qxl_*

2016-03-15 Thread Frediano Ziglio
> > This seems to make more sense this way, QXLInstance is the 'main' object > with QXLState being its private data. External users then use QXLInstance > rather than passing a pointer to the private data to red-qxl.h methods. > --- > server/dcc-send.c| 4 +- > server/display-channel.c

Re: [Spice-devel] [spice-server 4/8] Fix typo in variable name in function prototype

2016-03-15 Thread Frediano Ziglio
> > num_common_cap rather than num_common_caps was not consistent with > the naming of the other arguments. > --- > server/red-channel.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/server/red-channel.h b/server/red-channel.h > index 51d606e..ca06b4a 100644 > --- a/se

Re: [Spice-devel] [spice-server 2/8] Move RedChannel::data to ClientCbs::cbs_data

2016-03-15 Thread Frediano Ziglio
> > It's only used by these callbacks, moving it there makes things clearer > about its intended use. > --- > server/inputs-channel.c | 5 +++-- > server/main-channel.c | 2 +- > server/red-channel.c| 24 +--- > server/red-channel.h| 9 - > server/red-qxl.

Re: [Spice-devel] [PATCH v7 08/14] UsbDeviceManager: Implement asynchronous disconnect device flow

2016-03-15 Thread Jonathon Jongsma
Rebased patch using GTask: From 77c450ee865f8afb02bb03527fb507b22850f93a Mon Sep 17 00:00:00 2001 From: Kirill Moizik Date: Tue, 8 Mar 2016 16:05:55 +0200 Subject: [PATCH spice-gtk 08/14] UsbDeviceManager: Implement asynchronous disconnect device flow This commit introduces

Re: [Spice-devel] [PATCH v7 07/14] UsbDeviceManager: Track device redirection operations in progress

2016-03-15 Thread Jonathon Jongsma
Rebased patch using GTask - From 1ec5a45896cf0d3372cfcd426cfe1a163281c63b Mon Sep 17 00:00:00 2001 From: Kirill Moizik Date: Tue, 8 Mar 2016 16:05:54 +0200 Subject: [PATCH spice-gtk 07/14] UsbDeviceManager: Track device redirection operations in progress During device connec

Re: [Spice-devel] [PATCH v7 06/14] usbredir: Spawn a different thread for device redirection flow

2016-03-15 Thread Jonathon Jongsma
On Thu, 2016-03-10 at 14:08 -0600, Jonathon Jongsma wrote: > Looks good now > > Acked-by: Jonathon Jongsma ...Except I rebased this series on top of Fabiano's GTask work, and here's the patch after switching from GSimpleAsyncResult to GTask: --- From a6769470dfbf9bcc8243d9db1039b8

Re: [Spice-devel] [spice-server 3/8] Remove unused red_qxl_set_dispatcher_opaque

2016-03-15 Thread Frediano Ziglio
> > --- > server/red-qxl.c | 6 -- > 1 file changed, 6 deletions(-) > > diff --git a/server/red-qxl.c b/server/red-qxl.c > index f720fd5..408159d 100644 > --- a/server/red-qxl.c > +++ b/server/red-qxl.c > @@ -1005,12 +1005,6 @@ struct Dispatcher *red_qxl_get_dispatcher(QXLState > *qxl_state)

Re: [Spice-devel] [PATCH spice-gtk] build-sys: fix 'Only can be included directly' warning

2016-03-15 Thread Fabiano Fidêncio
On Tue, Mar 15, 2016 at 12:39 PM, Marc-André Lureau wrote: > Tests should be allowed to include directly private headers. Set > __SPICE_CLIENT_H_INSIDE__ where necessary or include spice-client.h > where possible. > > Signed-off-by: Marc-André Lureau > --- > tests/session.c | 4 +--- > tests/uti

Re: [Spice-devel] [PATCH v3 0/2] Lower gtk+ requirement

2016-03-15 Thread Fabiano Fidêncio
On Tue, Mar 15, 2016 at 12:03 PM, Marc-André Lureau wrote: > In order to build spice-gtk on current rhel7. > > (in general, spice-gtk is a GNOME desktop library and should thus be > allowed to follow the GNOME schedule and require recent gtk+, but for > various reasons, it helps to keep building o

Re: [Spice-devel] [PATCH v2 08/10] gtk: require gtk+ 3.16

2016-03-15 Thread Christophe Fergeau
On Tue, Mar 15, 2016 at 07:15:53AM -0400, Marc-André Lureau wrote: > Hi > > - Original Message - > > > If need be, we could lower gtk3 requirement to 3.10 (droping wayland > > > support in this case). Afaik, 3.16 is going to make it in rhel7 as > > > part of regular desktop rebase. > > >

Re: [Spice-devel] [PATCH v2 08/10] gtk: require gtk+ 3.16

2016-03-15 Thread Marc-André Lureau
Hi - Original Message - > > gtkglarea and found out that it just worked. And since recent gtk+ is > > required for wayland, depending on gtkglarea sounds like the best move > > forward anyway. But anyone, feel free to fix gl support on wayland > > with gtk 3.10. > > 3.10 + wayland isn't g

Re: [Spice-devel] [PATCH v2 08/10] gtk: require gtk+ 3.16

2016-03-15 Thread Gerd Hoffmann
Hi, > > Dropping wayland isn't an option I think. Is it possible to build > > with/without glarea support (depending on the installed gtk version) and > > hiding that from applications without too much fuss? I.e. with the > > glarea widget being a child of the new gtkstack widget, can we swap

[Spice-devel] [PATCH spice-gtk] build-sys: fix 'Only can be included directly' warning

2016-03-15 Thread Marc-André Lureau
Tests should be allowed to include directly private headers. Set __SPICE_CLIENT_H_INSIDE__ where necessary or include spice-client.h where possible. Signed-off-by: Marc-André Lureau --- tests/session.c | 4 +--- tests/util.c| 1 + 2 files changed, 2 insertions(+), 3 deletions(-) diff --git

Re: [Spice-devel] [PATCH v2 08/10] gtk: require gtk+ 3.16

2016-03-15 Thread Marc-André Lureau
Hi - Original Message - > > If need be, we could lower gtk3 requirement to 3.10 (droping wayland > > support in this case). Afaik, 3.16 is going to make it in rhel7 as > > part of regular desktop rebase. > > I think we should continue to support older 3.x versions for a while. I just sen

Re: [Spice-devel] [PATCH 14/15] smartcard: Move private constant to C file

2016-03-15 Thread Christophe Fergeau
On Thu, Mar 10, 2016 at 12:36:04PM +0100, Pavel Grunt wrote: > On Thu, 2016-03-10 at 05:40 -0500, Frediano Ziglio wrote: > > > > > > > > > On Wed, 2016-03-09 at 16:28 +, Frediano Ziglio wrote: > > > > > > > > From: Christophe Fergeau > > > > > > > > APDUBufSize is only used within smartcar

[Spice-devel] [PATCH v3 1/2] build-sys: remove epoxy from pc requires

2016-03-15 Thread Marc-André Lureau
libepoxy doesn't need to figure in spice-gtk pkg-config requires, it's a private dependency. Signed-off-by: Marc-André Lureau --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 6983b6b..052561a 100644 --- a/configure.ac +++ b/co

[Spice-devel] [PATCH v3 0/2] Lower gtk+ requirement

2016-03-15 Thread Marc-André Lureau
In order to build spice-gtk on current rhel7. (in general, spice-gtk is a GNOME desktop library and should thus be allowed to follow the GNOME schedule and require recent gtk+, but for various reasons, it helps to keep building on rhel7 too when possible) Marc-André Lureau (2): build-sys: remov

[Spice-devel] [PATCH v3 2/2] Lower gtk+ requirement to 3.10

2016-03-15 Thread Marc-André Lureau
Make GtkGlArea optional allows to lower gtk+ requirement to 3.10 (required for GtkStack). However, gl display is unsupported on wayland with gtk+ < 3.16. Signed-off-by: Marc-André Lureau --- configure.ac | 4 ++-- src/spice-widget-egl.c | 2 ++ src/spice-widget.c | 12 ++-

Re: [Spice-devel] [PATCH 05/15] Remove dependency of vdi_port_read_buf_process on RedsState

2016-03-15 Thread Christophe Fergeau
On Thu, Mar 10, 2016 at 12:17:19PM -0500, Frediano Ziglio wrote: > > > > From: Christophe Fergeau > > > > This makes it easier to move the VDIPort API to a different file, and > > make it as self-contained as possible. > > --- > > server/reds.c | 27 +++ > > 1 file chang

[Spice-devel] SPICE WDDM driver Windows 10

2016-03-15 Thread Jean-Marie Perron
Hi, I posed the question Ovirt-users. I was told to ask the question here. Is it planned a development of WDDM driver for Windows 10 fully support with SPICE ? Thanks, Jean-Marie ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org https

Re: [Spice-devel] [ovirt-users] Windows 10

2016-03-15 Thread Christophe Fergeau
Hey, On Fri, Mar 11, 2016 at 02:17:27PM +0100, Sandro Bonazzola wrote: > On Fri, Mar 11, 2016 at 10:48 AM, Uwe Laverenz wrote: > > > Hi, > > > > Am 10.03.2016 um 17:18 schrieb Jean-Marie Perron: > > > >> Hello, > >> > >> OVirt 3.6.3 is installed on CentOS 7. > >> > >> I use 64-bit Windows 10 cli

Re: [Spice-devel] [PATCH v2 08/10] gtk: require gtk+ 3.16

2016-03-15 Thread Gerd Hoffmann
On Mo, 2016-03-14 at 12:03 -0400, Marc-André Lureau wrote: > Hi > > - Original Message - > > On Fr, 2016-03-11 at 21:50 +0100, Marc-André Lureau wrote: > > > 3.16 is the minimal version for GtkGLArea widget, used in following > > > patches. > > > > > - 3.0) GTK_REQUIRED=2.91.3 > > > + 3