[Spice-devel] [spice-gtk] channel-usbredir: Fix crash due to a Task returning earlier than expected

g_task_return_error() has been completing the task immediately, not cleaning up/setting up the device state to STATE_DISCONNECTED. It's been causing a double free when trying to redirect a device without having the ACL permissions for doing it. See the backtrace: #0 0x724dc07d in

[Spice-devel] [PATCH] usbredir_handle_msg: rename data to err_data

To better reflect what this variable is used for and change the declare location such that it will be declared only if it should --- src/channel-usbredir.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/channel-usbredir.c b/src/channel-usbredir.c index

Re: [Spice-devel] [PATCH v7 06/14] usbredir: Spawn a different thread for device redirection flow

On Sun, Mar 20, 2016 at 12:19 PM, Dmitry Fleytman wrote: > Hi Jonathon, > > Sure, I’ll test. > I tried to build your branch but it requires newer spice-protocol: > > configure: error: Package requirements (spice-protocol >= 0.12.11) were not > met: > Requested 'spice-protocol

Re: [Spice-devel] [PATCH v7 06/14] usbredir: Spawn a different thread for device redirection flow

Updated proposal: --- a/src/channel-usbredir.c +++ b/src/channel-usbredir.c @@ -368,16 +368,19 @@ _open_device_async_cb(GTask *task, spice_usbredir_channel_lock(channel); if (!spice_usbredir_channel_open_device(channel, )) { -g_task_return_error(task, err);

Re: [Spice-devel] [PATCH v7 06/14] usbredir: Spawn a different thread for device redirection flow

Hi Jonathon, Sure, I’ll test. I tried to build your branch but it requires newer spice-protocol: configure: error: Package requirements (spice-protocol >= 0.12.11) were not met: Requested 'spice-protocol >= 0.12.11' but version of spice-protocol is 0.12.10 Do you have any idea where one can get

Re: [Spice-devel] spice update_area and handle_dev_update_async

Hey, On Thu, Mar 17, 2016 at 02:05:30PM +0800, feihu...@sina.com wrote: > In Windows or Linux guest os with qxl video card, when some window, > button or label call frequently update, the remote spice client will > display error background . The window, button or label will draw > background

Re: [Spice-devel] [phodav PATCH 5/7 v3] spice-webdavd-windows: Automount shared folder

Hi Lukas, On Thu, 2016-03-17 at 14:47 +0100, Lukas Venhoda wrote: > Try to connect to shared folder automatically on Windows. > > On each loop of run_service(), run a GTask, that waits for 0.5s. > If sharing is disabled, read_thread will immediately return and cause > the main_loop to stop. >

Re: [Spice-devel] [PATCH 1/2] define SPICE_CONSTRUCTOR_FUNC and SPICE_DESTRUCTOR_FUNC macros

Hi, On Wed, Mar 16, 2016 at 11:52:55AM -0400, Frediano Ziglio wrote: > > > > Hi, > > > > On Mon, Feb 29, 2016 at 10:36:53AM +, Frediano Ziglio wrote: > > > Allow to define functions executed at program/shared object initialization > > > or close. > > > > > > Signed-off-by: Frediano Ziglio

Re: [Spice-devel] [spice-server 5/8] Use QXLInstance instead of QXLState in red_qxl_*

On Tue, 2016-03-15 at 17:25 -0400, Frediano Ziglio wrote: > > > > This seems to make more sense this way, QXLInstance is the 'main' object > > with QXLState being its private data. External users then use QXLInstance > > rather than passing a pointer to the private data to red-qxl.h methods. > >

[Spice-devel] [PATCH spice-gtk 2/3] spice-display: Remove auto-clipboard notify

It was used to notify the (deprecated) auto-clipboard property of the SpiceDisplay everytime the SpiceGtkSession emits its auto-clipboard notify. The commit 70a00b8fcc2ca85d3601f6ac4895f906f9032e77 removed the property from SpiceDisplay causing a runtime warning: GLib-GObject-WARNING **: