Re: [Spice-devel] 答复: remote-viewer usb redirection

Please, On Wed, Mar 23, 2016 at 3:08 AM, lichanghua wrote: > Maybe it is, but I try to recompile the spice-gtk and virt-viewer, I can't > get correct result, Do anyone have the remote-viewer version supported > USB_redirection in windows OS. thanks very much! These kind of

Re: [Spice-devel] [spice-gtk v3] vmcstream, gtask: Do idle ourself instead of leaving it to GTask's heuristic

Hi, On Tue, Mar 22, 2016 at 10:33:56PM +0100, Fabiano Fidêncio wrote: > Seems that GTask heuristic only makes sense in a non-coroutine case. > After opening a bug[0] on spice-gtk and a few discussions in the mailing [0] ? > list, seems that is completely fine for coroutine code to deal with the

Re: [Spice-devel] [spice-gtk v3] vmcstream, gtask: Do idle ourself instead of leaving it to GTask's heuristic

On Tue, Mar 22, 2016 at 10:57 PM, Marc-André Lureau wrote: > ack > > - Original Message - >> Seems that GTask heuristic only makes sense in a non-coroutine case. >> After opening a bug[0] on spice-gtk and a few discussions in the mailing >> list, seems that is

Re: [Spice-devel] [spice-gtk v3] vmcstream, gtask: Do idle ourself instead of leaving it to GTask's heuristic

Pushed, thanks! On Tue, Mar 22, 2016 at 11:01 PM, Fabiano Fidêncio wrote: > On Tue, Mar 22, 2016 at 10:57 PM, Marc-André Lureau > wrote: >> ack >> >> - Original Message - >>> Seems that GTask heuristic only makes sense in a non-coroutine case.

Re: [Spice-devel] [spice-gtk v3] vmcstream, gtask: Do idle ourself instead of leaving it to GTask's heuristic

ack - Original Message - > Seems that GTask heuristic only makes sense in a non-coroutine case. > After opening a bug[0] on spice-gtk and a few discussions in the mailing > list, seems that is completely fine for coroutine code to deal with the > idle explicitly. > > Signed-off-by:

[Spice-devel] [spice-gtk v3] vmcstream, gtask: Do idle ourself instead of leaving it to GTask's heuristic

Seems that GTask heuristic only makes sense in a non-coroutine case. After opening a bug[0] on spice-gtk and a few discussions in the mailing list, seems that is completely fine for coroutine code to deal with the idle explicitly. Signed-off-by: Fabiano Fidêncio --- Changes

Re: [Spice-devel] remote-viewer usb redirection

On Fri, Mar 18, 2016 at 3:24 PM, lichanghua wrote: > Dear all, > > I setup the kvm virtual machine, which support the spice. I use > remote-viewer to access it , it is ok! but when I click the usb redir icon, > a pop window shows, it told me "the usb redirection support

Re: [Spice-devel] [spice-gtk v2] vmcstream, gtask: Do idle ourself as GTask's return gets messed up

Hi - Original Message - > Seems that our coroutines can mess up with GTask's return, ending up > in an early return from g_task_return_now() instead of doing a return > in idle. > As I still don't know if the bug is on spice-gtk or on GTask itself, > I've opened a bug[0] in spice-gtk's

[Spice-devel] [spice-gtk v2] vmcstream, gtask: Do idle ourself as GTask's return gets messed up

Seems that our coroutines can mess up with GTask's return, ending up in an early return from g_task_return_now() instead of doing a return in idle. As I still don't know if the bug is on spice-gtk or on GTask itself, I've opened a bug[0] in spice-gtk's bugzilla and also made a reference to the

Re: [Spice-devel] [spice-gtk] vmcstream, gtask: Do idle ourself as GTask's return gets messed up

On Tue, Mar 22, 2016 at 8:40 PM, Marc-André Lureau wrote: > Hi > > - Original Message - >> Seems that our coroutines can mess up with GTask's return, ending up >> in an early return from g_task_return_now() instead of doing a return >> in idle. >> As I still don't know

Re: [Spice-devel] [spice-gtk] vmcstream, gtask: Fix crash when trying to use webdav

On Tue, Mar 22, 2016 at 1:43 PM, Victor Toso wrote: > Interesting that I don't get the crash with remote-viewer, probably > because the shared-folder is not started by default as it is with spicy. > I thought it would be interesting to add here. > > Acked-by: Victor Toso

Re: [Spice-devel] [spice-gtk] vmcstream, gtask: Do idle ourself as GTask's return gets messed up

Hi - Original Message - > Seems that our coroutines can mess up with GTask's return, ending up > in an early return from g_task_return_now() instead of doing a return > in idle. > As I still don't know if the bug is on spice-gtk or on GTask itself, > I've opened a bug[0] in spice-gtk's

[Spice-devel] [spice-gtk] vmcstream, gtask: Do idle ourself as GTask's return gets messed up

Seems that our coroutines can mess up with GTask's return, ending up in an early return from g_task_return_now() instead of doing a return in idle. As I still don't know if the bug is on spice-gtk or on GTask itself, I've opened a bug[0] in spice-gtk's bugzilla and also made a reference to the

[Spice-devel] remote-viewer usb redirection

Dear all, I setup the kvm virtual machine, which support the spice. I use remote-viewer to access it , it is ok! but when I click the usb redir icon, a pop window shows, it told me "the usb redirection support not compiled", where can I download the new version with the usb redirction

[Spice-devel] [PATCH spice-gtk 1/2] widget: offset draw updates by widget allocation if necessary

According to gtk_widget_queue_draw_area() documentation: "The region here is specified in widget coordinates. Widget coordinates are a bit odd; for historical reasons, they are defined as widget->window coordinates for widgets that return TRUE for gtk_widget_get_has_window(), and are relative to

Re: [Spice-devel] [PATCH spice-gtk] Include gdk/gdkwayland.h anytime GDK_WINDOWING_WAYLAND is defined.

ack and pushed On Tue, Mar 22, 2016 at 3:14 PM, Jeremy White wrote: > A specific GTK version check is not appropriate for this particular include. > This fixes compilation on Debian Jessie. > > Signed-off-by: Jeremy White > --- >

[Spice-devel] [PATCH spice-gtk] Include gdk/gdkwayland.h anytime GDK_WINDOWING_WAYLAND is defined.

A specific GTK version check is not appropriate for this particular include. This fixes compilation on Debian Jessie. Signed-off-by: Jeremy White --- src/spice-widget-egl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/spice-widget-egl.c

Re: [Spice-devel] [PATCH v3 2/2] Lower gtk+ requirement to 3.10

On 03/22/2016 08:33 AM, Marc-André Lureau wrote: > Hi > > - Original Message - >> Hi, >> >>> diff --git a/src/spice-widget-egl.c b/src/spice-widget-egl.c >>> index 1b3cd07..a9bea52 100644 >>> --- a/src/spice-widget-egl.c >>> +++ b/src/spice-widget-egl.c >>> @@ -29,7 +29,9 @@ >>> #include

Re: [Spice-devel] [PATCH v3 2/2] Lower gtk+ requirement to 3.10

Hi - Original Message - > Hi, > > > diff --git a/src/spice-widget-egl.c b/src/spice-widget-egl.c > > index 1b3cd07..a9bea52 100644 > > --- a/src/spice-widget-egl.c > > +++ b/src/spice-widget-egl.c > > @@ -29,7 +29,9 @@ > > #include > > > > #include > > +#if

[Spice-devel] [PATCH spice-gtk v2 6/8] egl: check and update scanout after egl init

Once the egl/GL context are initialized, check if there is a scanout to associate to display widget. This solves races when scanout update is happening before the egl/GL context is ready. Signed-off-by: Marc-André Lureau --- src/spice-widget-egl.c | 5 + 1 file

[Spice-devel] [PATCH spice-gtk v2 5/8] widget: make gl-scanout and update-monitor-area privately exported

The following changes will call these functions from spice-widget-egl.c Signed-off-by: Marc-André Lureau --- src/spice-widget-priv.h | 3 +++ src/spice-widget.c | 17 +++-- 2 files changed, 14 insertions(+), 6 deletions(-) diff --git

[Spice-devel] [PATCH spice-gtk v2 4/8] display: return NULL in spice_display_get_gl_scanout()

If there is no valid scanout, return NULL. Signed-off-by: Marc-André Lureau --- src/channel-display.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/channel-display.c b/src/channel-display.c index 2c54df7..90d155e 100644 ---

[Spice-devel] [PATCH spice-gtk v2 8/8] widget: modify update-area to not require primary surface

If egl display is enabled, use GL scanout geometry to check intersection with the monitor area. This solves displaying GL display without software canvas. Signed-off-by: Marc-André Lureau --- src/spice-widget.c | 41 - 1 file

[Spice-devel] [PATCH spice-gtk v2 1/8] widget: remove superflous WIN32 check

The egl call is already inside a X11 conditional block. Signed-off-by: Marc-André Lureau --- src/spice-widget.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/spice-widget.c b/src/spice-widget.c index e329809..c8bb72c 100644 --- a/src/spice-widget.c +++

[Spice-devel] [PATCH spice-gtk v2 7/8] widget: update d->ready based on scanout image available

d->ready is updated based on monitor area & canvas. In case of GL rendering, update it based on monitor area & scanout and add check before drawing update. Signed-off-by: Marc-André Lureau --- src/spice-widget-egl.c | 6 ++ src/spice-widget.c | 6 +- 2

[Spice-devel] [PATCH spice-gtk v2 0/8] Various GL fixes

The following series fixes GL-only display (when there is no 2d primary canvas at all). A few cleanups also fix Wayland display. v1->v2: - fix mingw build - add a patch to enable egl before updating scanout - fix wayland display Marc-André Lureau (8): widget: remove superflous WIN32 check

[Spice-devel] [PATCH spice-gtk v2 3/8] widget: enable egl before updating scanout

The GLArea is realized lazily, when it is made visible in set_egl_enabled(). The egl context is initialized once the GLArea is realized. Enable egl before updating the scanout. Signed-off-by: Marc-André Lureau --- src/spice-widget.c | 6 +++--- 1 file changed, 3

[Spice-devel] [PATCH spice-gtk v2 2/8] egl: check context is ready

Add a new GL status field to check if the GL context is ready. This helps debugging races where GL is called before the context is ready. Signed-off-by: Marc-André Lureau --- src/spice-widget-egl.c | 10 -- src/spice-widget-priv.h | 1 + src/spice-widget.c

Re: [Spice-devel] [spice-gtk] vmcstream, gtask: Fix crash when trying to use webdav

Interesting that I don't get the crash with remote-viewer, probably because the shared-folder is not started by default as it is with spicy. I thought it would be interesting to add here. Acked-by: Victor Toso On Tue, Mar 22, 2016 at 01:01:30PM +0100, Pavel Grunt wrote: >

Re: [Spice-devel] [PATCH spice-gtk 1/7] widget: remove superflous WIN32 check

On Mon, 2016-03-21 at 19:14 +0100, Marc-André Lureau wrote: > The egl call is already inside a X11 conditional block. > > Signed-off-by: Marc-André Lureau Acked-by: Pavel Grunt > --- >  src/spice-widget.c | 2 -- >  1 file changed, 2 deletions(-) >

Re: [Spice-devel] [spice-gtk] vmcstream, gtask: Fix crash when trying to use webdav

Ack.  Pavel On Mon, 2016-03-21 at 16:02 +0100, Fabiano Fidêncio wrote: > Don't try to get the cancellable from a task that is, for sure > (ensured > by us), NULL. See the backtrace: > >  #0  0x729cf250 in g_task_get_cancellable () at > /lib64/libgio-2.0.so.0 >  #1  0x778a9012 in

Re: [Spice-devel] [PATCH] usbredir_handle_msg: rename data to err_data

On Mon, 2016-03-21 at 12:07 +0100, Victor Toso wrote: > On Sun, Mar 20, 2016 at 03:03:41PM +0200, Snir Sheriber wrote: > > > > To better reflect what this variable is used for and change the > > declare > > location such that it will be declared only if it should > Acked-by: Victor Toso

Re: [Spice-devel] [PATCH spice-gtk] Remove extra checks before g_cancellable_disconnect()

Hi, On Mon, Mar 21, 2016 at 01:50:55PM +0100, Pavel Grunt wrote: > If cancellable is NULL or handler_id is 0 the function does nothing. Acked-by: Victor Toso > --- > src/spice-pulse.c | 4 +--- > src/vmcstream.c | 15 +++ > 2 files changed, 4

Re: [Spice-devel] [PATCH v7 06/14] usbredir: Spawn a different thread for device redirection flow

Hi All, I compiled and tested the current code. For my scenarios it is working Ok. Please let me know if you need any additional help from me. Thanks, Dmitry > On 21 Mar 2016, at 17:19 PM, Fabiano Fidêncio wrote: > > On Mon, Mar 21, 2016 at 10:58 AM, Fabiano Fidêncio

Re: [Spice-devel] [PATCH] char-device: Add helpers for SpiceCharDeviceCallbacks vfuncs

On Mon, 2016-03-21 at 13:23 +, Frediano Ziglio wrote: > From: Christophe Fergeau > > Add helper functions wrapping calls to the virtual functions > defined in SpiceCharDeviceCallbacks. > --- >  server/char-device.c | 78 +- >