Re: [Spice-devel] [PATCH 10/14] Mark unused public API methods/code as deprecated

This one looks fine to me now Acked-by: Jonathon Jongsma On Thu, 2016-04-21 at 16:43 -0500, Jonathon Jongsma wrote: > From: Christophe Fergeau > > --- > Changes since last version: > - split out debug warnings from this patch > > server/spice-migration.h | 6 +++--- > server/spice-server.h

Re: [Spice-devel] [PATCH 05/14] Use weak gobject ref instead of reds_on_char_device_state_destroy

Acked-by: Jonathon Jongsma On Thu, 2016-04-21 at 16:43 -0500, Jonathon Jongsma wrote: > From: Christophe Fergeau > > RedCharDevice implementation had to callback into reds.c in order to let > it know a char device was being destroyed. Now that RedCharDevice is a > gobject, a weak reference can

[Spice-devel] [PATCH v2] Store display in Drawable struct

If the Drawable keeps a pointer to the Display channel that it is associated with, we can unref it directly and not need to pass the 'display' parameter separately to the unref function --- Changes: - remove 'dcc' parameer from release_item_after_push() I agree that additional changes / cleanups

Re: [Spice-devel] [PATCH spice] worker: remove check for canvas during cursor connect

Acked-by: Frediano Ziglio The check looks to come from the first commit in the repository (was checking worker->attached). Even looking at first commit was not clear why the check was there. Frediano > > ping > > On Mon, Mar 21, 2016 at 6:07 PM, Marc-André Lureau > wrote: > > We want the cu

Re: [Spice-devel] [PATCH spice] worker: remove check for canvas during cursor connect

ping On Mon, Mar 21, 2016 at 6:07 PM, Marc-André Lureau wrote: > We want the cursor to be initialized even if there is no canvas, > especially when using a GL scanout. This solves some client warnings > when using qemu with GL scanout-only (patches under review on qemu ML). > > Signed-off-by: Mar

Re: [Spice-devel] [PATCH] Fix make dist

pushed On 04/26/2016 02:24 AM, Pavel Grunt wrote: > On Mon, 2016-04-25 at 17:21 -0300, Eduardo Lima (Etrunko) wrote: >> spicec screenshot has been removed since commit >> b0186fe1267dfa2b8534c7c083dc301791279f08 >> >> Signed-off-by: Eduardo Lima (Etrunko) > Acked-by: Pavel Grunt > > Thanks, > P

Re: [Spice-devel] [PATCH spice-gtk 2/2] channel: Abort migration in delayed unref

Hi, On Tue, 2016-04-26 at 12:05 +0200, Victor Toso wrote: > Hi, > > On Fri, Apr 22, 2016 at 04:47:48PM +0200, Pavel Grunt wrote: > > When channel is unref'ed during migration migrate_channel_event_cb > > is called causing a crash by coroutine yielding to nonexistent channel. > > > > As comment i

Re: [Spice-devel] [PATCH] Attempt to manage redirection in a way similar to Unix

ping - Original Message - > > This patch allows remote-viewer to redirect output/error streams to > files. > Also if launched from a console program (for instance from the command > prompt) you are able to see output from the console where you launch > the program. > This allow to launch

Re: [Spice-devel] [PATCH spice-gtk 2/2] channel: Abort migration in delayed unref

Hi, On Fri, Apr 22, 2016 at 04:47:48PM +0200, Pavel Grunt wrote: > When channel is unref'ed during migration migrate_channel_event_cb > is called causing a crash by coroutine yielding to nonexistent channel. > > As comment in spice_channel_coroutine says: > Co-routine exits now - the SpiceChanne

Re: [Spice-devel] [PATCH spice-gtk 1/2] channel-main: Use CHANNEL_DEBUG for migration events

On Fri, Apr 22, 2016 at 04:47:47PM +0200, Pavel Grunt wrote: > To show which channel got an error or an unhandled event Acked-by: Victor Toso > --- > src/channel-main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/channel-main.c b/src/channel-main.c > index 604f

[Spice-devel] Still Failing: SPICE/spice#23 (master - b0186fe)

Build Update for SPICE/spice - Build: #23 Status: Still Failing Duration: 2 minutes and 56 seconds Commit: b0186fe (master) Author: Pavel Grunt Message: manual: Remove spicec screenshot View the changeset: https://github.com/SPICE/spice/compare/a21a81b994b7..

[Spice-devel] Canceled: SPICE/spice#25 (0.12 - 5bcb3b6)

Build Update for SPICE/spice - Build: #25 Status: Canceled Duration: 7 seconds Commit: 5bcb3b6 (0.12) Author: Christophe Fergeau Message: Revert "Set TCP_KEEPINTVL when enabling TCP keepalive" This reverts commit 3336d892c3d8647868423300905e5cad67de1db1. This

[Spice-devel] Failed: SPICE/spice#22 (v0.13.1 - 7d616b3)

Build Update for SPICE/spice - Build: #22 Status: Failed Duration: 2 minutes and 53 seconds Commit: 7d616b3 (v0.13.1) Author: Christophe Fergeau Message: char-device: Fix el6 compilation One more duplicate typedef, once in reds.c and another time in reds-priva

[Spice-devel] Failed: SPICE/spice#24 (v0.13.0 - 6e66366)

Build Update for SPICE/spice - Build: #24 Status: Failed Duration: 5 minutes and 2 seconds Commit: 6e66366 (v0.13.0) Author: Christophe Fergeau Message: Update NEWS for 0.13.0 release View the changeset: https://github.com/SPICE/spice/compare/v0.13.0 View the

[Spice-devel] Passed: SPICE/libcacard#11 (v2.5.2 - 998db1e)

Build Update for SPICE/libcacard - Build: #11 Status: Passed Duration: 53 seconds Commit: 998db1e (v2.5.2) Author: Marc-André Lureau Message: Remove libcacard.h warning qemu.git uses -Werror by default, and this is problematic as 2.5.0 doesn't use libcacard.h

Re: [Spice-devel] [spice-gtk PATCH v2] Usbredir: enable lz4 compression

On Tue, Apr 26, 2016 at 10:44:54AM +0200, Victor Toso wrote: > Hi, > > On Sun, Apr 10, 2016 at 05:24:23PM +0300, Snir Sheriber wrote: > > Compressed message type is CompressedData which contains compression > > type (1 byte) followed by the uncompressed data size (4 bytes) followed > > by the comp

Re: [Spice-devel] [spice-gtk PATCH v2] Usbredir: enable lz4 compression

Hi, On Sun, Apr 10, 2016 at 05:24:23PM +0300, Snir Sheriber wrote: > Compressed message type is CompressedData which contains compression > type (1 byte) followed by the uncompressed data size (4 bytes) followed > by the compressed data size (4 bytes) followed by the compressed data > > If SPICE_