Re: [Spice-devel] [PATCH] red-parse-qxl: Check consistency of QXL_DRAW_COPY operations

2016-05-27 Thread Francois Gouget
On Thu, 26 May 2016, Frediano Ziglio wrote: > > > > The source area should not extend outside the source bitmap, or have > > swapped coordinates. > > > > Signed-off-by: Francois Gouget > > --- > > > > The patch could be wrong: I could not find any documentation, neither in > > the code, neithe

[Spice-devel] [PATCH v2] red-parse-qxl: Check consistency of QXL_DRAW_COPY operations

2016-05-27 Thread Francois Gouget
The source area should not extend outside the source bitmap, or have swapped coordinates. Signed-off-by: Francois Gouget --- server/red-parse-qxl.c | 12 1 file changed, 12 insertions(+) diff --git a/server/red-parse-qxl.c b/server/red-parse-qxl.c index 0dafbef..d1f0ea7 100644 ---

Re: [Spice-devel] [spice-gtk v2 02/16] file-xfer: introduce flush_callback and flush_done

2016-05-27 Thread Pavel Grunt
Hi Victor, On Mon, 2016-05-23 at 13:50 +0200, Victor Toso wrote: > By introducing a flush_callback such as SpiceFileTransferTaskFlushCb > SpiceFileTransferTask becomes agnostic on how channel-main flushes > the data. > The spice_file_transfer_task_flush_done() function is now introduced > to tell

Re: [Spice-devel] [spice-gtk v2 05/16] file-xfer: inform agent of errors only when task finished

2016-05-27 Thread Pavel Grunt
On Mon, 2016-05-23 at 13:50 +0200, Victor Toso wrote: > No need to inform of a problem under > spice_file_transfer_task_completed() as the task will be finalized and > we can send the error to the agent there. > It sounds good > This change is related to split SpiceFileTransferTask from > channel

Re: [Spice-devel] [spice-gtk v2 02/16] file-xfer: introduce flush_callback and flush_done

2016-05-27 Thread Victor Toso
Hi, On Fri, May 27, 2016 at 10:54:15AM +0200, Pavel Grunt wrote: > Hi Victor, > > On Mon, 2016-05-23 at 13:50 +0200, Victor Toso wrote: > > By introducing a flush_callback such as SpiceFileTransferTaskFlushCb > > SpiceFileTransferTask becomes agnostic on how channel-main flushes > > the data. > >

[Spice-devel] [PATCH spice-gtk] Update README

2016-05-27 Thread Pavel Grunt
Remove gtk2 related stuff. Recommend dnf for installing dependencies. --- README | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/README b/README index e80e168..43ee08a 100644 --- a/README +++ b/README @@ -15,7 +15,7 @@ libspice-client-glib-2.0 * SpiceAudio

Re: [Spice-devel] [spice-gtk v2 13/16] channel: avoid crash on spice_channel_wakupe due NULL channel

2016-05-27 Thread Pavel Grunt
Hi, Can you explain when this can happen? Is it related to your tests? On Mon, 2016-05-23 at 13:50 +0200, Victor Toso wrote: > --- >  src/spice-channel.c | 5 - >  1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/src/spice-channel.c b/src/spice-channel.c > index c555f75..8b159f

Re: [Spice-devel] [spice-gtk v2 11/16] channel: avoid crash on CHANNEL_DEBUG due NULL channel

2016-05-27 Thread Pavel Grunt
Hi, I am not sure if functions working with a channel (using CHANNEL_DEBUG) should work without channel. Do you know which functions are causing the problem? Pavel On Mon, 2016-05-23 at 13:50 +0200, Victor Toso wrote: > --- >  src/spice-channel-priv.h | 4 +++- >  1 file changed, 3 insertions(+),

[Spice-devel] [vdagent-linux v1] systemd-login: check for LockedHint property

2016-05-27 Thread Victor Toso
Property introduced in v230 of systemd. Systems that don't have up to date systemd-login will get the following log message: "Properties.Get failed: Unknown property or interface." Resolves: rhbz#1323623 --- src/systemd-login.c | 102 1 file

[Spice-devel] [vdagent-linux v1 1/2] systemd-login: change template string for later usage

2016-05-27 Thread Victor Toso
Removing '' will make this define usable in next patch --- src/systemd-login.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/systemd-login.c b/src/systemd-login.c index fa59348..730547a 100644 --- a/src/systemd-login.c +++ b/src/systemd-login.c @@ -39,7 +39,7 @@ str

[Spice-devel] [vdagent-linux v1 0/2] disable drag and drop on locked sessions

2016-05-27 Thread Victor Toso
By checking the LockedHint property introduced in systemd v230 [0] we can avoid/disable features that should not work on Locked Sessions. [0] https://github.com/systemd/systemd/pull/3238 The Desktop Environment is responsable to keep this property up to date with SetLockedHint method. In GNOME th

Re: [Spice-devel] [PATCH v2] red-parse-qxl: Check consistency of QXL_DRAW_COPY operations

2016-05-27 Thread Frediano Ziglio
> > The source area should not extend outside the source bitmap, or have > swapped coordinates. > > Signed-off-by: Francois Gouget > --- > server/red-parse-qxl.c | 12 > 1 file changed, 12 insertions(+) > I checked and if this function return error the resource is correctly relea

Re: [Spice-devel] [spice-gtk v2 13/16] channel: avoid crash on spice_channel_wakupe due NULL channel

2016-05-27 Thread Victor Toso
Hi, On Fri, May 27, 2016 at 11:37:17AM +0200, Pavel Grunt wrote: > Hi, > > Can you explain when this can happen? Is it related to your tests? 100% related to tests. I'm testing file-transfer without SpiceMainChannel set. > > On Mon, 2016-05-23 at 13:50 +0200, Victor Toso wrote: > > --- > >  src/

Re: [Spice-devel] [spice-gtk v2 11/16] channel: avoid crash on CHANNEL_DEBUG due NULL channel

2016-05-27 Thread Victor Toso
Hi, On Fri, May 27, 2016 at 11:42:12AM +0200, Pavel Grunt wrote: > Hi, > > I am not sure if functions working with a channel (using > CHANNEL_DEBUG) should work without channel. Do you know which > functions are causing the problem? > > Pavel It is also related to the tests. This function: https:

Re: [Spice-devel] [spice-gtk v2 13/16] channel: avoid crash on spice_channel_wakupe due NULL channel

2016-05-27 Thread Pavel Grunt
On Fri, 2016-05-27 at 11:45 +0200, Victor Toso wrote: > Hi, > > On Fri, May 27, 2016 at 11:37:17AM +0200, Pavel Grunt wrote: > > Hi, > > > > Can you explain when this can happen? Is it related to your tests? > > 100% related to tests. I'm testing file-transfer without > SpiceMainChannel set. Ar

Re: [Spice-devel] [spice-gtk v2 13/16] channel: avoid crash on spice_channel_wakupe due NULL channel

2016-05-27 Thread Victor Toso
Hi, On Fri, May 27, 2016 at 11:52:31AM +0200, Pavel Grunt wrote: > On Fri, 2016-05-27 at 11:45 +0200, Victor Toso wrote: > > Hi, > > > > On Fri, May 27, 2016 at 11:37:17AM +0200, Pavel Grunt wrote: > > > Hi, > > > > > > Can you explain when this can happen? Is it related to your tests? > > > >

Re: [Spice-devel] [spice-gtk v2 11/16] channel: avoid crash on CHANNEL_DEBUG due NULL channel

2016-05-27 Thread Pavel Grunt
On Fri, 2016-05-27 at 11:47 +0200, Victor Toso wrote: > Hi, > > On Fri, May 27, 2016 at 11:42:12AM +0200, Pavel Grunt wrote: > > Hi, > > > > I am not sure if functions working with a channel (using > > CHANNEL_DEBUG) should work without channel. Do you know which > > functions are causing the pro

Re: [Spice-devel] [spice-gtk v2 11/16] channel: avoid crash on CHANNEL_DEBUG due NULL channel

2016-05-27 Thread Victor Toso
Hi, On Fri, May 27, 2016 at 11:57:31AM +0200, Pavel Grunt wrote: > On Fri, 2016-05-27 at 11:47 +0200, Victor Toso wrote: > > Hi, > > > > On Fri, May 27, 2016 at 11:42:12AM +0200, Pavel Grunt wrote: > > > Hi, > > > > > > I am not sure if functions working with a channel (using > > > CHANNEL_DEBUG

Re: [Spice-devel] [PATCH v2] red-parse-qxl: Check consistency of QXL_DRAW_COPY operations

2016-05-27 Thread Frediano Ziglio
> > > > > The source area should not extend outside the source bitmap, or have > > swapped coordinates. > > > > Signed-off-by: Francois Gouget > > --- > > server/red-parse-qxl.c | 12 > > 1 file changed, 12 insertions(+) > > > > I checked and if this function return error the re

Re: [Spice-devel] [PATCH spice-gtk] Update README

2016-05-27 Thread Marc-André Lureau
ack - Original Message - > Remove gtk2 related stuff. > Recommend dnf for installing dependencies. > --- > README | 14 ++ > 1 file changed, 6 insertions(+), 8 deletions(-) > > diff --git a/README b/README > index e80e168..43ee08a 100644 > --- a/README > +++ b/README > @@ -15

Re: [Spice-devel] [phodav PATCH 2/3 v7] spice-webdavd-windows: Check for mapped shared folder

2016-05-27 Thread Lukas Venhoda
Hi On Thu, May 26, 2016 at 1:07 PM, Marc-André Lureau wrote: > > - Original Message - > Rather than the user name of the driver, it would be more reliable to > check the connection details, with a function such as > WNetGetResourceInformation(). (I haven't looked in details if this is the

Re: [Spice-devel] [phodav PATCH 2/3 v7] spice-webdavd-windows: Check for mapped shared folder

2016-05-27 Thread Marc-André Lureau
- Original Message - > Hi > On Thu, May 26, 2016 at 1:07 PM, Marc-André Lureau < mlur...@redhat.com > > wrote: > > > - Original Message - > Rather than the user name of the driver, it would be more reliable to check > the connection details, with a function such as > WNetGetReso

Re: [Spice-devel] [phodav PATCH 2/3 v7] spice-webdavd-windows: Check for mapped shared folder

2016-05-27 Thread Lukas Venhoda
On Fri, May 27, 2016 at 4:36 PM, Marc-André Lureau wrote: > > >> Rather than the user name of the driver, it would be more reliable to > check > >> the connection details, with a function such as > >> WNetGetResourceInformation(). (I haven't looked in details if this is > the > >> right function)

[Spice-devel] [phodav PATCH 3/3 v7] spice-webdavd-windows: Dismount shared folder on service stop

2016-05-27 Thread Lukáš Venhoda
From: Lukas Venhoda When stopping the service, automatically disconnect shared folder on windows. Not dismounting could lead to multiple shared folders. --- Fixup: - Added GMutex init and clear - Inititalize service_data - Only unmap when drive_letter != 0 Changes since v6: - Changed gchar*

[Spice-devel] how to use spicy-screenshot without interrupt the normal connection ?

2016-05-27 Thread 赵会波
Hi,                  how to use spicy-screenshot and not to interrupt the normal  connection ?                any suggestions ? very appreciate !!!___ Spice-devel mailing list Spice-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listi

Re: [Spice-devel] [spice v15 02/21] streaming: Remove the width/height encode_frame() parameters

2016-05-27 Thread Christophe Fergeau
Hey, On Thu, May 26, 2016 at 05:15:56PM +0200, Francois Gouget wrote: > encode_frame() needs the QXL_DRAW_COPY operation's SpiceCopy.src_area > field anyway, so the width and height parameters were redundant. > > Signed-off-by: Francois Gouget > --- > server/dcc-send.c | 26 ---

Re: [Spice-devel] [spice v15 00/21] Add GStreamer support for video streaming

2016-05-27 Thread Christophe Fergeau
Hey, Not going to answer to each patch as I don't have a lot to add at this point, it looks mostly good to me. One thing to fix (I believe) which was introduced in these patches is "is_chunk_stride_aligned", the name was changed, but its return value should be inverted too, currently it returns FA

Re: [Spice-devel] how to use spicy-screenshot without interrupt the normal connection ?

2016-05-27 Thread Marc-André Lureau
Hi - Original Message - > > > Hi, > > how to use spicy-screenshot and not to interrupt the normal connection ? > any suggestions ? very appreciate !!! If the server has the experimental multi-client support enabled, using spicy-screenshot should not interrupt the existing connection.