We check that there is a matching frame in the queue before popping the
old ones. So we know the inner loop will find a match and thus that
frame will not be NULL. But figuring that out is too hard for the
compiler.
Signed-off-by: Francois Gouget
---
Adding an if (frame) check suggests that fram
CC'ing Francois
- Original Message -
> CC channel-display-gst.lo
> channel-display-gst.c: In function ‘new_sample’:
> channel-display-gst.c:192:31: error: potential null pointer dereference
> [-Werror=null-dereference]
> frame->sample = sample;
> ~~~
CC channel-display-gst.lo
channel-display-gst.c: In function ‘new_sample’:
channel-display-gst.c:192:31: error: potential null pointer dereference
[-Werror=null-dereference]
frame->sample = sample;
~~^~~~
Signed-off-by: Marc-André Lureau
--
Signed-off-by: Marc-André Lureau
---
m4/manywarnings.m4 | 39 ++-
1 file changed, 34 insertions(+), 5 deletions(-)
diff --git a/m4/manywarnings.m4 b/m4/manywarnings.m4
index 3e6dd21..90823b0 100644
--- a/m4/manywarnings.m4
+++ b/m4/manywarnings.m4
@@ -1,5 +1,5
Signed-off-by: Marc-André Lureau
---
src/channel-base.c | 2 +-
src/channel-cursor.c | 2 +-
src/channel-display-gst.c | 4 +--
src/channel-display-mjpeg.c| 2 +-
src/channel-display.c | 20 +++---
src/cha
manywarnings.m4 update will bring new flags that fail with some
glib/gst headers.
Signed-off-by: Marc-André Lureau
---
configure.ac | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index 8f1e91b..3fe8055 100644
--- a/configure.ac
+++ b/configure
The warning doesn't show up anymore.
Signed-off-by: Marc-André Lureau
---
configure.ac | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/configure.ac b/configure.ac
index 3c90e9e..8f1e91b 100644
--- a/configure.ac
+++ b/configure.ac
@@ -581,11 +581,7 @@ SPICE_CHECK_LZ4
dn
As we dropped gtk+ 2.0 anyway.
Signed-off-by: Marc-André Lureau
---
configure.ac | 7 ---
1 file changed, 7 deletions(-)
diff --git a/configure.ac b/configure.ac
index c94d41b..3c90e9e 100644
--- a/configure.ac
+++ b/configure.ac
@@ -585,13 +585,6 @@ dnl check compiler flags
# decl mess wi
Turns out it is possible to fix the warnings now.
Signed-off-by: Marc-André Lureau
---
configure.ac | 2 +-
src/channel-base.c | 20 ++--
src/channel-playback.c | 1 +
src/giopipe.c | 6 +-
src/spice-gstaudio.c | 2 +-
src/spice-uri.c| 4
Note that we can only avoid copies for the first 1 Mpixels or so.
That's because Spice splits larger frames into more chunks than we can
fit GstMemory fragments in a GStreamer buffer. So if there are more
pixels we will avoid copies for the first 3840 KB and copy the rest.
Furthermore, while in pra
This introduces a pared down GStreamer-based video encoder to serve as
the basis for later enhancements.
In this form the new encoder supports both regular and sized streams
but lacks any rate control. It should still work fine if bandwidth is
sufficient such as on LANs.
Signed-off-by: Francois Go
On Fri, 27 May 2016, Christophe Fergeau wrote:
> Hey,
>
> On Thu, May 26, 2016 at 05:15:56PM +0200, Francois Gouget wrote:
> > encode_frame() needs the QXL_DRAW_COPY operation's SpiceCopy.src_area
> > field anyway, so the width and height parameters were redundant.
> >
> > Signed-off-by: Francoi
Hi
- Original Message -
> Hi Marc-André,
>
> On Mon, 2016-05-30 at 11:54 -0400, Marc-André Lureau wrote:
> > Hi
> >
> > - Original Message -
> > > Related: rhbz#1335239
> >
> > include header, but what for?
>
> It should be included otherwise changing a declaration in spice-uri
Hi Marc-André,
On Mon, 2016-05-30 at 11:54 -0400, Marc-André Lureau wrote:
> Hi
>
> - Original Message -
> > Related: rhbz#1335239
>
> include header, but what for?
It should be included otherwise changing a declaration in spice-uri-priv.h will
not require changing the corresponding def
Hi
- Original Message -
> Related: rhbz#1335239
include header, but what for? Shouldn't it be merged with some other patch?
> ---
> src/spice-uri.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/src/spice-uri.c b/src/spice-uri.c
> index 8cf870d..3bdb502 100644
> --- a/src/spi
Use g_ascii_strtoll because it helps to detect overflow.
Related: rhbz#1335239
---
src/spice-uri.c| 8 ++--
tests/test-spice-uri.c | 2 ++
2 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/src/spice-uri.c b/src/spice-uri.c
index ea25aaa..7eec6e5 100644
--- a/src/spice-uri
Related: rhbz#1335239
---
src/spice-uri.c| 26 --
tests/test-spice-uri.c | 2 ++
2 files changed, 18 insertions(+), 10 deletions(-)
diff --git a/src/spice-uri.c b/src/spice-uri.c
index 7eec6e5..83ebe79 100644
--- a/src/spice-uri.c
+++ b/src/spice-uri.c
@@ -109,7 +
Just basic support - http://user:password@[host]:port
Resolves: rhbz#1335239
---
src/spice-uri.c| 24 +++---
tests/test-spice-uri.c | 90 +-
2 files changed, 87 insertions(+), 27 deletions(-)
diff --git a/src/spice-uri.c b/src/spic
Related: rhbz#1335239
---
src/spice-uri.c| 3 +++
tests/test-spice-uri.c | 1 +
2 files changed, 4 insertions(+)
diff --git a/src/spice-uri.c b/src/spice-uri.c
index 9f793de..ea25aaa 100644
--- a/src/spice-uri.c
+++ b/src/spice-uri.c
@@ -176,6 +176,9 @@ gboolean spice_uri_parse(SpiceURI *
Related: rhbz#1335239
---
src/spice-uri.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/spice-uri.c b/src/spice-uri.c
index 8cf870d..3bdb502 100644
--- a/src/spice-uri.c
+++ b/src/spice-uri.c
@@ -22,6 +22,7 @@
#include "spice-client.h"
#include "spice-uri.h"
+#include "spice-uri-priv
Avoid using old values after parsing a new uri.
Related: rhbz#1335239
---
src/spice-uri.c| 17 +
tests/test-spice-uri.c | 4 ++--
2 files changed, 15 insertions(+), 6 deletions(-)
diff --git a/src/spice-uri.c b/src/spice-uri.c
index 3bdb502..9f793de 100644
--- a/src/spic
---
src/spice-uri.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/spice-uri.c b/src/spice-uri.c
index e1317bd..8cf870d 100644
--- a/src/spice-uri.c
+++ b/src/spice-uri.c
@@ -340,7 +340,7 @@ static void spice_uri_finalize(GObject* obj)
G_OBJECT_CLASS (spice_uri_parent
Hi,
these patches add ipv6 support to SpiceUri, so it can be used in SPICE_PROXY.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1335239
v4 contains changes suggested by Christophe, Victor, Frediano:
- Added check for scheme
- Tests check for error messages
- Port 0 is considered inval
Related: rhbz#1335239
---
tests/Makefile.am | 2 ++
tests/test-spice-uri.c | 93 ++
2 files changed, 95 insertions(+)
create mode 100644 tests/test-spice-uri.c
diff --git a/tests/Makefile.am b/tests/Makefile.am
index c1d95c1..fb97138 100644
-
Acked-by: Pavel Grunt
On Mon, 2016-05-30 at 13:23 +0200, Victor Toso wrote:
> ---
> src/spice-channel.c | 5 -
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/src/spice-channel.c b/src/spice-channel.c
> index c555f75..61ab15c 100644
> --- a/src/spice-channel.c
> +++ b/src/
---
tests/file-transfer.c | 49 +
1 file changed, 49 insertions(+)
diff --git a/tests/file-transfer.c b/tests/file-transfer.c
index c268654..2efaba8 100644
--- a/tests/file-transfer.c
+++ b/tests/file-transfer.c
@@ -211,6 +211,47 @@ test_cancel_on_f
---
tests/file-transfer.c | 49 +
1 file changed, 49 insertions(+)
diff --git a/tests/file-transfer.c b/tests/file-transfer.c
index 1421f1e..c268654 100644
--- a/tests/file-transfer.c
+++ b/tests/file-transfer.c
@@ -170,6 +170,47 @@ test_cancel_on_s
---
src/spice-channel.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/src/spice-channel.c b/src/spice-channel.c
index c555f75..61ab15c 100644
--- a/src/spice-channel.c
+++ b/src/spice-channel.c
@@ -1891,7 +1891,10 @@ error:
G_GNUC_INTERNAL
void spice_channel_wakeup(Spic
Acked-by: Pavel Grunt
On Mon, 2016-05-30 at 11:55 +0200, Victor Toso wrote:
> In file included from
> ../spice-common/common/client_marshallers.h:29:0,
> from ../src/spice-channel-priv.h:35,
> from ../src/spice-file-transfer-task-priv.h:28,
> from file-transfer.c:3:
> ../spice-common/common/messa
Hi,
On Mon, 2016-05-30 at 11:55 +0200, Victor Toso wrote:
> ---
> src/spice-channel.c | 5 -
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/src/spice-channel.c b/src/spice-channel.c
> index c555f75..8b159f4 100644
> --- a/src/spice-channel.c
> +++ b/src/spice-channel.c
> @
Hi,
One could test this with the following branch:
https://cgit.freedesktop.org/~victortoso/spice-gtk/log/?h=move-xfer
Cheers,
toso
On Mon, May 30, 2016 at 11:54:56AM +0200, Victor Toso wrote:
> v2->v3
> * rebased
> * pushed v2 01/16 ~ 349a52ca2d6af4 - acked by Pavel and Jonathon
> * split v2
---
tests/file-transfer.c | 49 +
1 file changed, 49 insertions(+)
diff --git a/tests/file-transfer.c b/tests/file-transfer.c
index d8dcf6c..be4d585 100644
--- a/tests/file-transfer.c
+++ b/tests/file-transfer.c
@@ -211,6 +211,47 @@ test_cancel_on_f
Application can start multiple file-transfers in one operation and
cancel a few of them while the operation is ongoing. In that case, we
should remove the file-size of the transfer operation otherwise we
will send incorrect progress data.
Taking in consideration the split of SpiceFileTransferTask,
SpiceFileTransferTask has a callback to be called when operation
ended. Til this patch, we were setting the user callback which means
that in multiple file-transfers, we were calling the user callback
several times.
Following the same logic pointed from 113093dd00a1cf10f6d3c3589b7 this
is a SpiceM
This only includes a simple test for file-transfer with a small
summary of the possible situations of the test.
As the test is specifically for SpiceFileTransferTask, we don't create
a SpiceMainChannel. That could cause a simple crash on CHANNEL_DEBUG
which this patch addresses.
---
tests/Makefil
---
src/spice-channel.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/src/spice-channel.c b/src/spice-channel.c
index c555f75..8b159f4 100644
--- a/src/spice-channel.c
+++ b/src/spice-channel.c
@@ -1891,7 +1891,10 @@ error:
G_GNUC_INTERNAL
void spice_channel_wakeup(Spic
Previous six patches are related to this change. This patch moves:
* GObject boilerplate
* External API related to SpiceFileTransferTask
* Internal API needed by channel-main
* Helpers that belong to this object
---
src/Makefile.am | 2 +
src/channel-main.c |
---
tests/file-transfer.c | 34 ++
1 file changed, 34 insertions(+)
diff --git a/tests/file-transfer.c b/tests/file-transfer.c
index 5ef11a7..1421f1e 100644
--- a/tests/file-transfer.c
+++ b/tests/file-transfer.c
@@ -144,6 +144,32 @@ test_simple_transfer(Fixture *f
Agent only can only send error or cancel from a transfer operation
after it was initialized. In the context of SpiceFileTransferTask, it
means that we need to test only after file-info was emitted.
---
tests/file-transfer.c | 90 +++
1 file changed,
---
tests/file-transfer.c | 49 +
1 file changed, 49 insertions(+)
diff --git a/tests/file-transfer.c b/tests/file-transfer.c
index 1421f1e..d8dcf6c 100644
--- a/tests/file-transfer.c
+++ b/tests/file-transfer.c
@@ -170,6 +170,47 @@ test_cancel_on_s
By introducing a flush_callback such as SpiceFileTransferTaskFlushCb
SpiceFileTransferTask becomes agnostic on how channel-main flushes
the data.
The spice_file_transfer_task_flush_done() function is now introduced
to tell SpiceFileTransferTask that flushing is over and we can read
more data if no
In order to channel-main interact with each SpiceFileTransferTask for
the file-transfer operation, the following functions are introduced:
* spice_file_transfer_task_get_id
* spice_file_transfer_task_get_channel
* spice_file_transfer_task_get_cancellable
Note that although "id" property is public
In file included from
../spice-common/common/client_marshallers.h:29:0,
from ../src/spice-channel-priv.h:35,
from ../src/spice-file-transfer-task-priv.h:28,
from file-transfer.c:3:
../spice-common/common/messages.h:45:23: fatal error: libcacard.h: No such file
or directory
compilation terminated.
By splitting file_xfer_send_start_msg_async we can separate in three
different steps the spice_main_file_copy_async function:
1-) Creating tasks with spice_file_transfer_task_create_tasks which
now returns a GList of SpiceFileTransferTask;
2-) Setting handlers before the SpiceFileTransferTask
Each call to spice_main_file_copy_async will now create a
FileTransferOperation which groups all SpiceFileTransferTasks of the
copy operation and also the progress_callback passed from Application.
As pointed in the fix 113093dd00a1cf10f6d3c3589b7589a184cec081, the
progress_callback should provide
No need to inform of a problem under
spice_file_transfer_task_completed() as the task will be finalized and
we can send the error to the agent there.
This change is related to split SpiceFileTransferTask from
channel-main.
Acked-by: Pavel Grunt
---
src/channel-main.c | 19 +--
1
In order to avoid sending the agent message on
file_xfer_info_async_cb, we can provide the "file-info" signal to
SpiceFileTransferTask.
In order to this signal be significant to applications, we request all
standard attributes to g_file_query_info_async.
This change is related to split SpiceFileT
v2->v3
* rebased
* pushed v2 01/16 ~ 349a52ca2d6af4 - acked by Pavel and Jonathon
* split v2 02/16 to have private helpers in different patch (Pavel)
- v3 01/16 ~ file-xfer: get functions for SpiceFileTransferTask
- v3 02/16 ~ file-xfer: introduce flush_callback and flush_done
* change assert to re
48 matches
Mail list logo