Re: [Spice-devel] [spice v15 01/21] mjpeg: Use src_area as the authoritative source for the frame dimensions

On Tue, 31 May 2016, Christophe Fergeau wrote: > On Thu, May 26, 2016 at 05:15:35PM +0200, Francois Gouget wrote: > > Video frames correspond to QXL_DRAW_COPY operations where the frame area > > is defined by the SpiceCopy.src_area field. > > > > Signed-off-by: Francois Gouget

Re: [Spice-devel] [PATCH v2] Handle flow control without crashing for agent

> > On 05/31/2016 03:06 PM, Frediano Ziglio wrote: > > RedCharDevice used for the agent has flow control enabled. > > This make possible for red_char_device_write_buffer_get to return NULL. > > Handle such situation without crashing avoiding NULL dereference. > > > > This fixes

Re: [Spice-devel] [PATCH v2] Handle flow control without crashing for agent

On 05/31/2016 03:06 PM, Frediano Ziglio wrote: RedCharDevice used for the agent has flow control enabled. This make possible for red_char_device_write_buffer_get to return NULL. Handle such situation without crashing avoiding NULL dereference. This fixes

Re: [Spice-devel] [PATCH spice-gtk 3/7] build-sys: remove -Wmissing-declarations

On Mon, 2016-05-30 at 19:31 +0200, Marc-André Lureau wrote: > The warning doesn't show up anymore. > > Signed-off-by: Marc-André Lureau Acked-by: Pavel Grunt > --- >  configure.ac | 6 +- >  1 file changed, 1 insertion(+), 5 deletions(-) > >

Re: [Spice-devel] [PATCH spice-gtk 4/5] test-session: Also test hostname, username and password

On Tue, 2016-05-31 at 12:12 +0200, Victor Toso wrote: > Hi, > > On Fri, May 20, 2016 at 02:50:59PM +0200, Pavel Grunt wrote: > > --- > >  tests/session.c | 48 +--- > >  1 file changed, 45 insertions(+), 3 deletions(-) > > > > diff --git

[Spice-devel] [PATCH v2] Handle flow control without crashing for agent

RedCharDevice used for the agent has flow control enabled. This make possible for red_char_device_write_buffer_get to return NULL. Handle such situation without crashing avoiding NULL dereference. This fixes https://bugs.freedesktop.org/show_bug.cgi?id=95416. Signed-off-by: Frediano Ziglio

Re: [Spice-devel] [PATCH spice-gtk 1/3] Fix non gtk-doc comments

Series looks good, Acked-by: Victor Toso On Tue, May 31, 2016 at 01:12:32PM +0200, Marc-André Lureau wrote: > Fixes the following warning: > ../../src/vmcstream.c:124: warning: Symbol name not found at the start of the > comment block. >

Re: [Spice-devel] [PATCH] Handle flow control without crashing for agent

Hi, On Tue, May 31, 2016 at 11:20:04AM +0100, Frediano Ziglio wrote: > RedCharDevice used for the agent has flow control enabled. > This make possible for red_char_device_write_buffer_get to return NULL. > Handle such situation without crashing avoiding NULL dereference. > > This fixes

[Spice-devel] [PATCH] Handle flow control without crashing for agent

RedCharDevice used for the agent has flow control enabled. This make possible for red_char_device_write_buffer_get to return NULL. Handle such situation without crashing avoiding NULL dereference. This fixes https://bugs.freedesktop.org/show_bug.cgi?id=95416. Signed-off-by: Frediano Ziglio

Re: [Spice-devel] [PATCH spice-gtk 5/5] test-session: Test invalid URIs

Hi, On Fri, May 20, 2016 at 02:51:00PM +0200, Pavel Grunt wrote: > --- > tests/session.c | 30 -- > 1 file changed, 28 insertions(+), 2 deletions(-) > > diff --git a/tests/session.c b/tests/session.c > index 00a5a1e..eace40a 100644 > --- a/tests/session.c > +++

Re: [Spice-devel] [PATCH spice-gtk 4/5] test-session: Also test hostname, username and password

Hi, On Fri, May 20, 2016 at 02:50:59PM +0200, Pavel Grunt wrote: > --- > tests/session.c | 48 +--- > 1 file changed, 45 insertions(+), 3 deletions(-) > > diff --git a/tests/session.c b/tests/session.c > index 549378b..00a5a1e 100644 > ---

Re: [Spice-devel] [PATCH spice-gtk 3/5] test-session: Do not fail on g_warning

Hi, On Fri, May 20, 2016 at 02:50:58PM +0200, Pavel Grunt wrote: > Following commit adds tests for password set in uri which will produce > a runtime warning. Reset fatal mask set by g_test_init() to avoid > failing. > --- > tests/session.c | 9 + > 1 file changed, 9 insertions(+) > >

Re: [Spice-devel] [PATCH spice-gtk 1/7] build-sys: enable -Wmissing-prototypes

On Tue, 2016-05-31 at 12:01 +0200, Marc-André Lureau wrote: > On Tue, May 31, 2016 at 10:51 AM, Pavel Grunt wrote: > > Why removing G_GNUC_INTERNAL ? It is declared the -priv header and used only > > internally. (Also an extra space was added) > > > My bad, fixed. > ok, ack

Re: [Spice-devel] [PATCH spice-gtk 2/7] build-sys: remove some gtk+ 2.0 warnings flags

On Mon, 2016-05-30 at 19:31 +0200, Marc-André Lureau wrote: > As we dropped gtk+ 2.0 anyway. > > Signed-off-by: Marc-André Lureau Acked-by: Pavel Grunt > --- >  configure.ac | 7 --- >  1 file changed, 7 deletions(-) > > diff --git

Re: [Spice-devel] [PATCH spice-gtk 2/5] test-session: Test alternative way for setting port

Hi, On Fri, May 20, 2016 at 02:50:57PM +0200, Pavel Grunt wrote: > --- > tests/session.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/tests/session.c b/tests/session.c > index 00076f2..a6276c2 100644 > --- a/tests/session.c > +++ b/tests/session.c > @@ -24,6 +24,12 @@ static

Re: [Spice-devel] [PATCH spice-gtk 1/5] test-session: Fix signed compare

Hi, On Fri, May 20, 2016 at 02:50:56PM +0200, Pavel Grunt wrote: > The varible is compared with G_N_ELEMENTS which returns unsigned value Sure, Acked-by: Victor Toso > --- > tests/session.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [Spice-devel] [PATCH spice-gtk 1/7] build-sys: enable -Wmissing-prototypes

On Tue, May 31, 2016 at 10:51 AM, Pavel Grunt wrote: > Why removing G_GNUC_INTERNAL ? It is declared the -priv header and used only > internally. (Also an extra space was added) My bad, fixed. -- Marc-André Lureau ___ Spice-devel

[Spice-devel] [PATCH 2/3] Remove obsolete comment

AGENT_CONNECT with token count is implemented by agent_connected_tokens message. Signed-off-by: Frediano Ziglio --- server/char-device.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/server/char-device.h b/server/char-device.h index 2dd848f..1ada763 100644 ---

[Spice-devel] [PATCH 3/3] Simplify setting char device instance

Setting "sin" property is equivalent to call red_char_device_reset_dev_instance so there is no need for a if/else as the code is doing mostly (beside setting agent_attached) the same thing Signed-off-by: Frediano Ziglio --- server/reds.c | 8 ++-- 1 file changed, 2

[Spice-devel] [PATCH 1/3] Fix some typos in comments

Signed-off-by: Frediano Ziglio --- server/char-device.h | 4 ++-- server/reds.c| 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/server/char-device.h b/server/char-device.h index 39bff4e..2dd848f 100644 --- a/server/char-device.h +++

Re: [Spice-devel] [spice v15 01/21] mjpeg: Use src_area as the authoritative source for the frame dimensions

On Thu, May 26, 2016 at 05:15:35PM +0200, Francois Gouget wrote: > Video frames correspond to QXL_DRAW_COPY operations where the frame area > is defined by the SpiceCopy.src_area field. > > Signed-off-by: Francois Gouget > --- > server/mjpeg-encoder.c | 14

Re: [Spice-devel] [spice v15 02/21] streaming: Remove the width/height encode_frame() parameters

Hi, On Mon, May 30, 2016 at 07:12:48PM +0200, Francois Gouget wrote: > On Fri, 27 May 2016, Christophe Fergeau wrote: > > I'm afraid this bit is not going to work as expected with older clients > > (ones not supporting SPICE_DISPLAY_CAP_SIZED_STREAM). > > This chunk does not change whether we

Re: [Spice-devel] [PATCH spice-gtk v4 7/8] spice-uri: Validate uri scheme

Hi, On Tue, May 31, 2016 at 11:07:21AM +0200, Pavel Grunt wrote: > On Tue, 2016-05-31 at 10:50 +0200, Victor Toso wrote: > > Hi, > > > > On Mon, May 30, 2016 at 05:46:49PM +0200, Pavel Grunt wrote: > > > Related: rhbz#1335239 > > > --- > > >  src/spice-uri.c| 26

Re: [Spice-devel] [PATCH spice-gtk v4 7/8] spice-uri: Validate uri scheme

On Tue, 2016-05-31 at 10:50 +0200, Victor Toso wrote: > Hi, > > On Mon, May 30, 2016 at 05:46:49PM +0200, Pavel Grunt wrote: > > Related: rhbz#1335239 > > --- > >  src/spice-uri.c| 26 -- > >  tests/test-spice-uri.c |  2 ++ > >  2 files changed, 18 insertions(+), 10

Re: [Spice-devel] [PATCH spice-gtk v4 8/8] spice-uri: Add ipv6 support

Hi, On Mon, May 30, 2016 at 05:46:50PM +0200, Pavel Grunt wrote: > Just basic support - http://user:password@[host]:port > > Resolves: rhbz#1335239 > --- > src/spice-uri.c| 24 +++--- > tests/test-spice-uri.c | 90 > +- > 2 files

Re: [Spice-devel] [PATCH spice-gtk 1/7] build-sys: enable -Wmissing-prototypes

Hi, On Mon, 2016-05-30 at 19:31 +0200, Marc-André Lureau wrote: > Turns out it is possible to fix the warnings now. > > Signed-off-by: Marc-André Lureau > --- >  configure.ac   |  2 +- >  src/channel-base.c | 20 ++-- >  

Re: [Spice-devel] [PATCH spice-gtk v4 7/8] spice-uri: Validate uri scheme

Hi, On Mon, May 30, 2016 at 05:46:49PM +0200, Pavel Grunt wrote: > Related: rhbz#1335239 > --- > src/spice-uri.c| 26 -- > tests/test-spice-uri.c | 2 ++ > 2 files changed, 18 insertions(+), 10 deletions(-) > > diff --git a/src/spice-uri.c b/src/spice-uri.c >

Re: [Spice-devel] [PATCH spice-gtk v4 4/8] spice-uri: Reset SpiceUri before parsing

Hi, On Tue, May 31, 2016 at 10:29:30AM +0200, Pavel Grunt wrote: > Hi Victor, > > On Tue, 2016-05-31 at 10:01 +0200, Victor Toso wrote: > > Hi, > > > > On Mon, May 30, 2016 at 05:46:46PM +0200, Pavel Grunt wrote: > > > Avoid using old values after parsing a new uri. > > > > > > Related:

Re: [Spice-devel] [PATCH spice-gtk v4 4/8] spice-uri: Reset SpiceUri before parsing

Hi Victor, On Tue, 2016-05-31 at 10:01 +0200, Victor Toso wrote: > Hi, > > On Mon, May 30, 2016 at 05:46:46PM +0200, Pavel Grunt wrote: > > Avoid using old values after parsing a new uri. > > > > Related: rhbz#1335239 > > --- > >  src/spice-uri.c| 17 + > >  

Re: [Spice-devel] [PATCH spice-gtk v4 6/8] spice-uri: Check if port is in allowed range

Hi, On Mon, May 30, 2016 at 05:46:48PM +0200, Pavel Grunt wrote: > Use g_ascii_strtoll because it helps to detect overflow. > > Related: rhbz#1335239 Acked-by: Victor Toso > --- > src/spice-uri.c| 8 ++-- > tests/test-spice-uri.c | 2 ++ > 2 files changed, 8

Re: [Spice-devel] [PATCH spice-gtk v4 5/8] spice-uri: Do not allow empty port string

Hi, On Mon, May 30, 2016 at 05:46:47PM +0200, Pavel Grunt wrote: > Related: rhbz#1335239 Acked-by: Victor Toso > --- > src/spice-uri.c| 3 +++ > tests/test-spice-uri.c | 1 + > 2 files changed, 4 insertions(+) > > diff --git a/src/spice-uri.c b/src/spice-uri.c

Re: [Spice-devel] [PATCH spice-gtk v4 4/8] spice-uri: Reset SpiceUri before parsing

Hi, On Mon, May 30, 2016 at 05:46:46PM +0200, Pavel Grunt wrote: > Avoid using old values after parsing a new uri. > > Related: rhbz#1335239 > --- > src/spice-uri.c| 17 + > tests/test-spice-uri.c | 4 ++-- > 2 files changed, 15 insertions(+), 6 deletions(-) > > diff

Re: [Spice-devel] [PATCH spice-gtk v4 3/8] spice-uri: Add missing include

Hi, On Mon, May 30, 2016 at 05:46:45PM +0200, Pavel Grunt wrote: > Related: rhbz#1335239 > --- > src/spice-uri.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/spice-uri.c b/src/spice-uri.c > index 8cf870d..3bdb502 100644 > --- a/src/spice-uri.c > +++ b/src/spice-uri.c > @@ -22,6

Re: [Spice-devel] [PATCH spice-gtk v4 2/8] spice-uri: Mark parameter as unused

Hi, On Mon, May 30, 2016 at 05:46:44PM +0200, Pavel Grunt wrote: > --- > src/spice-uri.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/spice-uri.c b/src/spice-uri.c > index e1317bd..8cf870d 100644 > --- a/src/spice-uri.c > +++ b/src/spice-uri.c > @@ -340,7 +340,7

Re: [Spice-devel] [PATCH spice-gtk v4 1/8] tests: Add test for SpiceUri

Hi, On Mon, May 30, 2016 at 05:46:43PM +0200, Pavel Grunt wrote: > Related: rhbz#1335239 > --- > tests/Makefile.am | 2 ++ > tests/test-spice-uri.c | 93 > ++ > 2 files changed, 95 insertions(+) > create mode 100644 tests/test-spice-uri.c >