Hi,
On Mon, May 30, 2016 at 05:46:43PM +0200, Pavel Grunt wrote:
> Related: rhbz#1335239
> ---
> tests/Makefile.am | 2 ++
> tests/test-spice-uri.c | 93
> ++
> 2 files changed, 95 insertions(+)
> create mode 100644 tests/test-spice-uri.c
>
Hi,
On Mon, May 30, 2016 at 05:46:44PM +0200, Pavel Grunt wrote:
> ---
> src/spice-uri.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/spice-uri.c b/src/spice-uri.c
> index e1317bd..8cf870d 100644
> --- a/src/spice-uri.c
> +++ b/src/spice-uri.c
> @@ -340,7 +340,7 @
Hi,
On Mon, May 30, 2016 at 05:46:45PM +0200, Pavel Grunt wrote:
> Related: rhbz#1335239
> ---
> src/spice-uri.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/src/spice-uri.c b/src/spice-uri.c
> index 8cf870d..3bdb502 100644
> --- a/src/spice-uri.c
> +++ b/src/spice-uri.c
> @@ -22,6 +
Hi,
On Mon, May 30, 2016 at 05:46:46PM +0200, Pavel Grunt wrote:
> Avoid using old values after parsing a new uri.
>
> Related: rhbz#1335239
> ---
> src/spice-uri.c| 17 +
> tests/test-spice-uri.c | 4 ++--
> 2 files changed, 15 insertions(+), 6 deletions(-)
>
> diff --
Hi,
On Mon, May 30, 2016 at 05:46:47PM +0200, Pavel Grunt wrote:
> Related: rhbz#1335239
Acked-by: Victor Toso
> ---
> src/spice-uri.c| 3 +++
> tests/test-spice-uri.c | 1 +
> 2 files changed, 4 insertions(+)
>
> diff --git a/src/spice-uri.c b/src/spice-uri.c
> index 9f793de..ea25aaa
Hi,
On Mon, May 30, 2016 at 05:46:48PM +0200, Pavel Grunt wrote:
> Use g_ascii_strtoll because it helps to detect overflow.
>
> Related: rhbz#1335239
Acked-by: Victor Toso
> ---
> src/spice-uri.c| 8 ++--
> tests/test-spice-uri.c | 2 ++
> 2 files changed, 8 insertions(+), 2 deleti
Hi Victor,
On Tue, 2016-05-31 at 10:01 +0200, Victor Toso wrote:
> Hi,
>
> On Mon, May 30, 2016 at 05:46:46PM +0200, Pavel Grunt wrote:
> > Avoid using old values after parsing a new uri.
> >
> > Related: rhbz#1335239
> > ---
> > src/spice-uri.c| 17 +
> > tests/test-spi
Hi,
On Tue, May 31, 2016 at 10:29:30AM +0200, Pavel Grunt wrote:
> Hi Victor,
>
> On Tue, 2016-05-31 at 10:01 +0200, Victor Toso wrote:
> > Hi,
> >
> > On Mon, May 30, 2016 at 05:46:46PM +0200, Pavel Grunt wrote:
> > > Avoid using old values after parsing a new uri.
> > >
> > > Related: rhbz#13
Hi,
On Mon, May 30, 2016 at 05:46:49PM +0200, Pavel Grunt wrote:
> Related: rhbz#1335239
> ---
> src/spice-uri.c| 26 --
> tests/test-spice-uri.c | 2 ++
> 2 files changed, 18 insertions(+), 10 deletions(-)
>
> diff --git a/src/spice-uri.c b/src/spice-uri.c
> inde
Hi,
On Mon, 2016-05-30 at 19:31 +0200, Marc-André Lureau wrote:
> Turns out it is possible to fix the warnings now.
>
> Signed-off-by: Marc-André Lureau
> ---
> configure.ac | 2 +-
> src/channel-base.c | 20 ++--
> src/channel-playback.c | 1 +
> src/giopipe.c
Hi,
On Mon, May 30, 2016 at 05:46:50PM +0200, Pavel Grunt wrote:
> Just basic support - http://user:password@[host]:port
>
> Resolves: rhbz#1335239
> ---
> src/spice-uri.c| 24 +++---
> tests/test-spice-uri.c | 90
> +-
> 2 files c
On Tue, 2016-05-31 at 10:50 +0200, Victor Toso wrote:
> Hi,
>
> On Mon, May 30, 2016 at 05:46:49PM +0200, Pavel Grunt wrote:
> > Related: rhbz#1335239
> > ---
> > src/spice-uri.c| 26 --
> > tests/test-spice-uri.c | 2 ++
> > 2 files changed, 18 insertions(+), 10
Hi,
On Tue, May 31, 2016 at 11:07:21AM +0200, Pavel Grunt wrote:
> On Tue, 2016-05-31 at 10:50 +0200, Victor Toso wrote:
> > Hi,
> >
> > On Mon, May 30, 2016 at 05:46:49PM +0200, Pavel Grunt wrote:
> > > Related: rhbz#1335239
> > > ---
> > > src/spice-uri.c| 26 --
Hi,
On Mon, May 30, 2016 at 07:12:48PM +0200, Francois Gouget wrote:
> On Fri, 27 May 2016, Christophe Fergeau wrote:
> > I'm afraid this bit is not going to work as expected with older clients
> > (ones not supporting SPICE_DISPLAY_CAP_SIZED_STREAM).
>
> This chunk does not change whether we sen
On Thu, May 26, 2016 at 05:15:35PM +0200, Francois Gouget wrote:
> Video frames correspond to QXL_DRAW_COPY operations where the frame area
> is defined by the SpiceCopy.src_area field.
>
> Signed-off-by: Francois Gouget
> ---
> server/mjpeg-encoder.c | 14 ++
> 1 file changed, 6 ins
Signed-off-by: Frediano Ziglio
---
server/char-device.h | 4 ++--
server/reds.c| 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/server/char-device.h b/server/char-device.h
index 39bff4e..2dd848f 100644
--- a/server/char-device.h
+++ b/server/char-device.h
@@ -175,9 +
Setting "sin" property is equivalent to call
red_char_device_reset_dev_instance so there is no need for a if/else
as the code is doing mostly (beside setting agent_attached) the
same thing
Signed-off-by: Frediano Ziglio
---
server/reds.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions
AGENT_CONNECT with token count is implemented by agent_connected_tokens
message.
Signed-off-by: Frediano Ziglio
---
server/char-device.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/server/char-device.h b/server/char-device.h
index 2dd848f..1ada763 100644
--- a/server/char-device.h
+++ b
On Tue, May 31, 2016 at 10:51 AM, Pavel Grunt wrote:
> Why removing G_GNUC_INTERNAL ? It is declared the -priv header and used only
> internally. (Also an extra space was added)
My bad, fixed.
--
Marc-André Lureau
___
Spice-devel mailing list
Spice-d
Hi,
On Fri, May 20, 2016 at 02:50:56PM +0200, Pavel Grunt wrote:
> The varible is compared with G_N_ELEMENTS which returns unsigned value
Sure, Acked-by: Victor Toso
> ---
> tests/session.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/session.c b/tests/session
Hi,
On Fri, May 20, 2016 at 02:50:57PM +0200, Pavel Grunt wrote:
> ---
> tests/session.c | 6 ++
> 1 file changed, 6 insertions(+)
>
> diff --git a/tests/session.c b/tests/session.c
> index 00076f2..a6276c2 100644
> --- a/tests/session.c
> +++ b/tests/session.c
> @@ -24,6 +24,12 @@ static vo
On Mon, 2016-05-30 at 19:31 +0200, Marc-André Lureau wrote:
> As we dropped gtk+ 2.0 anyway.
>
> Signed-off-by: Marc-André Lureau
Acked-by: Pavel Grunt
> ---
> configure.ac | 7 ---
> 1 file changed, 7 deletions(-)
>
> diff --git a/configure.ac b/configure.ac
> index c94d41b..3c90e9e 10064
On Tue, 2016-05-31 at 12:01 +0200, Marc-André Lureau wrote:
> On Tue, May 31, 2016 at 10:51 AM, Pavel Grunt wrote:
> > Why removing G_GNUC_INTERNAL ? It is declared the -priv header and used only
> > internally. (Also an extra space was added)
>
>
> My bad, fixed.
>
ok, ack
Pavel
_
Hi,
On Fri, May 20, 2016 at 02:50:58PM +0200, Pavel Grunt wrote:
> Following commit adds tests for password set in uri which will produce
> a runtime warning. Reset fatal mask set by g_test_init() to avoid
> failing.
> ---
> tests/session.c | 9 +
> 1 file changed, 9 insertions(+)
>
> di
Hi,
On Fri, May 20, 2016 at 02:50:59PM +0200, Pavel Grunt wrote:
> ---
> tests/session.c | 48 +---
> 1 file changed, 45 insertions(+), 3 deletions(-)
>
> diff --git a/tests/session.c b/tests/session.c
> index 549378b..00a5a1e 100644
> --- a/tests/sess
Hi,
On Fri, May 20, 2016 at 02:51:00PM +0200, Pavel Grunt wrote:
> ---
> tests/session.c | 30 --
> 1 file changed, 28 insertions(+), 2 deletions(-)
>
> diff --git a/tests/session.c b/tests/session.c
> index 00a5a1e..eace40a 100644
> --- a/tests/session.c
> +++ b/tests
RedCharDevice used for the agent has flow control enabled.
This make possible for red_char_device_write_buffer_get to return NULL.
Handle such situation without crashing avoiding NULL dereference.
This fixes https://bugs.freedesktop.org/show_bug.cgi?id=95416.
Signed-off-by: Frediano Ziglio
---
Hi,
On Tue, May 31, 2016 at 11:20:04AM +0100, Frediano Ziglio wrote:
> RedCharDevice used for the agent has flow control enabled.
> This make possible for red_char_device_write_buffer_get to return NULL.
> Handle such situation without crashing avoiding NULL dereference.
>
> This fixes https://bu
>
> Hi,
>
> On Tue, May 31, 2016 at 11:20:04AM +0100, Frediano Ziglio wrote:
> > RedCharDevice used for the agent has flow control enabled.
> > This make possible for red_char_device_write_buffer_get to return NULL.
> > Handle such situation without crashing avoiding NULL dereference.
> >
> > Th
Hi,
On Tue, May 31, 2016 at 06:31:23AM -0400, Frediano Ziglio wrote:
> > Hi,
> >
> > On Tue, May 31, 2016 at 11:20:04AM +0100, Frediano Ziglio wrote:
> > > RedCharDevice used for the agent has flow control enabled.
> > > This make possible for red_char_device_write_buffer_get to return NULL.
> > >
Fixes the following warning:
../../src/vmcstream.c:124: warning: Symbol name not found at the start of the
comment block.
../../src/win-usb-driver-install.c:347: warning: Symbol name not found at the
start of the comment block.
Signed-off-by: Marc-André Lureau
---
src/vmcstream.c
Signed-off-by: Marc-André Lureau
---
src/channel-display.h | 35 +++
src/spice-grabsequence-priv.h | 1 +
src/spice-grabsequence.h | 5 +
3 files changed, 41 insertions(+)
diff --git a/src/channel-display.h b/src/channel-display.h
index bd4bc87.
Fix all the gtk-doc: "unused declarations. They should be added to
spice-gtk-sections.txt in the appropriate place."
Signed-off-by: Marc-André Lureau
---
doc/reference/Makefile.am| 12 +++-
doc/reference/spice-gtk-sections.txt | 16 +++-
2 files changed, 26 insert
Series looks good,
Acked-by: Victor Toso
On Tue, May 31, 2016 at 01:12:32PM +0200, Marc-André Lureau wrote:
> Fixes the following warning:
> ../../src/vmcstream.c:124: warning: Symbol name not found at the start of the
> comment block.
> ../../src/win-usb-driver-install.c:347: warning: Symbol na
RedCharDevice used for the agent has flow control enabled.
This make possible for red_char_device_write_buffer_get to return NULL.
Handle such situation without crashing avoiding NULL dereference.
This fixes https://bugs.freedesktop.org/show_bug.cgi?id=95416.
Signed-off-by: Frediano Ziglio
---
On Tue, 2016-05-31 at 12:12 +0200, Victor Toso wrote:
> Hi,
>
> On Fri, May 20, 2016 at 02:50:59PM +0200, Pavel Grunt wrote:
> > ---
> > tests/session.c | 48 +---
> > 1 file changed, 45 insertions(+), 3 deletions(-)
> >
> > diff --git a/tests/session.
On Mon, 2016-05-30 at 19:31 +0200, Marc-André Lureau wrote:
> The warning doesn't show up anymore.
>
> Signed-off-by: Marc-André Lureau
Acked-by: Pavel Grunt
> ---
> configure.ac | 6 +-
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/configure.ac b/configure.ac
> index 3
On 05/31/2016 03:06 PM, Frediano Ziglio wrote:
RedCharDevice used for the agent has flow control enabled.
This make possible for red_char_device_write_buffer_get to return NULL.
Handle such situation without crashing avoiding NULL dereference.
This fixes https://bugs.freedesktop.org/show_bug.cgi
>
> On 05/31/2016 03:06 PM, Frediano Ziglio wrote:
> > RedCharDevice used for the agent has flow control enabled.
> > This make possible for red_char_device_write_buffer_get to return NULL.
> > Handle such situation without crashing avoiding NULL dereference.
> >
> > This fixes https://bugs.freede
On Tue, 31 May 2016, Christophe Fergeau wrote:
> On Thu, May 26, 2016 at 05:15:35PM +0200, Francois Gouget wrote:
> > Video frames correspond to QXL_DRAW_COPY operations where the frame area
> > is defined by the SpiceCopy.src_area field.
> >
> > Signed-off-by: Francois Gouget
> > ---
> > serve
On Mon, 2016-05-30 at 21:37 +0200, Francois Gouget wrote:
> We check that there is a matching frame in the queue before popping the
> old ones. So we know the inner loop will find a match and thus that
> frame will not be NULL. But figuring that out is too hard for the
> compiler.
>
> Signed-off-b
On Mon, 2016-05-30 at 19:31 +0200, Marc-André Lureau wrote:
> Signed-off-by: Marc-André Lureau
Acked-by: Pavel Grunt
> ---
> src/channel-base.c | 2 +-
> src/channel-cursor.c | 2 +-
> src/channel-display-gst.c | 4 +--
> src/channel-display-
On Mon, 2016-05-30 at 19:31 +0200, Marc-André Lureau wrote:
> manywarnings.m4 update will bring new flags that fail with some
> glib/gst headers.
>
> Signed-off-by: Marc-André Lureau
Acked-by: Pavel Grunt
> ---
> configure.ac | 5 -
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff
On Mon, 2016-05-30 at 19:31 +0200, Marc-André Lureau wrote:
> Signed-off-by: Marc-André Lureau
Acked-by: Pavel Grunt
> ---
> m4/manywarnings.m4 | 39 ++-
> 1 file changed, 34 insertions(+), 5 deletions(-)
>
> diff --git a/m4/manywarnings.m4 b/m4/manywarnings.
44 matches
Mail list logo