Re: [Spice-devel] [spice-gtk] main: Don't delay update_display_timer(0) for up to 1 second

On Wed, 2016-06-01 at 15:47 +0200, Pavel Grunt wrote: > Hi Christophe, > > On Wed, 2016-05-25 at 18:14 +0200, Christophe Fergeau wrote: > > > > When using remote-viewer --full-screen with a VM/client with multiple > > monitors, a race can be observed during auto-configuration. First, the > >

Re: [Spice-devel] [PATCH] smartcard: Avoid crash on remove_interface call

This patch reminds me that we have still should discuss how to manage cleanup functions. Frediano > > Acked-by: Jonathon Jongsma > > On Wed, 2016-06-01 at 13:40 +0100, Frediano Ziglio wrote: > > SpiceCharDeviceInstance is not a GObject, the GObject is char_device->st > >

Re: [Spice-devel] [PATCH] char-device.h: add needed headers

> > Include spice-common headers for types that are used directly in the > RedCharDevice header. > --- > These includes are not currently needed -- they get pulled in by the > red-channel.h include. But if we decide in the future to remove the > red-channel.h include here and use forward

Re: [Spice-devel] [PATCH 2/3] Remove obsolete comment

Acked-by: Jonathon Jongsma On Tue, 2016-05-31 at 10:53 +0100, Frediano Ziglio wrote: > AGENT_CONNECT with token count is implemented by agent_connected_tokens > message. > > Signed-off-by: Frediano Ziglio > --- >  server/char-device.h | 2 -- >  1 file

Re: [Spice-devel] [PATCH] smartcard: Avoid crash on remove_interface call

Acked-by: Jonathon Jongsma On Wed, 2016-06-01 at 13:40 +0100, Frediano Ziglio wrote: > SpiceCharDeviceInstance is not a GObject, the GObject is char_device->st > as the above line is stating. > The crash never happen as Qemu never calls spice_server_remove_interface > for

Re: [Spice-devel] [PATCH 3/3] Simplify setting char device instance

Looks fine Acked-by: Jonathon Jongsma On Tue, 2016-05-31 at 10:53 +0100, Frediano Ziglio wrote: > Setting "sin" property is equivalent to call > red_char_device_reset_dev_instance so there is no need for a if/else > as the code is doing mostly (beside setting

Re: [Spice-devel] [PATCH 1/3] Fix some typos in comments

Acked-by: Jonathon Jongsma On Tue, 2016-05-31 at 10:53 +0100, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio > --- >  server/char-device.h | 4 ++-- >  server/reds.c| 2 +- >  2 files changed, 3 insertions(+), 3 deletions(-) > > diff

[Spice-devel] [PATCH] channel: Remove clients_num and use g_list_length

clients_num was no more updated correctly. This fixes a regression introduced by 4028fb1c794ef2a212f22b024b1c39f460439e7b. The number of client is quite small so there is no much reason to cache the number of elements. Signed-off-by: Frediano Ziglio ---

Re: [Spice-devel] [spice-gtk v3 02/16] file-xfer: introduce flush_callback and flush_done

Hi, On Wed, Jun 01, 2016 at 03:24:09PM +0200, Pavel Grunt wrote: > Hi Victor, > > I put some questions/comments inline > > On Mon, 2016-05-30 at 11:54 +0200, Victor Toso wrote: > > By introducing a flush_callback such as SpiceFileTransferTaskFlushCb > > SpiceFileTransferTask becomes agnostic on

Re: [Spice-devel] [spice-gtk v3 01/16] file-xfer: get functions for SpiceFileTransferTask

Hi, On Wed, Jun 01, 2016 at 02:42:58PM +0200, Pavel Grunt wrote: > Hi Victor, > > On Mon, 2016-05-30 at 11:54 +0200, Victor Toso wrote: > > In order to channel-main interact with each SpiceFileTransferTask for > > the file-transfer operation, the following functions are introduced: > > *

Re: [Spice-devel] [spice-gtk] main: Don't delay update_display_timer(0) for up to 1 second

Hi Christophe, On Wed, 2016-05-25 at 18:14 +0200, Christophe Fergeau wrote: > When using remote-viewer --full-screen with a VM/client with multiple > monitors, a race can be observed during auto-configuration. First, the > client monitors config is sent to the guest: > (remote-viewer:19480):

Re: [Spice-devel] [spice-gtk] main: Don't delay update_display_timer(0) for up to 1 second

Ping? Christophe On Wed, May 25, 2016 at 06:14:47PM +0200, Christophe Fergeau wrote: > When using remote-viewer --full-screen with a VM/client with multiple > monitors, a race can be observed during auto-configuration. First, the > client monitors config is sent to the guest: >

[Spice-devel] [PATCH] Reset char device when agent is disconnected

Before commit 1cec1c5118b65124de6bc6f984f376ff4e297bfb ("reds: Make VDIPortState a GObject") char device was entirely destroyed. After nothing happens to the device leaving all possible pending data. Do a soft reset to avoid a possible regression. Signed-off-by: Frediano Ziglio

Re: [Spice-devel] [spice-gtk v3 01/16] file-xfer: get functions for SpiceFileTransferTask

Hi Victor, On Mon, 2016-05-30 at 11:54 +0200, Victor Toso wrote: > In order to channel-main interact with each SpiceFileTransferTask for > the file-transfer operation, the following functions are introduced: > * spice_file_transfer_task_get_id (I would go for spice_file_transfer_task_get_task_id

[Spice-devel] [PATCH] smartcard: Avoid crash on remove_interface call

SpiceCharDeviceInstance is not a GObject, the GObject is char_device->st as the above line is stating. The crash never happen as Qemu never calls spice_server_remove_interface for smartcards. Signed-off-by: Frediano Ziglio --- server/smartcard.c | 2 +- 1 file changed, 1

Re: [Spice-devel] [PATCH] streaming: Tweak the GStreamer decoder to avoid a compiler warning

On Wed, 1 Jun 2016, Marc-André Lureau wrote: > hi > > On Mon, May 30, 2016 at 9:37 PM, Francois Gouget > wrote: > > We check that there is a matching frame in the queue before popping the > > old ones. So we know the inner loop will find a match and thus that > > frame

Re: [Spice-devel] [PATCH] streaming: Tweak the GStreamer decoder to avoid a compiler warning

hi On Mon, May 30, 2016 at 9:37 PM, Francois Gouget wrote: > We check that there is a matching frame in the queue before popping the > old ones. So we know the inner loop will find a match and thus that > frame will not be NULL. But figuring that out is too hard for the

Re: [Spice-devel] [PATCH v2] red-parse-qxl: Check consistency of QXL_DRAW_COPY operations

On Wed, 1 Jun 2016, Frediano Ziglio wrote: [...] > Can I suggest > > @@ -682,6 +682,20 @@ static int red_get_copy_ptr(RedMemSlotInfo *slots, int > group_id, > return 1; > } > red_get_rect_ptr(>src_area, >src_area); > +/* The source area should not extend outside the

Re: [Spice-devel] [PATCH v2] red-parse-qxl: Check consistency of QXL_DRAW_COPY operations

> On Fri, 27 May 2016, Frediano Ziglio wrote: > > > > > > > The source area should not extend outside the source bitmap, or have > > > swapped coordinates. > > > > > > Signed-off-by: Francois Gouget > > > --- > > > server/red-parse-qxl.c | 12 > > > 1

Re: [Spice-devel] [PATCH v2] red-parse-qxl: Check consistency of QXL_DRAW_COPY operations

On Fri, 27 May 2016, Frediano Ziglio wrote: > > > > The source area should not extend outside the source bitmap, or have > > swapped coordinates. > > > > Signed-off-by: Francois Gouget > > --- > > server/red-parse-qxl.c | 12 > > 1 file changed, 12

Re: [Spice-devel] [PATCH spice-gtk v5 0/6] Allow ipv6 proxy url

Hi, On Wed, Jun 01, 2016 at 10:04:43AM +0200, Pavel Grunt wrote: > Hi, > > these patches add ipv6 support to SpiceUri, so it can be used in SPICE_PROXY. > > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1335239 Series looks good, thanks! Acked-by: Victor Toso > >

[Spice-devel] [PATCH spice-gtk v5 5/6] spice-uri: Validate uri scheme

Related: rhbz#1335239 Acked-by: Victor Toso --- src/spice-uri.c | 26 -- tests/uri.c | 2 ++ 2 files changed, 18 insertions(+), 10 deletions(-) diff --git a/src/spice-uri.c b/src/spice-uri.c index 7eec6e5..83ebe79 100644 --- a/src/spice-uri.c

[Spice-devel] [PATCH spice-gtk v5 4/6] spice-uri: Check if port is in allowed range

Use g_ascii_strtoll because it helps to detect overflow. Related: rhbz#1335239 Acked-by: Victor Toso --- src/spice-uri.c | 8 ++-- tests/uri.c | 3 +++ 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/src/spice-uri.c b/src/spice-uri.c index

[Spice-devel] [PATCH spice-gtk v5 6/6] spice-uri: Add ipv6 support

Just basic support - http://user:password@[host]:port Resolves: rhbz#1335239 --- src/spice-uri.c | 24 tests/uri.c | 33 + 2 files changed, 53 insertions(+), 4 deletions(-) diff --git a/src/spice-uri.c b/src/spice-uri.c index

[Spice-devel] [PATCH spice-gtk v5 2/6] spice-uri: Reset SpiceURI before parsing

Avoid using old values after parsing a new uri. Related: rhbz#1335239 --- src/spice-uri.c | 17 + tests/uri.c | 1 + 2 files changed, 14 insertions(+), 4 deletions(-) diff --git a/src/spice-uri.c b/src/spice-uri.c index 3bdb502..9f793de 100644 --- a/src/spice-uri.c +++

[Spice-devel] [PATCH spice-gtk v5 1/6] tests: Add test for SpiceURI

Related: rhbz#1335239 --- tests/Makefile.am | 2 ++ tests/uri.c | 103 ++ 2 files changed, 105 insertions(+) create mode 100644 tests/uri.c diff --git a/tests/Makefile.am b/tests/Makefile.am index d56ff1b..1a8b768 100644 ---

[Spice-devel] [PATCH spice-gtk v5 3/6] spice-uri: Do not allow empty port string

Related: rhbz#1335239 Acked-by: Victor Toso --- src/spice-uri.c | 3 +++ tests/uri.c | 1 + 2 files changed, 4 insertions(+) diff --git a/src/spice-uri.c b/src/spice-uri.c index 9f793de..ea25aaa 100644 --- a/src/spice-uri.c +++ b/src/spice-uri.c @@ -176,6 +176,9 @@

[Spice-devel] [PATCH spice-gtk v5 0/6] Allow ipv6 proxy url

Hi, these patches add ipv6 support to SpiceUri, so it can be used in SPICE_PROXY. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1335239 v5 per Victor's review: - renamed tests/test-spice-uri.c to tests/uri.c (binary name is test-spice-uri) - helper function for tests are introduced in

Re: [Spice-devel] [PATCH spice-gtk 4/5] test-session: Also test hostname, username and password

Hi, On Tue, May 31, 2016 at 03:56:06PM +0200, Pavel Grunt wrote: > On Tue, 2016-05-31 at 12:12 +0200, Victor Toso wrote: > > Hi, > > > > On Fri, May 20, 2016 at 02:50:59PM +0200, Pavel Grunt wrote: > > > --- > > >  tests/session.c | 48 +--- > > >  1

Re: [Spice-devel] [PATCH spice-gtk 7/7] build-sys: update manywarnings.m4

On Mon, 2016-05-30 at 19:31 +0200, Marc-André Lureau wrote: > Signed-off-by: Marc-André Lureau Acked-by: Pavel Grunt > --- >  m4/manywarnings.m4 | 39 ++- >  1 file changed, 34 insertions(+), 5 deletions(-) > >

Re: [Spice-devel] [PATCH spice-gtk 5/7] Fix many -Werror=format warnings

On Mon, 2016-05-30 at 19:31 +0200, Marc-André Lureau wrote: > Signed-off-by: Marc-André Lureau Acked-by: Pavel Grunt > --- >  src/channel-base.c |  2 +- >  src/channel-cursor.c   |  2 +- >  

Re: [Spice-devel] [PATCH spice-gtk 6/7] build-sys: -Wshift-overflow=2

On Mon, 2016-05-30 at 19:31 +0200, Marc-André Lureau wrote: > manywarnings.m4 update will bring new flags that fail with some > glib/gst headers. > > Signed-off-by: Marc-André Lureau Acked-by: Pavel Grunt > --- >  configure.ac | 5 - >  1 file

Re: [Spice-devel] [PATCH] streaming: Tweak the GStreamer decoder to avoid a compiler warning

On Mon, 2016-05-30 at 21:37 +0200, Francois Gouget wrote: > We check that there is a matching frame in the queue before popping the > old ones. So we know the inner loop will find a match and thus that > frame will not be NULL. But figuring that out is too hard for the > compiler. > >