Re: [Spice-devel] [PATCH v3 05/17] Move image_encoders_compress_glz to dcc-encoders.c

2016-06-13 Thread Jonathon Jongsma
Acked-by: Jonathon Jongsma On Fri, 2016-06-10 at 09:48 +0100, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio > --- >  server/dcc-encoders.c | 133 + >  server/dcc-encoders.h |   4 ++ >  server/dcc.c  | 147 -

Re: [Spice-devel] [PATCH v3 04/17] Make dcc_compress_image_glz independent to DisplayChannelClient

2016-06-13 Thread Jonathon Jongsma
Acked-by: Jonathon Jongsma On Fri, 2016-06-10 at 09:48 +0100, Frediano Ziglio wrote: > Also rename to image_encoders_compress_glz > > Signed-off-by: Frediano Ziglio > --- >  server/dcc.c | 31 --- >  1 file changed, 16 insertions(+), 15 deletions(-) > > diff --git a

Re: [Spice-devel] [PATCH v3 03/17] Move others glz fields to dcc-encoders

2016-06-13 Thread Jonathon Jongsma
(I see here we add a non-stats field to ImageEncoderGlobals. So per my earlier suggestion, i'd prefer a name of something like ImageEncoderSharedData.) Acked-by: Jonathon Jongsma On Fri, 2016-06-10 at 09:48 +0100, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio > --- >  server/dcc-enco

Re: [Spice-devel] [PATCH v3 02/17] Move some glz fields to ImageEncoders

2016-06-13 Thread Jonathon Jongsma
On Fri, 2016-06-10 at 09:48 +0100, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio > --- >  server/dcc-encoders.c| 99 +++-- > --- >  server/dcc-encoders.h| 22 +++ >  server/dcc-send.c| 10 ++--- >  server/dcc.c | 45

Re: [Spice-devel] [PATCH v3 01/17] Add a structure to hold ImageEncoders global data

2016-06-13 Thread Jonathon Jongsma
The general idea seems good, but I don't really like the name "globals". It doesn't really tell us anything about what it is.  At the moment it only holds stats fields. Will it eventually hold other stuff? If not, I'd prefer a name like ImageEncoderStats. If it does grow fields for non-stats funct

[Spice-devel] [PATCH spice-gtk] widget: use scanout offset when using virgl

2016-06-13 Thread Marc-André Lureau
Ignoring the display area offset doesn't work nicely with virgl. Imho, this condition is wrong even in QXL case. Signed-off-by: Marc-André Lureau --- src/spice-widget.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/spice-widget.c b/src/spice-widget.c index c528614..61a8

Re: [Spice-devel] [spice-gtk PATCH] Handle single headed monitors that have a non-zero x, y config offset

2016-06-13 Thread Marc-André Lureau
Hi On Mon, Jun 22, 2015 at 3:15 PM, Christophe Fergeau wrote: > On Mon, Jun 22, 2015 at 03:03:24PM +0200, Christophe Fergeau wrote: >> On Thu, Jun 18, 2015 at 07:14:13PM -0400, sstut...@redhat.com wrote: >> > From: Sandy Stutsman >> > >> > Each monitor on a Windows guest is represented as a sepa

Re: [Spice-devel] [spice-gtk v2] widget: Do not mix function linkage

2016-06-13 Thread Jonathon Jongsma
Acked-by: Jonathon Jongsma On Fri, 2016-06-10 at 10:56 +0100, Frediano Ziglio wrote: > This prevents a possible crash on windows 32 bit. > The linkage of UnhookWindowsHookEx is WINAPI which is __stdcall while > callback for g_clear_pointer is C. This could cause stack pointer > corruption depen

Re: [Spice-devel] [PATCH] Remove a warning compiling under Windows

2016-06-13 Thread Jonathon Jongsma
Acked-by: Jonathon Jongsma On Mon, 2016-06-13 at 12:31 +0100, Frediano Ziglio wrote: > > On Windows long is always 32 bit so under x64 the cast from pointer to > "unsigned long" cause a warning. > > Signed-off-by: Frediano Ziglio > --- >  common/quic.c | 2 +- >  1 file changed, 1 insertion(+),

[Spice-devel] [PATCH v7 server] LZ4 compression is now available at the Spicevmc channel

2016-06-13 Thread Snir Sheriber
Compressed message type is CompressedData which contains compression type (1 byte) followed by the uncompressed data size (4 bytes - exists only if data was compressed) followed by the compressed data If SPICE_USBREDIR_CAP_DATA_COMPRESS_LZ4 capability is available && data_size > COMPRESS_THRESHOLD

[Spice-devel] [PATCH v7 spice-common 3/3] Add LZ4 data compression and use it in spicevmc channel

2016-06-13 Thread Snir Sheriber
Compressed message type is CompressedData which contains compression type (1 byte) followed by the uncompressed data size (4 bytes-exists only if data was compressed) followed by the compressed data Update the required protocol to 0.12.12: Signed-off-by: Frediano Ziglio Signed-off-by: Snir Sheri

[Spice-devel] [PATCH v7 spice-protocol] LZ4 compression is now available at the Spicevmc channel

2016-06-13 Thread Snir Sheriber
-New message type for compressed messages has been added to the protocol Compressed message type is CompressedData which contains compression type (1 byte) followed by the uncompressed data size (4 bytes -exists only if data was compressed) followed by the compressed data -SPICE_SPICEVMC_CAP_DATA

[Spice-devel] [PATCH v7 spice-common 2/3] extend a comment for type attributes

2016-06-13 Thread Snir Sheriber
From: Frediano Ziglio Signed-off-by: Frediano Ziglio --- python_modules/ptypes.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/python_modules/ptypes.py b/python_modules/ptypes.py index 1f4e068..f4a09f7 100644 --- a/python_modules/ptypes.py +++ b/python_modules/ptypes.py @

[Spice-devel] [PATCH v7 spice-common 1/3] add a check for negate cases on enumerations

2016-06-13 Thread Snir Sheriber
From: Frediano Ziglio --- python_modules/ptypes.py | 1 + 1 file changed, 1 insertion(+) diff --git a/python_modules/ptypes.py b/python_modules/ptypes.py index 74f3e55..1f4e068 100644 --- a/python_modules/ptypes.py +++ b/python_modules/ptypes.py @@ -686,6 +686,7 @@ class SwitchCase:

[Spice-devel] [PATCH v7] LZ4 Usbredir compression

2016-06-13 Thread Snir Sheriber
This is all the parts of the usbredir lz4 compression with the latest fixes changes from v6 -squashed with previous commits & with the proposed changes by Frediano -more info inside the commit msgs -minor fixes -- 2.5.5 ___ Spice-devel mailing list S

[Spice-devel] [PATCH v7 spice-gtk] Usbredir: enable lz4 compression

2016-06-13 Thread Snir Sheriber
Compressed message type is CompressedData which contains compression type (1 byte) followed by the uncompressed data size (4 bytes-exists only if data was compressed) followed by the compressed data If SPICE_SPICEVMC_CAP_DATA_COMPRESS_LZ4 capability is available && data_size > COMPRESS_THRESHOLD &

Re: [Spice-devel] [spice-gtk v3 05/16] file-xfer: inform agent of errors only when task finished

2016-06-13 Thread Victor Toso
Hi, Sorry for taking some time to reply :) On Tue, Jun 07, 2016 at 12:17:40PM -0500, Jonathon Jongsma wrote: > On Tue, 2016-06-07 at 11:14 -0500, Jonathon Jongsma wrote: > > On Sun, 2016-06-05 at 10:38 +0200, Victor Toso wrote: > > > > > > Hi, > > > > > > On Fri, Jun 03, 2016 at 10:17:05AM -050

Re: [Spice-devel] [spice-gtk] Remove some warnings compiling for Windows

2016-06-13 Thread Marc-André Lureau
ack - Original Message - > GetLastError returns a DWORD which is a "unsigned long" on Windows > so use "%lu" formatting instead of "%u". > > Signed-off-by: Frediano Ziglio > --- > src/controller/test.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/src/c

[Spice-devel] [PATCH] Remove a warning compiling under Windows

2016-06-13 Thread Frediano Ziglio
On Windows long is always 32 bit so under x64 the cast from pointer to "unsigned long" cause a warning. Signed-off-by: Frediano Ziglio --- common/quic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common/quic.c b/common/quic.c index f014a2a..5b00d65 100644 --- a/common/qu

[Spice-devel] [spice-gtk] Remove some warnings compiling for Windows

2016-06-13 Thread Frediano Ziglio
GetLastError returns a DWORD which is a "unsigned long" on Windows so use "%lu" formatting instead of "%u". Signed-off-by: Frediano Ziglio --- src/controller/test.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/controller/test.c b/src/controller/test.c index 7c43f

Re: [Spice-devel] [PATCH] Remove deprecated init functions

2016-06-13 Thread Marc-André Lureau
ack - Original Message - > No need to keep API compatibility in spice-common. > > Signed-off-by: Frediano Ziglio > --- > common/quic.h | 2 -- > common/rop3.h | 2 -- > common/sw_canvas.h | 2 -- > 3 files changed, 6 deletions(-) > > diff --git a/common/quic.h b/common/quic.h

[Spice-devel] [PATCH] Remove deprecated init functions

2016-06-13 Thread Frediano Ziglio
No need to keep API compatibility in spice-common. Signed-off-by: Frediano Ziglio --- common/quic.h | 2 -- common/rop3.h | 2 -- common/sw_canvas.h | 2 -- 3 files changed, 6 deletions(-) diff --git a/common/quic.h b/common/quic.h index 97622b3..7c1da85 100644 --- a/common/quic.h +++

Re: [Spice-devel] [PATCH spice-gtk 3/3] channel-display: Remove deprecated init functions

2016-06-13 Thread Pavel Grunt
Hi, On Mon, 2016-06-13 at 06:03 -0400, Marc-André Lureau wrote: > Hi > > - Original Message - > > They are called at the construct time since spice-common commit: > > 5b6be16b37370bb774aa3c2a7d5c41791fdc3a1e > > Ok, ack then (imho the old functions should have been dropped in this commit

Re: [Spice-devel] [spice-gtk] widget: Disable IME context on main widget

2016-06-13 Thread Frediano Ziglio
> > On Fri, Jun 10, 2016 at 08:45:56AM -0400, Frediano Ziglio wrote: > > > > This seems quite strong! I think this will remove the IME context > > even from the Windows desktop :) > > Oh? I just assumed that the win32 hierarchy was more or less the same as > the GTK+ hierarchy, and that iteratin

Re: [Spice-devel] [PATCH spice-gtk 3/3] channel-display: Remove deprecated init functions

2016-06-13 Thread Marc-André Lureau
Hi - Original Message - > They are called at the construct time since spice-common commit: > 5b6be16b37370bb774aa3c2a7d5c41791fdc3a1e Ok, ack then (imho the old functions should have been dropped in this commit, we don't need to have API/ABI stability in spice-common) > --- > src/chan

Re: [Spice-devel] [PATCH spice-gtk 2/3] tests-uri: Define g_assert_nonnull

2016-06-13 Thread Marc-André Lureau
ack - Original Message - > It is available since Glib 2.40 > --- > tests/uri.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/tests/uri.c b/tests/uri.c > index ea8b794..5bfed2d 100644 > --- a/tests/uri.c > +++ b/tests/uri.c > @@ -19,6 +19,11 @@ > #include > #include "sp

Re: [Spice-devel] [PATCH spice-gtk 1/3] Require gtk+ 3.12

2016-06-13 Thread Marc-André Lureau
ack - Original Message - > Allow to use gtk_stack_get_child_by_name > --- > configure.ac | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/configure.ac b/configure.ac > index 3fe8055..6e65188 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -123,8 +123,8 @

Re: [Spice-devel] github mirror

2016-06-13 Thread Kevin Won
Yes, please tell me how, and what I can do to meet the needs. Thank you. From:"Victor Toso"; Date:2016??5??11??(??) 10:09 To:"Marc-Andr?1?7 Lureau"; Cc:"spice-devel";"hsm"; Subject:Re: [Spice-devel] github mirror Hey! On Tue, Nov 24, 2015 at 01:57:11PM +0100, Marc-Andr?

[Spice-devel] 回复: how to use spicy-screenshot without interrupt the normal connection ?

2016-06-13 Thread 赵会波
Hi,  I have a question to ask you,I have know I can exit the fullscreen of spicy connection by using  “Shift + F12”my questio is whether  there is  any method   to  add a sliver or bar  to the fullscreen of spicy connection on the central top of the screen  ?just seems  like the fullscreen of vir

[Spice-devel] [PATCH spice-gtk 1/3] Require gtk+ 3.12

2016-06-13 Thread Pavel Grunt
Allow to use gtk_stack_get_child_by_name --- configure.ac | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index 3fe8055..6e65188 100644 --- a/configure.ac +++ b/configure.ac @@ -123,8 +123,8 @@ AC_ARG_WITH([gtk], [with_gtk=3.0]) case "$with

[Spice-devel] [PATCH spice-gtk 3/3] channel-display: Remove deprecated init functions

2016-06-13 Thread Pavel Grunt
They are called at the construct time since spice-common commit: 5b6be16b37370bb774aa3c2a7d5c41791fdc3a1e --- src/channel-display.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/channel-display.c b/src/channel-display.c index 22e64e2..cf9c583 100644 --- a/src/channel-display.c +++ b/sr

[Spice-devel] [PATCH spice-gtk 2/3] tests-uri: Define g_assert_nonnull

2016-06-13 Thread Pavel Grunt
It is available since Glib 2.40 --- tests/uri.c | 5 + 1 file changed, 5 insertions(+) diff --git a/tests/uri.c b/tests/uri.c index ea8b794..5bfed2d 100644 --- a/tests/uri.c +++ b/tests/uri.c @@ -19,6 +19,11 @@ #include #include "spice-uri-priv.h" +/* GLIB_CHECK_VERSION(2, 40, 0) */ +#if

Re: [Spice-devel] 回复: how to use spicy-screenshot without interrupt the normal connection ?

2016-06-13 Thread Marc-André Lureau
Hi - Original Message - > Hi, >  I have a question to ask you,I have know I can exit the fullscreen of spicy >  connection by using  “Shift + F12”my questio is whether  there is  any >  method  to  add a sliver or bar  to the fullscreen of spicy connection on >  the central top of the scre