Hi Jonathon,
On Tue, 2016-06-14 at 16:04 -0500, Jonathon Jongsma wrote:
> Having a goto label in the middle of a switch/case statement is a bit
> confusing. But the same behavior can be achieved
it changes the behavior - if LZ4 compression is selected on server but it is not
supported on the cli
On Tue, 2016-06-14 at 10:33 +0100, Frediano Ziglio wrote:
> The field was used just as a flag.
> This has the advantage to make clear to not use the pointer as we don't
> have ownership.
> Also many the structure a bit smaller.
s/many/makes/
Acked-by: Jonathon Jongsma
>
> Signed-off-by: Fredia
Acked-by: Jonathon Jongsma
On Tue, 2016-06-14 at 10:33 +0100, Frediano Ziglio wrote:
> Avoid to access some fields from dcc.c
>
> Signed-off-by: Frediano Ziglio
> ---
> server/dcc-encoders.c | 4
> server/dcc.c | 3 ---
> 2 files changed, 4 insertions(+), 3 deletions(-)
>
> dif
Having a goto label in the middle of a switch/case statement is a bit
confusing. But the same behavior can be achieved by simply rearranging
the cases so that we fall through to the one that we wanted to jump to.
---
This should apply on top of frediano's encapsulation patch series.
server/dcc.c
On Tue, 2016-06-14 at 10:33 +0100, Frediano Ziglio wrote:
> Do not access too much encoders data.
> Slightly different as now if glz is frozen lz compression is used.
This *seems* safe, though I don't know the code enough to know what
side-effects
it might have. Would like a second opinion.
>
Acked-by: Jonathon Jongsma
On Tue, 2016-06-14 at 10:33 +0100, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> server/dcc-encoders.c | 4 +++-
> server/dcc-encoders.h | 1 -
> server/dcc.c | 1 -
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/serve
Acked-by: Jonathon Jongsma
On Tue, 2016-06-14 at 10:33 +0100, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> server/dcc-encoders.c | 10 ++
> server/dcc-encoders.h | 2 ++
> server/dcc-send.c | 8 ++--
> 3 files changed, 14 insertions(+), 6 deletions(-)
>
>
On 06/14/2016 10:24 AM, Christophe Fergeau wrote:
> Hey,
>
> So I've finally pushed all of the spice-server bits save for the
> patch trying to guess the number of CPUs to use for the vp8 encoder
> (hopefully I did not introduce rebase issues).
>
> Thanks a lot (again) for all the work, and sorry
Hi
On Tue, Jun 14, 2016 at 10:46 AM, Christophe Fergeau
wrote:
>> Imho, the fix should be on server or guest/driver side, it shouldn't
>> use a display monitor config with a scanout offset if there is none to
>> be applied by the client.
>
> Regarding fixing this on the server, isn't it going to
Great job both of you!
Frediano
>
> Hey,
>
> So I've finally pushed all of the spice-server bits save for the
> patch trying to guess the number of CPUs to use for the vp8 encoder
> (hopefully I did not introduce rebase issues).
>
> Thanks a lot (again) for all the work, and sorry for the time
Hey,
So I've finally pushed all of the spice-server bits save for the
patch trying to guess the number of CPUs to use for the vp8 encoder
(hopefully I did not introduce rebase issues).
Thanks a lot (again) for all the work, and sorry for the time it took to
get this in :(
Christophe
On Tue, Ju
Acked-by: Jonathon Jongsma
On Tue, 2016-06-14 at 10:33 +0100, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> server/dcc-encoders.c | 4 ++--
> server/dcc-encoders.h | 2 --
> 2 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/server/dcc-encoders.c b/server/dcc-
On Tue, 2016-06-14 at 10:14 -0500, Jonathon Jongsma wrote:
> Rename this function to red_glz_drawable_free() and remove the
> ImageEncoders argument since the RedGlzDrawable already holds a pointer
> to the ImageEncoders structure
> ---
> server/dcc-encoders.c | 17 +
> 1 file chan
Rename this function to red_glz_drawable_free() and remove the
ImageEncoders argument since the RedGlzDrawable already holds a pointer
to the ImageEncoders structure
---
server/dcc-encoders.c | 17 +
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/server/dcc-encoders.
Rename this function to glz_drawable_instance_item_free() and remove the
ImageEncoders argument since the RedGlzDrawable already holds a pointer
to the ImageEncoders structure.
---
server/dcc-encoders.c | 15 ++-
1 file changed, 6 insertions(+), 9 deletions(-)
diff --git a/server/dcc-
These patches should apply on top of Frediano's "Better encapsulation of image
encoding stuff" patch series.
Jonathon Jongsma (2):
Rename image_encoders_free_glz_drawable_instance()
Rename image_encoders_free_glz_drawable()
server/dcc-encoders.c | 32 +++-
1 file
On Tue, 2016-06-14 at 10:32 +0100, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> server/dcc-encoders.c| 60 ++-
> -
> server/dcc-encoders.h| 33 ++
> server/display-channel.c | 13 +++
> server/d
Acked-by: Jonathon Jongsma
On Mon, 2016-06-13 at 12:31 +0100, Frediano Ziglio wrote:
> On Windows long is always 32 bit so under x64 the cast from pointer to
> "unsigned long" cause a warning.
>
> Signed-off-by: Frediano Ziglio
> ---
> common/quic.c | 2 +-
> 1 file changed, 1 insertion(+), 1
Acked-by: Jonathon Jongsma
On Tue, 2016-06-14 at 10:32 +0100, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> server/dcc-encoders.c | 4 +---
> server/dcc-encoders.h | 2 +-
> server/dcc.c | 2 +-
> 3 files changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/ser
Acked-by: Jonathon Jongsma
On Tue, 2016-06-14 at 10:32 +0100, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> server/dcc-encoders.c| 121 +++---
> -
> server/dcc-encoders.h| 33 +
> server/dcc.c | 26 +++
This is a minor fix in the logic as in both situations (with or
without the patch) the reference count for the SpiceFileTransferTask
object is the same.
The change is interesting as SpiceFileTransferTask is created but on
g_file_read_async() it increases its reference count while
c->file_xfer_task
On Tue, 2016-06-14 at 14:28 +0200, Victor Toso wrote:
Acked-by: Pavel Grunt
> ---
> src/channel-main.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/channel-main.c b/src/channel-main.c
> index 89675d5..e7171c1 100644
> --- a/src/channel-main.c
> +++ b/src/channel
---
src/channel-main.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/channel-main.c b/src/channel-main.c
index 89675d5..e7171c1 100644
--- a/src/channel-main.c
+++ b/src/channel-main.c
@@ -3181,12 +3181,13 @@ void spice_main_file_copy_async(SpiceMainChannel
*channel,
Signed-off-by: Frediano Ziglio
---
server/dcc-encoders.c | 4 +++-
server/dcc-encoders.h | 1 -
server/dcc.c | 1 -
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/server/dcc-encoders.c b/server/dcc-encoders.c
index f423f22..6668dff 100644
--- a/server/dcc-encoders.c
+++ b
Remove some coupling, we mainly need to store a list of RedGlzDrawables.
Signed-off-by: Frediano Ziglio
---
server/dcc-encoders.c| 8
server/dcc-encoders.h| 4 ++--
server/display-channel.c | 4 ++--
3 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/server/dcc-encod
Signed-off-by: Frediano Ziglio
---
server/dcc-encoders.c| 60 ++--
server/dcc-encoders.h| 33 ++
server/display-channel.c | 13 +++
server/display-channel.h | 5
4 files changed, 63 insertions(+), 48 deletio
This buffer was just written and then used, no reason to store into
a more persistent structure.
Signed-off-by: Frediano Ziglio
---
server/dcc-encoders.c | 34 ++
server/dcc-encoders.h | 1 -
2 files changed, 18 insertions(+), 17 deletions(-)
diff --git a/server
Signed-off-by: Frediano Ziglio
---
server/dcc-encoders.c | 10 ++
server/dcc-encoders.h | 2 ++
server/dcc-send.c | 8 ++--
3 files changed, 14 insertions(+), 6 deletions(-)
diff --git a/server/dcc-encoders.c b/server/dcc-encoders.c
index 13dbff5..2e5984a 100644
--- a/server/dc
Do not access too much encoders data.
Slightly different as now if glz is frozen lz compression is used.
Signed-off-by: Frediano Ziglio
---
server/dcc-encoders.c | 15 +++
server/dcc.c | 17 -
2 files changed, 19 insertions(+), 13 deletions(-)
diff --git a/s
Also rename to image_encoders_compress_glz
Signed-off-by: Frediano Ziglio
Acked-by: Jonathon Jongsma
---
server/dcc.c | 31 ---
1 file changed, 16 insertions(+), 15 deletions(-)
diff --git a/server/dcc.c b/server/dcc.c
index 6060b7d..9007afb 100644
--- a/server/dcc.
Signed-off-by: Frediano Ziglio
Acked-by: Jonathon Jongsma
---
server/dcc-encoders.c| 76 +---
server/dcc-encoders.h| 19 +++-
server/dcc.c | 18 +---
server/dcc.h | 5
server/display-channel.c | 12
Signed-off-by: Frediano Ziglio
---
server/dcc-encoders.c | 4 ++--
server/dcc-encoders.h | 2 --
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/server/dcc-encoders.c b/server/dcc-encoders.c
index 2e5984a..f423f22 100644
--- a/server/dcc-encoders.c
+++ b/server/dcc-encoders.c
@@ -5
Avoid to access some fields from dcc.c
Signed-off-by: Frediano Ziglio
---
server/dcc-encoders.c | 4
server/dcc.c | 3 ---
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/server/dcc-encoders.c b/server/dcc-encoders.c
index 3547adc..22cfcf3 100644
--- a/server/dcc-enc
Signed-off-by: Frediano Ziglio
Acked-by: Jonathon Jongsma
---
server/dcc-encoders.c | 133 +
server/dcc-encoders.h | 4 ++
server/dcc.c | 147 --
3 files changed, 137 insertions(+), 147 deletio
Avoid dependencies from RedChannel stuff.
Signed-off-by: Frediano Ziglio
---
server/dcc-encoders.h | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/server/dcc-encoders.h b/server/dcc-encoders.h
index 47051b4..75962ad 100644
--- a/server/dcc-encoders.h
+++ b/server/dcc-en
The field was used just as a flag.
This has the advantage to make clear to not use the pointer as we don't
have ownership.
Also many the structure a bit smaller.
Signed-off-by: Frediano Ziglio
---
server/dcc-encoders.c | 12 +---
1 file changed, 5 insertions(+), 7 deletions(-)
diff --gi
Signed-off-by: Frediano Ziglio
---
server/dcc-encoders.c| 14 ++
server/dcc-encoders.h| 2 ++
server/display-channel.c | 18 +-
3 files changed, 21 insertions(+), 13 deletions(-)
diff --git a/server/dcc-encoders.c b/server/dcc-encoders.c
index a83794e..7b129e
Signed-off-by: Frediano Ziglio
---
server/dcc-encoders.c| 121 +++
server/dcc-encoders.h| 33 +
server/dcc.c | 26 +-
server/display-channel.c | 73 ++--
server/display-channel.h | 9 +
Encoding image requires a RedDrawable (where the data is stored) and
a Ring where to store information to free Glz structures.
Signed-off-by: Frediano Ziglio
---
server/dcc-encoders.c | 17 ++---
server/dcc-encoders.h | 3 ++-
server/dcc.c | 4 +++-
3 files changed, 15 ins
Signed-off-by: Frediano Ziglio
---
server/dcc-encoders.c | 10 ++
server/dcc-encoders.h | 11 +--
2 files changed, 11 insertions(+), 10 deletions(-)
diff --git a/server/dcc-encoders.c b/server/dcc-encoders.c
index 7b129e4..4c7d73e 100644
--- a/server/dcc-encoders.c
+++ b/server/d
Hi,
after the discussion and tests to reduce typedef mess I realized
the code lack some proper encapsulation.
In DisplayChannel there are multiple files to handle different stuff
but all code needs to know all structures and basically include all
stuff.
Looking at code one stuff that could/should
Signed-off-by: Frediano Ziglio
---
server/dcc-encoders.c | 4 +---
server/dcc-encoders.h | 2 +-
server/dcc.c | 2 +-
3 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/server/dcc-encoders.c b/server/dcc-encoders.c
index c03409c..7497029 100644
--- a/server/dcc-encoders.c
+++
Signed-off-by: Frediano Ziglio
Acked-by: Jonathon Jongsma
---
server/dcc-encoders.c| 95 +++-
server/dcc-encoders.h| 20 +++---
server/dcc-send.c| 10 ++---
server/dcc.c | 43 +++---
server/dcc.h
On Mon, Jun 13, 2016 at 07:09:29PM +0200, Marc-André Lureau wrote:
> My understanding is that there is some confusing between monitor
> configuration position (the monitor config on main channel), and the
> scanout/primary position (the monitor config on display channel).
>
> Imho, the fix should
Hey,
On Mon, Jun 13, 2016 at 06:07:53AM -0400, Frediano Ziglio wrote:
> >
> > On Fri, Jun 10, 2016 at 08:45:56AM -0400, Frediano Ziglio wrote:
> > >
> > > This seems quite strong! I think this will remove the IME context
> > > even from the Windows desktop :)
> >
> > Oh? I just assumed that the
Hey,
On Mon, Jun 13, 2016 at 07:09:29PM +0200, Marc-André Lureau wrote:
> >> On Thu, Jun 18, 2015 at 07:14:13PM -0400, sstut...@redhat.com wrote:
> >> > From: Sandy Stutsman
> >> >
> >> > Each monitor on a Windows guest is represented as a separate,
> >> > single-headed
> >> > device with its ow
>
> Compressed message type is CompressedData which contains compression
> type (1 byte) followed by the uncompressed data size (4 bytes - exists
> only if data was compressed) followed by the compressed data
>
> If SPICE_USBREDIR_CAP_DATA_COMPRESS_LZ4 capability is available &&
> data_size > COM
>
> Compressed message type is CompressedData which contains compression
> type (1 byte) followed by the uncompressed data size (4 bytes-exists
> only if data was compressed) followed by the compressed data
>
> Update the required protocol to 0.12.12:
>
> Signed-off-by: Frediano Ziglio
> Signed
>
> -New message type for compressed messages has been added to the protocol
>
> Compressed message type is CompressedData which contains compression
> type (1 byte) followed by the uncompressed data size (4 bytes -exists
> only if data was compressed) followed by the compressed data
>
> -SPICE_
49 matches
Mail list logo