Re: [Spice-devel] [PATCH 4/8] Make servers global static

Acked-by: Jonathon Jongsma On Mon, 2016-06-20 at 10:15 +0100, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio > --- >  server/reds.c | 2 +- >  1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/server/reds.c b/server/reds.c > index

Re: [Spice-devel] [PATCH 3/8] Constify spice_server_char_device_recognized_subtypes

There aren't many users of spice-server, and the required fix is pretty small here, but I don't think we should break API for this unless there's a really good reason coming in the following patches... Reviewed-by: Jonathon Jongsma On Mon, 2016-06-20 at 10:15 +0100,

Re: [Spice-devel] [PATCH 2/8] Make spice_server_char_device_recognized_subtypes_list static

Acked-by: Jonathon Jongsma On Mon, 2016-06-20 at 10:15 +0100, Frediano Ziglio wrote: > Not used outside the compile unit. > > Signed-off-by: Frediano Ziglio > --- >  server/reds.c | 2 +- >  1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [Spice-devel] [PATCH 1/8] Constify event_loop_core

On Mon, 2016-06-20 at 10:15 +0100, Frediano Ziglio wrote: > Was used as write variable only for testing. > Avoid usage of not constant globals. It'd be nice to expand just a little bit more on the how this change benefits us.  > > Signed-off-by: Frediano Ziglio > --- >  

Re: [Spice-devel] [PATCH 4/5] Refactory Glz RedDrawable retention code

On Fri, 2016-06-17 at 14:58 +0100, Frediano Ziglio wrote: > The code was quite complicated. > - a GlzEncDictImageContext was bound to a GlzDrawableInstanceItem >   (1-1 relation); > - multiple GlzDrawableInstanceItem were attached to RedGlzDrawable; > - multiple RedGlzDrawable (one for RedClient)

Re: [Spice-devel] [NSIS 1/5] packaging: bump version to 4.1

On Tue, Jun 21, 2016 at 10:24 PM, Yedidyah Bar David wrote: > On Tue, Jun 21, 2016 at 6:05 PM, Christophe Fergeau > wrote: >> Were there any changes? > > No. > >> If yes, a "Changes since v2" would be useful, if >> not, it's not strictly needed to resend as

Re: [Spice-devel] [NSIS 1/5] packaging: bump version to 4.1

On Tue, Jun 21, 2016 at 6:05 PM, Christophe Fergeau wrote: > Were there any changes? No. > If yes, a "Changes since v2" would be useful, if > not, it's not strictly needed to resend as this was ack'ed already. Can't see it merged on [1]. Is the repo now hosted elsewhere?

Re: [Spice-devel] [NSIS 5/5] ovirt: Add ovirt-guest-agent service removal

> On Jun 21, 2016, at 5:11 PM, Christophe Fergeau wrote: > > > On Tue, Jun 21, 2016 at 05:26:33PM +0300, Yedidyah Bar David wrote: >> From: Vinzenz Feenstra >> >> Previously the ovirt guest agent service registration has not been >> removed during

[Spice-devel] ANNOUNCE: spice-gtk v0.32 released

Hi! The Spice team is pleased to release a new spice-gtk version 0.32, and celebrate summer (to come in Paris...), with the following highlights: libspice-client-gtk API/ABI break: library soname/version has been bumped, and deprecated symbols have been removed. In practice, most of the API (in

Re: [Spice-devel] [NSIS 5/5] ovirt: Add ovirt-guest-agent service removal

On Tue, Jun 21, 2016 at 05:26:33PM +0300, Yedidyah Bar David wrote: > From: Vinzenz Feenstra > > Previously the ovirt guest agent service registration has not been > removed during the uninstallation. > This patch adds the removal code. Isn't this supposed to be handled by

Re: [Spice-devel] [NSIS 4/5] ovirt: Remove all files install by the ovirt-guest-agent

Acked-by: Christophe Fergeau On Tue, Jun 21, 2016 at 05:26:32PM +0300, Yedidyah Bar David wrote: > From: Vinzenz Feenstra > > Previously we left behind: > - default.ini > - default-logger.ini > - ovirt-guest-agent.ini > - vcredist_x86.exe > >

Re: [Spice-devel] [NSIS 3/5] OVirtGuestService.exe is a File not a Directory to remove

Acked-by: Christophe Fergeau On Tue, Jun 21, 2016 at 05:26:31PM +0300, Yedidyah Bar David wrote: > From: Vinzenz Feenstra > > Change-Id: Ie71a0164c33d41aa1945f6dfe6feb6e54d1806e1 > Signed-off-by: Vinzenz Feenstra > --- >

Re: [Spice-devel] [NSIS 1/5] packaging: bump version to 4.1

Were there any changes? If yes, a "Changes since v2" would be useful, if not, it's not strictly needed to resend as this was ack'ed already. Christophe On Tue, Jun 21, 2016 at 05:26:29PM +0300, Yedidyah Bar David wrote: > Change-Id: I1961132f01baf4e655a414f1b586576c1eb6d4a0 > Signed-off-by:

[Spice-devel] [NSIS 5/5] ovirt: Add ovirt-guest-agent service removal

From: Vinzenz Feenstra Previously the ovirt guest agent service registration has not been removed during the uninstallation. This patch adds the removal code. Change-Id: I9e2f89b01468ea51fe64afb68a75c50eb21888c1 Signed-off-by: Vinzenz Feenstra ---

[Spice-devel] [NSIS 3/5] OVirtGuestService.exe is a File not a Directory to remove

From: Vinzenz Feenstra Change-Id: Ie71a0164c33d41aa1945f6dfe6feb6e54d1806e1 Signed-off-by: Vinzenz Feenstra --- win-guest-tools.nsis | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/win-guest-tools.nsis b/win-guest-tools.nsis index

[Spice-devel] [NSIS 2/5] Add guest agent hooks directories

From: Vinzenz Feenstra For the new lifecycle events hook feature of the ovirt guest agent the following directories should be installed, so it's more easy for users to know where to put their hooks. Change-Id: Ia815927a8f5e9e1adf216389fa404f80a6bf7ed7 Bug-Url:

[Spice-devel] [NSIS 4/5] ovirt: Remove all files install by the ovirt-guest-agent

From: Vinzenz Feenstra Previously we left behind: - default.ini - default-logger.ini - ovirt-guest-agent.ini - vcredist_x86.exe Change-Id: If625ea358d0808bbee70bff9124d4f4e083157dc Signed-off-by: Vinzenz Feenstra --- win-guest-tools.nsis | 5 + 1

[Spice-devel] [NSIS 1/5] packaging: bump version to 4.1

Change-Id: I1961132f01baf4e655a414f1b586576c1eb6d4a0 Signed-off-by: Yedidyah Bar David --- ovirt-guest-tools-iso.spec.in | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/ovirt-guest-tools-iso.spec.in b/ovirt-guest-tools-iso.spec.in index c91da04..0cd6e09

Re: [Spice-devel] [PATCH spice-gtk 2/2] session: Keep brackets around ipv6 hostname

> According to rfc2732: > "To use a literal IPv6 address in a URL, the literal address should be > enclosed in "[" and "]" characters." > Yes, but this does not apply as the address is not used in a URL but came from a URL. But perhaps is coherent with "host" property: /** *

Re: [Spice-devel] [PATCH spice-gtk 2/2] session: Keep brackets around ipv6 hostname

ack - Original Message - > According to rfc2732: > "To use a literal IPv6 address in a URL, the literal address should be > enclosed in "[" and "]" characters." > > Resolves: rhbz#1331777 > --- > src/spice-session.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [Spice-devel] [PATCH spice-gtk 1/2] session: Removed write-only variable

- Original Message - > --- > src/spice-session.c | 4 > 1 file changed, 4 deletions(-) > > diff --git a/src/spice-session.c b/src/spice-session.c > index 8b3cdd0..888d9fb 100644 > --- a/src/spice-session.c > +++ b/src/spice-session.c > @@ -416,7 +416,6 @@ static int

[Spice-devel] [PATCH spice-gtk 2/2] session: Keep brackets around ipv6 hostname

According to rfc2732: "To use a literal IPv6 address in a URL, the literal address should be enclosed in "[" and "]" characters." Resolves: rhbz#1331777 --- src/spice-session.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/spice-session.c b/src/spice-session.c index

[Spice-devel] [PATCH spice-gtk 1/2] session: Removed write-only variable

--- src/spice-session.c | 4 1 file changed, 4 deletions(-) diff --git a/src/spice-session.c b/src/spice-session.c index 8b3cdd0..888d9fb 100644 --- a/src/spice-session.c +++ b/src/spice-session.c @@ -416,7 +416,6 @@ static int spice_parse_uri(SpiceSession *session, const char

Re: [Spice-devel] [spice-common 3/3] codegen: Autogenerate client_marshallers.h

> > On Tue, Jun 21, 2016 at 07:22:34AM -0400, Frediano Ziglio wrote: > > > On Tue, Jun 21, 2016 at 05:15:54AM -0400, Frediano Ziglio wrote: > > > > About the macro, what about > > > > > > > > > > > > diff --git a/python_modules/marshal.py b/python_modules/marshal.py > > > > index

Re: [Spice-devel] [NSIS] Add guest agent hooks directories

> On Jun 21, 2016, at 1:13 PM, Christophe Fergeau wrote: > > On Tue, Jun 21, 2016 at 01:08:19PM +0200, Vinzenz Feenstra wrote: >> >>> On Jun 21, 2016, at 12:30 PM, Christophe Fergeau >>> wrote: >>> >>> On Tue, Jun 21, 2016 at 12:02:22PM +0300,

Re: [Spice-devel] [PATCH spice-gtk] Update NEWS for 0.32 release

- Original Message - > Hi, > > On Tue, 2016-06-21 at 14:28 +0200, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > Signed-off-by: Marc-André Lureau > > --- > >  NEWS | 30 ++ > >

Re: [Spice-devel] [PATCH spice-gtk] Update NEWS for 0.32 release

Hi, On Tue, 2016-06-21 at 14:28 +0200, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Signed-off-by: Marc-André Lureau > --- >  NEWS | 30 ++ >  1 file changed, 30 insertions(+) > > diff

[Spice-devel] [PATCH spice-gtk] Update NEWS for 0.32 release

From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- NEWS | 30 ++ 1 file changed, 30 insertions(+) diff --git a/NEWS b/NEWS index 7e040bf..2a2d26c 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,33 @@ +v0.32

Re: [Spice-devel] [spice-gtk] main: channel-main to increase file-transfer reference

Hi, On Tue, Jun 21, 2016 at 02:00:23PM +0200, Marc-André Lureau wrote: > ack Thanks, pushed > > On Tue, Jun 14, 2016 at 3:01 PM, Victor Toso wrote: > > This is a minor fix in the logic as in both situations (with or > > without the patch) the reference count for the

Re: [Spice-devel] [spice-gtk] main: assign variable after check for null

Hi, On Tue, Jun 14, 2016 at 02:30:23PM +0200, Pavel Grunt wrote: > On Tue, 2016-06-14 at 14:28 +0200, Victor Toso wrote: > Acked-by: Pavel Grunt Thanks, pushed > > --- > >  src/channel-main.c | 3 ++- > >  1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git

Re: [Spice-devel] [spice-gtk] main: channel-main to increase file-transfer reference

ack On Tue, Jun 14, 2016 at 3:01 PM, Victor Toso wrote: > This is a minor fix in the logic as in both situations (with or > without the patch) the reference count for the SpiceFileTransferTask > object is the same. > > The change is interesting as SpiceFileTransferTask is

Re: [Spice-devel] [NSIS] packaging: bump version to 4.1

On Tue, Jun 21, 2016 at 1:31 PM, Christophe Fergeau wrote: > Acked-by: Christophe Fergeau OK, please merge. Thanks. > > On Tue, Jun 21, 2016 at 01:17:05PM +0300, Yedidyah Bar David wrote: >> Change-Id: I1961132f01baf4e655a414f1b586576c1eb6d4a0 >>

Re: [Spice-devel] [PATCH 2/3] extend a comment for type attributes

Acked-by: Christophe Fergeau On Tue, Jun 21, 2016 at 10:26:59AM +0100, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio > --- > python_modules/ptypes.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [Spice-devel] [PATCH 3/3] Use a macro to simplify ring_get_length

Acked-by: Christophe Fergeau On Tue, Jun 21, 2016 at 10:27:00AM +0100, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio > --- > common/ring.h | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/common/ring.h

Re: [Spice-devel] [PATCH 1/3] add a check for negate cases on enumerations

On Tue, Jun 21, 2016 at 10:26:58AM +0100, Frediano Ziglio wrote: > Not supported by code so trigger an error to avoid invalid usages There are probably a lot of such cases which are not properly caught fwiw, but why not for this one. Acked-by: Christophe Fergeau > >

Re: [Spice-devel] [spice-common 3/3] codegen: Autogenerate client_marshallers.h

On Tue, Jun 21, 2016 at 07:22:34AM -0400, Frediano Ziglio wrote: > > On Tue, Jun 21, 2016 at 05:15:54AM -0400, Frediano Ziglio wrote: > > > About the macro, what about > > > > > > > > > diff --git a/python_modules/marshal.py b/python_modules/marshal.py > > > index cd4b4fa..c2235e2 100644 > > >

Re: [Spice-devel] [spice-common 3/3] codegen: Autogenerate client_marshallers.h

> > On Tue, Jun 21, 2016 at 05:15:54AM -0400, Frediano Ziglio wrote: > > About the macro, what about > > > > > > diff --git a/python_modules/marshal.py b/python_modules/marshal.py > > index cd4b4fa..c2235e2 100644 > > --- a/python_modules/marshal.py > > +++ b/python_modules/marshal.py > > @@

Re: [Spice-devel] [NSIS] Add guest agent hooks directories

On Tue, Jun 21, 2016 at 01:08:19PM +0200, Vinzenz Feenstra wrote: > > > On Jun 21, 2016, at 12:30 PM, Christophe Fergeau > > wrote: > > > > On Tue, Jun 21, 2016 at 12:02:22PM +0300, Yedidyah Bar David wrote: > >> From: Vinzenz Feenstra > >> > >> For

Re: [Spice-devel] [NSIS] Add guest agent hooks directories

> On Jun 21, 2016, at 12:30 PM, Christophe Fergeau wrote: > > On Tue, Jun 21, 2016 at 12:02:22PM +0300, Yedidyah Bar David wrote: >> From: Vinzenz Feenstra >> >> For the new lifecycle events hook feature of the ovirt guest agent >> the following

Re: [Spice-devel] [spice-common 3/3] codegen: Autogenerate client_marshallers.h

On Tue, Jun 21, 2016 at 05:15:54AM -0400, Frediano Ziglio wrote: > About the macro, what about > > > diff --git a/python_modules/marshal.py b/python_modules/marshal.py > index cd4b4fa..c2235e2 100644 > --- a/python_modules/marshal.py > +++ b/python_modules/marshal.py > @@ -1,13 +1,20 @@ > >

Re: [Spice-devel] [NSIS] packaging: bump version to 4.1

Acked-by: Christophe Fergeau On Tue, Jun 21, 2016 at 01:17:05PM +0300, Yedidyah Bar David wrote: > Change-Id: I1961132f01baf4e655a414f1b586576c1eb6d4a0 > Signed-off-by: Yedidyah Bar David > --- > ovirt-guest-tools-iso.spec.in | 5 - > 1 file changed, 4

Re: [Spice-devel] [NSIS] Add guest agent hooks directories

On Tue, Jun 21, 2016 at 12:02:22PM +0300, Yedidyah Bar David wrote: > From: Vinzenz Feenstra > > For the new lifecycle events hook feature of the ovirt guest agent > the following directories should be installed, so it's more easy > for users to know where to put their

[Spice-devel] [spice-common] Adjust verify.h licence

verify.h can be licensed as LGPLv2+ rather than GPLv3, see http://git.savannah.gnu.org/gitweb/?p=gnulib.git;a=blob;f=modules/verify;h=5216ce890dac58e596a27341e31258e5d6c0d702;hb=HEAD A verify.h file with the appropriate licence can be generated from a gnulib clone using: gnulib-tool --lgpl=2

Re: [Spice-devel] [spice-common] Adjust verify.h licence

ack - Original Message - > verify.h can be licensed as LGPLv2+ rather than GPLv3, see > http://git.savannah.gnu.org/gitweb/?p=gnulib.git;a=blob;f=modules/verify;h=5216ce890dac58e596a27341e31258e5d6c0d702;hb=HEAD > > A verify.h file with the appropriate licence can be generated from a >

[Spice-devel] [NSIS] packaging: bump version to 4.1

Change-Id: I1961132f01baf4e655a414f1b586576c1eb6d4a0 Signed-off-by: Yedidyah Bar David --- ovirt-guest-tools-iso.spec.in | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/ovirt-guest-tools-iso.spec.in b/ovirt-guest-tools-iso.spec.in index c91da04..0cd6e09

[Spice-devel] [PATCH 2/3] extend a comment for type attributes

Signed-off-by: Frediano Ziglio --- python_modules/ptypes.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/python_modules/ptypes.py b/python_modules/ptypes.py index 1f4e068..f4a09f7 100644 --- a/python_modules/ptypes.py +++ b/python_modules/ptypes.py @@

[Spice-devel] [PATCH 3/3] Use a macro to simplify ring_get_length

Signed-off-by: Frediano Ziglio --- common/ring.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/common/ring.h b/common/ring.h index b13bc7d..4b0e313 100644 --- a/common/ring.h +++ b/common/ring.h @@ -155,9 +155,7 @@ static inline unsigned int

[Spice-devel] [PATCH 1/3] add a check for negate cases on enumerations

Not supported by code so trigger an error to avoid invalid usages Signed-off-by: Frediano Ziglio --- python_modules/ptypes.py | 1 + 1 file changed, 1 insertion(+) diff --git a/python_modules/ptypes.py b/python_modules/ptypes.py index 74f3e55..1f4e068 100644 ---

Re: [Spice-devel] [spice-common 3/3] codegen: Autogenerate client_marshallers.h

About the macro, what about diff --git a/python_modules/marshal.py b/python_modules/marshal.py index cd4b4fa..c2235e2 100644 --- a/python_modules/marshal.py +++ b/python_modules/marshal.py @@ -1,13 +1,20 @@ from . import ptypes from . import codegen +import re def write_includes(writer):

[Spice-devel] [NSIS] Add guest agent hooks directories

From: Vinzenz Feenstra For the new lifecycle events hook feature of the ovirt guest agent the following directories should be installed, so it's more easy for users to know where to put their hooks. Change-Id: Ia815927a8f5e9e1adf216389fa404f80a6bf7ed7 Bug-Url:

Re: [Spice-devel] [spice-common 3/3] codegen: Autogenerate client_marshallers.h

On Mon, Jun 20, 2016 at 05:06:25PM +0200, Christophe Fergeau wrote: > This commit adds autogeneration of a generated_client_marshallers.h > header, which is then included in client_marshallers.h > > This allows to remove the SpiceMessageMarshallers struct from this file, > which has to match what

[Spice-devel] [NSIS] Add guest agent hooks directories

From: Vinzenz Feenstra For the new lifecycle events hook feature of the ovirt guest agent the following directories should be installed, so it's more easy for users to know where to put their hooks. Change-Id: Ia815927a8f5e9e1adf216389fa404f80a6bf7ed7 Bug-Url:

Re: [Spice-devel] Help :Build error of "mingw32-configure --prefix=$INST_ROOT"

Hi Pavel, Thanks a lot for your reply! I will try it. koizumi On 2016/06/21 15:41, Pavel Grunt wrote: Hi, you need to install dependencies, everything is on the latest Fedora, so let dnf help you with it: sudo dnf builddep mingw-spice-gtk Pavel On Tue, 2016-06-21 at 09:48 +0900, 小泉

Re: [Spice-devel] Help :Build error of "mingw32-configure --prefix=$INST_ROOT"

Hi, you need to install dependencies, everything is on the latest Fedora, so let dnf help you with it:   sudo dnf builddep mingw-spice-gtk Pavel On Tue, 2016-06-21 at 09:48 +0900, 小泉 wrote: > Hi all, > > I am building spice-gtk for Windows on my fedora based on following > instruction. > >