About typedef of struct is true, all structures, even declared in C++ have
typedefs.
About all upper case is false, beside the definitions added by these patches
but are C definitions, not C++.
About space there is a space after the structure name before bracket ("{").
About empty lines mostly
This style was used in order to match the current style of VDAgent.
On Mon, Jul 18, 2016 at 10:54 AM, Frediano Ziglio
wrote:
> >
> > From: Sameeh Jubran
> >
> > This patch adds new ioctl operation to Vdagent in order to update
> > the driver on Vdagent state. This allows the driver to know
> >
Out of curiosity, what are these build scripts used for?
Day-to-day development, CI, package building, something else?
Christophe
On Mon, Jul 18, 2016 at 09:34:44AM +0300, Dmitry Fleytman wrote:
> Signed-off-by: Dmitry Fleytman
> ---
> Tools/vs_cmdline.vbs | 23 +++
> Tools/
On Wed, Jul 20, 2016 at 06:00:53PM +0200, Christophe Fergeau wrote:
> On Mon, Jul 18, 2016 at 09:34:48AM +0300, Dmitry Fleytman wrote:
> > From: Sameeh Jubran
> >
> > This patch adds new ioctl operation to Vdagent in order to update
> > the driver on Vdagent state. This allows the driver to know
On Mon, Jul 18, 2016 at 09:34:48AM +0300, Dmitry Fleytman wrote:
> From: Sameeh Jubran
>
> This patch adds new ioctl operation to Vdagent in order to update
> the driver on Vdagent state. This allows the driver to know
> when Vdagent is running and when it is off.
Why does it need to know that?
'Unify' ? Make them consistent between the various vcxproj files?
Christophe
On Mon, Jul 18, 2016 at 09:34:43AM +0300, Dmitry Fleytman wrote:
> Signed-off-by: Dmitry Fleytman
> ---
> vdagent/vdagent.vcxproj | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/vdagent/vdagen
What does this mean, what issues is this causing, why does it need to
be done? One or 2 sentences to know what's going on wouldn't hurt :)
Christophe
On Mon, Jul 18, 2016 at 09:34:41AM +0300, Dmitry Fleytman wrote:
> Signed-off-by: Dmitry Fleytman
> ---
> vdagent/vdagent.vcxproj | 2 +-
>
I guess this could be squashed in "Provide support for Windows 10 CCD API"?
Christophe
On Mon, Jul 18, 2016 at 09:34:40AM +0300, Dmitry Fleytman wrote:
> Signed-off-by: Dmitry Fleytman
> ---
> vdagent/vdagent.vcxproj | 16
> vdservice/vdservice.vcxproj | 8
> 2 fi
Ah, the autotools based build-system knows how to autogenerate a
.gitignore file, but we should indeed make sure it's committed to git
so that it can be useful to people using VC++.
Christophe
On Mon, Jul 18, 2016 at 09:34:39AM +0300, Dmitry Fleytman wrote:
> Signed-off-by: Dmitry Fleytman
> ---
Why does this need to be a subdomule? Until now, this was managed as an
external dependency.
Christophe
On Mon, Jul 18, 2016 at 09:34:37AM +0300, Dmitry Fleytman wrote:
> Signed-off-by: Dmitry Fleytman
> ---
> .gitmodules | 3 +++
> cximage | 1 +
> 2 files changed, 4 insertions(+)
> creat
On Mon, Jul 18, 2016 at 09:34:36AM +0300, Dmitry Fleytman wrote:
> diff --git a/vdagent/display_configuration.h b/vdagent/display_configuration.h
> new file mode 100644
> index 000..eeba1c2
> --- /dev/null
> +++ b/vdagent/display_configuration.h
> @@ -0,0 +1,192 @@
> +/*
> +Copyright (C) 2015 R
What is this CCD API, why is it needed? Is this Win10 only, or did older
Windows version have an equivalent?
Does the old code keeps working after this commit?
Given the size of thecommits I'd expect many more explanations as to
what's being done and why.
Christophe
On Mon, Jul 18, 2016 at 09:34
This log could include a bit more about the failure (ie how it happens).
I'd guess with very long filenames?
Christophe
On Mon, Jul 18, 2016 at 09:34:35AM +0300, Dmitry Fleytman wrote:
> From: Sandy Stutsman
>
> ---
> vdagent/display_setting.cpp | 2 +-
> 1 file changed, 1 insertion(+), 1 dele
On Tue, Jul 19, 2016 at 09:41:22AM -0400, Frediano Ziglio wrote:
> > I don't think we have strong reasons to support software encoding, video
> > encoding is really expensive, and that mmap/copy is not going to be
> > marginal, so even less these 2 syscalls.
> >
>
> Using HW encoding is not easy
From: Marc-André Lureau
Eventually, during a seamless migration, qemu may finish to migrate
before the spice client even finished to connect all channels to
destination and informed the server. In this case,
main_channel_client_migrate_src_complete() will fall back to
switch-host method, and reds
Hi,
would be helpful if you can explain a bit what you are trying to
achieve and what your usage.
How many machine are you using?
Which OS/version are you using on guests and host?
What kind of network/bandwidth?
Which kind of applications? Office ones?
Regards,
Frediano
- Original Messa
Hi.
When there is not enough memory for QXL driver, it will send a OOM message
to spice sever to release some memory. And then the function
handle_dev_oom, which in server/red_worker.c will be called. In this
function, there is a line of code:
worker->qxl->st->qif->flush_resources(worker->qxl), wh
Hi,
> > Hmm. The guest will not give us 2-3 frames though. We'll have either
> > one or two, depending on whenever the guest uses page-flips or not. So
> > implementing a buffering scheme as outlined above requires us to copy
> > (or let the gpu copy) the frames.
> Probably 2 are enough, 1 I
18 matches
Mail list logo
