Re: [Spice-devel] [PATCH spice-gtk 0/3] Avoid sending extra resize requests

2016-07-26 Thread Pavel Grunt
Hi, On Tue, 2016-07-26 at 17:04 -0400, Marc-André Lureau wrote: > Hi > > - Original Message - > > > > Hi, > > > > Intention of these patches is to avoid sending unnecessary resize requests > > which causes strange behavior ("flickering") of GNOME on Wayland guests [0]. > > The main chan

[Spice-devel] [PATCH spice-gtk] vmcstream: set the right result for the task

2016-07-26 Thread Fabiano Fidêncio
This bogus code was introduced when switching to GTask API. Seems that while writing those patches I just overlooked this part and set the wrong result for the task. As part of the problems introduced (and now fixed) you can notice that no output stream was being sent to the guest. Signed-off-by:

Re: [Spice-devel] [PATCH spice-gtk 0/3] Avoid sending extra resize requests

2016-07-26 Thread Marc-André Lureau
Hi - Original Message - > Hi, > > Intention of these patches is to avoid sending unnecessary resize requests > which causes strange behavior ("flickering") of GNOME on Wayland guests [0]. > The main channel now compares new resize requests with the information about > the monitor configur

Re: [Spice-devel] [PATCH] usbredirparser: prevent endless recursion if interface_count == 0

2016-07-26 Thread Christophe Fergeau
Hey Alon, On Tue, Jul 26, 2016 at 01:47:16PM +0300, Alon Levy wrote: > On fedora 24 this function is tail optimized, resulting in a busy wait. > > This happens to me with virt-manager running a win7 vm Ah ok, probably goes with the call with interface_count == 0 in usbredirhost.c if libusb_get_

[Spice-devel] [PATCH spice-gtk 2/3] move SpiceDisplayConfig from main channel to session

2016-07-26 Thread Pavel Grunt
It helps to get the real display configuration from display channels instead of relying on the last requested monitor config. Related: https://bugs.freedesktop.org/show_bug.cgi?id=94950 --- src/channel-main.c | 32 +- src/spice-session-priv.h | 17 ++ src

[Spice-devel] [PATCH spice-gtk 3/3] main: Do not request to resize when have desired size

2016-07-26 Thread Pavel Grunt
Check for current size of monitors stored in display channels and avoid sending request to resize if it matches new requested size. Related: https://bugs.freedesktop.org/show_bug.cgi?id=94950 --- src/channel-main.c | 21 + 1 file changed, 21 insertions(+) diff --git a/src/cha

[Spice-devel] [PATCH spice-gtk 1/3] spicy: Add dialog for precise resizing

2016-07-26 Thread Pavel Grunt
--- src/spicy.c | 72 + 1 file changed, 72 insertions(+) diff --git a/src/spicy.c b/src/spicy.c index ea4d4e0..2013e68 100644 --- a/src/spicy.c +++ b/src/spicy.c @@ -566,6 +566,70 @@ static void keyboard_grab_cb(GtkWidget *widget, gint

[Spice-devel] [PATCH spice-gtk 0/3] Avoid sending extra resize requests

2016-07-26 Thread Pavel Grunt
Hi, Intention of these patches is to avoid sending unnecessary resize requests which causes strange behavior ("flickering") of GNOME on Wayland guests [0]. The main channel now compares new resize requests with the information about the monitor configuration stored in the display channels. I noti

[Spice-devel] [spice-gtk v2] Handle pause key correctly

2016-07-26 Thread Frediano Ziglio
Windows does not like Pause key sent with same scancodes as Break. Although is the same physical key the two functions send two completely different set of codes. Tested with Linux and Windows clients. Tested with Linux, Windows and DOS guests. On Windows guest VK_PAUSE was not arriving correctly.

Re: [Spice-devel] [spice-gtk 2/2] Handle pause key correctly

2016-07-26 Thread Frediano Ziglio
> > Hi Frediano, > > On Tue, 2016-07-26 at 10:04 +0100, Frediano Ziglio wrote: > > Windows does not like Pause key sent with same scancodes as Break. > > Although is the same physical key the two functions send two complitely > typo - completely Got it, fixed. > > different set of codes. > > Te

Re: [Spice-devel] [spice-gtk 2/2] Handle pause key correctly

2016-07-26 Thread Pavel Grunt
Hi Frediano, On Tue, 2016-07-26 at 10:04 +0100, Frediano Ziglio wrote: > Windows does not like Pause key sent with same scancodes as Break. > Although is the same physical key the two functions send two complitely typo - completely > different set of codes. > Tested with Linux and Windows clients.

Re: [Spice-devel] [spice] server: Make sure g_object_new receive the correct data

2016-07-26 Thread Uri Lublin
On 07/25/2016 07:51 PM, Francois Gouget wrote: On Mon, 25 Jul 2016, Frediano Ziglio wrote: [...] -"client-tokens-interval", REDS_TOKENS_TO_SEND, -"self-tokens", REDS_NUM_INTERNAL_AGENT_MESSAGES, +"client-tokens-interval", (g

Re: [Spice-devel] [spice-gtk 1/2] Support more extension codes

2016-07-26 Thread Pavel Grunt
On Tue, 2016-07-26 at 10:03 +0100, Frediano Ziglio wrote: > Not only E0 prefix but also E1 and E2. > They are used in some special cases, one is the pause key. > > Signed-off-by: Frediano Ziglio Acked-by: Pavel Grunt > --- >  src/spice-util.c | 20 +++- >  1 file changed, 7 insert

[Spice-devel] [PATCH] usbredirparser: prevent endless recursion if interface_count == 0

2016-07-26 Thread Alon Levy
On fedora 24 this function is tail optimized, resulting in a busy wait. This happens to me with virt-manager running a win7 vm usbredir-0.7.1-2.fc24.x86_64 --- Hi Guys! One liner to fix an issue I had with virt-manager - symptom is 100% cpu taken in it, stack traced to the problem fixed by th

[Spice-devel] Fwd: where do usbredir patches go nowadays?

2016-07-26 Thread Hans de Goede
Forwarded Message Subject: where do usbredir patches go nowadays? Date: Mon, 18 Jul 2016 17:23:44 +0300 From: Alon Levy To: Hans de Goede Well, ok, so I'm taking this time to say hi - you seem to be having good GPU fun these days. >From 132286d0972914cd36c586be6b9b6fa3d0ee

[Spice-devel] [spice-gtk 1/2] Support more extension codes

2016-07-26 Thread Frediano Ziglio
Not only E0 prefix but also E1 and E2. They are used in some special cases, one is the pause key. Signed-off-by: Frediano Ziglio --- src/spice-util.c | 20 +++- 1 file changed, 7 insertions(+), 13 deletions(-) diff --git a/src/spice-util.c b/src/spice-util.c index bca3abc..81a66

[Spice-devel] [spice-gtk 2/2] Handle pause key correctly

2016-07-26 Thread Frediano Ziglio
Windows does not like Pause key sent with same scancodes as Break. Although is the same physical key the two functions send two complitely different set of codes. Tested with Linux and Windows clients. Tested with Linux, Windows and DOS guests. On Windows guest VK_PAUSE was not arriving correctly.

Re: [Spice-devel] Multiple monitors for a windows virtual machine where each is to be displayed on a different client (for a windows 10 virtual machine)

2016-07-26 Thread Pavel Grunt
Hi, On Tue, 2016-07-26 at 00:19 -0400, pt...@jgh.mcgill.ca wrote: > Hi! > > I have a server (in my basement) running windows 10 as a virtual machine.  I > would like the windows virtual machine to have 3 virtual displays (or at least > 2) That is not a problem, you just need to add more '-vga qx

[Spice-devel] Multiple monitors for a windows virtual machine where each is to be displayed on a different client (for a windows 10 virtual machine)

2016-07-26 Thread ptroy
Hi! I have a server (in my basement) running windows 10 as a virtual machine. I would like the windows virtual machine to have 3 virtual displays (or at least 2), and I would like to display the frist virtual display on the monitor on the first machine in my office, the second virtual display on